)]}'
{"neutron/common/utils.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b9cc0d8b3d0f5948ff1a77efb03558b4a92e1049","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def attach_exc_details(e, msg, args\u003dNone):"},{"line_number":666,"context_line":"    e.__error_context_msg \u003d msg"},{"line_number":667,"context_line":"    e.__error_context_args \u003d args"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_86845b0b","line":666,"updated":"2016-06-29 14:30:51.000000000","message":"Nit: I am not sure why the \u0027__\u0027 prefix? How about \u0027neutron_\u0027 instead?","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eaf4b1c67e40525966970676bfadb3462886e450","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def attach_exc_details(e, msg, args\u003dNone):"},{"line_number":666,"context_line":"    e.__error_context_msg \u003d msg"},{"line_number":667,"context_line":"    e.__error_context_args \u003d args"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_39ad9a9b","line":666,"in_reply_to":"3aaa91ec_350644ce","updated":"2016-06-30 10:52:38.000000000","message":"When I commented first, I used double underscore. Now I think a single underscore is enough as Kevin commented.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d892d0843cf5b129b786cc05a3d013452472f26","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def attach_exc_details(e, msg, args\u003dNone):"},{"line_number":666,"context_line":"    e.__error_context_msg \u003d msg"},{"line_number":667,"context_line":"    e.__error_context_args \u003d args"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_350644ce","line":666,"in_reply_to":"3aaa91ec_7171030c","updated":"2016-06-30 08:33:10.000000000","message":"i am in favor of the _","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf94d91c993ca9c965decb52aca600232b8628c8","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def attach_exc_details(e, msg, args\u003dNone):"},{"line_number":666,"context_line":"    e.__error_context_msg \u003d msg"},{"line_number":667,"context_line":"    e.__error_context_args \u003d args"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_86a1fb48","line":666,"in_reply_to":"3aaa91ec_86845b0b","updated":"2016-06-29 14:34:42.000000000","message":"__ is to indicate it is not meant to be accessed directly. I can rename, but I will let others to chime in with their reviews first.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"608c57ccad275b6e875a8f35024ae6070f3ffe18","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def attach_exc_details(e, msg, args\u003dNone):"},{"line_number":666,"context_line":"    e.__error_context_msg \u003d msg"},{"line_number":667,"context_line":"    e.__error_context_args \u003d args"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7171030c","line":666,"in_reply_to":"3aaa91ec_86a1fb48","updated":"2016-06-30 07:33:53.000000000","message":"A single \u0027_\u0027 is probably enough to indicate that it\u0027s private.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bd9090fbdb5fc7448a9a7949df761443e28ba57b","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            return _LE(\u0027No details.\u0027)"},{"line_number":674,"context_line":"    details \u003d e.__error_context_msg"},{"line_number":675,"context_line":"    args \u003d e.__error_context_args"},{"line_number":676,"context_line":"    if args is None:"},{"line_number":677,"context_line":"        return details"},{"line_number":678,"context_line":"    return details % args"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5c57b459","line":678,"range":{"start_line":676,"start_character":0,"end_line":678,"end_character":25},"updated":"2016-06-30 11:11:07.000000000","message":"Nit: Is there a reason to postpone this formatting? We could store formatted patch already at L666, the number of the beast. It would simplify both functions.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5573a4a5f4eea7e09ab5b27e323b40a67df35641","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            return _LE(\u0027No details.\u0027)"},{"line_number":674,"context_line":"    details \u003d e.__error_context_msg"},{"line_number":675,"context_line":"    args \u003d e.__error_context_args"},{"line_number":676,"context_line":"    if args is None:"},{"line_number":677,"context_line":"        return details"},{"line_number":678,"context_line":"    return details % args"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1c4b6c88","line":678,"range":{"start_line":676,"start_character":0,"end_line":678,"end_character":25},"in_reply_to":"3aaa91ec_5c57b459","updated":"2016-06-30 11:13:48.000000000","message":"Same reason why we postpone it when logging: to avoid formatting when it\u0027s not really needed.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"528c8e518a0286a9dd7d947f728bd87ac3796f5d","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            return _LE(\u0027No details.\u0027)"},{"line_number":674,"context_line":"    details \u003d e._error_context_msg"},{"line_number":675,"context_line":"    args \u003d e._error_context_args"},{"line_number":676,"context_line":"    if args is None:"},{"line_number":677,"context_line":"        return details"},{"line_number":678,"context_line":"    return details % args"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ee105b50","line":676,"updated":"2016-06-30 14:29:00.000000000","message":"this means we cannot pass None as an argument, but I think this is a reasonable assumption. I think we usually pass some other information like ID if we need to pass None as extra information.","commit_id":"48b3472cb5c989f6ad696652fd901c6724475d11"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6604cae9ed50013dce78bebf3e57836b137234a9","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            return _LE(\u0027No details.\u0027)"},{"line_number":674,"context_line":"    details \u003d e._error_context_msg"},{"line_number":675,"context_line":"    args \u003d e._error_context_args"},{"line_number":676,"context_line":"    if args is None:"},{"line_number":677,"context_line":"        return details"},{"line_number":678,"context_line":"    return details % args"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_04f0ff65","line":676,"in_reply_to":"3aaa91ec_ee105b50","updated":"2016-07-01 08:43:18.000000000","message":"Well actually, I think it\u0027s a valid concern, because the argument may be of None value, due to a bug or something. We still need to interpolate it.\n\nI will introduce a special marker object.","commit_id":"48b3472cb5c989f6ad696652fd901c6724475d11"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"35d637e4285ea9652d46eb4c3d050e005a11de86","unresolved":false,"context_lines":[{"line_number":651,"context_line":"                                    \u0027result\u0027: result,"},{"line_number":652,"context_line":"                                    \u0027attributes\u0027: attrs})"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        except Exception:"},{"line_number":655,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":656,"context_line":"                LOG.exception(_LE(\"An exception occurred while creating \""},{"line_number":657,"context_line":"                                  \"the %(resource)s:%(item)s\"),"},{"line_number":658,"context_line":"                              {\u0027resource\u0027: resource, \u0027item\u0027: item})"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            postcommit_op \u003d getattr(self.mechanism_manager,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4f0a82d3","side":"PARENT","line":658,"range":{"start_line":654,"start_character":0,"end_line":658,"end_character":67},"updated":"2016-06-17 13:30:31.000000000","message":"Is this also relevant to this fix? create resource is also handled by retry on api level","commit_id":"496f1f75e8b97c486ebdcb1e505d71656398026c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7424088103e035aef0ad07c86dd4c47a519fec5c","unresolved":false,"context_lines":[{"line_number":651,"context_line":"                                    \u0027result\u0027: result,"},{"line_number":652,"context_line":"                                    \u0027attributes\u0027: attrs})"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        except Exception:"},{"line_number":655,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":656,"context_line":"                LOG.exception(_LE(\"An exception occurred while creating \""},{"line_number":657,"context_line":"                                  \"the %(resource)s:%(item)s\"),"},{"line_number":658,"context_line":"                              {\u0027resource\u0027: resource, \u0027item\u0027: item})"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            postcommit_op \u003d getattr(self.mechanism_manager,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ef7c0e22","side":"PARENT","line":658,"range":{"start_line":654,"start_character":0,"end_line":658,"end_character":67},"in_reply_to":"7aa08908_4f0a82d3","updated":"2016-06-17 14:29:55.000000000","message":"Great spot! Somehow missed that one.","commit_id":"496f1f75e8b97c486ebdcb1e505d71656398026c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bd9090fbdb5fc7448a9a7949df761443e28ba57b","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            except KeyError:"},{"line_number":633,"context_line":"                LOG.exception(_LE(\"Could not find %s to delete.\"),"},{"line_number":634,"context_line":"                              resource)"},{"line_number":635,"context_line":"            except Exception as e:"},{"line_number":636,"context_line":"                utils.attach_exc_details("},{"line_number":637,"context_line":"                    e, _LE(\"Could not delete %(res)s %(id)s.\"),"},{"line_number":638,"context_line":"                    {\u0027res\u0027: resource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5c55f4bf","line":635,"updated":"2016-06-30 11:11:07.000000000","message":"Missing save_and_reraise_exception()? Otherwise we just add info to exception object which is not used anywhere.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dff375e0c70df859c1a0d2a3146439743bbe2f5c","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            except KeyError:"},{"line_number":633,"context_line":"                LOG.exception(_LE(\"Could not find %s to delete.\"),"},{"line_number":634,"context_line":"                              resource)"},{"line_number":635,"context_line":"            except Exception as e:"},{"line_number":636,"context_line":"                utils.attach_exc_details("},{"line_number":637,"context_line":"                    e, _LE(\"Could not delete %(res)s %(id)s.\"),"},{"line_number":638,"context_line":"                    {\u0027res\u0027: resource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7e4c2042","line":635,"in_reply_to":"3aaa91ec_1c640c20","updated":"2016-06-30 12:43:24.000000000","message":"OK, I reverted that one to the original version. I reported a bug about the way we handle cleanups for bulk operations as https://bugs.launchpad.net/neutron/+bug/1597752","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5573a4a5f4eea7e09ab5b27e323b40a67df35641","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            except KeyError:"},{"line_number":633,"context_line":"                LOG.exception(_LE(\"Could not find %s to delete.\"),"},{"line_number":634,"context_line":"                              resource)"},{"line_number":635,"context_line":"            except Exception as e:"},{"line_number":636,"context_line":"                utils.attach_exc_details("},{"line_number":637,"context_line":"                    e, _LE(\"Could not delete %(res)s %(id)s.\"),"},{"line_number":638,"context_line":"                    {\u0027res\u0027: resource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1c640c20","line":635,"in_reply_to":"3aaa91ec_5c55f4bf","updated":"2016-06-30 11:13:48.000000000","message":"Hm. Maybe it\u0027s actually designed this way to ignore exceptions. Which honestly sounds like a bug to me.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6490b48607867157caf7c92010756f4d101ee74","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            except KeyError:"},{"line_number":633,"context_line":"                LOG.exception(_LE(\"Could not find %s to delete.\"),"},{"line_number":634,"context_line":"                              resource)"},{"line_number":635,"context_line":"            except Exception as e:"},{"line_number":636,"context_line":"                utils.attach_exc_details("},{"line_number":637,"context_line":"                    e, _LE(\"Could not delete %(res)s %(id)s.\"),"},{"line_number":638,"context_line":"                    {\u0027res\u0027: resource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_03fb007a","line":635,"in_reply_to":"3aaa91ec_7e4c2042","updated":"2016-06-30 14:23:19.000000000","message":"Good catch. I agree this is a bug.","commit_id":"41534d428119bb0290a3f544a9782c9d888e049b"}]}
