)]}'
{"neutron/conf/agent/dhcp.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f5b21f5b7c66cdcaf726528241d9bd1e59275483","unresolved":false,"context_lines":[{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def register_agent_dhcp_opts(opts, cfg\u003dcfg.CONF):"},{"line_number":108,"context_line":"    cfg.register_opts(opts)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def register_agent_dhcp_all_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2ba1d5f7","line":107,"updated":"2016-06-17 20:48:01.000000000","message":"How does this helper... Help? Can\u0027t the users of this function simply call cfg.register_opts(opts) directly?","commit_id":"3844ae9cbd1d1c6657941281080dfa1d61e0c675"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f7da666a213a0ed15bb01a8ce04c6a261237378f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def register_agent_dhcp_opts(opts, cfg\u003dcfg.CONF):"},{"line_number":108,"context_line":"    cfg.register_opts(opts)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def register_agent_dhcp_all_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_371c9665","line":107,"in_reply_to":"7aa08908_2ba1d5f7","updated":"2016-06-17 23:06:39.000000000","message":"The reason why this bothers me is that now we get two functions with a very similar name and the caller has to look at the implementation to determine which one to call. I don\u0027t think that makes sense. The solution would be to delete this function.","commit_id":"3844ae9cbd1d1c6657941281080dfa1d61e0c675"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"34375cc256e8dafb9e11fe0d45c3154e4075fbe4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def register_agent_dhcp_all_opts(cfg\u003dcfg.CONF):"},{"line_number":108,"context_line":"    cfg.register_opts(DHCP_AGENT_OPTS)"},{"line_number":109,"context_line":"    cfg.register_opts(DHCP_OPTS)"},{"line_number":110,"context_line":"    cfg.register_opts(DNSMASQ_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_50b162df","line":107,"updated":"2016-06-18 14:06:19.000000000","message":"If you need to respin in the future, this can be renamed to \u0027register_dhcp_agent_opts\u0027 or similar. The \u0027all\u0027 is redundant now.","commit_id":"8ff29e02ccca7027f50dc2316bbab1dd544c7654"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"81c9f7594581ff7a5706e78fb8d5e72b7c1d22c5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def register_agent_dhcp_opts(cfg\u003dcfg.CONF):"},{"line_number":108,"context_line":"    cfg.register_opts(DHCP_AGENT_OPTS)"},{"line_number":109,"context_line":"    cfg.register_opts(DHCP_OPTS)"},{"line_number":110,"context_line":"    cfg.register_opts(DNSMASQ_OPTS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_f5c22852","line":107,"range":{"start_line":107,"start_character":13,"end_line":107,"end_character":23},"updated":"2016-07-11 19:19:52.000000000","message":"reads better if this was dhcp_agent.","commit_id":"607957ef3501a771a61cd3b82b32f5de83a6e117"}],"neutron/tests/functional/agent/linux/test_dhcp.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d422cc1966832ed145fc709c52c370f7c5767bf7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        conf.register_opts(config.INTERFACE_DRIVER_OPTS)"},{"line_number":34,"context_line":"        conf.register_opts(interface.OPTS)"},{"line_number":35,"context_line":"        conf.register_opts(common_conf.core_opts)"},{"line_number":36,"context_line":"        dhcp_conf.register_agent_dhcp_opts(dhcp_conf.DHCP_AGENT_OPTS, conf)"},{"line_number":37,"context_line":"        conf.set_override(\u0027interface_driver\u0027, \u0027openvswitch\u0027)"},{"line_number":38,"context_line":"        conf.set_override(\u0027host\u0027, \u0027foo_host\u0027)"},{"line_number":39,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d78c3237","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":75},"updated":"2016-06-17 23:27:29.000000000","message":"agree with assaf directly use conf.register_opts(dhcp_conf.DHCP_AGENT_OPTS)\n\nthe function register_agent_dhcp_opts is not doing any help other adding a jump statement.","commit_id":"3844ae9cbd1d1c6657941281080dfa1d61e0c675"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d422cc1966832ed145fc709c52c370f7c5767bf7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                        sys_argv.return_value \u003d ["},{"line_number":260,"context_line":"                            \u0027dhcp\u0027, \u0027--config-file\u0027,"},{"line_number":261,"context_line":"                            base.etcdir(\u0027neutron.conf\u0027)]"},{"line_number":262,"context_line":"                        dhcp_config.register_agent_dhcp_opts(dhcp_config."},{"line_number":263,"context_line":"                                                        DHCP_AGENT_OPTS, cfg.CONF)"},{"line_number":264,"context_line":"                        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":265,"context_line":"                        config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":266,"context_line":"                        cfg.CONF.register_opts(interface.OPTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_777c5e20","line":263,"range":{"start_line":262,"start_character":24,"end_line":263,"end_character":82},"updated":"2016-06-17 23:27:29.000000000","message":"same here","commit_id":"3844ae9cbd1d1c6657941281080dfa1d61e0c675"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d422cc1966832ed145fc709c52c370f7c5767bf7","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        super(TestConfBase, self).setUp()"},{"line_number":829,"context_line":"        self.conf \u003d config.setup_conf()"},{"line_number":830,"context_line":"        self.conf.register_opts(base_config.core_opts)"},{"line_number":831,"context_line":"        dhcp_config.register_agent_dhcp_opts(dhcp_config.DHCP_OPTS, self.conf)"},{"line_number":832,"context_line":"        dhcp_config.register_agent_dhcp_opts(dhcp_config.DNSMASQ_OPTS, self.conf)"},{"line_number":833,"context_line":"        self.conf.register_opts(external_process.OPTS)"},{"line_number":834,"context_line":"        config.register_interface_driver_opts_helper(self.conf)"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b7724648","line":832,"range":{"start_line":831,"start_character":8,"end_line":832,"end_character":81},"updated":"2016-06-17 23:27:29.000000000","message":"same","commit_id":"3844ae9cbd1d1c6657941281080dfa1d61e0c675"}]}
