)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"2a4d0edda3f81c583ae334d83d38fdf364196fc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     3703b31e (tests: clean up designate client session mock on test exit)"},{"line_number":2,"context_line":"Author:     sunny-verma \u003csunnyverma1992@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-06-20 16:08:56 -0400"},{"line_number":4,"context_line":"Commit:     sunny-verma \u003csunnyverma1992@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_14974891","line":1,"updated":"2016-06-20 20:12:54.000000000","message":"Please improve your commit message: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"78a741648c60fecc2883a49f573cd790435c5c47"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"2ccd54816f7758d7f4d0fa381bac4e96d72217bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        matter , we should remove the order/sequence dependency in _update_port_with_address"},{"line_number":10,"context_line":"        method."},{"line_number":11,"context_line":"Solution: The proposed solution is to sort the allowed address pairs and"},{"line_number":12,"context_line":"        then perform assert."},{"line_number":13,"context_line":"Closed-Bug: #1594571"},{"line_number":14,"context_line":"Change-Id: Ib8c219e8230fef5c51534c131b40d2165467b078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a9d85d2_6b098695","line":12,"updated":"2016-06-20 21:22:29.000000000","message":"Standard convention for commit messages is one line summary (ideally less than 50 characters), blank line, then one or more paragraphs explaining change wrapped to 72 characters, with a blank line delimiting paragraphs.","commit_id":"2efa59ccd858161df3174567e93f2865fcec6b85"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"2ab31650fe7beba20b9cf3326209c28ae95d8e5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sunny-verma \u003csunnyverma1992@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-20 21:02:13 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removed restriction on sequence of allowed address pairs."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the order in which we receive the allowed address pair doesn\u0027t matter, we should remove the order/sequence dependency in _update_port_with_address method."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a9d85d2_4773c415","line":7,"updated":"2016-06-21 10:48:08.000000000","message":"First line of commit message should be limited to 50 chars and not end with a period.","commit_id":"0e87720ecf3dc40d2b671ef015158ad01a04f080"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"2ab31650fe7beba20b9cf3326209c28ae95d8e5e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the order in which we receive the allowed address pair doesn\u0027t matter, we should remove the order/sequence dependency in _update_port_with_address method."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The proposed solution is to assert on the Items in the allowed address pairs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closed-Bug: #1594571"},{"line_number":14,"context_line":"Change-Id: Ib8c219e8230fef5c51534c131b40d2165467b078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a9d85d2_c7d4d4be","line":11,"updated":"2016-06-21 10:48:08.000000000","message":"All other lines should be limited to 72 chars.","commit_id":"0e87720ecf3dc40d2b671ef015158ad01a04f080"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"2ab31650fe7beba20b9cf3326209c28ae95d8e5e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The proposed solution is to assert on the Items in the allowed address pairs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closed-Bug: #1594571"},{"line_number":14,"context_line":"Change-Id: Ib8c219e8230fef5c51534c131b40d2165467b078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a9d85d2_a7eee888","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2016-06-21 10:48:08.000000000","message":"Closes-Bug:","commit_id":"0e87720ecf3dc40d2b671ef015158ad01a04f080"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"05fc943aa29d788fe02d12527ccdd2a29e6e2dd0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the order in which we receive the allowed address pair doesn\u0027t"},{"line_number":10,"context_line":"matter, we should remove the order/sequence dependency in"},{"line_number":11,"context_line":"_update_port_with_address method.The proposed solution is to assert"},{"line_number":12,"context_line":"on the Items in the allowed address pairs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1594571"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_c1c6d015","line":11,"updated":"2016-06-21 18:16:55.000000000","message":"nit: please add a space after the period","commit_id":"e2993dec7fb334a9e5fa65900ead86aabc3a25a7"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"05fc943aa29d788fe02d12527ccdd2a29e6e2dd0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since the order in which we receive the allowed address pair doesn\u0027t"},{"line_number":10,"context_line":"matter, we should remove the order/sequence dependency in"},{"line_number":11,"context_line":"_update_port_with_address method.The proposed solution is to assert"},{"line_number":12,"context_line":"on the Items in the allowed address pairs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1594571"},{"line_number":15,"context_line":"Change-Id: Ib8c219e8230fef5c51534c131b40d2165467b078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_a1f2a46d","line":12,"updated":"2016-06-21 18:16:55.000000000","message":"nit: s/Items/items/","commit_id":"e2993dec7fb334a9e5fa65900ead86aabc3a25a7"}],"neutron/tests/tempest/api/test_allowed_address_pair.py":[{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"2ccd54816f7758d7f4d0fa381bac4e96d72217bf","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":87,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":88,"context_line":"        self.assertEqual(sorted(allowed_address_pair),"},{"line_number":89,"context_line":"                         sorted(allowed_address_pairs))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":92,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_0b272213","line":89,"updated":"2016-06-20 21:22:29.000000000","message":"Rather than sorting the expected and actual lists, use assertItemsEqual instead.","commit_id":"2efa59ccd858161df3174567e93f2865fcec6b85"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"7d88cbec4c1ba0188be37a1e642c68338aa8cd63","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        body \u003d self.client.update_port("},{"line_number":86,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":87,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":88,"context_line":"        self.assertItemsEqual(allowed_address_pair, allowed_address_pairs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":91,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a9ec1cc8","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":29},"updated":"2016-06-22 12:39:27.000000000","message":"It looks like this was renamed to assertCountEqual in python 3.2. We may need to get around this by just sorting the lists and sticking with assertEqual.","commit_id":"8ef4315fdedec10cccb1f0bd70301c9f998f9158"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"4a572170d900242c8d7c6b8a21a32171cfb0c382","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        body \u003d self.client.update_port("},{"line_number":86,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":87,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":88,"context_line":"        self.assertItemsEqual(allowed_address_pair, allowed_address_pairs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":91,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e7bac4e0","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":29},"in_reply_to":"3aaa91ec_a9ec1cc8","updated":"2016-06-22 14:49:54.000000000","message":"John, good you mentioned this. Didn\u0027t suspect that this could be a problem. But we don\u0027t need to sort lists, we can use six to deal with renamed methods.\n\nhttps://pythonhosted.org/six/#unittest-assertions\n six.assertCountEqual()\n Alias for assertCountEqual() on Python 3 and assertItemsEqual() on Python 2.","commit_id":"8ef4315fdedec10cccb1f0bd70301c9f998f9158"},{"author":{"_account_id":21451,"name":"Sunny Verma","email":"sunnyverma1992@gmail.com","username":"sunnyve"},"change_message_id":"aad0779580c1b1e15a764e667805e53b52bfae07","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        body \u003d self.client.update_port("},{"line_number":86,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":87,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":88,"context_line":"        self.assertItemsEqual(allowed_address_pair, allowed_address_pairs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":91,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_44f46bf1","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":29},"in_reply_to":"3aaa91ec_e7bac4e0","updated":"2016-06-22 17:32:57.000000000","message":"I agree Darek.","commit_id":"8ef4315fdedec10cccb1f0bd70301c9f998f9158"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"83baf352c842275d6f2f9a1e3d749b83f310abe7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        body \u003d self.client.update_port("},{"line_number":87,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":88,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":89,"context_line":"        six.assertCountEqual(self, allowed_address_pair,"},{"line_number":90,"context_line":"                             allowed_address_pairs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_4d163ff2","line":89,"updated":"2016-08-16 09:28:02.000000000","message":"AssertCount??? Does that mean we stop looking at the contents entirely? If so, this isn\u0027t any good. Convert them to sets if all you care about is no ordering.","commit_id":"180487d98480f65e79e1f524c1694e1081281777"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"af2cd45c8c5f0f119a53bb6b15174b6c2af2498e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        body \u003d self.client.update_port("},{"line_number":87,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":88,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":89,"context_line":"        six.assertCountEqual(self, allowed_address_pair,"},{"line_number":90,"context_line":"                             allowed_address_pairs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_6305e178","line":89,"updated":"2016-06-29 14:19:02.000000000","message":"Neutron uses unittest2 which provides assertItemsEqual for Python3 also. Let\u0027s use assertItemsEqual for Neutron tests. There are many test cases that already use it.","commit_id":"180487d98480f65e79e1f524c1694e1081281777"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b66d64fc6d7560f910026ad4f545af889d440b46","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        body \u003d self.client.update_port("},{"line_number":87,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":88,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":89,"context_line":"        six.assertCountEqual(self, allowed_address_pair,"},{"line_number":90,"context_line":"                             allowed_address_pairs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_5aad09e8","line":89,"in_reply_to":"3aaa91ec_6305e178","updated":"2016-06-30 01:24:40.000000000","message":"I checked, and it occurs that tempest, under the hood, uses testtools, which enhances unittest and unittest2. So, in the end, as you mentioned, allows to use self.assertItemsEqual.\n\nThanks for pointing this out.","commit_id":"180487d98480f65e79e1f524c1694e1081281777"}]}
