)]}'
{"neutron/tests/functional/db/test_ipam.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"55cbf7daeaa8a405448acef4fb391dc64e9976b7","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class TestIpamMySql(testlib_api.MySQLTestCaseMixin, IpamTestCase):"},{"line_number":164,"context_line":"    def test_we_are_mysql(self):"},{"line_number":165,"context_line":"        self.cxt.session.execute(\"select curdate()\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestIpamPsql(testlib_api.PostgreSQLTestCaseMixin, IpamTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_a36db7cd","line":165,"range":{"start_line":164,"start_character":4,"end_line":165,"end_character":52},"updated":"2016-06-26 06:43:17.000000000","message":"I think we can remove this already?","commit_id":"400050147f51f45fe0f089e37e6e5d4b004ff346"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"6d9891884e546d753c2fb57b5a345dde8674ea1f","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class TestIpamMySql(testlib_api.MySQLTestCaseMixin, IpamTestCase):"},{"line_number":164,"context_line":"    def test_we_are_mysql(self):"},{"line_number":165,"context_line":"        self.cxt.session.execute(\"select curdate()\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestIpamPsql(testlib_api.PostgreSQLTestCaseMixin, IpamTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_3d91b053","line":165,"range":{"start_line":164,"start_character":4,"end_line":165,"end_character":52},"in_reply_to":"3aaa91ec_22434f6e","updated":"2016-06-27 15:32:04.000000000","message":"well I think perhaps I want to move this to be an \"assert\" that\u0027s just in the setup of the Opportunistic cases (and invokes only once), that is at least have it be silent and part of the fixtures themselves.","commit_id":"400050147f51f45fe0f089e37e6e5d4b004ff346"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"31773e7abde05e3cd3b87a3c399c4a2e8c1755f5","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class TestIpamMySql(testlib_api.MySQLTestCaseMixin, IpamTestCase):"},{"line_number":164,"context_line":"    def test_we_are_mysql(self):"},{"line_number":165,"context_line":"        self.cxt.session.execute(\"select curdate()\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestIpamPsql(testlib_api.PostgreSQLTestCaseMixin, IpamTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_cc5c44f3","line":165,"range":{"start_line":164,"start_character":4,"end_line":165,"end_character":52},"in_reply_to":"3aaa91ec_a36db7cd","updated":"2016-06-27 14:44:41.000000000","message":"\"yes\", though I had removed it, and then a few of my patches here were actually running on SQLite again w/o saying anything :) .   Im wondering if there\u0027s a way to definitely assert that any test under the MySQL/Postgresql mixins is on the right system.","commit_id":"400050147f51f45fe0f089e37e6e5d4b004ff346"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f8fb86b1ee23bf03be2e468ee8f5196a677c0222","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class TestIpamMySql(testlib_api.MySQLTestCaseMixin, IpamTestCase):"},{"line_number":164,"context_line":"    def test_we_are_mysql(self):"},{"line_number":165,"context_line":"        self.cxt.session.execute(\"select curdate()\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestIpamPsql(testlib_api.PostgreSQLTestCaseMixin, IpamTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_22434f6e","line":165,"range":{"start_line":164,"start_character":4,"end_line":165,"end_character":52},"in_reply_to":"3aaa91ec_cc5c44f3","updated":"2016-06-27 15:24:01.000000000","message":"In this case I think we can leave it, but with a comment why we want to have it.","commit_id":"400050147f51f45fe0f089e37e6e5d4b004ff346"}],"neutron/tests/functional/db/test_migrations.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3b56d70d6b8d88c8871f02b2a9a42e48debac595","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                check(engine, data)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def test_walk_versions(self):"},{"line_number":457,"context_line":"        \"\"\"Test migrations ability to upgrade and downgrade."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        \"\"\""},{"line_number":460,"context_line":"        engine \u003d self.engine"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_4b0f2888","line":457,"range":{"start_line":457,"start_character":45,"end_line":457,"end_character":59},"updated":"2016-06-29 11:47:29.000000000","message":"Nit: Neutron doesn\u0027t support or test downgrade.","commit_id":"324e93d8d1e54c4a2e4d13a87fa6651a82460dd8"}],"neutron/tests/unit/testlib_api.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"6cc5151a4c49c1dca690cb0f02dda4759a1c28a8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def _generate_schema(cls, engine):"},{"line_number":75,"context_line":"        model_base.BASEV2.metadata.create_all(engine)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _delete_from_schema(self, engine):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_fbd3a65d","line":74,"updated":"2016-06-27 18:42:52.000000000","message":"so, one thing to think about here.  We\u0027re using create_all() to build up the schema regardless of backend database.  that works fine, however, it means we aren\u0027t actually testing the schema that the migrations themselves have built up.   We should consider using alembic migrations to build up the schema in the case of non-SQLite db.  Opinions ?","commit_id":"6362b95b96db520806cdef33e934d5a751629944"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"c8f4540c3c3ecdc0bdd8ddc5eb2bb5a6a5d920e4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def _generate_schema(cls, engine):"},{"line_number":75,"context_line":"        model_base.BASEV2.metadata.create_all(engine)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _delete_from_schema(self, engine):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_dac0562d","line":74,"in_reply_to":"3aaa91ec_0ac5735a","updated":"2016-06-28 02:05:28.000000000","message":"right, so that\u0027s the whole point of the testresources OpportunisticTestSuite thing - the \"resource\" that builds up each MySQL database would only run one per process (noting that the test suite uses something like 10 processes).   The downsides with the opportunistic test suite is that you need some boilerplate in each test module (or in the __init__.py, but then it won\u0027t always get invoked if you are just running some subset of tests, I am going to experiment more w/ this to understand better what the options are) and also it doesn\u0027t work with runners like py.test (which doesn\u0027t matter here since we run w/ testtools, though I use py.test for individual tests).\n\nalso, if you look at what I have in https://review.openstack.org/#/c/314054/, you can see there\u0027s quite a bit of redundancy for the stored function / trigger testing if we still use create_all() in the test suite.","commit_id":"6362b95b96db520806cdef33e934d5a751629944"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"aa99abc297f2ec89d37c64457dea20bd1e00efd9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def _generate_schema(cls, engine):"},{"line_number":75,"context_line":"        model_base.BASEV2.metadata.create_all(engine)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _delete_from_schema(self, engine):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_493498dd","line":74,"in_reply_to":"3aaa91ec_dac0562d","updated":"2016-06-28 09:15:45.000000000","message":"+1 for making this as a separate effort.","commit_id":"6362b95b96db520806cdef33e934d5a751629944"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3e9ada041739c9802675517f94c14025b07c32bf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def _generate_schema(cls, engine):"},{"line_number":75,"context_line":"        model_base.BASEV2.metadata.create_all(engine)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _delete_from_schema(self, engine):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_0ac5735a","line":74,"in_reply_to":"3aaa91ec_fbd3a65d","updated":"2016-06-27 23:55:58.000000000","message":"+1 from me, although IIRC it is quite a bit slower. Can we avoid running the migrations for every test case?\n\nIt seems like something to work on in a separate patch.","commit_id":"6362b95b96db520806cdef33e934d5a751629944"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e34029ade3e4077d376dc8bbbf9923d83e29d8ed","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.db import api as db_api"},{"line_number":28,"context_line":"# Import all data models"},{"line_number":29,"context_line":"from neutron.db.migration import cli as migration"},{"line_number":30,"context_line":"from neutron.db.migration.models import head  # noqa"},{"line_number":31,"context_line":"from neutron.db import model_base"},{"line_number":32,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_c310d85b","line":29,"updated":"2016-06-30 14:35:06.000000000","message":"Nit: The comment on line 28 is meant for the import on line 30.","commit_id":"546ba377db81e7ba984b63942f6bbb974a653e3c"}]}
