)]}'
{"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":743,"context_line":"            \u0027start_flag\u0027: True,"},{"line_number":744,"context_line":"            \u0027agent_type\u0027: constants.AGENT_TYPE_DHCP}"},{"line_number":745,"context_line":"        report_interval \u003d cfg.CONF.AGENT.report_interval"},{"line_number":746,"context_line":"        self.call \u003d True"},{"line_number":747,"context_line":"        if report_interval:"},{"line_number":748,"context_line":"            self.heartbeat \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":749,"context_line":"                self._report_state)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FnL0%3D","line":746,"updated":"2013-06-26 18:52:49.000000000","message":"I\u0027m not a big fan of call as a instance var name.  Consider \"use_call\"","commit_id":"dcbb4814dfd1d878534e7ebcedfffa490c5cf50b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":743,"context_line":"            \u0027start_flag\u0027: True,"},{"line_number":744,"context_line":"            \u0027agent_type\u0027: constants.AGENT_TYPE_DHCP}"},{"line_number":745,"context_line":"        report_interval \u003d cfg.CONF.AGENT.report_interval"},{"line_number":746,"context_line":"        self.call \u003d True"},{"line_number":747,"context_line":"        if report_interval:"},{"line_number":748,"context_line":"            self.heartbeat \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":749,"context_line":"                self._report_state)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FmAI%3D","line":746,"in_reply_to":"AAAAPn%2F%2Fmak%3D","updated":"2013-06-27 05:34:52.000000000","message":"Done","commit_id":"dcbb4814dfd1d878534e7ebcedfffa490c5cf50b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ef46967db9434fe189bb3366447e0dd50a49420","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            \u0027start_flag\u0027: True,"},{"line_number":744,"context_line":"            \u0027agent_type\u0027: constants.AGENT_TYPE_DHCP}"},{"line_number":745,"context_line":"        report_interval \u003d cfg.CONF.AGENT.report_interval"},{"line_number":746,"context_line":"        self.call \u003d True"},{"line_number":747,"context_line":"        if report_interval:"},{"line_number":748,"context_line":"            self.heartbeat \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":749,"context_line":"                self._report_state)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fmak%3D","line":746,"in_reply_to":"AAAAPn%2F%2FnL0%3D","updated":"2013-06-26 23:07:51.000000000","message":"nice advice, I will change my +2 back after this change. thanks","commit_id":"dcbb4814dfd1d878534e7ebcedfffa490c5cf50b"}],"quantum/agent/l3_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":758,"context_line":"            self.heartbeat.stop()"},{"line_number":759,"context_line":"            return"},{"line_number":760,"context_line":"        except Exception:"},{"line_number":761,"context_line":"            self.call \u003d True"},{"line_number":762,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def agent_updated(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F05A%3D","line":761,"updated":"2013-06-20 10:12:36.000000000","message":"I think you\u0027re introducing self.call for ensuring that is the server does not support report_state than AttributeError is raised and the hearthbeating stops, which looks ok to me.\n\nBut why restore it to true in case of generic exceptions?\nI think once the first report_state works with call we can use cast in all other instances.","commit_id":"0ba4dd2fcde45df5a9e0c7203a1d7d132f68a3be"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ef46967db9434fe189bb3366447e0dd50a49420","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            self.heartbeat.stop()"},{"line_number":759,"context_line":"            return"},{"line_number":760,"context_line":"        except Exception:"},{"line_number":761,"context_line":"            self.call \u003d True"},{"line_number":762,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def agent_updated(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FuEk%3D","line":761,"in_reply_to":"AAAAPn%2F%2F01g%3D","updated":"2013-06-24 14:37:55.000000000","message":"I am afraid even if the broker is down, the cast will not throw an exception.","commit_id":"0ba4dd2fcde45df5a9e0c7203a1d7d132f68a3be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"230eb57d8a341365ac12d0da4e906d4a677ada4a","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            self.heartbeat.stop()"},{"line_number":759,"context_line":"            return"},{"line_number":760,"context_line":"        except Exception:"},{"line_number":761,"context_line":"            self.call \u003d True"},{"line_number":762,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def agent_updated(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F01g%3D","line":761,"in_reply_to":"AAAAPn%2F%2F05A%3D","updated":"2013-06-20 10:36:09.000000000","message":"My concern here is that the call message has a timeout. This could be due to the fact that the quantum service is down/under heavy load when the first call message takes place. Or even worse, the message broker is down. It is just to be on the safe side.","commit_id":"0ba4dd2fcde45df5a9e0c7203a1d7d132f68a3be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":758,"context_line":"            self.heartbeat.stop()"},{"line_number":759,"context_line":"            return"},{"line_number":760,"context_line":"        except Exception:"},{"line_number":761,"context_line":"            self.call \u003d True"},{"line_number":762,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def agent_updated(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FtyI%3D","line":761,"in_reply_to":"AAAAPn%2F%2FuEk%3D","updated":"2013-06-24 16:28:23.000000000","message":"yes, you guys are correct. i can and should remove this setting here","commit_id":"0ba4dd2fcde45df5a9e0c7203a1d7d132f68a3be"}],"quantum/agent/rpc.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c037a45d18b324cd3216a9aa27f14e2016a5601","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":56,"context_line":"        return self.cast(context,"},{"line_number":57,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":58,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":59,"context_line":"                                                    agent_state},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F9a8%3D","line":56,"updated":"2013-06-17 12:00:08.000000000","message":"We keep switching between cast and call for this line!\n\nSwitching back to cast might cause a regression of bug 1159581 which you fixed with commit 1586cab03175060ce6c9e5f444ce67a4d9e50eea\n\nwhat do you think?","commit_id":"6dea2d878bf7e808e43578ae3375f63870575066"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":56,"context_line":"        return self.cast(context,"},{"line_number":57,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":58,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":59,"context_line":"                                                    agent_state},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F9X8%3D","line":56,"in_reply_to":"AAAAPn%2F%2F9Zs%3D","updated":"2013-06-17 12:31:54.000000000","message":"It is better to have a comment why we need call here instead of cast to avoid a future confusion.","commit_id":"6dea2d878bf7e808e43578ae3375f63870575066"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"230eb57d8a341365ac12d0da4e906d4a677ada4a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":56,"context_line":"        return self.cast(context,"},{"line_number":57,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":58,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":59,"context_line":"                                                    agent_state},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F9Zs%3D","line":56,"in_reply_to":"AAAAPn%2F%2F9a8%3D","updated":"2013-06-17 12:07:42.000000000","message":"I think that I want to cry :)\nhttps://bugs.launchpad.net/quantum/+bug/1159581\nThe issue here is that the agent needs to catch and exception that the function is not supported to roll back to to not sending the report states.\nI\u0027ll try and find a way of resolving this. Good catch!","commit_id":"6dea2d878bf7e808e43578ae3375f63870575066"}]}