)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1e1f698562c6fcf00f2264a195e7211927f24df2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    m \u003d _(\"ofctl request %(request)s timed out\") % {"},{"line_number":85,"context_line":"                        \"request\": msg,"},{"line_number":86,"context_line":"                    }"},{"line_number":87,"context_line":"                    LOG.error(m)"},{"line_number":88,"context_line":"                    # NOTE(yamamoto): use RuntimeError for compat with ovs_lib"},{"line_number":89,"context_line":"                    raise RuntimeError(m)"},{"line_number":90,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f1a2654a","line":87,"updated":"2016-06-23 01:37:40.000000000","message":"This doesn\u0027t make sense to me. Based on the guidelines it says to use \u0027_(\u0027 if it\u0027s going to be user-facing and then _LE if it\u0027s going to logs. This exception will go to the agent\u0027s log file as well and won\u0027t be shown to a user so that doesn\u0027t seem like it should qualify for \u0027_(\u0027.","commit_id":"e48fa66c6de6255d8521f80d6edbc54e82228f89"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7a2c44bb2fe522d9d5c8af2841add73579ba1eea","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    m \u003d _(\"ofctl request %(request)s timed out\") % {"},{"line_number":85,"context_line":"                        \"request\": msg,"},{"line_number":86,"context_line":"                    }"},{"line_number":87,"context_line":"                    LOG.error(m)"},{"line_number":88,"context_line":"                    # NOTE(yamamoto): use RuntimeError for compat with ovs_lib"},{"line_number":89,"context_line":"                    raise RuntimeError(m)"},{"line_number":90,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f1d7febc","line":87,"in_reply_to":"3aaa91ec_f1a2654a","updated":"2016-06-23 06:19:22.000000000","message":"@Kevin, please look below, the message is raised as part of an exception. Exception messages should not have log hints. Please look at http://docs.openstack.org/developer/oslo.i18n/guidelines.html\nWhat is written here is correct","commit_id":"e48fa66c6de6255d8521f80d6edbc54e82228f89"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"19dd5e40756e6310ba5c23bcbec9b6bff1355b76","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    m \u003d _(\"ofctl request %(request)s timed out\") % {"},{"line_number":85,"context_line":"                        \"request\": msg,"},{"line_number":86,"context_line":"                    }"},{"line_number":87,"context_line":"                    LOG.error(m)"},{"line_number":88,"context_line":"                    # NOTE(yamamoto): use RuntimeError for compat with ovs_lib"},{"line_number":89,"context_line":"                    raise RuntimeError(m)"},{"line_number":90,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a7613807","line":87,"in_reply_to":"3aaa91ec_f1d7febc","updated":"2016-06-26 09:46:32.000000000","message":"@Kevin,  Because of LN 89, this message is user facing as well.\nDoes that make sense now?","commit_id":"e48fa66c6de6255d8521f80d6edbc54e82228f89"}]}