)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9493216254d53a43968bab3272773db444c6d3a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Auto Scheduling for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DHCP agent is scheduled on segments if not already scheduled"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7d9f01dbd6d9c216474ee47c968919c1826787f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aa78d24_ea3bb436","line":9,"updated":"2016-07-08 18:48:12.000000000","message":"The commit message should give some context about the issue or improvement that it\u0027s trying to solve","commit_id":"6867873616bf24a741bb62ed35165561e6d4775f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2ce1c4093b7acdde6ea3955c4c198b5508ce1a23","unresolved":false,"context_lines":[{"line_number":12,"context_line":"segment to the DHCP agent."},{"line_number":13,"context_line":"1. Find ids of all networks which have subnets and segments on the given host"},{"line_number":14,"context_line":"  1.1 If no networks, host is not part of a segment, continue the old way"},{"line_number":15,"context_line":"  1.2 If more than one network, then raise exception host connected to"},{"line_number":16,"context_line":"      multiple segments"},{"line_number":17,"context_line":"  1.3 If one network"},{"line_number":18,"context_line":"      1.3.1 Check if number of dhcp agents on network is less than max no of"},{"line_number":19,"context_line":"            dhcp agents."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1aa78d24_8b526011","line":16,"range":{"start_line":15,"start_character":6,"end_line":16,"end_character":23},"updated":"2016-07-12 22:01:59.000000000","message":"I\u0027m not sure this is quite right.  We are currently restricting a host to connecting to only one segment of a given network.  But, we do not restrict how many networks that host can connect to.  A host can connected to multiple routed networks, just one segment for each of them.","commit_id":"b1acbf1fb0bd105943f9227dc4992293806f9a91"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"38d7dff27af98e7f6817680628389e93d076ad3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"segment to the DHCP agent."},{"line_number":13,"context_line":"1. Find ids of all networks which have subnets and segments on the given host"},{"line_number":14,"context_line":"  1.1 If no networks, host is not part of a segment, continue the old way"},{"line_number":15,"context_line":"  1.2 If more than one network, then raise exception host connected to"},{"line_number":16,"context_line":"      multiple segments"},{"line_number":17,"context_line":"  1.3 If one network"},{"line_number":18,"context_line":"      1.3.1 Check if number of dhcp agents on network is less than max no of"},{"line_number":19,"context_line":"            dhcp agents."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1aa78d24_d5ea190e","line":16,"range":{"start_line":15,"start_character":6,"end_line":16,"end_character":23},"in_reply_to":"1aa78d24_8b526011","updated":"2016-07-13 15:46:55.000000000","message":"ok, got it","commit_id":"b1acbf1fb0bd105943f9227dc4992293806f9a91"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2ce1c4093b7acdde6ea3955c4c198b5508ce1a23","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  1.2 If more than one network, then raise exception host connected to"},{"line_number":16,"context_line":"      multiple segments"},{"line_number":17,"context_line":"  1.3 If one network"},{"line_number":18,"context_line":"      1.3.1 Check if number of dhcp agents on network is less than max no of"},{"line_number":19,"context_line":"            dhcp agents."},{"line_number":20,"context_line":"      1.3.2 Check if dhcp agent availability zone is in availability zone"},{"line_number":21,"context_line":"            hints of the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1aa78d24_ab763ca1","line":18,"range":{"start_line":18,"start_character":46,"end_line":18,"end_character":53},"updated":"2016-07-12 22:01:59.000000000","message":"segment?","commit_id":"b1acbf1fb0bd105943f9227dc4992293806f9a91"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"38d7dff27af98e7f6817680628389e93d076ad3d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  1.2 If more than one network, then raise exception host connected to"},{"line_number":16,"context_line":"      multiple segments"},{"line_number":17,"context_line":"  1.3 If one network"},{"line_number":18,"context_line":"      1.3.1 Check if number of dhcp agents on network is less than max no of"},{"line_number":19,"context_line":"            dhcp agents."},{"line_number":20,"context_line":"      1.3.2 Check if dhcp agent availability zone is in availability zone"},{"line_number":21,"context_line":"            hints of the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1aa78d24_489850c0","line":18,"range":{"start_line":18,"start_character":46,"end_line":18,"end_character":53},"in_reply_to":"1aa78d24_ab763ca1","updated":"2016-07-13 15:46:55.000000000","message":"i meant network, used value from cfg.CONF.dhcp_agents_per_network.\ndoes it make sense to have this check?","commit_id":"b1acbf1fb0bd105943f9227dc4992293806f9a91"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"3a23f62f4e27133d385a9687ae576c9495514c1d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In routed provider networks, a network can be divided by segments and each"},{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling  scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d9f01dbd6d9c216474ee47c968919c1826787f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dada55a8_1bf8bd48","line":11,"range":{"start_line":11,"start_character":65,"end_line":11,"end_character":67},"updated":"2016-07-20 12:53:44.000000000","message":"teeny tiny nit: extra space","commit_id":"e88018607b932fdb18d4d90f4b7794b9b2c6c2fe"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"3a23f62f4e27133d385a9687ae576c9495514c1d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling  scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d9f01dbd6d9c216474ee47c968919c1826787f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dada55a8_61514836","line":13,"updated":"2016-07-20 12:53:44.000000000","message":"Partially-implements: blueprint routed-networks","commit_id":"e88018607b932fdb18d4d90f4b7794b9b2c6c2fe"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af69a43bff95a0af46e6300957469de6fdc7b019","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP Auto Scheduling for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In routed provider networks, a network can be divided by segments and each"},{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dada55a8_ef187186","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":74},"updated":"2016-07-26 15:53:08.000000000","message":"nit: this exceeds the limit of 72 chars in the description","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP Auto Scheduling for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In routed provider networks, a network can be divided by segments and each"},{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dada55a8_01de62dc","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":74},"in_reply_to":"dada55a8_ef187186","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af69a43bff95a0af46e6300957469de6fdc7b019","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In routed provider networks, a network can be divided by segments and each"},{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d9f01dbd6d9c216474ee47c968919c1826787f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dada55a8_0f14e54a","line":11,"updated":"2016-07-26 15:53:08.000000000","message":"ditto: line 9","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In routed provider networks, a network can be divided by segments and each"},{"line_number":10,"context_line":"segment will have its own DHCP agent."},{"line_number":11,"context_line":"AutoScheduling for networks exists. This patchset is for enabling scheduling"},{"line_number":12,"context_line":"of non-hosted segment to the DHCP agent."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d9f01dbd6d9c216474ee47c968919c1826787f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dada55a8_e1d86ef1","line":11,"in_reply_to":"dada55a8_0f14e54a","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"0944c13285061d45dad5b3bf220888562ad691ab","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        segments_not_scheduled \u003d query.all()"},{"line_number":97,"context_line":"        for entry in segments_not_scheduled:"},{"line_number":98,"context_line":"            host \u003d entry[1]"},{"line_number":99,"context_line":"            helpers.register_dhcp_agent(host)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class ChanceScheduler(base_scheduler.BaseChanceScheduler, AutoScheduler):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_836a57b1","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":45},"updated":"2016-06-24 14:32:00.000000000","message":"this method is in neutron/tests/common/helpers\nneed to find another method which registers dhcp agent on host","commit_id":"1663b1a9be01f35d1938b2f07b47671c5ebf6747"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4ab8490247cf2480d85da0f4b07cb330beae6110","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027]"},{"line_number":50,"context_line":"            subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            # check if network has segment"},{"line_number":53,"context_line":"            query \u003d context.session.query(segments_db.NetworkSegment)"},{"line_number":54,"context_line":"            network_segments \u003d query.all()"},{"line_number":55,"context_line":"            if len(network_segments) \u003d\u003d 0:"},{"line_number":56,"context_line":"                LOG.debug(\"no segments on this network continue as it is\")"},{"line_number":57,"context_line":"                net_ids \u003d set(s[\u0027network_id\u0027] for s in subnets"},{"line_number":58,"context_line":"                              if s[\u0027enable_dhcp\u0027])"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0d03ca0e","line":56,"range":{"start_line":52,"start_character":0,"end_line":56,"end_character":74},"updated":"2016-06-28 02:23:38.000000000","message":"You are querying all segments, not segments on network. So, the comment and log here might need change.","commit_id":"eae34a2a13f1926bdd570224009735fe56b7dca6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4ab8490247cf2480d85da0f4b07cb330beae6110","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                #multiple segments on network"},{"line_number":63,"context_line":"                #find all the net_ids for the newtorks that contains"},{"line_number":64,"context_line":"                #segment on a given host"},{"line_number":65,"context_line":"                query \u003d context.session.query("},{"line_number":66,"context_line":"                    segments_db.NetworkSegment.network_id).join("},{"line_number":67,"context_line":"                    segmenthostmappings_db.SegmentHostMapping,"},{"line_number":68,"context_line":"                    segments_db.NetworkSegment.id \u003d\u003d"},{"line_number":69,"context_line":"                    segmenthostmappings_db.SegmentHostMapping.segment_id)\\"},{"line_number":70,"context_line":"                    .filter(segmenthostmappings_db.SegmentHostMapping.host \u003d\u003d"},{"line_number":71,"context_line":"                    host)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"                net_ids \u003d query.all()"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_adaef6e4","line":71,"range":{"start_line":65,"start_character":0,"end_line":71,"end_character":25},"updated":"2016-06-28 02:23:38.000000000","message":"I think the process here should be divided into two: one is for routed network(subnet with segment), the other is for l2-adjacent network.\n\nFor the routed network, the segment scheduling is required. For l2-adjacent network, the original logic should be keep.","commit_id":"eae34a2a13f1926bdd570224009735fe56b7dca6"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9943eff81444b232a489c7226cc1dc5daf7ee542","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            query \u003d context.session.query(sh_db.SegmentHostMapping)"},{"line_number":54,"context_line":"            query \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":55,"context_line":"            # given: one segment per host"},{"line_number":56,"context_line":"            num_segments \u003d query.all()"},{"line_number":57,"context_line":"            if len(num_segments) \u003d\u003d 0:"},{"line_number":58,"context_line":"                net_ids \u003d set(s[\u0027network_id\u0027] for s in subnets"},{"line_number":59,"context_line":"                              if s[\u0027enable_dhcp\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_00382fed","line":56,"updated":"2016-06-30 06:06:21.000000000","message":"i think you should get all segment_ids from all the subnets first, then check the segment host mapping for host.  this way you can determine fairly quickly if a segment can be auto scheduled or not.\n\nEvery other subnet that does not have a segment_id should continue the the old way.","commit_id":"7a44b5ba2b373620081e37a1e9b9efb6cb68e63a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9493216254d53a43968bab3272773db444c6d3a9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027]"},{"line_number":85,"context_line":"                subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":86,"context_line":"                net_ids \u003d set(s[\u0027network_id\u0027] for s in subnets"},{"line_number":87,"context_line":"                              if s[\u0027enable_dhcp\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"                if not net_ids:"},{"line_number":90,"context_line":"                    LOG.debug(\u0027No non-hosted networks\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_751cca77","line":87,"range":{"start_line":87,"start_character":33,"end_line":87,"end_character":49},"updated":"2016-07-08 18:48:12.000000000","message":"Maybe you can avoid this line if you include enable_dhcp as filter in the previous query.","commit_id":"6867873616bf24a741bb62ed35165561e6d4775f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9493216254d53a43968bab3272773db444c6d3a9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":91,"context_line":"                    return False"},{"line_number":92,"context_line":"                query \u003d context.session.query(agents_db.Agent)"},{"line_number":93,"context_line":"                query \u003d query.filter(agents_db.Agent.agent_type \u003d\u003d"},{"line_number":94,"context_line":"                                     constants.AGENT_TYPE_DHCP,"},{"line_number":95,"context_line":"                                     agents_db.Agent.host \u003d\u003d host,"},{"line_number":96,"context_line":"                                     agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":97,"context_line":"                                     sql.true())"},{"line_number":98,"context_line":"                dhcp_agents \u003d query.all()"},{"line_number":99,"context_line":"                for dhcp_agent in dhcp_agents:"},{"line_number":100,"context_line":"                    if agents_db.AgentDbMixin.is_agent_down("},{"line_number":101,"context_line":"                        dhcp_agent.heartbeat_timestamp):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_7051780e","line":98,"range":{"start_line":93,"start_character":0,"end_line":98,"end_character":41},"updated":"2016-07-08 18:48:12.000000000","message":"You can create a method with these instructions","commit_id":"6867873616bf24a741bb62ed35165561e6d4775f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9493216254d53a43968bab3272773db444c6d3a9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                     sql.true())"},{"line_number":98,"context_line":"                dhcp_agents \u003d query.all()"},{"line_number":99,"context_line":"                for dhcp_agent in dhcp_agents:"},{"line_number":100,"context_line":"                    if agents_db.AgentDbMixin.is_agent_down("},{"line_number":101,"context_line":"                        dhcp_agent.heartbeat_timestamp):"},{"line_number":102,"context_line":"                        LOG.warning(_LW(\u0027DHCP agent %s is not active\u0027),"},{"line_number":103,"context_line":"                                    dhcp_agent.id)"},{"line_number":104,"context_line":"                        continue"},{"line_number":105,"context_line":"                    for net_id in net_ids:"},{"line_number":106,"context_line":"                        agents \u003d plugin.get_dhcp_agents_hosting_networks("}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_50e71c40","line":103,"range":{"start_line":100,"start_character":21,"end_line":103,"end_character":50},"updated":"2016-07-08 18:48:12.000000000","message":"ditto: these validation can be shared and reduce code","commit_id":"6867873616bf24a741bb62ed35165561e6d4775f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4baa1bd7b7db395bb2aed79f2bbecb4e5324065b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                subnet_db.Subnet.network_id).join("},{"line_number":51,"context_line":"                sh_db.SegmentHostMapping,"},{"line_number":52,"context_line":"                subnet_db.Subnet.segment_id \u003d\u003d"},{"line_number":53,"context_line":"                sh_db.SegmentHostMapping.segment_id).distinct()\\"},{"line_number":54,"context_line":"                .filter(sh_db.SegmentHostMapping.host \u003d\u003d"},{"line_number":55,"context_line":"                host)"},{"line_number":56,"context_line":"            net_ids \u003d query.all()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_7a1b2e1d","line":53,"range":{"start_line":53,"start_character":53,"end_line":53,"end_character":63},"updated":"2016-07-14 06:42:54.000000000","message":"what column is this choosing to be distinct? I can\u0027t tell from the sqlalchemy docs. I think its just Subnet.network_id.\n\nAnyway, to make this query more readable, could you break up into something like this:\n\nquery \u003d context.session.query(subnet_db.Subnet.network_id)\nquery \u003d query.join(\n    sh_db.SegmentHostMapping,\n    subnet_db.Subnet.segment_id \u003d\u003d\n    sh_db.SegmentHostMapping.segment_id).distinct()\nquery \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)","commit_id":"8e2baa5091e9c62e1a27f8f95067d6098334f617"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8e69fef852d6a86c879c86cfde22077184d04fb9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                subnet_db.Subnet.network_id).join("},{"line_number":51,"context_line":"                sh_db.SegmentHostMapping,"},{"line_number":52,"context_line":"                subnet_db.Subnet.segment_id \u003d\u003d"},{"line_number":53,"context_line":"                sh_db.SegmentHostMapping.segment_id).distinct()\\"},{"line_number":54,"context_line":"                .filter(sh_db.SegmentHostMapping.host \u003d\u003d"},{"line_number":55,"context_line":"                host)"},{"line_number":56,"context_line":"            net_ids \u003d query.all()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fad55976_7896a395","line":53,"range":{"start_line":53,"start_character":53,"end_line":53,"end_character":63},"in_reply_to":"1aa78d24_7a1b2e1d","updated":"2016-07-15 20:13:06.000000000","message":"it is Subnet.network_id, used distinct to avoid duplicate network_id if more than one subnet exist on a given network","commit_id":"8e2baa5091e9c62e1a27f8f95067d6098334f617"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4baa1bd7b7db395bb2aed79f2bbecb4e5324065b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                .filter(sh_db.SegmentHostMapping.host \u003d\u003d"},{"line_number":55,"context_line":"                host)"},{"line_number":56,"context_line":"            net_ids \u003d query.all()"},{"line_number":57,"context_line":"            if len(net_ids) !\u003d 0:"},{"line_number":58,"context_line":"                routed_networks \u003d True"},{"line_number":59,"context_line":"                net_ids \u003d net_ids[0]"},{"line_number":60,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_dac22234","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":33},"updated":"2016-07-14 06:42:54.000000000","message":"if net_ids:","commit_id":"8e2baa5091e9c62e1a27f8f95067d6098334f617"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4baa1bd7b7db395bb2aed79f2bbecb4e5324065b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            net_ids \u003d query.all()"},{"line_number":57,"context_line":"            if len(net_ids) !\u003d 0:"},{"line_number":58,"context_line":"                routed_networks \u003d True"},{"line_number":59,"context_line":"                net_ids \u003d net_ids[0]"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027]"},{"line_number":62,"context_line":"                subnets \u003d plugin.get_subnets(context, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_3ab366eb","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":36},"updated":"2016-07-14 06:42:54.000000000","message":"this makes net_ids no longer a list.  And you the code starts iterating over net_ids as if its a list at L80.\n\nI\u0027m not sure why you just want the first network_id from the query and do nothing with the rest of the network_ids though.","commit_id":"8e2baa5091e9c62e1a27f8f95067d6098334f617"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4baa1bd7b7db395bb2aed79f2bbecb4e5324065b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                        query \u003d context.session.query(subnet_db.Network."},{"line_number":87,"context_line":"                                availability_zone_hints)"},{"line_number":88,"context_line":"                        query \u003d query.filter(subnet_db.Network.id \u003d\u003d net_id)"},{"line_number":89,"context_line":"                        az_hints \u003d (query.all()[0][0] or"},{"line_number":90,"context_line":"                                    cfg.CONF.default_availability_zones)"},{"line_number":91,"context_line":"                    else:"},{"line_number":92,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_5afc7272","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":50},"updated":"2016-07-14 06:42:54.000000000","message":"query.first()\n\nHowever, I think you\u0027re going to have to still check if that return value is a list and if its non-empty before you pull the 0 index out.","commit_id":"8e2baa5091e9c62e1a27f8f95067d6098334f617"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"09caf113108bbd0d8128f2d70489247091431a11","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            net_ids \u003d query.all()"},{"line_number":57,"context_line":"            if net_ids:"},{"line_number":58,"context_line":"                routed_networks \u003d True"},{"line_number":59,"context_line":"                net_ids \u003d [t[0] for t in net_ids]"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027]"},{"line_number":62,"context_line":"                subnets \u003d plugin.get_subnets(context, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_4a82d401","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":31},"updated":"2016-07-18 13:17:23.000000000","message":"Please, use \u0027t.network_id\u0027 instead of \u0027t[0]\u0027.","commit_id":"fb940e2b3a7d238e9b4d737126361248a8387eee"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"09caf113108bbd0d8128f2d70489247091431a11","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if net_ids:"},{"line_number":58,"context_line":"                routed_networks \u003d True"},{"line_number":59,"context_line":"                net_ids \u003d [t[0] for t in net_ids]"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027]"},{"line_number":62,"context_line":"                subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":63,"context_line":"                net_ids \u003d set(s[\u0027network_id\u0027] for s in subnets"},{"line_number":64,"context_line":"                              if s[\u0027enable_dhcp\u0027])"},{"line_number":65,"context_line":"            if not net_ids:"},{"line_number":66,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":67,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_6affd834","line":64,"range":{"start_line":60,"start_character":0,"end_line":64,"end_character":50},"updated":"2016-07-18 13:17:23.000000000","message":"As far as I understand, it is possible to have both routed and regular networks at the same time on the same host. But this \u0027if\u0027 block does not allow for that and the regular networks will not be auto-scheduled if a router network exists (i.e. net_ids non-empty).","commit_id":"fb940e2b3a7d238e9b4d737126361248a8387eee"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ce1437ba187fbd9c9db5a72519963e8ce898cc83","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            for s in subnets:"},{"line_number":51,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":52,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d (True"},{"line_number":53,"context_line":"                    if s[\u0027segment_id\u0027] is not None else False)"},{"line_number":54,"context_line":"            if not net_ids:"},{"line_number":55,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":56,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_b591de54","line":53,"range":{"start_line":53,"start_character":20,"end_line":53,"end_character":50},"updated":"2016-07-19 21:43:15.000000000","message":"if \u0027segment_id\u0027 in s and s[\u0027segment_id\u0027] else False","commit_id":"085da6a76aae44f72bb51c8565121d239e347626"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"3a23f62f4e27133d385a9687ae576c9495514c1d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            net_ids \u003d {}"},{"line_number":50,"context_line":"            for s in subnets:"},{"line_number":51,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":52,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d True \\"},{"line_number":53,"context_line":"                        if(\u0027segment_id\u0027 in s and s[\u0027segment_id\u0027] is not None) \\"},{"line_number":54,"context_line":"                        else False"},{"line_number":55,"context_line":"            if not net_ids:"},{"line_number":56,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":57,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_b6e6e8ad","line":54,"range":{"start_line":52,"start_character":20,"end_line":54,"end_character":34},"updated":"2016-07-20 12:53:44.000000000","message":"This can be shortened to:\nnet_ids[s[\u0027network_id\u0027]] \u003d (s.get(\u0027segment_id\u0027) is not None)","commit_id":"e88018607b932fdb18d4d90f4b7794b9b2c6c2fe"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ac227b1621c5ef0ccc51fec6094176a1cd68597e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            net_ids \u003d {}"},{"line_number":50,"context_line":"            for s in subnets:"},{"line_number":51,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":52,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d \\"},{"line_number":53,"context_line":"                        (s.get(\u0027segment_id\u0027) is not None)"},{"line_number":54,"context_line":"            if not net_ids:"},{"line_number":55,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":56,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a1a43708","line":53,"range":{"start_line":52,"start_character":20,"end_line":53,"end_character":57},"updated":"2016-07-23 23:45:47.000000000","message":"According to http://docs.openstack.org/developer/hacking/, \"It is preferred to wrap long lines in parentheses and not a backslash for line continuation.\"\n\nIn this case, we can easily wrap the line as follows, since you have the parentheses anyway:\n\nnet_ids[s[\u0027network_id\u0027]] \u003d (s.get(\u0027segment_id\u0027) is not\n                            None)","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            net_ids \u003d {}"},{"line_number":50,"context_line":"            for s in subnets:"},{"line_number":51,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":52,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d \\"},{"line_number":53,"context_line":"                        (s.get(\u0027segment_id\u0027) is not None)"},{"line_number":54,"context_line":"            if not net_ids:"},{"line_number":55,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":56,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_61f3de73","line":53,"range":{"start_line":52,"start_character":20,"end_line":53,"end_character":57},"in_reply_to":"dada55a8_a1a43708","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ac227b1621c5ef0ccc51fec6094176a1cd68597e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    LOG.warning(_LW(\u0027DHCP agent %s is not active\u0027),"},{"line_number":67,"context_line":"                                dhcp_agent.id)"},{"line_number":68,"context_line":"                    continue"},{"line_number":69,"context_line":"                for net_id, routed_networks in net_ids.items():"},{"line_number":70,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":71,"context_line":"                        context, [net_id])"},{"line_number":72,"context_line":"                    if not routed_networks:"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_413bbb9c","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":43},"updated":"2016-07-23 23:45:47.000000000","message":"Since the values stored in net_ids are booleans, I think it readability will be improved if you call this variable \u0027is_routed_network\u0027.\n\nI found \u0027routed_networks\u0027 misleading. We are not referring to a collection of routed networks. We are referring to whether a single network is routed or not","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    LOG.warning(_LW(\u0027DHCP agent %s is not active\u0027),"},{"line_number":67,"context_line":"                                dhcp_agent.id)"},{"line_number":68,"context_line":"                    continue"},{"line_number":69,"context_line":"                for net_id, routed_networks in net_ids.items():"},{"line_number":70,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":71,"context_line":"                        context, [net_id])"},{"line_number":72,"context_line":"                    if not routed_networks:"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_c1e60aaf","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":43},"in_reply_to":"dada55a8_413bbb9c","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ac227b1621c5ef0ccc51fec6094176a1cd68597e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                for net_id, routed_networks in net_ids.items():"},{"line_number":70,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":71,"context_line":"                        context, [net_id])"},{"line_number":72,"context_line":"                    if not routed_networks:"},{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a140b708","line":72,"range":{"start_line":72,"start_character":27,"end_line":72,"end_character":42},"updated":"2016-07-23 23:45:47.000000000","message":"Please see my comment @L69","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                for net_id, routed_networks in net_ids.items():"},{"line_number":70,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":71,"context_line":"                        context, [net_id])"},{"line_number":72,"context_line":"                    if not routed_networks:"},{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a1e95681","line":72,"range":{"start_line":72,"start_character":27,"end_line":72,"end_character":42},"in_reply_to":"dada55a8_a140b708","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a27c00115e6dba5f4c4aa952b60a0d451b02ccf5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"},{"line_number":76,"context_line":"                            continue"},{"line_number":77,"context_line":"                    net \u003d plugin.get_network(context, net_id)"},{"line_number":78,"context_line":"                    az_hints \u003d (net.get(az_ext.AZ_HINTS) or"},{"line_number":79,"context_line":"                                cfg.CONF.default_availability_zones)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_5aa55c02","line":76,"updated":"2016-07-25 00:48:49.000000000","message":"I might be missing something, but it seems to me that we need an else block to add logic to handle the case when we are dealing with a routed network. I modified the 3 test cases in https://review.openstack.org/#/c/333716/16/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py@295. In the 3 test cases (test_auto_schedule_one_network_one_segment_one_subnet, test_auto_schedule_one_network_one_segment_two_subnet, test_auto_schedule_one_network_two_segments_with_one_subnet_each). I just commented out the calls to segments_service_db.update_segment_host_mapping. The test cases succeed anyway: http://paste.openstack.org/show/541270/. So either we are missing logic here, or we don\u0027t need the calls to segments_service_db.update_segment_host_mapping in the test cases","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"},{"line_number":76,"context_line":"                            continue"},{"line_number":77,"context_line":"                    net \u003d plugin.get_network(context, net_id)"},{"line_number":78,"context_line":"                    az_hints \u003d (net.get(az_ext.AZ_HINTS) or"},{"line_number":79,"context_line":"                                cfg.CONF.default_availability_zones)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a4a6840c","line":76,"in_reply_to":"dada55a8_5aa55c02","updated":"2016-07-27 03:04:03.000000000","message":"removed calls to segments_service_db.update_segment_host_mapping in test cases","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cfff37d548f880eccc1809c58c202ca97be17e5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    LOG.warning(_LW(\u0027DHCP agent %s is not active\u0027),"},{"line_number":67,"context_line":"                                dhcp_agent.id)"},{"line_number":68,"context_line":"                    continue"},{"line_number":69,"context_line":"                for net_id, is_routed_networks in net_ids.items():"},{"line_number":70,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":71,"context_line":"                        context, [net_id])"},{"line_number":72,"context_line":"                    if not is_routed_networks:"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_b4e145d3","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":46},"updated":"2016-07-27 18:28:02.000000000","message":"Nit. I would drop the s at the end of this name. In each iteration of this loop, we are dealing only with one network. This kind of thing really improve readability. It takes one extra mental step when reading this code to realize that it refers to one network. While it is not much extra effort, why not help your readers?","commit_id":"e70e35d1e2bb652b95d5f42a817602389f60cc42"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ca5b90b04b51a8a8a85075b8e04dc03c196a0faf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"},{"line_number":76,"context_line":"                            continue"},{"line_number":77,"context_line":"                    net \u003d plugin.get_network(context, net_id)"},{"line_number":78,"context_line":"                    az_hints \u003d (net.get(az_ext.AZ_HINTS) or"},{"line_number":79,"context_line":"                                cfg.CONF.default_availability_zones)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_15421cae","line":76,"updated":"2016-07-27 05:43:41.000000000","message":"i do believe you need to handle if it is a routed network as an else statement (or as a replacement for this if statement).  If a network is a routed network then you will need to gather all the dhcp enabled subnets it has and make a set of segment ids.  For each unique segment_id you will need to check if the segment has a mapping to the host.  If none of the segments have a mapping to the host, continue the loop.\n\nIf any of the segments do, then you\u0027ll probably need to do the same checks as 73-76, so that will be common for both routed networks and non routed networks.  Hence, why I said preivously that the if statement on L72 can just be turned into if is_routed_networks and do the logic in the first paragraph.  L73-76 would move after the if statement.\n\nThe main idea to take away from this is if a network is a routed network and the host being auto scheduled does not touch a segment under that network, then don\u0027t schedule that network to the dhcp agent on that host.","commit_id":"e70e35d1e2bb652b95d5f42a817602389f60cc42"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cfff37d548f880eccc1809c58c202ca97be17e5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"},{"line_number":74,"context_line":"                            continue"},{"line_number":75,"context_line":"                        if any(dhcp_agent.id \u003d\u003d agent.id for agent in agents):"},{"line_number":76,"context_line":"                            continue"},{"line_number":77,"context_line":"                    net \u003d plugin.get_network(context, net_id)"},{"line_number":78,"context_line":"                    az_hints \u003d (net.get(az_ext.AZ_HINTS) or"},{"line_number":79,"context_line":"                                cfg.CONF.default_availability_zones)"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_5468c9ba","line":76,"in_reply_to":"dada55a8_15421cae","updated":"2016-07-27 18:28:02.000000000","message":"Fully agree with Brandon. Removing the calls to update the segment host mapping from the unit tests is clearly not the solution. We need to decide here whether the host is touching a segment (and therefore the network) or not","commit_id":"e70e35d1e2bb652b95d5f42a817602389f60cc42"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9a37390d38c2b6465a0b91287c761c924059f9e0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def auto_schedule_networks(self, plugin, context, host):"},{"line_number":42,"context_line":"        \"\"\"Schedule non-hosted networks to the DHCP agent on the specified"},{"line_number":43,"context_line":"           host."},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        agents_per_network \u003d cfg.CONF.dhcp_agents_per_network"},{"line_number":46,"context_line":"        # a list of (agent, net_ids) tuples"},{"line_number":47,"context_line":"        bindings_to_add \u003d []"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_6afe9339","line":44,"updated":"2016-07-28 16:13:58.000000000","message":"As this code is enabling the scheduling of non-hosted segment to the DHCP agent in addition to the scheduling of non-hosted networks to the DHCP agent, adding this information in the docstring of this method will improve readability of the code","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ddefb2ca6a371921bed900a9dad12dba8c0ce9e7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def auto_schedule_networks(self, plugin, context, host):"},{"line_number":42,"context_line":"        \"\"\"Schedule non-hosted networks to the DHCP agent on the specified"},{"line_number":43,"context_line":"           host."},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        agents_per_network \u003d cfg.CONF.dhcp_agents_per_network"},{"line_number":46,"context_line":"        # a list of (agent, net_ids) tuples"},{"line_number":47,"context_line":"        bindings_to_add \u003d []"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_cb5e97e8","line":44,"in_reply_to":"bacf61ea_6afe9339","updated":"2016-07-28 19:55:36.000000000","message":"this description looks good to me, networks include regular and routed network, do you have anything in mind?","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9a37390d38c2b6465a0b91287c761c924059f9e0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                for net_id, is_routed_network in net_ids.items():"},{"line_number":72,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":73,"context_line":"                        context, [net_id])"},{"line_number":74,"context_line":"                    if is_routed_network:"},{"line_number":75,"context_line":"                        query \u003d context.session.query("},{"line_number":76,"context_line":"                            subnet_db.Subnet.segment_id)"},{"line_number":77,"context_line":"                        query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_57589332","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":20},"updated":"2016-07-28 16:13:58.000000000","message":"line:74-90 nit: This section of the code can be put in a new method.  It would improve readability and modularity of the code. Also, it can be reused in other places where such checks are needed to find segments_on host for routed networks.","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"035980c07d0c6ed7dfd97c97a54a46dba2e2ac52","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                            subnet_db.Subnet.segment_id)"},{"line_number":77,"context_line":"                        query \u003d query.filter("},{"line_number":78,"context_line":"                            subnet_db.Subnet.network_id \u003d\u003d net_id,"},{"line_number":79,"context_line":"                            subnet_db.Subnet.enable_dhcp.is_(True))"},{"line_number":80,"context_line":"                        segments \u003d set(query.all())"},{"line_number":81,"context_line":"                        segments \u003d [t.segment_id for t in segments]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_4abc936c","line":79,"updated":"2016-07-28 03:59:26.000000000","message":"why are we querying again here? we already have a list of subnets with segment_ids and the dhcp flag on L50, use that.\n\nMultiple queries inside of the agent iteration is changing it from a constant query count to linear.","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ddefb2ca6a371921bed900a9dad12dba8c0ce9e7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                            subnet_db.Subnet.segment_id)"},{"line_number":77,"context_line":"                        query \u003d query.filter("},{"line_number":78,"context_line":"                            subnet_db.Subnet.network_id \u003d\u003d net_id,"},{"line_number":79,"context_line":"                            subnet_db.Subnet.enable_dhcp.is_(True))"},{"line_number":80,"context_line":"                        segments \u003d set(query.all())"},{"line_number":81,"context_line":"                        segments \u003d [t.segment_id for t in segments]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_68e1719a","line":79,"in_reply_to":"bacf61ea_4abc936c","updated":"2016-07-28 19:55:36.000000000","message":"done","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"035980c07d0c6ed7dfd97c97a54a46dba2e2ac52","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                        query \u003d query.filter("},{"line_number":86,"context_line":"                            sh_db.SegmentHostMapping.host \u003d\u003d host,"},{"line_number":87,"context_line":"                            sh_db.SegmentHostMapping.segment_id.in_(segments))"},{"line_number":88,"context_line":"                        segments_on_host \u003d query.all()"},{"line_number":89,"context_line":"                        if len(segments_on_host) \u003d\u003d 0:"},{"line_number":90,"context_line":"                            continue"},{"line_number":91,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_2ac15fe5","line":88,"updated":"2016-07-28 03:59:26.000000000","message":"figure out a way to emit a single query that gets all of the information you need about the host mappings before the iteration starts. e.g. using an in_ query for host as well so you get all of the necessary host mappings up front.\n\nDatabase queries are super fast compared to the time it takes to actually send the query to the db and deserialize the response. Keeping the query count constant gets us much better performance than a linear increase with the agent count.","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ddefb2ca6a371921bed900a9dad12dba8c0ce9e7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                        query \u003d query.filter("},{"line_number":86,"context_line":"                            sh_db.SegmentHostMapping.host \u003d\u003d host,"},{"line_number":87,"context_line":"                            sh_db.SegmentHostMapping.segment_id.in_(segments))"},{"line_number":88,"context_line":"                        segments_on_host \u003d query.all()"},{"line_number":89,"context_line":"                        if len(segments_on_host) \u003d\u003d 0:"},{"line_number":90,"context_line":"                            continue"},{"line_number":91,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_a8f1a96c","line":88,"in_reply_to":"bacf61ea_2ac15fe5","updated":"2016-07-28 19:55:36.000000000","message":"done","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9a37390d38c2b6465a0b91287c761c924059f9e0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                            sh_db.SegmentHostMapping.host \u003d\u003d host,"},{"line_number":87,"context_line":"                            sh_db.SegmentHostMapping.segment_id.in_(segments))"},{"line_number":88,"context_line":"                        segments_on_host \u003d query.all()"},{"line_number":89,"context_line":"                        if len(segments_on_host) \u003d\u003d 0:"},{"line_number":90,"context_line":"                            continue"},{"line_number":91,"context_line":"                    else:"},{"line_number":92,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_6547e41d","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":24},"updated":"2016-07-28 16:13:58.000000000","message":"Is it possible to have a use case where len(segments_on_host) \u003e 0? If yes, how is it handled.","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ddefb2ca6a371921bed900a9dad12dba8c0ce9e7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                            sh_db.SegmentHostMapping.host \u003d\u003d host,"},{"line_number":87,"context_line":"                            sh_db.SegmentHostMapping.segment_id.in_(segments))"},{"line_number":88,"context_line":"                        segments_on_host \u003d query.all()"},{"line_number":89,"context_line":"                        if len(segments_on_host) \u003d\u003d 0:"},{"line_number":90,"context_line":"                            continue"},{"line_number":91,"context_line":"                    else:"},{"line_number":92,"context_line":"                        if len(agents) \u003e\u003d agents_per_network:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_68a69154","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":24},"in_reply_to":"bacf61ea_6547e41d","updated":"2016-07-28 19:55:36.000000000","message":"yup, if len(segments_on_host) \u003e 0, it goes to line 94 and henceforth.","commit_id":"d2757992eea724b045ecea79e9439da93f49a8f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":31,"context_line":"from neutron.scheduler import base_resource_filter"},{"line_number":32,"context_line":"from neutron.scheduler import base_scheduler"},{"line_number":33,"context_line":"from neutron.services.segments import db as sh_db"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_a030e0e9","line":33,"range":{"start_line":33,"start_character":44,"end_line":33,"end_character":46},"updated":"2016-08-02 17:09:37.000000000","message":"nit: What is sh? I find it a bit distracting to call it something that isn\u0027t obviously related to what it is. I\u0027d prefer segments_db.","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"f924c1808b3e21d1cd846d8a89e78dccb7a49180","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":31,"context_line":"from neutron.scheduler import base_resource_filter"},{"line_number":32,"context_line":"from neutron.scheduler import base_scheduler"},{"line_number":33,"context_line":"from neutron.services.segments import db as sh_db"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_250fac89","line":33,"range":{"start_line":33,"start_character":44,"end_line":33,"end_character":46},"in_reply_to":"bacf61ea_a030e0e9","updated":"2016-08-03 22:21:56.000000000","message":"Done","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":50,"context_line":"            net_ids \u003d {}"},{"line_number":51,"context_line":"            for s in subnets:"},{"line_number":52,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":53,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d (s.get(\u0027segment_id\u0027) is not"},{"line_number":54,"context_line":"                                                None)"},{"line_number":55,"context_line":"            if not net_ids:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_2387dad8","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":36},"updated":"2016-08-02 17:09:37.000000000","message":"Unrelated note: It\u0027d be nice to push this down to the DB query by passing a filter to get_subnets. But, that shouldn\u0027t be done in this patch. How would you feel about creating a follow on patch to make this change? You certainly don\u0027t have to sign up for that if you don\u0027t have time.","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"f924c1808b3e21d1cd846d8a89e78dccb7a49180","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":50,"context_line":"            net_ids \u003d {}"},{"line_number":51,"context_line":"            for s in subnets:"},{"line_number":52,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":53,"context_line":"                    net_ids[s[\u0027network_id\u0027]] \u003d (s.get(\u0027segment_id\u0027) is not"},{"line_number":54,"context_line":"                                                None)"},{"line_number":55,"context_line":"            if not net_ids:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_856db834","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":36},"in_reply_to":"bacf61ea_2387dad8","updated":"2016-08-03 22:21:56.000000000","message":"i will take it","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            query \u003d context.session.query(sh_db.SegmentHostMapping.segment_id)"},{"line_number":66,"context_line":"            query \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":67,"context_line":"            segments_on_host \u003d query.all()"},{"line_number":68,"context_line":"            segments_on_host \u003d set([s.segment_id for s in segments_on_host])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            for dhcp_agent in dhcp_agents:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_e0665828","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":42},"updated":"2016-08-02 17:09:37.000000000","message":"Take this line out and replace segments_on_host with query in the generator on the next line. It is a more efficient pattern.","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"f924c1808b3e21d1cd846d8a89e78dccb7a49180","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            query \u003d context.session.query(sh_db.SegmentHostMapping.segment_id)"},{"line_number":66,"context_line":"            query \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":67,"context_line":"            segments_on_host \u003d query.all()"},{"line_number":68,"context_line":"            segments_on_host \u003d set([s.segment_id for s in segments_on_host])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            for dhcp_agent in dhcp_agents:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_0d79eefc","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":42},"in_reply_to":"bacf61ea_e0665828","updated":"2016-08-03 22:21:56.000000000","message":"Done","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            query \u003d context.session.query(sh_db.SegmentHostMapping.segment_id)"},{"line_number":66,"context_line":"            query \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":67,"context_line":"            segments_on_host \u003d query.all()"},{"line_number":68,"context_line":"            segments_on_host \u003d set([s.segment_id for s in segments_on_host])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            for dhcp_agent in dhcp_agents:"},{"line_number":71,"context_line":"                if agents_db.AgentDbMixin.is_agent_down("}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_6008a82e","line":68,"range":{"start_line":68,"start_character":35,"end_line":68,"end_character":36},"updated":"2016-08-02 17:09:37.000000000","message":"nit: You don\u0027t need to generate a list. Do this to avoid being a bit wasteful with memory and extra iterations:\n\n  segments_on_host \u003d {s.segment_id for s in query}\n\nNotice that it iterates query directly and avoids generating a list. This avoids two unnecessary intermediate lists.\n\nI marked this a nit because it won\u0027t affect performance much. It is just a good idea to adopt this pattern in general because it has better general performance characteristics without sacrificing anything. In fact, it is more readable. So, I don\u0027t consider it a \"premature optimization\".","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"f924c1808b3e21d1cd846d8a89e78dccb7a49180","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            query \u003d context.session.query(sh_db.SegmentHostMapping.segment_id)"},{"line_number":66,"context_line":"            query \u003d query.filter(sh_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":67,"context_line":"            segments_on_host \u003d query.all()"},{"line_number":68,"context_line":"            segments_on_host \u003d set([s.segment_id for s in segments_on_host])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            for dhcp_agent in dhcp_agents:"},{"line_number":71,"context_line":"                if agents_db.AgentDbMixin.is_agent_down("}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_2d7032dc","line":68,"range":{"start_line":68,"start_character":35,"end_line":68,"end_character":36},"in_reply_to":"bacf61ea_6008a82e","updated":"2016-08-03 22:21:56.000000000","message":"Done","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        context, [net_id])"},{"line_number":79,"context_line":"                    if is_routed_network:"},{"line_number":80,"context_line":"                        segments_on_network \u003d set("},{"line_number":81,"context_line":"                            s.get(\u0027segment_id\u0027) for s in subnets"},{"line_number":82,"context_line":"                            if (s.get(\u0027network_id\u0027) \u003d\u003d net_id and"},{"line_number":83,"context_line":"                                s.get(\u0027enable_dhcp\u0027)))"},{"line_number":84,"context_line":"                        if len(segments_on_network \u0026 segments_on_host) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_4ec0357d","line":81,"range":{"start_line":81,"start_character":48,"end_line":81,"end_character":64},"updated":"2016-08-02 17:09:37.000000000","message":"This is where the -1 comes from.\n\nThis is inefficient. If the number of routed networks is N and the total number of subnets is M, then this is a O(NM) algorithm. It might not be a big deal because I don\u0027t expect the number of routed networks to get very large. But, I\u0027m a little bit nervous about it because I don\u0027t know how many routed networks some deployers are going to want to create.\n\nWe should first group subnets by network up around L53, then figure out which are routed networks. I\u0027m thinking something like this:\n\n  net_subnets \u003d collections.defaultdict(list)\n  for s in subnets:\n      if s[\u0027enabled_dhcp\u0027]:\n          net_subnets[s[\u0027network_id\u0027].append(s)\n\n  net_ids \u003d {network_id: subnet.get(\u0027segment_id\u0027) is not None\n             for network_id, subnet in net_subnets.items()}\n\nNow, we can iterate over just the subnets in this network instead of iterating over all subnets for all networks.\n\n  segments_on_network \u003d {s.get(\u0027segment_id\u0027) for s in net_subnets[net_id]}\n\nI didn\u0027t test any of this code, I hope I didn\u0027t get it wrong but I just wanted to give you the gist of what I\u0027m thinking. It eliminates the O(NM) stuff and is more like O(N + M). I think besides just being a more efficient algorithm, it is easier to follow because it fits the problem more naturally.","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"f924c1808b3e21d1cd846d8a89e78dccb7a49180","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        context, [net_id])"},{"line_number":79,"context_line":"                    if is_routed_network:"},{"line_number":80,"context_line":"                        segments_on_network \u003d set("},{"line_number":81,"context_line":"                            s.get(\u0027segment_id\u0027) for s in subnets"},{"line_number":82,"context_line":"                            if (s.get(\u0027network_id\u0027) \u003d\u003d net_id and"},{"line_number":83,"context_line":"                                s.get(\u0027enable_dhcp\u0027)))"},{"line_number":84,"context_line":"                        if len(segments_on_network \u0026 segments_on_host) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_423561d9","line":81,"range":{"start_line":81,"start_character":48,"end_line":81,"end_character":64},"in_reply_to":"bacf61ea_4ec0357d","updated":"2016-08-03 22:21:56.000000000","message":"Done","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5b548facf435f49022377492452e0cacc9913881","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    if is_routed_network:"},{"line_number":80,"context_line":"                        segments_on_network \u003d set("},{"line_number":81,"context_line":"                            s.get(\u0027segment_id\u0027) for s in subnets"},{"line_number":82,"context_line":"                            if (s.get(\u0027network_id\u0027) \u003d\u003d net_id and"},{"line_number":83,"context_line":"                                s.get(\u0027enable_dhcp\u0027)))"},{"line_number":84,"context_line":"                        if len(segments_on_network \u0026 segments_on_host) \u003d\u003d 0:"},{"line_number":85,"context_line":"                            continue"},{"line_number":86,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":20,"id":"bacf61ea_2e8181fc","line":83,"range":{"start_line":82,"start_character":28,"end_line":83,"end_character":54},"updated":"2016-08-02 17:09:37.000000000","message":"This all goes away with my previous suggestion.","commit_id":"199fdaedaf6f962a705e144ddf307e6a71442aa8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            fields \u003d [\u0027network_id\u0027, \u0027enable_dhcp\u0027, \u0027segment_id\u0027]"},{"line_number":49,"context_line":"            subnets \u003d plugin.get_subnets(context, fields\u003dfields)"},{"line_number":50,"context_line":"            net_ids \u003d {}"},{"line_number":51,"context_line":"            net_subnets \u003d collections.defaultdict(list)"},{"line_number":52,"context_line":"            for s in subnets:"},{"line_number":53,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":54,"context_line":"                    net_subnets[s[\u0027network_id\u0027]].append(s)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_a40cf7ec","line":51,"range":{"start_line":51,"start_character":50,"end_line":51,"end_character":54},"updated":"2016-08-04 16:57:57.000000000","message":"Actually, given the way this is used now (L82), let\u0027s make this a set of segment_ids to begin with.\n\n  net_segment_ids \u003d collections.defaultdict(set)","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            net_subnets \u003d collections.defaultdict(list)"},{"line_number":52,"context_line":"            for s in subnets:"},{"line_number":53,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":54,"context_line":"                    net_subnets[s[\u0027network_id\u0027]].append(s)"},{"line_number":55,"context_line":"            for network_id, subnets in net_subnets.items():"},{"line_number":56,"context_line":"                net_ids[network_id] \u003d any([subnet.get(\u0027segment_id\u0027)"},{"line_number":57,"context_line":"                                          for subnet in subnets])"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_a496b73b","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":58},"updated":"2016-08-04 16:57:57.000000000","message":"This becomes:\n\n  net_segment_ids[s[\u0027network_id\u0027]].add(s.get(\u0027segment_id\u0027))","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            for s in subnets:"},{"line_number":53,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":54,"context_line":"                    net_subnets[s[\u0027network_id\u0027]].append(s)"},{"line_number":55,"context_line":"            for network_id, subnets in net_subnets.items():"},{"line_number":56,"context_line":"                net_ids[network_id] \u003d any([subnet.get(\u0027segment_id\u0027)"},{"line_number":57,"context_line":"                                          for subnet in subnets])"},{"line_number":58,"context_line":"            if not net_ids:"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_e4270f10","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":59},"updated":"2016-08-04 16:57:57.000000000","message":"This becomes:\n\n  for network_id, segment_ids in net_segment_ids.items():","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                if s[\u0027enable_dhcp\u0027]:"},{"line_number":54,"context_line":"                    net_subnets[s[\u0027network_id\u0027]].append(s)"},{"line_number":55,"context_line":"            for network_id, subnets in net_subnets.items():"},{"line_number":56,"context_line":"                net_ids[network_id] \u003d any([subnet.get(\u0027segment_id\u0027)"},{"line_number":57,"context_line":"                                          for subnet in subnets])"},{"line_number":58,"context_line":"            if not net_ids:"},{"line_number":59,"context_line":"                LOG.debug(\u0027No non-hosted networks\u0027)"},{"line_number":60,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_c4112b54","line":57,"range":{"start_line":56,"start_character":38,"end_line":57,"end_character":65},"updated":"2016-08-04 16:57:57.000000000","message":"This would be a little more readable if you introduced a local variable:\n\n  is_routed_network \u003d any(segments_ids)\n  net_ids[network_id] \u003d is_routed_network\n\nAlso, not that you don\u0027t need to generate a list. If you didn\u0027t follow the suggestion on L51, this would be:\n\n  is_routed_network \u003d any(segment.get(\u0027segment_id\u0027) for subnet in subnets)\n  net_ids[network_id] \u003d is_routed_network","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            query \u003d context.session.query("},{"line_number":69,"context_line":"                segments_db.SegmentHostMapping.segment_id)"},{"line_number":70,"context_line":"            query \u003d query.filter(segments_db.SegmentHostMapping.host \u003d\u003d host)"},{"line_number":71,"context_line":"            segments_on_host \u003d set([s.segment_id for s in query.all()])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            for dhcp_agent in dhcp_agents:"},{"line_number":74,"context_line":"                if agents_db.AgentDbMixin.is_agent_down("}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_e4426f3d","line":71,"range":{"start_line":71,"start_character":63,"end_line":71,"end_character":69},"updated":"2016-08-04 16:57:57.000000000","message":"Don\u0027t call .all(). You can iterate directly on the query and it is more efficient. Also, don\u0027t generate a list!\n\n  segments_on_host \u003d {s.segment_id for s in query}\n\nMore readable and it is a more efficient pattern to follow in general.","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e34bdec394697505180f0270b31fee25edb31a97","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                for net_id, is_routed_network in net_ids.items():"},{"line_number":80,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":81,"context_line":"                        context, [net_id])"},{"line_number":82,"context_line":"                    segments_on_network \u003d set(s.get(\u0027segment_id\u0027) for s in"},{"line_number":83,"context_line":"                                              net_subnets[net_id])"},{"line_number":84,"context_line":"                    if is_routed_network:"},{"line_number":85,"context_line":"                        if len(segments_on_network \u0026 segments_on_host) \u003d\u003d 0:"},{"line_number":86,"context_line":"                            continue"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_845c537e","line":83,"range":{"start_line":82,"start_character":20,"end_line":83,"end_character":66},"updated":"2016-08-04 16:57:57.000000000","message":"This becomes:\n\n  segment_on_network \u003d net_segment_ids[net_id]","commit_id":"32eec53d0297389400a90bdb4bdee30443539cc9"}],"neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af69a43bff95a0af46e6300957469de6fdc7b019","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_auto_schedule_network(self):"},{"line_number":266,"context_line":"        plugin \u003d mock.MagicMock()"},{"line_number":267,"context_line":"        plugin.get_subnets.return_value \u003d \\"},{"line_number":268,"context_line":"            ([{\"network_id\": self.network_id, \"enable_dhcp\": self.enable_dhcp,"},{"line_number":269,"context_line":"            \"segment_id\": None}] if self.network_present else [])"},{"line_number":270,"context_line":"        plugin.get_network.return_value \u003d {\u0027availability_zone_hints\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_6ac58f8c","line":267,"range":{"start_line":267,"start_character":42,"end_line":267,"end_character":43},"updated":"2016-07-26 15:53:08.000000000","message":"I think that the same comment applies here\n\nhttps://review.openstack.org/#/c/333716/16/neutron/scheduler/dhcp_agent_scheduler.py@53","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f183aaca706c1692991f76acce5c588740ca743","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_auto_schedule_network(self):"},{"line_number":266,"context_line":"        plugin \u003d mock.MagicMock()"},{"line_number":267,"context_line":"        plugin.get_subnets.return_value \u003d \\"},{"line_number":268,"context_line":"            ([{\"network_id\": self.network_id, \"enable_dhcp\": self.enable_dhcp,"},{"line_number":269,"context_line":"            \"segment_id\": None}] if self.network_present else [])"},{"line_number":270,"context_line":"        plugin.get_network.return_value \u003d {\u0027availability_zone_hints\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_e186aeb7","line":267,"range":{"start_line":267,"start_character":42,"end_line":267,"end_character":43},"in_reply_to":"dada55a8_6ac58f8c","updated":"2016-07-27 03:04:03.000000000","message":"done","commit_id":"2a78cd81aa74c4ee5aa0dc32dbd9e08c9625d750"}]}
