)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"0d053b6f6f0b455deabecf61aee3f319d6912093","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                )"},{"line_number":381,"context_line":"                context.session.add(router)"},{"line_number":382,"context_line":"                context.session.add(router_port)"},{"line_number":383,"context_line":"        except Exception:"},{"line_number":384,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":385,"context_line":"                try:"},{"line_number":386,"context_line":"                    self._core_plugin.delete_port(context.elevated(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_90407b37","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":25},"updated":"2016-07-08 11:18:51.000000000","message":"At this point, regarding your opinion, we should change to \"except exc.StaleDataError\" with exc is \"from sqlalchemy.orm import exc\". How do you think?","commit_id":"c15c02c61b978cdd96cea0cf4dace9cc8d64b8fc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0da70d3d82d171ec2054d93c93824d2a515d2ade","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                )"},{"line_number":381,"context_line":"                context.session.add(router)"},{"line_number":382,"context_line":"                context.session.add(router_port)"},{"line_number":383,"context_line":"        except Exception:"},{"line_number":384,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":385,"context_line":"                try:"},{"line_number":386,"context_line":"                    self._core_plugin.delete_port(context.elevated(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_cae19d00","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":25},"in_reply_to":"1aa78d24_90407b37","updated":"2016-07-08 18:40:46.000000000","message":"we want to catch any errors (e.g lost connections to databases or reference errors from concurrent router deletions).","commit_id":"c15c02c61b978cdd96cea0cf4dace9cc8d64b8fc"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"585706ccfcfa81a5561241e20eb3855e1f8c7093","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                          context.elevated(), gw_port[\u0027id\u0027]):"},{"line_number":373,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":374,"context_line":"                router.gw_port \u003d self._core_plugin._get_port("},{"line_number":375,"context_line":"                    context.elevated(), gw_port[\u0027id\u0027])"},{"line_number":376,"context_line":"                router_port \u003d RouterPort("},{"line_number":377,"context_line":"                    router_id\u003drouter.id,"},{"line_number":378,"context_line":"                    port_id\u003dgw_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_5b3743b0","line":375,"updated":"2016-07-15 23:46:01.000000000","message":"waste!","commit_id":"fbd3578d6494fa3f08d75686783f31454b1b42e5"}],"neutron/plugins/common/utils.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"585706ccfcfa81a5561241e20eb3855e1f8c7093","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"@contextlib.contextmanager"},{"line_number":206,"context_line":"def delete_port_on_error(core_plugin, context, port_id):"},{"line_number":207,"context_line":"    mgr \u003d _DelManager()"},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        yield mgr"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_7b2b2731","line":206,"updated":"2016-07-15 23:46:01.000000000","message":"have you considered something along the lines of:\n\ndef delete_resource_on_error(method, context, *args, **kwargs):","commit_id":"fbd3578d6494fa3f08d75686783f31454b1b42e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"585706ccfcfa81a5561241e20eb3855e1f8c7093","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            try:"},{"line_number":213,"context_line":"                if mgr.delete_on_error:"},{"line_number":214,"context_line":"                    core_plugin.delete_port(context, port_id,"},{"line_number":215,"context_line":"                                            l3_port_check\u003dFalse)"},{"line_number":216,"context_line":"            except Exception:"},{"line_number":217,"context_line":"                LOG.exception(_LE(\"Failed to cleanup port: %s\"), port_id)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_bbe47f0d","line":215,"updated":"2016-07-15 23:46:01.000000000","message":"method(context, *args, **kwargs)","commit_id":"fbd3578d6494fa3f08d75686783f31454b1b42e5"}]}
