)]}'
{"neutron/tests/unit/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b2d20013a0ec42e8daaa3d64a5271fc416a7038a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":38,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":39,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":40,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":41,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":42,"context_line":"            self.connection.start(table_name_list\u003dtable_name_list)"},{"line_number":43,"context_line":"        reg_all_called \u003d table_name_list is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a35033d5","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":46},"updated":"2016-06-24 14:34:13.000000000","message":"Would it be better to mock.patch.object on the connection module\u0027s threading import so that we aren\u0027t \"patching globally\"?","commit_id":"631ebc745f62be670c1a3371e4b081a8f7cdee78"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"9983180afcb2d905427a41cc65d09755afb9ab81","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":38,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":39,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":40,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":41,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":42,"context_line":"            self.connection.start(table_name_list\u003dtable_name_list)"},{"line_number":43,"context_line":"        reg_all_called \u003d table_name_list is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_97372e4c","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":46},"in_reply_to":"3aaa91ec_3762bad8","updated":"2016-06-24 15:30:14.000000000","message":"Mocks are local to a process though, and a worker cannot run more than a single test in parallel. What am I missing?","commit_id":"631ebc745f62be670c1a3371e4b081a8f7cdee78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2fa6399f6eba39e573d3692cf4e9e171e0cc449f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":38,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":39,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":40,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":41,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":42,"context_line":"            self.connection.start(table_name_list\u003dtable_name_list)"},{"line_number":43,"context_line":"        reg_all_called \u003d table_name_list is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_daf71dd1","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":46},"in_reply_to":"3aaa91ec_97372e4c","updated":"2016-06-24 15:47:00.000000000","message":"Yep, I have the same point, parallel tests are run by separate workers","commit_id":"631ebc745f62be670c1a3371e4b081a8f7cdee78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ec973eb62d18c149a084ea430c26aa39ef58d01f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":38,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":39,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":40,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":41,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":42,"context_line":"            self.connection.start(table_name_list\u003dtable_name_list)"},{"line_number":43,"context_line":"        reg_all_called \u003d table_name_list is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e3e35bd7","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":46},"in_reply_to":"3aaa91ec_a35033d5","updated":"2016-06-24 14:37:41.000000000","message":"this mocks globally only for lines 41-42 so I think it\u0027s ok","commit_id":"631ebc745f62be670c1a3371e4b081a8f7cdee78"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"dc8007c189ec01805899499835132f59f01ec089","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":38,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":39,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":40,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":41,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":42,"context_line":"            self.connection.start(table_name_list\u003dtable_name_list)"},{"line_number":43,"context_line":"        reg_all_called \u003d table_name_list is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3762bad8","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":46},"in_reply_to":"3aaa91ec_e3e35bd7","updated":"2016-06-24 15:23:16.000000000","message":"Hmmm. I think boden has a point. It might be a small window, but it could still affect other tests when running many in parallel.","commit_id":"631ebc745f62be670c1a3371e4b081a8f7cdee78"}]}
