)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"39e2c5921e50450472dc2bf41cdc583bcaa0401a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"allows the agent being abused in dDoS attacks, see [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"By setting the `--local-service` option dnsmasq will filter DNS queries"},{"line_number":14,"context_line":"and reply only to queries from directly attached networks."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1501206"},{"line_number":17,"context_line":"[2] https://review.openstack.org/256280"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_6ec52f5a","line":14,"updated":"2017-02-02 23:38:24.000000000","message":"IMO, you should explain why we can remove --interface --except-interface dnsmasq option, ie: now, dnsmasqs are always deployed in a namespace so they can no interact with each other.\n\nIMO, you should explain that --local-service is not supported with old dnsmasq implementations. It seems to imply that we should be able to disable this feature if --local-service is not supported","commit_id":"1a39f82dfb31e9f7685133c820e7a743b376c9be"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dfcd1cb3e80cd91ada0a658c9c8898c57e14c4a8","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            \u0027--no-hosts\u0027,"},{"line_number":320,"context_line":"            _no_resolv,"},{"line_number":321,"context_line":"            \u0027--strict-order\u0027,"},{"line_number":322,"context_line":"            \u0027--except-interface\u003dlo\u0027,"},{"line_number":323,"context_line":"            \u0027--pid-file\u003d%s\u0027 % pid_file,"},{"line_number":324,"context_line":"            \u0027--dhcp-hostsfile\u003d%s\u0027 % self.get_conf_file_name(\u0027host\u0027),"},{"line_number":325,"context_line":"            \u0027--addn-hosts\u003d%s\u0027 % self.get_conf_file_name(\u0027addn_hosts\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_5e65121c","side":"PARENT","line":322,"updated":"2016-08-17 05:18:40.000000000","message":"Another idea: Even if we don\u0027t add in the --local-service option, we might drop this statement here and the other --interface stuff below in order to make it easier for distros to just add the fix lateron.","commit_id":"8f585aad545a65d3c2872e67f252dcae59bc248f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e4dd5cbbd566fe462698788aeaba5fce464fa0a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.agent.linux import external_process"},{"line_number":36,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":37,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":38,"context_line":"from neutron.cmd.sanity.checks import dnsmasq_local_service_supported"},{"line_number":39,"context_line":"from neutron.common import constants as n_const"},{"line_number":40,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":41,"context_line":"from neutron.common import ipv6_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_169556dd","line":38,"updated":"2016-08-16 18:48:58.000000000","message":"I somehow just noticed this. Sanity check code should never be run at runtime. It exists solely to be run as a check after deployment, but before actually running the services. It is to verify that whatever is configured is capable of being run, before actually running it. As such, it\u0027s not good for dynamically using features of binaries.\n\nAlso, a general question: it sounds like this is a security fix which would supplant doing something else like adding iptables filters. If that is the case, should it be optional? If \u0027--local-service\u0027 is not supported, then we just silently allow a security issue? If we *are* going to rely on --local-service, then sanity checks work fine: you just always add --local-service and then have the sanity check fail if --test --local-service returns error. This would have distro packaging concerns as we would be requiring distros to backport the --local-service option to dnsmasq to solve the security issue. Filtering might be easier in the grand scheme of things, even if the code itself is more complex.","commit_id":"b86b2449a8763863a4fe4843e67bdf9b7d2877fd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dfcd1cb3e80cd91ada0a658c9c8898c57e14c4a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.agent.linux import external_process"},{"line_number":36,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":37,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":38,"context_line":"from neutron.cmd.sanity.checks import dnsmasq_local_service_supported"},{"line_number":39,"context_line":"from neutron.common import constants as n_const"},{"line_number":40,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":41,"context_line":"from neutron.common import ipv6_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_de8bc2c1","line":38,"in_reply_to":"3ac371cc_169556dd","updated":"2016-08-17 05:18:40.000000000","message":"The iptables approach is being proposed at https://review.openstack.org/256280 but doesn\u0027t seem to have made much progress in the past months. I\u0027m not sure whether the remaining issues there can be resolved any time soon.\n\nSince the issue will only affect a certain type of deployments (those using publically reachable addresses for project networks), my idea was indeed that solving it only for recent distros would be better than having it unsolved for almost one year.\n\nBut I do see the issues here, so maybe you are right and we should take up the filtering patch once more and if it succeeds, we can just abandon this one.","commit_id":"b86b2449a8763863a4fe4843e67bdf9b7d2877fd"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"747c2a37f4a4d1fe580bed9693cae298f30a4e4e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_5a30d701","line":186,"updated":"2016-08-15 16:21:03.000000000","message":"We should *not* perpetuate doing sanity checks for version numbers. The whole point of sanity checks in the first place was to remove checking for version numbers. Distros frequently backport features into code and version numbers are not a reliably way to test for features. The test should be rewritten to try to use whatever feature you require and test for failure.","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f150d80a2f5de4aa25e23cebc75c194112685f2b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_17bc6d04","line":186,"in_reply_to":"3ac371cc_047d5d1c","updated":"2016-08-15 19:36:26.000000000","message":"Oh wow, that\u0027s awesome. Hopefully that\u0027ll make it easier to remove the other dnsmasq version check as well. Thanks!","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d09b7263b1b479334e986c1ff0c7d176355f4a0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_a5f3879d","line":186,"in_reply_to":"3ac371cc_17bc6d04","updated":"2016-08-16 10:27:43.000000000","message":"If someone has an idea what feature neutron wants for requiring\n\n    MINIMUM_DNSMASQ_VERSION \u003d 2.67\n\nthen one could probably change that, too.","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b945a45bd426163eddb2e0baef8f2353265b03e3","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_9d37e9af","line":186,"in_reply_to":"3ac371cc_5a30d701","updated":"2016-08-15 16:28:17.000000000","message":"So you would rather want to see something like\n\n    dnsmasq --help | grep -q -- --local-service\n\nand use the return code?\n\nWould you still keep the check in this file?","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3c597d1e5abf302cd5a90017eb2ecc48fe6d8f67","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_7dbf8dd0","line":186,"in_reply_to":"3ac371cc_9d37e9af","updated":"2016-08-15 16:30:36.000000000","message":"Something like that would be acceptable. Same file should work. It\u0027s just funny; I wrote the sanity check framework specifically to remove dnsmasq version checks. And now there are dns version number checks in sanity checks. :p","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b030e0cc4185298ba41238f67e4af14ff9f0d8c3","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_fd925d56","line":186,"in_reply_to":"3ac371cc_9d37e9af","updated":"2016-08-15 16:32:28.000000000","message":"The ideal test actually tries to use the feature and detects failure. I don\u0027t know enough to suggest how that would be done. Checking the help would be better than the version number (even if it is a little fragile).","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb6a59118eee1c98041894b151a44fda18261696","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def dnsmasq_service_supported():"},{"line_number":187,"context_line":"    try:"},{"line_number":188,"context_line":"        cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":189,"context_line":"        env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_047d5d1c","line":186,"in_reply_to":"3ac371cc_fd925d56","updated":"2016-08-15 19:16:16.000000000","message":"Turns out that luckily dnsmasq has that functionality, on Xenial:\n\n    $ dnsmasq --test --local-service\n    dnsmasq: syntax check OK.\n\nOn Trusty:\n\n    $ dnsmasq --test --local-service\n    \n    dnsmasq: bad command line options: try --help\n\nand the return code is also set accordingly. I\u0027ll rewrite with this, thanks for your persistence.","commit_id":"9e90469db84d91baefa4460c2f4fd1748fd7ff8e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e4dd5cbbd566fe462698788aeaba5fce464fa0a8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    return MINIMUM_DNSMASQ_VERSION"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def dnsmasq_local_service_supported():"},{"line_number":186,"context_line":"    cmd \u003d [\u0027dnsmasq\u0027, \u0027--test\u0027, \u0027--local-service\u0027]"},{"line_number":187,"context_line":"    env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"},{"line_number":188,"context_line":"    obj, cmd \u003d agent_utils.create_process(cmd, addl_env\u003denv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_11228000","line":185,"updated":"2016-08-16 18:48:58.000000000","message":"sanity checks should be configurable to run via the command line. There should be an option to run this check via neutron/command/sanity_check.py with a BoolOptCallback. If we end up relying on --local-service support, then I think you could just do the check the same way the (evil) dnsmasq_version check is done:\n\n if cfg.CONF.dhcp_driver \u003d\u003d \u0027neutron.agent.linux.dhcp.Dnsmasq\u0027:\n     cfg.CONF.set_default(\u0027dnsmasq_local_service\u0027, True)\n\nor something like that.","commit_id":"b86b2449a8763863a4fe4843e67bdf9b7d2877fd"}],"releasenotes/notes/dnsmasq-local-service-c8eaa91894a7d6d4.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"14141b6443d30983f1f7cc3f62f7f2630fe61413","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes bug `1501206 \u003chttps://bugs.launchpad.net/neutron/+bug/1501206\u003e`_."},{"line_number":5,"context_line":"    This ensures that DHCP agent instances running dnsmasq as DNS server can"},{"line_number":6,"context_line":"    no longer be exploited as DNS amplifiers when the tenant network is"},{"line_number":7,"context_line":"    using publically routed IP addresses by adding an option that will make"},{"line_number":8,"context_line":"    only serve DNS requests from local networks."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_f8ba9009","line":5,"range":{"start_line":5,"start_character":62,"end_line":5,"end_character":65},"updated":"2018-11-28 20:40:31.000000000","message":"s/a DNS","commit_id":"dcb920a4b75fa4d221eb09c8916ef1f5183b0807"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"14141b6443d30983f1f7cc3f62f7f2630fe61413","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes bug `1501206 \u003chttps://bugs.launchpad.net/neutron/+bug/1501206\u003e`_."},{"line_number":5,"context_line":"    This ensures that DHCP agent instances running dnsmasq as DNS server can"},{"line_number":6,"context_line":"    no longer be exploited as DNS amplifiers when the tenant network is"},{"line_number":7,"context_line":"    using publically routed IP addresses by adding an option that will make"},{"line_number":8,"context_line":"    only serve DNS requests from local networks."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_383a4895","line":7,"range":{"start_line":7,"start_character":71,"end_line":7,"end_character":75},"updated":"2018-11-28 20:40:31.000000000","message":"s/allow it to","commit_id":"dcb920a4b75fa4d221eb09c8916ef1f5183b0807"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"14141b6443d30983f1f7cc3f62f7f2630fe61413","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes bug `1501206 \u003chttps://bugs.launchpad.net/neutron/+bug/1501206\u003e`_."},{"line_number":5,"context_line":"    This ensures that DHCP agent instances running dnsmasq as DNS server can"},{"line_number":6,"context_line":"    no longer be exploited as DNS amplifiers when the tenant network is"},{"line_number":7,"context_line":"    using publically routed IP addresses by adding an option that will make"},{"line_number":8,"context_line":"    only serve DNS requests from local networks."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_98b59c1c","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":20},"updated":"2018-11-28 20:40:31.000000000","message":"s/publicly","commit_id":"dcb920a4b75fa4d221eb09c8916ef1f5183b0807"}]}
