)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96c8a97bef49c15322ab150daec8eeac594725c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Rosenboom \u003cj.rosenboom@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-27 08:05:07 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tests.unit.common.test_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some checks have the order for reference/actual swapped, leading to"},{"line_number":10,"context_line":"misleading errors if they are tripped."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_f929ee8a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-06-27 19:24:56.000000000","message":"Do not depend on Python error strings in ...","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0dd2465f35693e00df57ff144bfcab3bf956c50d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Rosenboom \u003cj.rosenboom@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-27 08:05:07 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tests.unit.common.test_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some checks have the order for reference/actual swapped, leading to"},{"line_number":10,"context_line":"misleading errors if they are tripped."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_d41f97b5","line":7,"in_reply_to":"3aaa91ec_f929ee8a","updated":"2016-06-28 15:52:16.000000000","message":"Done","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"}],"neutron/tests/unit/common/test_utils.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f62091e1696d6721452a39e2ca779981e616e7f4","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                    {\"key2\": \"value2\"},"},{"line_number":411,"context_line":"                    {\"key4\": \"value4\"}]"},{"line_number":412,"context_line":"        added, removed \u003d utils.diff_list_of_dict(old_list, new_list)"},{"line_number":413,"context_line":"        self.assertEqual(added, [dict(key4\u003d\"value4\")])"},{"line_number":414,"context_line":"        self.assertEqual(removed, [dict(key3\u003d\"value3\")])"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"class TestDict2Tuples(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4434c748","line":414,"range":{"start_line":413,"start_character":0,"end_line":414,"end_character":56},"updated":"2016-06-27 05:43:32.000000000","message":"I think you can modify these two lines as well.","commit_id":"1ed457acb05fa5de7a321932fff5e59f6495cf98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"18909648c239f0e885a0ef4ee1da921f058b35f4","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                    {\"key2\": \"value2\"},"},{"line_number":411,"context_line":"                    {\"key4\": \"value4\"}]"},{"line_number":412,"context_line":"        added, removed \u003d utils.diff_list_of_dict(old_list, new_list)"},{"line_number":413,"context_line":"        self.assertEqual(added, [dict(key4\u003d\"value4\")])"},{"line_number":414,"context_line":"        self.assertEqual(removed, [dict(key3\u003d\"value3\")])"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"class TestDict2Tuples(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4a117151","line":414,"range":{"start_line":413,"start_character":0,"end_line":414,"end_character":56},"in_reply_to":"3aaa91ec_4434c748","updated":"2016-06-27 06:02:28.000000000","message":"+1","commit_id":"1ed457acb05fa5de7a321932fff5e59f6495cf98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0837f965a3a459f4457c8f3ebf80d3b385908476","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    {\"key4\": \"value4\"}]"},{"line_number":412,"context_line":"        added, removed \u003d utils.diff_list_of_dict(old_list, new_list)"},{"line_number":413,"context_line":"        self.assertEqual(added, [dict(key4\u003d\"value4\")])"},{"line_number":414,"context_line":"        self.assertEqual(removed, [dict(key3\u003d\"value3\")])"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"class TestDict2Tuples(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8a8a3962","line":414,"in_reply_to":"3aaa91ec_4434c748","updated":"2016-06-27 06:09:00.000000000","message":"Thanks for noticing, I did look at this, but on second look you are right, swapping these, too.","commit_id":"1ed457acb05fa5de7a321932fff5e59f6495cf98"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96c8a97bef49c15322ab150daec8eeac594725c8","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class UtilTestParseVlanRanges(base.BaseTestCase):"},{"line_number":146,"context_line":"    _err_prefix \u003d \"Invalid network VLAN range: \u0027\""},{"line_number":147,"context_line":"    _err_too_many_prefix \u003d \"\u0027 - \u0027too many values to unpack\""},{"line_number":148,"context_line":"    _err_not_int \u003d \"\u0027 - \u0027invalid literal for int() with base 10: \u0027%s\u0027\u0027.\""},{"line_number":149,"context_line":"    _err_bad_vlan \u003d \"\u0027 - \u0027%s is not a valid VLAN tag\u0027.\""},{"line_number":150,"context_line":"    _err_range \u003d \"\u0027 - \u0027End of VLAN range is less than start of VLAN range\u0027.\""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1e62e016","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":72},"updated":"2016-06-27 19:24:56.000000000","message":"These two are also strings from Python errors, which are not a stable interface. I think this is a good time to apply similar fixes for them also.","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96c8a97bef49c15322ab150daec8eeac594725c8","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        expected_msg_prefix \u003d self._range_err_prefix(config_str)"},{"line_number":271,"context_line":"        err \u003d self.assertRaises(n_exc.NetworkVlanRangeError,"},{"line_number":272,"context_line":"                                self.parse_one, config_str)"},{"line_number":273,"context_line":"        # The error message is not same in Python 3.4 and Python 3.5,"},{"line_number":274,"context_line":"        # so it cannot be predicted as a fixed string."},{"line_number":275,"context_line":"        self.assertTrue(str(err).startswith(expected_msg_prefix))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_parse_one_net_range_too_many(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7e2164b4","line":274,"range":{"start_line":273,"start_character":8,"end_line":274,"end_character":54},"updated":"2016-06-27 19:24:56.000000000","message":"The comment should say that we cannot depend on the text of Python error strings.","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96c8a97bef49c15322ab150daec8eeac594725c8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        expected_msg_prefix \u003d self._range_too_many_err_prefix(config_str)"},{"line_number":280,"context_line":"        err \u003d self.assertRaises(n_exc.NetworkVlanRangeError,"},{"line_number":281,"context_line":"                                self.parse_one, config_str)"},{"line_number":282,"context_line":"        # The error message is not same in Python 2 and Python 3. In Python 3,"},{"line_number":283,"context_line":"        # it depends on the amount of values used when unpacking, so it cannot"},{"line_number":284,"context_line":"        # be predicted as a fixed string."},{"line_number":285,"context_line":"        self.assertTrue(str(err).startswith(expected_msg_prefix))"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_parse_one_net_vlan1_not_int(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_be2bcc93","line":284,"range":{"start_line":282,"start_character":7,"end_line":284,"end_character":41},"updated":"2016-06-27 19:24:56.000000000","message":"Ditto.","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96c8a97bef49c15322ab150daec8eeac594725c8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        expected_msg \u003d self._vlan_not_int_err(config_str, \u0027foo\u0027)"},{"line_number":290,"context_line":"        err \u003d self.assertRaises(n_exc.NetworkVlanRangeError,"},{"line_number":291,"context_line":"                                self.parse_one, config_str)"},{"line_number":292,"context_line":"        self.assertEqual(expected_msg, str(err))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_parse_one_net_vlan2_not_int(self):"},{"line_number":295,"context_line":"        config_str \u003d \"net1:100:bar\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d94a3255","line":292,"updated":"2016-06-27 19:24:56.000000000","message":"Nit: IMO we don\u0027t need to make these kind of changes.","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0dd2465f35693e00df57ff144bfcab3bf956c50d","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        expected_msg \u003d self._vlan_not_int_err(config_str, \u0027foo\u0027)"},{"line_number":290,"context_line":"        err \u003d self.assertRaises(n_exc.NetworkVlanRangeError,"},{"line_number":291,"context_line":"                                self.parse_one, config_str)"},{"line_number":292,"context_line":"        self.assertEqual(expected_msg, str(err))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_parse_one_net_vlan2_not_int(self):"},{"line_number":295,"context_line":"        config_str \u003d \"net1:100:bar\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b678def9","line":292,"in_reply_to":"3aaa91ec_d94a3255","updated":"2016-06-28 15:52:16.000000000","message":"I think it makes life easier for a developer if for a failed test, \"reference\" shows the outcome predicted in the test and \"actual\" the actual result from the failing function. At least that was a bit confusing for myself when I started looking at this issue.\n\nAlso, some developers like myself tend to code most things by copy\u0026paste, so it would seem useful to avoid spreading inferior coding style.","commit_id":"86e029bc422487cf384e5d3d786928ab89f4b1c1"}]}
