)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"224180b17b0d4edd6b347ebc7c1d16ea36bd3853","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Limit the SQL query number when loading the sythetic fields for Neutron"},{"line_number":10,"context_line":"DB objects. If synthetic fields is defined in SQL model as orm.relationship,"},{"line_number":11,"context_line":"the objects are loaded with main object. No need to query for those resources"},{"line_number":12,"context_line":"ones more."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It has impact on performance in scale, to have constant number of SQL queries"},{"line_number":15,"context_line":"when number of resources stored in DB is increasing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_6043a1af","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2016-06-27 15:11:31.000000000","message":"once ?","commit_id":"fbfecd8311437ef7ce9c5bf9790615cd538a2cac"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3090183c0e742cb988b437caeaf29e89b190be9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Limit the SQL query number when loading the sythetic fields for Neutron"},{"line_number":10,"context_line":"DB objects. If synthetic fields is defined in SQL model as orm.relationship,"},{"line_number":11,"context_line":"the objects are loaded with main object. No need to query for those resources"},{"line_number":12,"context_line":"ones more."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It has impact on performance in scale, to have constant number of SQL queries"},{"line_number":15,"context_line":"when number of resources stored in DB is increasing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_e4fe4204","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2016-06-28 11:40:54.000000000","message":"once","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"da7a8695d58e068046b62af3bdccd699623cfc8f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Limit the SQL query number when loading the sythetic fields for Neutron"},{"line_number":10,"context_line":"DB objects. If synthetic fields is defined in SQL model as orm.relationship,"},{"line_number":11,"context_line":"the objects are loaded with main object. No need to query for those resources"},{"line_number":12,"context_line":"ones more."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It has impact on performance in scale, to have constant number of SQL queries"},{"line_number":15,"context_line":"when number of resources stored in DB is increasing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_cf2381bd","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"in_reply_to":"3aaa91ec_e4fe4204","updated":"2016-07-14 09:11:54.000000000","message":"Done","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"objects: loading synthetic fields from defined ORM relationships."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Limit the SQL query number when loading the sythetic fields for Neutron"},{"line_number":10,"context_line":"DB objects. If synthetic fields is defined in SQL model as orm.relationship,"},{"line_number":11,"context_line":"the objects are loaded with main object. No need to query for those resources"},{"line_number":12,"context_line":"once more."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dada55a8_46b41534","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":51},"updated":"2016-07-26 13:18:31.000000000","message":"synthetic","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"objects: loading synthetic fields from defined ORM relationships."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Limit the SQL query number when loading the sythetic fields for Neutron"},{"line_number":10,"context_line":"DB objects. If synthetic fields is defined in SQL model as orm.relationship,"},{"line_number":11,"context_line":"the objects are loaded with main object. No need to query for those resources"},{"line_number":12,"context_line":"once more."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dada55a8_dbd0d755","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":51},"in_reply_to":"dada55a8_46b41534","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"}],"neutron/objects/base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"224180b17b0d4edd6b347ebc7c1d16ea36bd3853","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_db0a461f","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":24},"updated":"2016-06-27 15:11:31.000000000","message":"Nit: I think there should be more descriptive name, what does this object maps?","commit_id":"fbfecd8311437ef7ce9c5bf9790615cd538a2cac"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"224180b17b0d4edd6b347ebc7c1d16ea36bd3853","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":414,"context_line":"                self.synthetic_fields_map.get(field, field))"},{"line_number":415,"context_line":"            if db_obj and (db_obj.get(synthetic_field_db_name, None)"},{"line_number":416,"context_line":"                           is not None):"},{"line_number":417,"context_line":"                db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":418,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_db7d266e","line":415,"range":{"start_line":415,"start_character":12,"end_line":415,"end_character":68},"updated":"2016-06-27 15:11:31.000000000","message":"Pythonic:\n\n if db_obj and db_obj.get(...):","commit_id":"fbfecd8311437ef7ce9c5bf9790615cd538a2cac"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"224180b17b0d4edd6b347ebc7c1d16ea36bd3853","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":419,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"},{"line_number":420,"context_line":"                else:"},{"line_number":421,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context, obj)"},{"line_number":422,"context_line":"                            for obj in db_objs]"},{"line_number":423,"context_line":"                    setattr(self, field, objs)"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                objs \u003d objclass.get_objects("},{"line_number":426,"context_line":"                    self.obj_context, **{"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3b29cae6","line":423,"range":{"start_line":421,"start_character":0,"end_line":423,"end_character":46},"updated":"2016-06-27 15:11:31.000000000","message":"Is this block tested by a UT?","commit_id":"fbfecd8311437ef7ce9c5bf9790615cd538a2cac"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3d5af0faff7a50e4032ea5c6f19cf0fcd00e1aea","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f3f7298a","line":127,"updated":"2016-06-28 11:33:43.000000000","message":"yet another dict :)\nTo me it seems we can use fields_need_translation for this purpose. In the end you want to copy the value of a field that it\u0027s automatically populated by ovo to another field.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"da7a8695d58e068046b62af3bdccd699623cfc8f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b2e2daff","line":127,"in_reply_to":"1aa78d24_3e3c6cc7","updated":"2016-07-14 09:11:54.000000000","message":"Ok, moved in PS4 to use fields_need_translation. Thanks for the input.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"8eaf09ab773f37f5f2e40dd05a641a55ccbb1af8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_df2f849f","line":127,"in_reply_to":"3aaa91ec_04cd4eb7","updated":"2016-06-28 14:47:45.000000000","message":"This dict is to have mapping for field in object to relationship names in SQL model. For example, in subnet object, subnet routes are called \u0027host_routes\u0027 [1] but in Subnet model relationship is called \u0027routes\u0027 [2]. When loading synthetic fields using relationship, we need to have it in general way defined [3].\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L154\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L211\n[3] https://review.openstack.org/#/c/334380/2/neutron/objects/base.py@417","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3882b5cf2806d85217d0cf22e9fb900648a9c6a2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3e3c6cc7","line":127,"in_reply_to":"3aaa91ec_df2f849f","updated":"2016-07-06 15:14:59.000000000","message":"that\u0027s exactly what fields_need_translation is for, isn\u0027t it? To create a mapping between the name of the object got directly from the db and the field name we want to use.\n\nif you add for example\n\nfields_need_translation \u003d {\u0027routes\u0027:\u0027host_routes\u0027}\n\nthat should do the magic. I am not 100% sure it will work but if it doesn\u0027t we should fix the problems. Let\u0027s try to avoid adding more dict please.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3090183c0e742cb988b437caeaf29e89b190be9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    synthetic_fields \u003d []"},{"line_number":127,"context_line":"    synthetic_fields_map \u003d {}"},{"line_number":128,"context_line":"    extra_filter_names \u003d set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_04cd4eb7","line":127,"in_reply_to":"3aaa91ec_f3f7298a","updated":"2016-06-28 11:40:54.000000000","message":"+. Also, I don\u0027t see any clear description of the new attribute that an outsider could wrap his/her head around.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3090183c0e742cb988b437caeaf29e89b190be9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                if field in db_obj and not self.is_synthetic(field):"},{"line_number":251,"context_line":"                    setattr(self, field, db_obj[field])"},{"line_number":252,"context_line":"                break"},{"line_number":253,"context_line":"        self.load_synthetic_db_fields(objs[0])"},{"line_number":254,"context_line":"        self.obj_reset_changes()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e473e2b2","line":253,"range":{"start_line":253,"start_character":38,"end_line":253,"end_character":45},"updated":"2016-06-28 11:40:54.000000000","message":"Why do we pass just the first one?","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"8eaf09ab773f37f5f2e40dd05a641a55ccbb1af8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                if field in db_obj and not self.is_synthetic(field):"},{"line_number":251,"context_line":"                    setattr(self, field, db_obj[field])"},{"line_number":252,"context_line":"                break"},{"line_number":253,"context_line":"        self.load_synthetic_db_fields(objs[0])"},{"line_number":254,"context_line":"        self.obj_reset_changes()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0d71f1a8","line":253,"range":{"start_line":253,"start_character":38,"end_line":253,"end_character":45},"in_reply_to":"3aaa91ec_e473e2b2","updated":"2016-06-28 14:47:45.000000000","message":"I do not understand why objs can be more that one, and did not see any use case of having more that one. Can someone explain why it introduced to be more that one?","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_model and db_model.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":443,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":444,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a0545954","line":441,"updated":"2016-07-18 11:24:27.000000000","message":"new line is redundant","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_model and db_model.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":443,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":444,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_2fcfb2b1","line":441,"in_reply_to":"dada55a8_a0545954","updated":"2016-07-18 12:44:47.000000000","message":"Removed.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":443,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":444,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context, obj)"},{"line_number":447,"context_line":"                            for obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_c0f98d4f","line":444,"range":{"start_line":444,"start_character":70,"end_line":444,"end_character":77},"updated":"2016-07-18 11:24:27.000000000","message":"shouldn\u0027t we convert db fields back to object fields before passing them into object constructor?","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":443,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":444,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context, obj)"},{"line_number":447,"context_line":"                            for obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_d6aaf718","line":444,"range":{"start_line":444,"start_character":70,"end_line":444,"end_character":77},"in_reply_to":"dada55a8_c0f98d4f","updated":"2016-07-18 12:44:47.000000000","message":"Seems legit.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                    setattr(self, field, objclass(self.obj_context, **db_objs))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context, obj)"},{"line_number":447,"context_line":"                            for obj in db_objs]"},{"line_number":448,"context_line":"                    setattr(self, field, objs)"},{"line_number":449,"context_line":"            else:"},{"line_number":450,"context_line":"                objs \u003d objclass.get_objects("}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_609f0104","line":447,"updated":"2016-07-18 11:24:27.000000000","message":"ditto","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"e79177c5d9c2f5c4ae8373c8e3f4344926709c02","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                if field in db_obj and not self.is_synthetic(field):"},{"line_number":273,"context_line":"                    setattr(self, field, db_obj[field])"},{"line_number":274,"context_line":"                break"},{"line_number":275,"context_line":"        for db_model in objs:"},{"line_number":276,"context_line":"            self.load_synthetic_db_fields(db_model)"},{"line_number":277,"context_line":"        self.obj_reset_changes()"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_c59b24c8","line":275,"range":{"start_line":275,"start_character":12,"end_line":275,"end_character":20},"updated":"2016-07-19 11:02:13.000000000","message":"Should not it be db_obj instead (see L269 in this method and \u0027_load_object\u0027 method)?","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c5a5822f64a68064e55ede93cba6038d720b6aa8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                if field in db_obj and not self.is_synthetic(field):"},{"line_number":273,"context_line":"                    setattr(self, field, db_obj[field])"},{"line_number":274,"context_line":"                break"},{"line_number":275,"context_line":"        for db_model in objs:"},{"line_number":276,"context_line":"            self.load_synthetic_db_fields(db_model)"},{"line_number":277,"context_line":"        self.obj_reset_changes()"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_f3f39208","line":275,"range":{"start_line":275,"start_character":12,"end_line":275,"end_character":20},"in_reply_to":"dada55a8_c59b24c8","updated":"2016-07-19 11:24:54.000000000","message":"yes, it is database object.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"e79177c5d9c2f5c4ae8373c8e3f4344926709c02","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return fields"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def load_synthetic_db_fields(self, db_model\u003dNone):"},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        Load the synthetic fields that are stored in a different table from the"},{"line_number":413,"context_line":"        main object."}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_851bec1a","line":410,"range":{"start_line":410,"start_character":39,"end_line":410,"end_character":47},"updated":"2016-07-19 11:02:13.000000000","message":"That is confusing. Considering how it is used in \u0027from_db_object\u0027, it is not a database model class, but a database object itself, isn\u0027t it?","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c5a5822f64a68064e55ede93cba6038d720b6aa8","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return fields"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def load_synthetic_db_fields(self, db_model\u003dNone):"},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        Load the synthetic fields that are stored in a different table from the"},{"line_number":413,"context_line":"        main object."}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_73e84211","line":410,"range":{"start_line":410,"start_character":39,"end_line":410,"end_character":47},"in_reply_to":"dada55a8_851bec1a","updated":"2016-07-19 11:24:54.000000000","message":"Yes.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"e79177c5d9c2f5c4ae8373c8e3f4344926709c02","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if db_model and db_model.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        objclass.modify_fields_from_db(**db_objs)))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context,"},{"line_number":447,"context_line":"                                objclass.modify_fields_from_db(obj))"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_4503b442","line":444,"range":{"start_line":443,"start_character":66,"end_line":444,"end_character":65},"updated":"2016-07-19 11:02:13.000000000","message":"Don\u0027t you need \"**\" here (see [1], \u0027modify_fields_from_db\u0027 returns a dict)?\n\nnit: I consider \u0027db_objs\u0027 a bit confusing here, as seeing \"s\" makes me think of it as a collection.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L129","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c5a5822f64a68064e55ede93cba6038d720b6aa8","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if db_model and db_model.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        objclass.modify_fields_from_db(**db_objs)))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context,"},{"line_number":447,"context_line":"                                objclass.modify_fields_from_db(obj))"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_f358b2fc","line":444,"range":{"start_line":443,"start_character":66,"end_line":444,"end_character":65},"in_reply_to":"dada55a8_4503b442","updated":"2016-07-19 11:24:54.000000000","message":"db_objs can be collection, see \u0027else\u0027 statement.\n\nRegarding \u0027**\u0027 it should be:\n\nsetattr(self, field, objclass(self.obj_context, **objclass.modify_fields_from_db(db_objs)))","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"9ef7157d2643d02361549e0318c74816e6705ea4","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if db_model and db_model.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                db_objs \u003d db_model.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        objclass.modify_fields_from_db(**db_objs)))"},{"line_number":445,"context_line":"                else:"},{"line_number":446,"context_line":"                    objs \u003d [objclass._load_object(self.obj_context,"},{"line_number":447,"context_line":"                                objclass.modify_fields_from_db(obj))"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_0d839605","line":444,"range":{"start_line":443,"start_character":66,"end_line":444,"end_character":65},"in_reply_to":"dada55a8_f358b2fc","updated":"2016-07-19 15:07:09.000000000","message":"\u003e db_objs can be collection, see \u0027else\u0027 statement.\n\nnit: Right, but in the first part of \u0027if\u0027 it is a single object. Yes, I\u0027m nitpicking :)","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"98d262d1642959b0211c2db919fd33b65d57cc0e","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            if len(objclass.foreign_keys.keys()) \u003e 1:"},{"line_number":436,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_9c005503","line":438,"updated":"2016-07-19 15:53:10.000000000","message":"I don\u0027t think we need to translate this here again, since when this is called by line 276, the translation will be executed at line 269","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"06cfaa1523496a135225d28314e7506486162386","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            if len(objclass.foreign_keys.keys()) \u003e 1:"},{"line_number":436,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_80bd7f6a","line":438,"in_reply_to":"dada55a8_9c005503","updated":"2016-07-19 18:53:32.000000000","message":"In line 276, we are passing unmodified db object. We have to do this because here we are using side loaded fields, which are removed when performing modify_fields_from_db()","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"98d262d1642959b0211c2db919fd33b65d57cc0e","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        **objclass.modify_fields_from_db(synth_db_objs)))"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_dcde4d3e","line":441,"updated":"2016-07-19 15:53:10.000000000","message":"mmm if the synthetic field is set in the db_obj why do we need to set it again at line 443 or line 449? I might miss something but this doesn\u0027t seem right to me","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"06cfaa1523496a135225d28314e7506486162386","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        **objclass.modify_fields_from_db(synth_db_objs)))"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_1b69028c","line":441,"in_reply_to":"dada55a8_dcde4d3e","updated":"2016-07-19 18:53:32.000000000","message":"db_obj is entity fetched from database, not OVO.","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"98d262d1642959b0211c2db919fd33b65d57cc0e","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        **objclass.modify_fields_from_db(synth_db_objs)))"},{"line_number":445,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_3c3169ed","line":442,"updated":"2016-07-19 15:53:10.000000000","message":"this is the same as 455, consider using a self-explanatory boolean then.\n\nis_object_field \u003d isinstance(self.fields[field], obj_fields.ObjectField)","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"cb86d0116c06e89acde2815f12f9e2d0e78d996b","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":440,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":441,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":442,"context_line":"                if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":443,"context_line":"                    setattr(self, field, objclass(self.obj_context,"},{"line_number":444,"context_line":"                        **objclass.modify_fields_from_db(synth_db_objs)))"},{"line_number":445,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_ded533e5","line":442,"in_reply_to":"dada55a8_3c3169ed","updated":"2016-07-21 12:56:17.000000000","message":"I have reworked this section to unify lines 442-449 and 451-458.","commit_id":"41502796e2abe0f3f63b417ff1b17fd0576f166a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"61d16d42d1d8ddb15a9bb53174a74625e574868f","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":464,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":467,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":468,"context_line":"                if not isinstance(synth_db_objs, list):"},{"line_number":469,"context_line":"                    synth_db_objs \u003d [synth_db_objs]"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_fe9b0415","line":466,"updated":"2016-07-26 16:17:20.000000000","message":"nit you add at line 465:\nsynth_db_objs \u003d db_obj.get(synthetic_field_db_name, None) if db_obj else None\n\nthen this becomes:\n\nif synth_db_objs\n\nand you don\u0027t need to use get again at line 467","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":464,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":467,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":468,"context_line":"                if not isinstance(synth_db_objs, list):"},{"line_number":469,"context_line":"                    synth_db_objs \u003d [synth_db_objs]"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_74f0b1c9","line":466,"in_reply_to":"dada55a8_3efc58b7","updated":"2016-07-27 11:02:45.000000000","message":"Thanks Rossella, changed in PS 14.","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"32712377520ed87d7aa884637cae66bbc8acbe30","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":464,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"            if db_obj and db_obj.get(synthetic_field_db_name, None):"},{"line_number":467,"context_line":"                synth_db_objs \u003d db_obj.get(synthetic_field_db_name)"},{"line_number":468,"context_line":"                if not isinstance(synth_db_objs, list):"},{"line_number":469,"context_line":"                    synth_db_objs \u003d [synth_db_objs]"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_3efc58b7","line":466,"in_reply_to":"dada55a8_fe9b0415","updated":"2016-07-27 09:26:34.000000000","message":"I need to change this IF statement.","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"849ab3de248c16780f73003790a97afa3f3dba31","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                    setattr(self, field, db_obj[field])"},{"line_number":293,"context_line":"                break"},{"line_number":294,"context_line":"        for obj in objs:"},{"line_number":295,"context_line":"            self.load_synthetic_db_fields(obj)"},{"line_number":296,"context_line":"        self.obj_reset_changes()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_bda013a7","line":295,"range":{"start_line":295,"start_character":42,"end_line":295,"end_character":45},"updated":"2016-07-27 16:09:03.000000000","message":"Nit: Might be worth passing as kwarg (db_obj\u003dobj) just in case additional kwargs are added later and also to be explicit.","commit_id":"394546743b4e7cf962a5bd7c0dce9681a7449140"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"849ab3de248c16780f73003790a97afa3f3dba31","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        return fields"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def load_synthetic_db_fields(self, db_obj\u003dNone):"},{"line_number":436,"context_line":"        \"\"\""},{"line_number":437,"context_line":"        Load the synthetic fields that are stored in a different table from the"},{"line_number":438,"context_line":"        main object."}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_cf9a6ec5","line":435,"range":{"start_line":435,"start_character":39,"end_line":435,"end_character":45},"updated":"2016-07-27 16:09:03.000000000","message":"Nit: Consider adding db_obj to method docstring (e.g. :param db_obj:)","commit_id":"394546743b4e7cf962a5bd7c0dce9681a7449140"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"849ab3de248c16780f73003790a97afa3f3dba31","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":464,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":465,"context_line":"            synth_db_objs \u003d (db_obj.get(synthetic_field_db_name, None)"},{"line_number":466,"context_line":"                             if db_obj else None)"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_8ff196d0","line":464,"range":{"start_line":464,"start_character":16,"end_line":464,"end_character":44},"updated":"2016-07-27 16:09:03.000000000","message":"Hopefully nobody sets fields_need_translation at the instance level vs. the class level.","commit_id":"394546743b4e7cf962a5bd7c0dce9681a7449140"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae14a8ac312c2593d2b1629453570d578ed7bc15","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":464,"context_line":"                self.fields_need_translation.get(field, field))"},{"line_number":465,"context_line":"            synth_db_objs \u003d (db_obj.get(synthetic_field_db_name, None)"},{"line_number":466,"context_line":"                             if db_obj else None)"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_4ef820e6","line":464,"range":{"start_line":464,"start_character":16,"end_line":464,"end_character":44},"in_reply_to":"bacf61ea_8ff196d0","updated":"2016-07-28 07:40:25.000000000","message":"Yes, on class level objects contain declarative description of the object, while instance level serves as data carrier and facade for accessing database. So fields_need_translation must remain the same for all instances.","commit_id":"394546743b4e7cf962a5bd7c0dce9681a7449140"}],"neutron/tests/unit/objects/network/extensions/test_port_security.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_861e0d6e","line":33,"updated":"2016-07-26 13:18:31.000000000","message":"why the change (why do you need three networks?)? Can\u0027t we avoid hardcoding the size of lists here?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"371a31b2decc7fc5d29821695ce59597e59f553f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7ba72ba7","line":33,"in_reply_to":"dada55a8_38493932","updated":"2016-07-26 14:29:27.000000000","message":"The NetworkPortSecurity object can be created only for one network_id. You cannot create this objects two times with the same network_id.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_be799195","line":33,"in_reply_to":"dada55a8_7ba72ba7","updated":"2016-07-26 14:41:34.000000000","message":"Hm. And tests were still passing?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_d55ee8e7","line":33,"in_reply_to":"dada55a8_861e0d6e","updated":"2016-07-26 14:05:36.000000000","message":"you have to iterate over all generated sets and inject the different network id for all db_obj and obj_fields pair.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_6996414d","line":33,"in_reply_to":"dada55a8_be799195","updated":"2016-07-26 15:03:41.000000000","message":"Oh I see, we need that because _create_object_with_synthetic_fields will fail.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fb9a0b7033e8e7d34eeead52c5c0b3bce81605e6","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_38493932","line":33,"in_reply_to":"dada55a8_d55ee8e7","updated":"2016-07-26 14:10:22.000000000","message":"Why a single network not enough? It was enough before this patch. So what changed?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, 3):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_7419d121","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":27},"updated":"2016-07-27 11:02:45.000000000","message":"changed to range(0, len(self.db_objs))","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"61a22e309c1ca292d68bd6451550942909275e73","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, len(self.db_objs)):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_f8b76f1e","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":44},"updated":"2016-07-27 12:00:13.000000000","message":"No need for indexing:\n\n for db_obj, obj_fields in zip(self.db_objs, self.obj_fields):\n      network \u003d ...\n      db_obj[\u0027network_id\u0027] \u003d network[\u0027id\u0027]\n      obj_field[\u0027id\u0027] \u003d network[\u0027id\u0027]","commit_id":"d249e68a2e3fe802176e245387aced1aed5cffee"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"ddd00b5d3ea3ac7308d67cf95968ac390274b749","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortSecurityDbObjTestCase, self).setUp()"},{"line_number":33,"context_line":"        for i in range(0, len(self.db_objs)):"},{"line_number":34,"context_line":"            network \u003d self._create_network()"},{"line_number":35,"context_line":"            self.db_objs[i][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":36,"context_line":"            self.obj_fields[i][\u0027id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_c36f1c29","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":44},"in_reply_to":"dada55a8_f8b76f1e","updated":"2016-07-27 12:19:21.000000000","message":"Thanks! I can always rely on your Pythonic skills!","commit_id":"d249e68a2e3fe802176e245387aced1aed5cffee"}],"neutron/tests/unit/objects/qos/test_rule.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"432cffac7ca33be1ca70b2d1fdcfc08c8d00a78e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        for obj in self.db_objs:"},{"line_number":87,"context_line":"            generated_qos_policy_id \u003d obj[\u0027qos_policy_id\u0027]"},{"line_number":88,"context_line":"            policy_obj \u003d policy.QosPolicy(self.context,"},{"line_number":89,"context_line":"                                      id\u003dgenerated_qos_policy_id)"},{"line_number":90,"context_line":"            policy_obj.create()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_17f6bb8e","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":40},"updated":"2016-07-26 17:19:58.000000000","message":"weird that this indentation is valida for pep8","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        for obj in self.db_objs:"},{"line_number":87,"context_line":"            generated_qos_policy_id \u003d obj[\u0027qos_policy_id\u0027]"},{"line_number":88,"context_line":"            policy_obj \u003d policy.QosPolicy(self.context,"},{"line_number":89,"context_line":"                                      id\u003dgenerated_qos_policy_id)"},{"line_number":90,"context_line":"            policy_obj.create()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_74e6f144","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":40},"in_reply_to":"dada55a8_17f6bb8e","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"432cffac7ca33be1ca70b2d1fdcfc08c8d00a78e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        for obj in self.db_objs:"},{"line_number":120,"context_line":"            generated_qos_policy_id \u003d obj[\u0027qos_policy_id\u0027]"},{"line_number":121,"context_line":"            policy_obj \u003d policy.QosPolicy(self.context,"},{"line_number":122,"context_line":"                                      id\u003dgenerated_qos_policy_id)"},{"line_number":123,"context_line":"            policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_f731675a","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":40},"updated":"2016-07-26 17:19:58.000000000","message":"ditto: line 89","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        for obj in self.db_objs:"},{"line_number":120,"context_line":"            generated_qos_policy_id \u003d obj[\u0027qos_policy_id\u0027]"},{"line_number":121,"context_line":"            policy_obj \u003d policy.QosPolicy(self.context,"},{"line_number":122,"context_line":"                                      id\u003dgenerated_qos_policy_id)"},{"line_number":123,"context_line":"            policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_54e12d29","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":40},"in_reply_to":"dada55a8_f731675a","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"224180b17b0d4edd6b347ebc7c1d16ea36bd3853","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        obj.create()"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        for field in object_fields:"},{"line_number":902,"context_line":"            objclasses \u003d obj_base.VersionedObjectRegistry.obj_classes("},{"line_number":903,"context_line":"            ).get(cls_.fields[field].objname)"},{"line_number":904,"context_line":"            if not objclasses:"},{"line_number":905,"context_line":"                # NOTE(korzen): this test does not handle fields of types"},{"line_number":906,"context_line":"                # that are not registered (for example, QosRule)"},{"line_number":907,"context_line":"                continue"},{"line_number":908,"context_line":"            objclass \u003d objclasses[0]"},{"line_number":909,"context_line":"            objclass_fields \u003d self.get_random_fields(obj_cls\u003dobjclass)"},{"line_number":910,"context_line":"            objclass_fields \u003d objclass.modify_fields_from_db(objclass_fields)"},{"line_number":911,"context_line":"            synth_field_obj \u003d objclass(self.context, **objclass_fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7bf072c9","line":908,"range":{"start_line":902,"start_character":0,"end_line":908,"end_character":36},"updated":"2016-06-27 15:11:31.000000000","message":"Pythonic:\n\n try:\n     objclass \u003d obj_base.VersionedObjectRegistry.obj_classes()[0]\n except IndexError:\n     continue","commit_id":"fbfecd8311437ef7ce9c5bf9790615cd538a2cac"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3d5af0faff7a50e4032ea5c6f19cf0fcd00e1aea","unresolved":false,"context_lines":[{"line_number":884,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":885,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":888,"context_line":"        cls_ \u003d self._test_class"},{"line_number":889,"context_line":"        object_fields \u003d ["},{"line_number":890,"context_line":"            field"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8e879ed6","line":887,"updated":"2016-06-28 11:33:43.000000000","message":"what did you have to add this test? We were already testing get_objects with synthetic fields, for example when using FakeNeutronObjectSyntheticField as test class.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"da7a8695d58e068046b62af3bdccd699623cfc8f","unresolved":false,"context_lines":[{"line_number":884,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":885,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":888,"context_line":"        cls_ \u003d self._test_class"},{"line_number":889,"context_line":"        object_fields \u003d ["},{"line_number":890,"context_line":"            field"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_32f1ca6b","line":887,"in_reply_to":"1aa78d24_9e32c0a5","updated":"2016-07-14 09:11:54.000000000","message":"I did not find any test in BaseDbObjectTestCase that is creating full object with synthetic fields. So I\u0027m leaving this test in place with a slight improvement for counter usage, see ps3.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"8eaf09ab773f37f5f2e40dd05a641a55ccbb1af8","unresolved":false,"context_lines":[{"line_number":884,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":885,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":888,"context_line":"        cls_ \u003d self._test_class"},{"line_number":889,"context_line":"        object_fields \u003d ["},{"line_number":890,"context_line":"            field"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9f95fc41","line":887,"in_reply_to":"3aaa91ec_8e879ed6","updated":"2016-06-28 14:47:45.000000000","message":"I have added this test to see if the subnet loading with synthetic fields will pass when using only one SQL query. Probably I should include in this test the query counter to see if sythetic fields will be loaded by only one query. I did not have time to finish or rework this UT.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3882b5cf2806d85217d0cf22e9fb900648a9c6a2","unresolved":false,"context_lines":[{"line_number":884,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":885,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":888,"context_line":"        cls_ \u003d self._test_class"},{"line_number":889,"context_line":"        object_fields \u003d ["},{"line_number":890,"context_line":"            field"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9e32c0a5","line":887,"in_reply_to":"3aaa91ec_9f95fc41","updated":"2016-07-06 15:14:59.000000000","message":"a query counter makes sense, please integrate that in the existing tests instead of adding a new test","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":941,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def _get_obj_fields(self, cls):"},{"line_number":944,"context_line":"        return remove_timestamps_from_fields("},{"line_number":945,"context_line":"            cls.modify_fields_from_db(self.get_random_fields())"},{"line_number":946,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_80095534","line":943,"updated":"2016-07-18 11:24:27.000000000","message":"cls is usually used as the first argument of a class method. Let\u0027s rename it into something more specific, like obj_cls.\n\nThough I also wonder why we need those TWO methods if they seem identical.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        self._test_class.get_objects(self.context, foo\u003d42)"},{"line_number":941,"context_line":"        self.assertEqual({\u0027foo\u0027: [42]}, self.filtered_args)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def _get_obj_fields(self, cls):"},{"line_number":944,"context_line":"        return remove_timestamps_from_fields("},{"line_number":945,"context_line":"            cls.modify_fields_from_db(self.get_random_fields())"},{"line_number":946,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f4d73321","line":943,"in_reply_to":"dada55a8_80095534","updated":"2016-07-18 12:44:47.000000000","message":"Removed this method and remaned _get_synthetic_obj_fields to get_obj_fields.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def _get_obj_fields(self, cls):"},{"line_number":944,"context_line":"        return remove_timestamps_from_fields("},{"line_number":945,"context_line":"            cls.modify_fields_from_db(self.get_random_fields())"},{"line_number":946,"context_line":"        )"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    def _get_synthetic_obj_fields(self, objclass):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_001d6573","line":945,"updated":"2016-07-18 11:24:27.000000000","message":"shouldn\u0027t we then pass obj_cls here too to reflect passed \u0027cls\u0027?","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":945,"context_line":"            cls.modify_fields_from_db(self.get_random_fields())"},{"line_number":946,"context_line":"        )"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    def _get_synthetic_obj_fields(self, objclass):"},{"line_number":949,"context_line":"        objclass_fields \u003d self.get_random_fields(obj_cls\u003dobjclass)"},{"line_number":950,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(objclass_fields)"},{"line_number":951,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_e02f719f","line":948,"range":{"start_line":948,"start_character":26,"end_line":948,"end_character":27},"updated":"2016-07-18 11:24:27.000000000","message":"why synthetic? doesn\u0027t it return all fields?\n\nAlso, what\u0027s the difference between this method and _get_obj_fields above? They seem to do the same thing, don\u0027t they?","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":945,"context_line":"            cls.modify_fields_from_db(self.get_random_fields())"},{"line_number":946,"context_line":"        )"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    def _get_synthetic_obj_fields(self, objclass):"},{"line_number":949,"context_line":"        objclass_fields \u003d self.get_random_fields(obj_cls\u003dobjclass)"},{"line_number":950,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(objclass_fields)"},{"line_number":951,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_74e4e30c","line":948,"range":{"start_line":948,"start_character":26,"end_line":948,"end_character":27},"in_reply_to":"dada55a8_e02f719f","updated":"2016-07-18 12:44:47.000000000","message":"Renamed to get_obj_fields().","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    def _get_synthetic_obj_fields(self, objclass):"},{"line_number":949,"context_line":"        objclass_fields \u003d self.get_random_fields(obj_cls\u003dobjclass)"},{"line_number":950,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(objclass_fields)"},{"line_number":951,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"},{"line_number":952,"context_line":"        return objclass_fields"},{"line_number":953,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_2063491c","line":950,"updated":"2016-07-18 11:24:27.000000000","message":"(No action required) that\u0027s actually a bit weird that get_random_fields() returns not object fields but db attributes. We probably need to refactor it to make more sense for its name.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            try:"},{"line_number":968,"context_line":"                objclass \u003d obj_base.VersionedObjectRegistry.obj_classes("},{"line_number":969,"context_line":"                ).get(cls_.fields[field].objname)[0]"},{"line_number":970,"context_line":"            except TypeError:"},{"line_number":971,"context_line":"                continue"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"            objclass_fields \u003d self._get_synthetic_obj_fields(objclass)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_435c8725","line":970,"updated":"2016-07-18 11:24:27.000000000","message":"what does that error indicate?","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            try:"},{"line_number":968,"context_line":"                objclass \u003d obj_base.VersionedObjectRegistry.obj_classes("},{"line_number":969,"context_line":"                ).get(cls_.fields[field].objname)[0]"},{"line_number":970,"context_line":"            except TypeError:"},{"line_number":971,"context_line":"                continue"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"            objclass_fields \u003d self._get_synthetic_obj_fields(objclass)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_94951742","line":970,"in_reply_to":"dada55a8_435c8725","updated":"2016-07-18 12:44:47.000000000","message":"Added note.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                setattr(obj, field, [synth_field_obj])"},{"line_number":983,"context_line":"        return obj"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"    def _list(self, resource, neutron_context):"},{"line_number":986,"context_line":"        cls_ \u003d resource"},{"line_number":987,"context_line":"        return cls_.get_objects(neutron_context)"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_23823353","line":985,"updated":"2016-07-18 11:24:27.000000000","message":"I don\u0027t see a single reason to have the method and not just call get_objects directly.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                setattr(obj, field, [synth_field_obj])"},{"line_number":983,"context_line":"        return obj"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"    def _list(self, resource, neutron_context):"},{"line_number":986,"context_line":"        cls_ \u003d resource"},{"line_number":987,"context_line":"        return cls_.get_objects(neutron_context)"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_79acdced","line":985,"in_reply_to":"dada55a8_23823353","updated":"2016-07-18 12:44:47.000000000","message":"_list() method is requirement for DbOperationBoundMixin._assert_object_list_queries_constant() method [1]. I have put it in base class, because network and port resources will have to implement the subnet test test_get_subnet_with_one_query.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_db_base_plugin_v2.py#L6403","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        return cls_.get_objects(neutron_context)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def test_get_objects_with_synthetic_fields(self):"},{"line_number":990,"context_line":"        object_fields \u003d ["},{"line_number":991,"context_line":"             field"},{"line_number":992,"context_line":"             for field in self._test_class.synthetic_fields"},{"line_number":993,"context_line":"             if self._test_class.is_object_field(field)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_c38d177d","line":990,"updated":"2016-07-18 11:24:27.000000000","message":"this seems to be a duplicate of lines 955-960.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        return cls_.get_objects(neutron_context)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def test_get_objects_with_synthetic_fields(self):"},{"line_number":990,"context_line":"        object_fields \u003d ["},{"line_number":991,"context_line":"             field"},{"line_number":992,"context_line":"             for field in self._test_class.synthetic_fields"},{"line_number":993,"context_line":"             if self._test_class.is_object_field(field)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_6f936aa4","line":990,"in_reply_to":"dada55a8_c38d177d","updated":"2016-07-18 12:44:47.000000000","message":"Added new method.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2eb0a1af0731c01f4522dab5367c70c38f0e59c","unresolved":false,"context_lines":[{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        for new in obj_list:"},{"line_number":1003,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1004,"context_line":"                self.assertEqual(obj.to_dict(), new.to_dict())"},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"class UniqueObjectBase(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_43cf67b0","line":1004,"updated":"2016-07-18 11:24:27.000000000","message":"why do we need to rely on to_dict to compare objects? Shouldn\u0027t __eq__ just work?","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c0985ca8887672c2d80ef3e1f9ccaa17d40b006e","unresolved":false,"context_lines":[{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        for new in obj_list:"},{"line_number":1003,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1004,"context_line":"                self.assertEqual(obj.to_dict(), new.to_dict())"},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"class UniqueObjectBase(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_54e71fe4","line":1004,"in_reply_to":"dada55a8_43cf67b0","updated":"2016-07-18 12:44:47.000000000","message":"I forgot to add obj.obj_reset_changes([field]) in create_object_with_synthetic_fields, so the obj_to_primitive() was returning additional fields changed, thus __eq__ did return False. Fixed.","commit_id":"0e6c0ae77490740bbb83b6e72177f17b05e54507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01fc5c8ff517507f66c23ee779a43f068c392126","unresolved":false,"context_lines":[{"line_number":963,"context_line":"                objclass \u003d obj_base.VersionedObjectRegistry.obj_classes("},{"line_number":964,"context_line":"                ).get(cls_.fields[field].objname)[0]"},{"line_number":965,"context_line":"            except TypeError:"},{"line_number":966,"context_line":"                # NOTE (korzen) this skip synthetic fields without OVO"},{"line_number":967,"context_line":"                # class defined, like boolean type etc."},{"line_number":968,"context_line":"                continue"},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_6f79aa2f","line":966,"updated":"2016-07-18 12:50:30.000000000","message":"but don\u0027t we already filter object-based fields only in line 951?","commit_id":"b36f343148ed6ed98c0ff0f08cd82029d0ba3ac0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a1134895f9cc1bc3794ddce754758389c76f57ab","unresolved":false,"context_lines":[{"line_number":963,"context_line":"                objclass \u003d obj_base.VersionedObjectRegistry.obj_classes("},{"line_number":964,"context_line":"                ).get(cls_.fields[field].objname)[0]"},{"line_number":965,"context_line":"            except TypeError:"},{"line_number":966,"context_line":"                # NOTE (korzen) this skip synthetic fields without OVO"},{"line_number":967,"context_line":"                # class defined, like boolean type etc."},{"line_number":968,"context_line":"                continue"},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_af55621e","line":966,"in_reply_to":"dada55a8_6f79aa2f","updated":"2016-07-18 12:58:14.000000000","message":"Sorry, I\u0027ve just checked and the problem is subclasses\u003dyes for QosPolicy rules field.","commit_id":"b36f343148ed6ed98c0ff0f08cd82029d0ba3ac0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            if field not in TIMESTAMP_FIELDS}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def remove_synthetic_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if field not in objclass.synthetic_fields}"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_847f25df","line":315,"range":{"start_line":315,"start_character":4,"end_line":315,"end_character":27},"updated":"2016-07-26 13:18:31.000000000","message":"This function should be renamed, because the way it is now named, it suggests it operates on obj_fields passed, not returns a filtered copy.\n\nI know it maps the name for remove_timestamps_from_fields, but it does not seem like an example to mimic.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            if field not in TIMESTAMP_FIELDS}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def remove_synthetic_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if field not in objclass.synthetic_fields}"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5bfa27be","line":315,"range":{"start_line":315,"start_character":4,"end_line":315,"end_character":27},"in_reply_to":"dada55a8_847f25df","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def remove_synthetic_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if field not in objclass.synthetic_fields}"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class _BaseObjectTestCase(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_69faca44","line":317,"range":{"start_line":317,"start_character":15,"end_line":317,"end_character":53},"updated":"2016-07-26 13:18:31.000000000","message":"not objclass.is_synthetic(field)","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def remove_synthetic_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if field not in objclass.synthetic_fields}"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class _BaseObjectTestCase(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7bfd6bb0","line":317,"range":{"start_line":317,"start_character":15,"end_line":317,"end_character":53},"in_reply_to":"dada55a8_69faca44","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def fake_get_objects(self, context, model, **kwargs):"},{"line_number":382,"context_line":"        return self.model_map[model]"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _get_synthetic_fields_list(self, objclass):"},{"line_number":385,"context_line":"        return [field for field in objclass.synthetic_fields"},{"line_number":386,"context_line":"                if objclass.is_object_field(field)]"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_a45fc9e3","line":384,"range":{"start_line":384,"start_character":9,"end_line":384,"end_character":34},"updated":"2016-07-26 13:18:31.000000000","message":"the name of the method does not describe what it does. It sounds like it will just return a list of synthetic fields, but it also filters out non-object fields. Should probably be _get_object_fields or smth.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def fake_get_objects(self, context, model, **kwargs):"},{"line_number":382,"context_line":"        return self.model_map[model]"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _get_synthetic_fields_list(self, objclass):"},{"line_number":385,"context_line":"        return [field for field in objclass.synthetic_fields"},{"line_number":386,"context_line":"                if objclass.is_object_field(field)]"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_bbbfe3ce","line":384,"range":{"start_line":384,"start_character":9,"end_line":384,"end_character":34},"in_reply_to":"dada55a8_a45fc9e3","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_obj_fields(self, objclass, fields):"},{"line_number":1037,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(fields)"},{"line_number":1038,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"},{"line_number":1039,"context_line":"        objclass_fields \u003d remove_synthetic_fields(objclass, objclass_fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ff494c32","line":1036,"range":{"start_line":1036,"start_character":9,"end_line":1036,"end_character":23},"updated":"2016-07-26 13:18:31.000000000","message":"_get_nonsynthetic_fields? _get_real_fields?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_obj_fields(self, objclass, fields):"},{"line_number":1037,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(fields)"},{"line_number":1038,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"},{"line_number":1039,"context_line":"        objclass_fields \u003d remove_synthetic_fields(objclass, objclass_fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_1fc6e099","line":1036,"range":{"start_line":1036,"start_character":40,"end_line":1036,"end_character":46},"updated":"2016-07-26 13:18:31.000000000","message":"it becomes hard to determine where we deal with obj fields and where we handle db attributes. Let\u0027s make it clear here by naming the argument as db_obj or db_fields or db_attrs.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_obj_fields(self, objclass, fields):"},{"line_number":1037,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(fields)"},{"line_number":1038,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"},{"line_number":1039,"context_line":"        objclass_fields \u003d remove_synthetic_fields(objclass, objclass_fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_1be42fde","line":1036,"range":{"start_line":1036,"start_character":40,"end_line":1036,"end_character":46},"in_reply_to":"dada55a8_1fc6e099","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5080d9f097464c903a8876e14f276b7d488ceac0","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_obj_fields(self, objclass, fields):"},{"line_number":1037,"context_line":"        objclass_fields \u003d objclass.modify_fields_from_db(fields)"},{"line_number":1038,"context_line":"        objclass_fields \u003d remove_timestamps_from_fields(objclass_fields)"},{"line_number":1039,"context_line":"        objclass_fields \u003d remove_synthetic_fields(objclass, objclass_fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_bbe243d3","line":1036,"range":{"start_line":1036,"start_character":9,"end_line":1036,"end_character":23},"in_reply_to":"dada55a8_ff494c32","updated":"2016-07-26 14:41:34.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        cls_ \u003d self._test_class"},{"line_number":1044,"context_line":"        object_fields \u003d self._get_synthetic_fields_list(cls_)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        db_obj \u003d next(self.iter_db_obj)"},{"line_number":1047,"context_line":"        obj \u003d cls_(self.context, **self._get_obj_fields(cls_, db_obj))"},{"line_number":1048,"context_line":"        obj.create()"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5f74d834","line":1046,"updated":"2016-07-26 13:18:31.000000000","message":"this function could use some comments","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        cls_ \u003d self._test_class"},{"line_number":1044,"context_line":"        object_fields \u003d self._get_synthetic_fields_list(cls_)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        db_obj \u003d next(self.iter_db_obj)"},{"line_number":1047,"context_line":"        obj \u003d cls_(self.context, **self._get_obj_fields(cls_, db_obj))"},{"line_number":1048,"context_line":"        obj.create()"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_feb149e1","line":1046,"in_reply_to":"dada55a8_5f74d834","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"            obj.obj_reset_changes([field])"},{"line_number":1065,"context_line":"        return obj"},{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    # NOTE (korzen) _list method is used in neutron.tests.db.unit.db."},{"line_number":1068,"context_line":"    # test_db_base_plugin_v2.DbOperationBoundMixin in _list_and_count_queries()"},{"line_number":1069,"context_line":"    # This is used in test_subnet for asserting that number of queries is"},{"line_number":1070,"context_line":"    # constant. It can be used also for port and network objects when ready."}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_1fcc2069","line":1067,"range":{"start_line":1067,"start_character":6,"end_line":1067,"end_character":19},"updated":"2016-07-26 13:18:31.000000000","message":"usually there is no space between NOTE and (...)","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"            obj.obj_reset_changes([field])"},{"line_number":1065,"context_line":"        return obj"},{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    # NOTE (korzen) _list method is used in neutron.tests.db.unit.db."},{"line_number":1068,"context_line":"    # test_db_base_plugin_v2.DbOperationBoundMixin in _list_and_count_queries()"},{"line_number":1069,"context_line":"    # This is used in test_subnet for asserting that number of queries is"},{"line_number":1070,"context_line":"    # constant. It can be used also for port and network objects when ready."}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7ebef9ae","line":1067,"range":{"start_line":1067,"start_character":6,"end_line":1067,"end_character":19},"in_reply_to":"dada55a8_1fcc2069","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"        object_fields \u003d self._get_synthetic_fields_list(self._test_class)"},{"line_number":1077,"context_line":"        if not object_fields:"},{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_045df546","line":1079,"range":{"start_line":1079,"start_character":17,"end_line":1079,"end_character":59},"updated":"2016-07-26 13:18:31.000000000","message":"that is not really correct. No *object* synthetic fields found.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"        object_fields \u003d self._get_synthetic_fields_list(self._test_class)"},{"line_number":1077,"context_line":"        if not object_fields:"},{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_be099197","line":1079,"range":{"start_line":1079,"start_character":17,"end_line":1079,"end_character":59},"in_reply_to":"dada55a8_045df546","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5f1b3873","line":1081,"range":{"start_line":1081,"start_character":8,"end_line":1081,"end_character":24},"updated":"2016-07-26 13:18:31.000000000","message":"that is weird. why not passing it as an argument to _create_object_with_synthetic_fields?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_95a7504f","line":1081,"range":{"start_line":1081,"start_character":8,"end_line":1081,"end_character":24},"in_reply_to":"dada55a8_5f1b3873","updated":"2016-07-26 14:05:36.000000000","message":"_create_object_with_synthetic_fields is called without arguments in [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_db_base_plugin_v2.py#L6411","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fb9a0b7033e8e7d34eeead52c5c0b3bce81605e6","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_980025ad","line":1081,"range":{"start_line":1081,"start_character":8,"end_line":1081,"end_character":24},"in_reply_to":"dada55a8_95a7504f","updated":"2016-07-26 14:10:22.000000000","message":"We can always pass a callable with bound arguments, functools.partial is just for that.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            self.skipTest("},{"line_number":1079,"context_line":"                \u0027No synthetic fields found in test class %r\u0027 % self._test_class"},{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_be1d1175","line":1081,"range":{"start_line":1081,"start_character":8,"end_line":1081,"end_character":24},"in_reply_to":"dada55a8_980025ad","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_3f4924b8","line":1083,"updated":"2016-07-26 13:18:31.000000000","message":"nit: there is little rationale to use _list here instead of direct call to get_objects()","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fb9a0b7033e8e7d34eeead52c5c0b3bce81605e6","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_d82c5d4c","line":1083,"in_reply_to":"dada55a8_3575c4ca","updated":"2016-07-26 14:10:22.000000000","message":"Yes, but this test is different.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_3575c4ca","line":1083,"in_reply_to":"dada55a8_3f4924b8","updated":"2016-07-26 14:05:36.000000000","message":"_list is used in [1] and this is requirement to invoke line 1091 in this PS.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_db_base_plugin_v2.py#L6403","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            )"},{"line_number":1081,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_de63a518","line":1083,"in_reply_to":"dada55a8_d82c5d4c","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7f327ca8","line":1085,"range":{"start_line":1085,"start_character":12,"end_line":1085,"end_character":15},"updated":"2016-07-26 13:18:31.000000000","message":"if it\u0027s new, where is \u0027old\u0027? Should we rename it into \u0027listed_obj\u0027?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"        obj \u003d self._create_object_with_synthetic_fields()"},{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_a95f990d","line":1085,"range":{"start_line":1085,"start_character":12,"end_line":1085,"end_character":15},"in_reply_to":"dada55a8_7f327ca8","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7f66fc51","line":1086,"updated":"2016-07-26 13:18:31.000000000","message":"if we ignore other objects, then why not just pass composite keys into get_object(s)?","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        obj_list \u003d self._list(self._test_class, self.context)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_895c551a","line":1086,"in_reply_to":"dada55a8_7f66fc51","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ffe5cc08","line":1087,"updated":"2016-07-26 13:18:31.000000000","message":"should we fail if it\u0027s not triggered? otherwise we risk a silent test disablement later.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_e99b51c7","line":1087,"in_reply_to":"dada55a8_352304bf","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"        for new in obj_list:"},{"line_number":1086,"context_line":"            if new._get_composite_keys() \u003d\u003d obj._get_composite_keys():"},{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_352304bf","line":1087,"in_reply_to":"dada55a8_ffe5cc08","updated":"2016-07-26 14:05:36.000000000","message":"Yes, we should fail.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d7f59b546cdd4af6007f2135739e1e84f3c03ad","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5ffa1844","line":1090,"range":{"start_line":1090,"start_character":8,"end_line":1090,"end_character":25},"updated":"2016-07-26 13:18:31.000000000","message":"same as above, I don\u0027t think it\u0027s a good way to pass data into _create_object_... And argument will do a better job.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_c9a00df7","line":1090,"range":{"start_line":1090,"start_character":8,"end_line":1090,"end_character":25},"in_reply_to":"dada55a8_550dd83c","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                self.assertEqual(obj, new)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_550dd83c","line":1090,"range":{"start_line":1090,"start_character":8,"end_line":1090,"end_character":25},"in_reply_to":"dada55a8_5ffa1844","updated":"2016-07-26 14:05:36.000000000","message":"The same line 1081.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bcc192e9773ca7755f22ea6414673925655abbce","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"},{"line_number":1094,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_383819d3","line":1091,"updated":"2016-07-26 14:05:36.000000000","message":"In this line we are calling DbOperationBoundMixin which requires to have _list and obj_creator method that is invoked without any arguments.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fb9a0b7033e8e7d34eeead52c5c0b3bce81605e6","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"},{"line_number":1094,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_781451e8","line":1091,"in_reply_to":"dada55a8_383819d3","updated":"2016-07-26 14:10:22.000000000","message":"Yes, for THAT case _list is needed, but not for the other case above.","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f294c2511eabc511d4232247ca103a511a2fe727","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1090,"context_line":"        self.iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1091,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":1092,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":1093,"context_line":"            self._test_class"},{"line_number":1094,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_29a289fc","line":1091,"in_reply_to":"dada55a8_781451e8","updated":"2016-07-26 15:03:41.000000000","message":"Done","commit_id":"13a8aa940831b8cee5f742d56f637dfd27608984"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"432cffac7ca33be1ca70b2d1fdcfc08c8d00a78e","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            if field not in TIMESTAMP_FIELDS}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def get_real_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if not objclass.is_synthetic(field)}"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_32f78dd4","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":12},"updated":"2016-07-26 17:19:58.000000000","message":"nit: s/get_real_fields/get_non_synthetic_fields/","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a2420e6b4745c2d9a701058ccb21532bc2e45558","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            if field not in TIMESTAMP_FIELDS}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def get_real_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if not objclass.is_synthetic(field)}"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_4ff6b45d","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":12},"in_reply_to":"dada55a8_32f78dd4","updated":"2016-07-27 10:39:23.000000000","message":"+1, real can be confusing","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            if field not in TIMESTAMP_FIELDS}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def get_real_fields(objclass, obj_fields):"},{"line_number":316,"context_line":"    return {field: value for field, value in obj_fields.items()"},{"line_number":317,"context_line":"            if not objclass.is_synthetic(field)}"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_4fdfd30c","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":12},"in_reply_to":"dada55a8_4ff6b45d","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"432cffac7ca33be1ca70b2d1fdcfc08c8d00a78e","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        self.useFixture(tools.CommonDbMixinHooksFixture())"},{"line_number":839,"context_line":"        synthetic_fields \u003d self._get_object_synthetic_fields(self._test_class)"},{"line_number":840,"context_line":"        for synth_field in synthetic_fields:"},{"line_number":841,"context_line":"            objclass \u003d self._get_ovo_object_class(self._test_class,"},{"line_number":842,"context_line":"                                                  synth_field)"},{"line_number":843,"context_line":"            if not objclass:"},{"line_number":844,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_72ebc5dc","line":841,"range":{"start_line":841,"start_character":28,"end_line":841,"end_character":49},"updated":"2016-07-26 17:19:58.000000000","message":"Maybe should be valuable to have a _is_ovo_object_class method","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        self.useFixture(tools.CommonDbMixinHooksFixture())"},{"line_number":839,"context_line":"        synthetic_fields \u003d self._get_object_synthetic_fields(self._test_class)"},{"line_number":840,"context_line":"        for synth_field in synthetic_fields:"},{"line_number":841,"context_line":"            objclass \u003d self._get_ovo_object_class(self._test_class,"},{"line_number":842,"context_line":"                                                  synth_field)"},{"line_number":843,"context_line":"            if not objclass:"},{"line_number":844,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_34759963","line":841,"range":{"start_line":841,"start_character":28,"end_line":841,"end_character":49},"in_reply_to":"dada55a8_72ebc5dc","updated":"2016-07-27 11:02:45.000000000","message":"I\u0027m not sure if it is needed. Besides, here we need object class from synthetic field name so...","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a2420e6b4745c2d9a701058ccb21532bc2e45558","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_real_fields(self, objclass, db_attrs):"},{"line_number":1037,"context_line":"        fields \u003d objclass.modify_fields_from_db(db_attrs)"},{"line_number":1038,"context_line":"        fields \u003d remove_timestamps_from_fields(fields)"},{"line_number":1039,"context_line":"        fields \u003d get_real_fields(objclass, fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_af65b01e","line":1036,"updated":"2016-07-27 10:39:23.000000000","message":"same comment about \u0027real\u0027","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            new \u003d self._test_class.get_objects(self.context, **filters)"},{"line_number":1034,"context_line":"            self.assertEqual([obj], new)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    def _get_real_fields(self, objclass, db_attrs):"},{"line_number":1037,"context_line":"        fields \u003d objclass.modify_fields_from_db(db_attrs)"},{"line_number":1038,"context_line":"        fields \u003d remove_timestamps_from_fields(fields)"},{"line_number":1039,"context_line":"        fields \u003d get_real_fields(objclass, fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_cf974346","line":1036,"in_reply_to":"dada55a8_af65b01e","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a2420e6b4745c2d9a701058ccb21532bc2e45558","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        obj \u003d cls_(self.context, **self._get_real_fields(cls_, db_obj))"},{"line_number":1048,"context_line":"        obj.create()"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        # create objects that are going to be loaded into the base object thru"},{"line_number":1051,"context_line":"        # synthetic fields"},{"line_number":1052,"context_line":"        for field in object_fields:"},{"line_number":1053,"context_line":"            objclass \u003d self._get_ovo_object_class(cls_, field)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_af4c909e","line":1050,"range":{"start_line":1050,"start_character":74,"end_line":1050,"end_character":78},"updated":"2016-07-27 10:39:23.000000000","message":"nit: thru -\u003e through","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        obj \u003d cls_(self.context, **self._get_real_fields(cls_, db_obj))"},{"line_number":1048,"context_line":"        obj.create()"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        # create objects that are going to be loaded into the base object thru"},{"line_number":1051,"context_line":"        # synthetic fields"},{"line_number":1052,"context_line":"        for field in object_fields:"},{"line_number":1053,"context_line":"            objclass \u003d self._get_ovo_object_class(cls_, field)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_2fbb7fc5","line":1050,"range":{"start_line":1050,"start_character":74,"end_line":1050,"end_character":78},"in_reply_to":"dada55a8_af4c909e","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b190497da0ae24951f5e1bb78483779c45f30b90","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":1097,"context_line":"        iter_db_obj \u003d iter(self.db_objs)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        def _create():"},{"line_number":1100,"context_line":"            self._create_object_with_synthetic_fields(next(iter_db_obj))"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        self._assert_object_list_queries_constant(_create, self._test_class)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_04284c32","line":1099,"updated":"2016-07-26 15:19:33.000000000","message":"Nice one :)","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"61a22e309c1ca292d68bd6451550942909275e73","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from neutron.objects import subnet"},{"line_number":40,"context_line":"from neutron.tests import base as test_base"},{"line_number":41,"context_line":"from neutron.tests import tools"},{"line_number":42,"context_line":"from neutron.tests.unit.db.test_db_base_plugin_v2 import DbOperationBoundMixin"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"SQLALCHEMY_COMMIT \u003d \u0027sqlalchemy.engine.Connection._commit_impl\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_588afb1b","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":78},"updated":"2016-07-27 12:00:13.000000000","message":"You should import test_db_base_plugin_v2 module:\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"d249e68a2e3fe802176e245387aced1aed5cffee"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"ddd00b5d3ea3ac7308d67cf95968ac390274b749","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from neutron.objects import subnet"},{"line_number":40,"context_line":"from neutron.tests import base as test_base"},{"line_number":41,"context_line":"from neutron.tests import tools"},{"line_number":42,"context_line":"from neutron.tests.unit.db.test_db_base_plugin_v2 import DbOperationBoundMixin"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"SQLALCHEMY_COMMIT \u003d \u0027sqlalchemy.engine.Connection._commit_impl\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_23655844","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":78},"in_reply_to":"dada55a8_588afb1b","updated":"2016-07-27 12:19:21.000000000","message":"Shame on me :(","commit_id":"d249e68a2e3fe802176e245387aced1aed5cffee"}],"neutron/tests/unit/objects/test_subnet.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"9ef7157d2643d02361549e0318c74816e6705ea4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.assertEqual(2, new.dns_nameservers[1].order)"},{"line_number":166,"context_line":"        self.assertEqual(4, new.dns_nameservers[-1].order)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _get_obj_fields(self, cls):"},{"line_number":169,"context_line":"        fields \u003d super(SubnetDbObjectTestCase, self)._get_obj_fields(cls)"},{"line_number":170,"context_line":"        fields[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":171,"context_line":"        return fields"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_get_subnet_with_one_query(self):"},{"line_number":174,"context_line":"        self._assert_object_list_queries_constant("}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_f3ab84d4","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":21},"updated":"2016-07-19 15:07:09.000000000","message":"same as for test_trunk.py","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"9ef7157d2643d02361549e0318c74816e6705ea4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        fields[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":171,"context_line":"        return fields"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_get_subnet_with_one_query(self):"},{"line_number":174,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":175,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":176,"context_line":"            self._test_class"},{"line_number":177,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_d37da06f","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":9},"updated":"2016-07-19 15:07:09.000000000","message":"The code seems generic. Why is it specific to the subnet only but is not part of the base class? And it seems that you added \u0027_list\u0027 to the base class exactly for that.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cdcc03ae82a18aeb4a86881104bb2db018073952","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        fields[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":171,"context_line":"        return fields"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_get_subnet_with_one_query(self):"},{"line_number":174,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":175,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":176,"context_line":"            self._test_class"},{"line_number":177,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_f846984d","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":9},"in_reply_to":"dada55a8_0464f9e1","updated":"2016-07-20 09:21:58.000000000","message":"Agreed with Ilya. I think it\u0027s a fair requirement for all resources. We should try to make it so.\n\nThat said, I think we may have issues with enforcing that for qos policy as it is now. AFAIK currently we load rules in separate statements. To move forward, I would just disable that particular test for qos policy, and move on enforcing it for all other objects. Then someone will tackle scaling issue for qos policies as a follow up.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"d4025789c7a24e27dfc2037be51752166d637b82","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        fields[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":171,"context_line":"        return fields"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_get_subnet_with_one_query(self):"},{"line_number":174,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":175,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":176,"context_line":"            self._test_class"},{"line_number":177,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_0464f9e1","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":9},"in_reply_to":"dada55a8_5b937a4f","updated":"2016-07-19 22:40:50.000000000","message":"I\u0027d say that we either do it for all objects or none at all. Having \u0027_list\u0027 (that is required by the DbOperationBoundMixin) in the base object class and the mixin being optional does not make sense to me.\n\nNote that \u0027__assert_object_list_queries_constant\u0027 does not require that \u0027object is fetched using one SQL query\u0027. It ensures that the number of queries stays constant after adding more objects which is slightly different thing. Think of it as a scalability test.\n\nI do like that test and I do think it makes sense as a requirement for all object, not just the selected ones, as it ensures that object implementation scales well.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6b6000daee2b684b08fae86f49a16aead2f5b307","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        fields[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":171,"context_line":"        return fields"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_get_subnet_with_one_query(self):"},{"line_number":174,"context_line":"        self._assert_object_list_queries_constant("},{"line_number":175,"context_line":"            self._create_object_with_synthetic_fields,"},{"line_number":176,"context_line":"            self._test_class"},{"line_number":177,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_5b937a4f","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":9},"in_reply_to":"dada55a8_d37da06f","updated":"2016-07-19 19:03:21.000000000","message":"yes, it is generic but the question is: can every object be fetched using one SQL query? I\u0027m sure that network, port and subnet can be, but it is not general rule for every other database entities. If I\u0027m wrong, and every resource can be fetched just just one SQL query, then we can move this test to test base class.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"}],"neutron/tests/unit/objects/test_trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3090183c0e742cb988b437caeaf29e89b190be9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":113,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":116,"context_line":"        # NOTE: this test is covered in test_create_with_sub_ports"},{"line_number":117,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_44463622","line":115,"updated":"2016-06-28 11:40:54.000000000","message":"OK. But why do you need to DISABLE the common test?","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"8eaf09ab773f37f5f2e40dd05a641a55ccbb1af8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":113,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_get_object_with_synthetic_fields(self):"},{"line_number":116,"context_line":"        # NOTE: this test is covered in test_create_with_sub_ports"},{"line_number":117,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3f01686b","line":115,"in_reply_to":"3aaa91ec_44463622","updated":"2016-06-28 14:47:45.000000000","message":"trunk object requires special treatment and I did not have time to fix it ;) Generally speaking maybe this should not be in test_base. This test should detect if object was loaded using just one sql query. Maybe this is not true to all objects, but this is required for network, subnet and port.","commit_id":"fb09fb01f2d90eae7ac1086e206a79946b1ff7d3"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"e79177c5d9c2f5c4ae8373c8e3f4344926709c02","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_c8ba19e1","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"updated":"2016-07-19 11:02:13.000000000","message":"Could you please clarify what are you trying to do here? Doesn\u0027t it conflict with  \u0027_create_port\u0027 call in \u0027setUp\u0027?","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"3a03b24a4915244a4ffbf2c99c4ed1c3dd836616","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_6d0cad3b","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"in_reply_to":"dada55a8_1050b85c","updated":"2016-07-20 07:26:32.000000000","message":"If we would introduce test case with fetching object with one query to all objects, the _get_obj_fields will be called multiple times due to DbOperationBoundMixin, so it cannot be done in setUp method.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"9ef7157d2643d02361549e0318c74816e6705ea4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_4d08ed2c","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"in_reply_to":"dada55a8_3369aabf","updated":"2016-07-19 15:07:09.000000000","message":"I\u0027d rather like to see that covered in the base class. It just does not sit well with me that we\u0027ll need to override that method in each object that has FK constraint (maybe it\u0027s just Trunk and SubNet now, but I\u0027m sure there\u0027s more to come).\n\nMaybe we can move that preparation to \u0027setUp\u0027? Then we could probably have the synthetic-field test fail with a meaningful error (to guide other developers) if the necessary preparations have not been done in \u0027setUp\u0027.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"d4025789c7a24e27dfc2037be51752166d637b82","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_1050b85c","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"in_reply_to":"dada55a8_3bf4c684","updated":"2016-07-19 22:40:50.000000000","message":"Technically we can fully automate it (all the necessary metadata is available). But that would be quite complicated and certainly outside of this patch\u0027s scope.\n\nWhat I\u0027m suggesting is to move the logic of \u0027_get_obj_fields\u0027 to \u0027setUp\u0027 so if the tested object has synthetic fields, \u0027setUp\u0027 has to take care of preparing proper objects as it does with \u0027self.obj_fields\u0027/\u0027self.db_objs\u0027. That logic is already partially there [1]. And then we also need a test that would check if the object has synthetic fields and \u0027setUp\u0027 has prepared the children objects properly (and otherwise fail with a hint for a developer to do initialisation in \u0027setUp\u0027).\n\nJust think of other developers that would get their OVO to fail your tests. How are they supposed to know that they need to override \u0027_get_obj_fields\u0027?\n\n[1] https://github.com/openstack/neutron/blob/581b854/neutron/tests/unit/objects/test_base.py#L325","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6b6000daee2b684b08fae86f49a16aead2f5b307","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_3bf4c684","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"in_reply_to":"dada55a8_4d08ed2c","updated":"2016-07-19 19:03:21.000000000","message":"I\u0027m not sure how can we do it in general way. It is like per object case, what is needed to fully initialize the foreign keys.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c5a5822f64a68064e55ede93cba6038d720b6aa8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, trunk.sub_ports)))"},{"line_number":123,"context_line":"        self.assertEqual(expected, set(map(_as_tuple, sub_ports)))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _get_obj_fields(self, objclass):"},{"line_number":126,"context_line":"        fields \u003d super(TrunkDbObjectTestCase, self)._get_obj_fields(objclass)"},{"line_number":127,"context_line":"        if objclass in [t_obj.SubPort, t_obj.Trunk]:"},{"line_number":128,"context_line":"            self._create_port(id\u003dfields[\u0027port_id\u0027],"},{"line_number":129,"context_line":"                              network_id\u003dself._network[\u0027id\u0027])"},{"line_number":130,"context_line":"        return fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_3369aabf","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":21},"in_reply_to":"dada55a8_c8ba19e1","updated":"2016-07-19 11:24:54.000000000","message":"create_port is called here, because when creating object with all synthetic fields, we are generating new fields, so setUp() is not taking part in creating port for trunk and SubPort.\n\n_get_obj_fields is generating new input for creating new objects, in order to test creating multiple resources and possible performance overhead when used in scale.","commit_id":"dd6a208d9db3fa5c5d4fabf31d349f20df98038e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c6033359d8ace6617a537534e2029d83979e8ae3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib import exceptions as n_exc"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_af1daf10","line":16,"updated":"2016-07-27 10:44:38.000000000","message":"btw, itertools is stdlib while mock is 3party. We should probably put an empty line between. Yeah, I know that mock is split from neutron_lib and friends, which is wrong...","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af8522fdf3ce6f1259c6c7770726d4f00bceee20","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib import exceptions as n_exc"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_52d2dc5c","line":16,"in_reply_to":"dada55a8_af1daf10","updated":"2016-07-27 11:02:45.000000000","message":"Done","commit_id":"94bf4bf7e21ad13c1bd6a3a566d4133094b14b48"}]}
