)]}'
{"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @property"},{"line_number":265,"context_line":"    def l2_agent(self):"},{"line_number":266,"context_line":"        if self.host_desc.l2_agent_type \u003d\u003d constants.AGENT_TYPE_LINUXBRIDGE:"},{"line_number":267,"context_line":"            return self.linuxbridge_agent"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            return self.ovs_agent"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"class Environment(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_e5e3a331","line":269,"range":{"start_line":266,"start_character":0,"end_line":269,"end_character":33},"updated":"2016-07-29 13:07:54.000000000","message":"Consider implementing this via map:\n\n  self._agent_map \u003d {\n      constants.AGENT_TYPE_LINUXBRIDGE: self.linux_bridgeagent,\n      constants.AGENT_TYPE_OPENVSWITCH: self.ovs_agent,\n  }\n  ...\n  @property\n  def l2_agent(self):\n      return self._agent_map[self.host_desc.l2_agent_type]","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @property"},{"line_number":265,"context_line":"    def l2_agent(self):"},{"line_number":266,"context_line":"        if self.host_desc.l2_agent_type \u003d\u003d constants.AGENT_TYPE_LINUXBRIDGE:"},{"line_number":267,"context_line":"            return self.linuxbridge_agent"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            return self.ovs_agent"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"class Environment(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_6c42c569","line":269,"range":{"start_line":266,"start_character":0,"end_line":269,"end_character":33},"in_reply_to":"bacf61ea_e5e3a331","updated":"2016-08-01 07:59:34.000000000","message":"Value of the self.linux_bridgeagent and self.ovs_agent properties change in runtime, and can generally be changed anytime externally as there are also setters for these properties. Hence such a map would have to be updated every time. Other way is to reference property getters directly, yet is the hassle with property getter references (as explained here [1]) seems not worth it. IMHO it would rather reduce the final code readability.","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":30,"context_line":"from neutron.tests.fullstack import base as fullstack_base"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_25301b9e","line":32,"updated":"2016-07-29 13:07:54.000000000","message":"Nit: Empty line not needed","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":30,"context_line":"from neutron.tests.fullstack import base as fullstack_base"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_4c3ee1da","line":32,"in_reply_to":"bacf61ea_25301b9e","updated":"2016-08-01 07:59:34.000000000","message":"Done","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        common_utils.wait_until_true(self.server_is_live)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def restart(self, **kwargs):"},{"line_number":143,"context_line":"        return self.process_fixture.restart(**kwargs)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def server_is_live(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_6513330e","line":142,"range":{"start_line":142,"start_character":22,"end_line":142,"end_character":30},"updated":"2016-07-29 13:07:54.000000000","message":"What is the reason of kwargs here? Would it be better to define a strict api for this method?","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        common_utils.wait_until_true(self.server_is_live)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def restart(self, **kwargs):"},{"line_number":143,"context_line":"        return self.process_fixture.restart(**kwargs)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def server_is_live(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_2f9d5fbc","line":142,"range":{"start_line":142,"start_character":22,"end_line":142,"end_character":30},"in_reply_to":"bacf61ea_6513330e","updated":"2016-08-01 07:59:34.000000000","message":"Done","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"}],"neutron/tests/fullstack/test_connectivity.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5610cc94451ff21ec82f1d3c61b670b7a4c07a73","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron_lib import constants"},{"line_number":16,"context_line":"import time"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":"import testscenarios"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a790bc96","line":16,"updated":"2016-06-28 11:53:23.000000000","message":"time should not be part of the third party imports","commit_id":"dba6a142ae2f0bf44b84e2f4c4baf2def767cfb6"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def skip_if_tunneling():"},{"line_number":38,"context_line":"    def deco(f):"},{"line_number":39,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":40,"context_line":"            if self.environment.env_desc.tunneling_enabled:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_45d42f1f","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":24},"updated":"2016-07-29 13:07:54.000000000","message":"This can be removed, 3 layers are only for parametrized decorators","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def skip_if_tunneling():"},{"line_number":38,"context_line":"    def deco(f):"},{"line_number":39,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":40,"context_line":"            if self.environment.env_desc.tunneling_enabled:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_efb7c737","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":24},"in_reply_to":"bacf61ea_45d42f1f","updated":"2016-08-01 07:59:34.000000000","message":"Done","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for vm in vms:"},{"line_number":96,"context_line":"            vm.block_until_boot()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for i in range(len(vms) - 1):"},{"line_number":99,"context_line":"            for j in range(i + 1, len(vms)):"},{"line_number":100,"context_line":"                vms[i].block_until_ping(vms[j].ip)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return vms"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_65afb394","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":50},"updated":"2016-07-29 13:07:54.000000000","message":"Consider separate it to a method.","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for vm in vms:"},{"line_number":96,"context_line":"            vm.block_until_boot()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for i in range(len(vms) - 1):"},{"line_number":99,"context_line":"            for j in range(i + 1, len(vms)):"},{"line_number":100,"context_line":"                vms[i].block_until_ping(vms[j].ip)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return vms"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_6ff11701","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":50},"in_reply_to":"bacf61ea_65afb394","updated":"2016-08-01 07:59:34.000000000","message":"Done","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4fab9b7a452c94259d4def2fb4240de3b4de11b8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # It is necessary to give agents time to initialize"},{"line_number":197,"context_line":"            # because some crucial steps (e.g. setting up bridge flows)"},{"line_number":198,"context_line":"            # happen only after RPC is established"},{"line_number":199,"context_line":"            utils.wait_until_true(done)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_25081b91","line":199,"updated":"2016-07-29 13:07:54.000000000","message":"I think we should get used to pass a message to wait_until_true(), we\u0027re getting so much traces saying \"TimeoutException\" without explanation of what is going on.","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"24daf74e1ceae9281ee6248e7a86803ce740c493","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # It is necessary to give agents time to initialize"},{"line_number":197,"context_line":"            # because some crucial steps (e.g. setting up bridge flows)"},{"line_number":198,"context_line":"            # happen only after RPC is established"},{"line_number":199,"context_line":"            utils.wait_until_true(done)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_efc6a766","line":199,"in_reply_to":"bacf61ea_25081b91","updated":"2016-08-01 07:59:34.000000000","message":"Done","commit_id":"8f6e625023363d1dfabf0f7747bea0999ffb86fb"}]}
