)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"9639fb045f2ebce361febd5b22fdac75822ac19a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            lambda: collections.defaultdict(list))"},{"line_number":86,"context_line":"        self.pre_sg_members \u003d None"},{"line_number":87,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":88,"context_line":"        self._add_sg_chain_v4v6()"},{"line_number":89,"context_line":"        self._enabled_netfilter_for_bridges \u003d False"},{"line_number":90,"context_line":"        self.updated_rule_sg_ids \u003d set()"},{"line_number":91,"context_line":"        self.updated_sg_members \u003d set()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_86904d50","line":88,"updated":"2016-07-14 04:08:59.000000000","message":"why add sg chain at this class init?","commit_id":"3e210fad6387f5e212cef8654b3091918407a22c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"752c1f8eac4df268e88430129085b8a9255bae28","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            lambda: collections.defaultdict(list))"},{"line_number":86,"context_line":"        self.pre_sg_members \u003d None"},{"line_number":87,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":88,"context_line":"        self._add_sg_chain_v4v6()"},{"line_number":89,"context_line":"        self._enabled_netfilter_for_bridges \u003d False"},{"line_number":90,"context_line":"        self.updated_rule_sg_ids \u003d set()"},{"line_number":91,"context_line":"        self.updated_sg_members \u003d set()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_9c6b7a1f","line":88,"in_reply_to":"1aa78d24_86904d50","updated":"2016-07-14 05:43:28.000000000","message":"Existing code -\nDelete SG_CHAIN, so that all SG_CHAIN rules for all ports will also be deleted. During setup_chains_apply, SG_CHAIN is created again and SG_CHAIN rules for all ports recreated.\n\nNew approach -\nDon\u0027t delete SG_CHAIN as we it will have rules for ports which we are not refreshing. Instead, only delete and create SG_CHAIN rules for ports which needs to be refreshed.\n\nSo SG_CHAIN should be created before firewall rules for any ports are created, I am adding that during initialization.","commit_id":"3e210fad6387f5e212cef8654b3091918407a22c"}]}