)]}'
{"neutron/worker.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1589579a8878b79538cf6bf3c7f69f90ec2a0f60","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return self._worker_process_count"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def start(self):"},{"line_number":91,"context_line":"        if self.worker_process_count \u003e 0:"},{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_96c83776","line":91,"updated":"2016-06-28 18:55:02.000000000","message":"why is this on the condition of the processes?","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7d6b46fc5dd55d3dd5b17a440964b3c405df6f94","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return self._worker_process_count"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def start(self):"},{"line_number":91,"context_line":"        if self.worker_process_count \u003e 0:"},{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_57697bf8","line":91,"in_reply_to":"3aaa91ec_5a26dfba","updated":"2016-06-29 15:16:59.000000000","message":"git blame has your answer.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0c60dad19c810bf42b0b93a3296733a65708002d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return self._worker_process_count"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def start(self):"},{"line_number":91,"context_line":"        if self.worker_process_count \u003e 0:"},{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f1ad459c","line":91,"in_reply_to":"3aaa91ec_96c83776","updated":"2016-06-28 19:16:07.000000000","message":"why are you asking me?","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"041bf7ecf7790ae4636a4cb465c5e02bc57968a4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return self._worker_process_count"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def start(self):"},{"line_number":91,"context_line":"        if self.worker_process_count \u003e 0:"},{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5a26dfba","line":91,"in_reply_to":"3aaa91ec_f1ad459c","updated":"2016-06-29 07:01:45.000000000","message":"cause i was hoping that you would have an answer","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7b8cc7660366b64540bed5fd348f08e5043caa7f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0ec54b8d","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"updated":"2016-06-28 21:35:54.000000000","message":"Is AFTER_INIT the proper choice for event names here? \n\n\nGiven its usage here in start(), I would\u0027ve expected the event name to relate to starting or running.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1589579a8878b79538cf6bf3c7f69f90ec2a0f60","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_56208f49","line":95,"updated":"2016-06-28 18:55:02.000000000","message":"test?","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8dc7e1bfa0e2384bd560bfb4738cc8f1f272095c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fcaa35d1","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"in_reply_to":"3aaa91ec_0ec54b8d","updated":"2016-06-28 22:45:42.000000000","message":"I am open to suggestions.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8dc7e1bfa0e2384bd560bfb4738cc8f1f272095c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9ce9711d","line":95,"in_reply_to":"3aaa91ec_4e911399","updated":"2016-06-28 22:45:42.000000000","message":"No there is no explicit test about AFTER_INIT. What I am saying is that this code is covered [1], and thus an error in notification would be caught.\n\n[1] https://review.openstack.org/#/c/189391","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7b8cc7660366b64540bed5fd348f08e5043caa7f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4e911399","line":95,"in_reply_to":"3aaa91ec_5195393e","updated":"2016-06-28 21:35:54.000000000","message":"There\u0027s a test for the AFTER_INIT process notification? I must have missed it.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0c60dad19c810bf42b0b93a3296733a65708002d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5195393e","line":95,"in_reply_to":"3aaa91ec_56208f49","updated":"2016-06-28 19:16:07.000000000","message":"this is already covered.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d5fd15ec7afd183b1355688f90e7a492fc704ab8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_faf79cd0","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"in_reply_to":"3aaa91ec_bfd346d4","updated":"2016-06-29 21:25:04.000000000","message":"Got it. In that case IMHO the values you\u0027re using now are better as they could perhaps be repurposed more easily.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"f6dc59ba19b343273028cf337dc48791029aacd7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8ffd75b3","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"in_reply_to":"3aaa91ec_bfd346d4","updated":"2016-06-30 00:48:00.000000000","message":"I\u0027m partial to AFTER_INIT. Agreed that there is no need to add event types that won\u0027t be used right now.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c49baa743d81467a63f280c633855e4cc7ec4cbc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ffc2ee83","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"in_reply_to":"3aaa91ec_fcaa35d1","updated":"2016-06-29 20:59:52.000000000","message":"I guess I\u0027m 100% clear what the event indicates. If it\u0027s meant to indicate start/stop process lifecycle perhaps it should just be START and STOP (STOP would notify in stop() most likely).","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e4fa78a9d268a081fce0ddee76a09b4183cf490a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # TODO(armax): remove the AFTER_CREATE notification once"},{"line_number":93,"context_line":"            # subscribers have been updated"},{"line_number":94,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_CREATE, self.start)"},{"line_number":95,"context_line":"            registry.notify(resources.PROCESS, events.AFTER_INIT, self.start)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bfd346d4","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":64},"in_reply_to":"3aaa91ec_ffc2ee83","updated":"2016-06-29 21:13:03.000000000","message":"Consider this a couple of events that can be emitted when a process is starting up, prior to making the process functional and right after it. To me INIT can be synonymous of STARTUP, BOOT, etc. INIT is evocative enough IMO as it\u0027s short for initialization, but I can replace it with STARTUP if it\u0027s better.\n\nPerhaps it would be clear if I added the following:\n\nBEFORE_TEARDOWN\nAFTER_TEARDOWN\n\nThese could be used to notify that the process is about to be torn down or that the torn down is complete.\n\nI did not add them because there\u0027s no use for them right now.","commit_id":"2c8debdc5752fd4c01ed4a9ca8d2631e99aabbd5"}]}
