)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"12387ac926311a66bb2c5166844399ed50721875","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv6 raise exception AddrFormatError"},{"line_number":10,"context_line":"if address is specified as empty string.  Method is_valid_ipv6"},{"line_number":11,"context_line":"catches the exception and returns boolean value. So"},{"line_number":12,"context_line":"we\u0027d better use it from oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_15b9bdcb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":60},"updated":"2016-06-29 11:04:31.000000000","message":"Can you put here a source where you get this information from? As per netaddr documentation it returns False:\n\nhttps://pythonhosted.org/netaddr/api.html#netaddr.valid_ipv6\n\nI also tried it in python 2.7.8:\n\n In [2]: netaddr.valid_ipv6(\u0027192.168.0.1\u0027)\n Out[2]: False","commit_id":"e9e30ab91c857d56bc90a7a3945244bc1546d656"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cca4ce2ecf1b815dbc7f8e0e93af614dedf71e20","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv6 raise exception AddrFormatError"},{"line_number":10,"context_line":"if address is specified as empty string.  Method is_valid_ipv6"},{"line_number":11,"context_line":"catches the exception and returns boolean value. So"},{"line_number":12,"context_line":"we\u0027d better use it from oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_d9b00446","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":60},"in_reply_to":"3aaa91ec_15b9bdcb","updated":"2016-06-29 14:39:01.000000000","message":"+1","commit_id":"e9e30ab91c857d56bc90a7a3945244bc1546d656"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"83ee24fd657373526a662617c815c179634c96ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv6 raise exception AddrFormatError"},{"line_number":10,"context_line":"if address is specified as empty string.  Method is_valid_ipv6"},{"line_number":11,"context_line":"catches the exception and returns boolean value. So"},{"line_number":12,"context_line":"we\u0027d better use it from oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_f52686b8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":60},"in_reply_to":"3aaa91ec_d9b00446","updated":"2016-06-30 01:58:21.000000000","message":"This is from source code ,the docstring of netaddr.valid_ipv6 need mention the exceptionAddrFormatError","commit_id":"e9e30ab91c857d56bc90a7a3945244bc1546d656"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"038dd5df68755f277982b735218695591ca48f96","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        # (dzyu) Check if it is legal ipv6 address, if so, need wrap"},{"line_number":620,"context_line":"        # it with \u0027[]\u0027 to let dnsmasq to distinguish MAC address from"},{"line_number":621,"context_line":"        # IPv6 address."},{"line_number":622,"context_line":"        if netutils.is_valid_ipv6(address):"},{"line_number":623,"context_line":"            return \u0027[%s]\u0027 % address"},{"line_number":624,"context_line":"        return address"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f642090e","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":33},"updated":"2016-06-30 06:53:58.000000000","message":"You probably missed my previous question so I\u0027ll put it here. If I get it correctly, netaddr.valid_ipv6 raises exception only for empy strings. Previously, if by some reason address was an empty string here, we raised an exception because it\u0027s not a valid input.\n\nNow we proceed not leaving any warning which will later lead to writing no address to lease and hosts file for dnsmasq. This seems unsafe to me and I think the exception approach is better. Thoughts?","commit_id":"8e9180f5bf8b5ebb0807546a9628669499e6fa35"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f5c42413e8b340f5f6f8a10ff2a0cd3e6388ae9b","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        # (dzyu) Check if it is legal ipv6 address, if so, need wrap"},{"line_number":620,"context_line":"        # it with \u0027[]\u0027 to let dnsmasq to distinguish MAC address from"},{"line_number":621,"context_line":"        # IPv6 address."},{"line_number":622,"context_line":"        if netutils.is_valid_ipv6(address):"},{"line_number":623,"context_line":"            return \u0027[%s]\u0027 % address"},{"line_number":624,"context_line":"        return address"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_fb482d5e","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":33},"in_reply_to":"3aaa91ec_f642090e","updated":"2016-06-30 09:06:47.000000000","message":"Sorry, I missed your previous comments, you are right, this only occurs when IP address is empty string. Should we check address if it\u0027s valid ipv4 address before return?","commit_id":"8e9180f5bf8b5ebb0807546a9628669499e6fa35"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"38112fdb5c751c9f30ff945940111ae60a9f272f","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        # (dzyu) Check if it is legal ipv6 address, if so, need wrap"},{"line_number":620,"context_line":"        # it with \u0027[]\u0027 to let dnsmasq to distinguish MAC address from"},{"line_number":621,"context_line":"        # IPv6 address."},{"line_number":622,"context_line":"        if netutils.is_valid_ipv6(address):"},{"line_number":623,"context_line":"            return \u0027[%s]\u0027 % address"},{"line_number":624,"context_line":"        return address"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5b6fc1fb","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":33},"in_reply_to":"3aaa91ec_fb482d5e","updated":"2016-06-30 09:25:02.000000000","message":"I think the question here lies on what are you attempting to fix here. If you add a check for valid ipv4 and it fails, what would you do?\n\nMaybe it doesn\u0027t even happen that we get an empty string here, that\u0027s why I\u0027m asking what does this patch fix?","commit_id":"8e9180f5bf8b5ebb0807546a9628669499e6fa35"}]}
