)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2bdc45b3b9bab7b0e7ded04488e5bef4a52f882f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename DB columns: tenant -\u003e project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All occurences of ``tenant_id`` across the database are renamed"},{"line_number":10,"context_line":"to ``project_id``. Both options are equally valid, but ``project_id``"},{"line_number":11,"context_line":"is preferred."},{"line_number":12,"context_line":"To inform external users about the change, HasTenant class was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_fb47bfb9","line":9,"updated":"2016-07-05 22:20:22.000000000","message":"what about changes to the neutron/objects layer? Not needed/postponed? Would be nice to clarify.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5249603a3ae244338247cfa7c70c7b8f0f30d17","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename DB columns: tenant -\u003e project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All occurences of ``tenant_id`` across the database are renamed"},{"line_number":10,"context_line":"to ``project_id``. Both options are equally valid, but ``project_id``"},{"line_number":11,"context_line":"is preferred."},{"line_number":12,"context_line":"To inform external users about the change, HasTenant class was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_ca5c26f3","line":9,"in_reply_to":"1aa78d24_fb47bfb9","updated":"2016-07-08 02:09:29.000000000","message":"Need to clarify this with OVO folks. Will update commit message later.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Partially-Implements: blueprint keystone-v3"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I87a8ef342ccea004731ba0192b23a8e79bc382dc"},{"line_number":19,"context_line":"Depends-On: Ic55b893bd567a6faf79bef16f3701a567bc44974"},{"line_number":20,"context_line":"Depends-On: I8f9cb9d19e1f540d4edf169a3b52badcc30f6cc9"},{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_fe70bede","line":19,"updated":"2016-08-02 15:18:34.000000000","message":"lbaas: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I87a8ef342ccea004731ba0192b23a8e79bc382dc"},{"line_number":19,"context_line":"Depends-On: Ic55b893bd567a6faf79bef16f3701a567bc44974"},{"line_number":20,"context_line":"Depends-On: I8f9cb9d19e1f540d4edf169a3b52badcc30f6cc9"},{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_3e7376e9","line":20,"updated":"2016-08-02 15:18:34.000000000","message":"sfc: let\u0027s not wait on this to merge.","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Change-Id: I87a8ef342ccea004731ba0192b23a8e79bc382dc"},{"line_number":19,"context_line":"Depends-On: Ic55b893bd567a6faf79bef16f3701a567bc44974"},{"line_number":20,"context_line":"Depends-On: I8f9cb9d19e1f540d4edf169a3b52badcc30f6cc9"},{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_de485a8d","line":21,"updated":"2016-08-02 15:18:34.000000000","message":"l2gw: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Depends-On: Ic55b893bd567a6faf79bef16f3701a567bc44974"},{"line_number":20,"context_line":"Depends-On: I8f9cb9d19e1f540d4edf169a3b52badcc30f6cc9"},{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"},{"line_number":25,"context_line":"Depends-On: I984502745629280c033e52f0f1c06fc268fa0255"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_5e5d8a47","line":22,"updated":"2016-08-02 15:18:34.000000000","message":"vpnaas: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Depends-On: I8f9cb9d19e1f540d4edf169a3b52badcc30f6cc9"},{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"},{"line_number":25,"context_line":"Depends-On: I984502745629280c033e52f0f1c06fc268fa0255"},{"line_number":26,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_fe3efed8","line":23,"updated":"2016-08-02 15:18:34.000000000","message":"midonet: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Depends-On: If404c88cac07688dbbae3372219a697efc68356f"},{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"},{"line_number":25,"context_line":"Depends-On: I984502745629280c033e52f0f1c06fc268fa0255"},{"line_number":26,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"},{"line_number":27,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_3e08962d","line":24,"updated":"2016-08-02 15:18:34.000000000","message":"dynamic-routing: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Depends-On: I7e6b6186f7c6fe5b8f6e000b3ae39a758c5d0f16"},{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"},{"line_number":25,"context_line":"Depends-On: I984502745629280c033e52f0f1c06fc268fa0255"},{"line_number":26,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"},{"line_number":27,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_79198879","line":25,"updated":"2016-08-02 15:18:34.000000000","message":"fwaas: merged","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a06c65a73e3eeca325d290c4f8a87c2e85f42f28","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Depends-On: Ia59629fd953750c9f7d495e74c7ca6cfbf3ca077"},{"line_number":24,"context_line":"Depends-On: If6a4db955a2e00635a37605dc165cf9f2f0fac31"},{"line_number":25,"context_line":"Depends-On: I984502745629280c033e52f0f1c06fc268fa0255"},{"line_number":26,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"},{"line_number":27,"context_line":"Depends-On: I017b3f8ec432f1d334879f30026d8b16f6295eff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_b9eca02a","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":53},"updated":"2016-08-02 15:18:34.000000000","message":"You have two reviews (bgpvpn and astara) with the same change ID. I think you will confuse gerrit and zuul?\n\nAnyway, let\u0027s not wait on bgpvpn or astara either.","commit_id":"62de2a22c385849f157e7f18ac280bef2b8603ea"}],"neutron/db/migration/alembic_migrations/versions/newton/contract/7d9d8eeec6ad_rename_tenant_to_project.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8a8c51db65ed97c8054b2376234f48918cad10c4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# NOTE(dasm): List of tables gathered with query attached below:"},{"line_number":35,"context_line":"# SELECT DISTINCT TABLE_NAME"},{"line_number":36,"context_line":"#     FROM INFORMATION_SCHEMA.COLUMNS"},{"line_number":37,"context_line":"#     WHERE COLUMN_NAME IN (\u0027tenant_id\u0027)"},{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c1e644af","line":38,"range":{"start_line":34,"start_character":2,"end_line":38,"end_character":37},"updated":"2016-07-06 09:25:03.000000000","message":"You should check neutron models, not neutron db for tables, as now you rename columns of external projects as well.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5249603a3ae244338247cfa7c70c7b8f0f30d17","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# NOTE(dasm): List of tables gathered with query attached below:"},{"line_number":35,"context_line":"# SELECT DISTINCT TABLE_NAME"},{"line_number":36,"context_line":"#     FROM INFORMATION_SCHEMA.COLUMNS"},{"line_number":37,"context_line":"#     WHERE COLUMN_NAME IN (\u0027tenant_id\u0027)"},{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e5295a39","line":38,"range":{"start_line":34,"start_character":2,"end_line":38,"end_character":37},"in_reply_to":"1aa78d24_59019737","updated":"2016-07-08 02:09:29.000000000","message":"Done","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9574ffbb646eb8f35df5712c0d42dc2bdcd8ca83","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# NOTE(dasm): List of tables gathered with query attached below:"},{"line_number":35,"context_line":"# SELECT DISTINCT TABLE_NAME"},{"line_number":36,"context_line":"#     FROM INFORMATION_SCHEMA.COLUMNS"},{"line_number":37,"context_line":"#     WHERE COLUMN_NAME IN (\u0027tenant_id\u0027)"},{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_59019737","line":38,"range":{"start_line":34,"start_character":2,"end_line":38,"end_character":37},"in_reply_to":"1aa78d24_c1e644af","updated":"2016-07-06 14:25:24.000000000","message":"Thanks for catching this. I used the metadata from [1] to list the tables:\n\n  [table.fullname for table in metadata.sorted_tables]\n\nand got the following list:\n\n    [\u0027address_scopes\u0027, \u0027agents\u0027, \u0027dvr_host_macs\u0027, \u0027flavors\u0027, \u0027ipamsubnets\u0027, \u0027meteringlabels\u0027, \u0027ml2_flat_allocations\u0027, \u0027ml2_geneve_allocations\u0027, \u0027ml2_geneve_endpoints\u0027, \u0027ml2_gre_allocations\u0027, \u0027ml2_gre_endpoints\u0027, \u0027ml2_vlan_allocations\u0027, \u0027ml2_vxlan_allocations\u0027, \u0027ml2_vxlan_endpoints\u0027, \u0027providerresourceassociations\u0027, \u0027qos_policies\u0027, \u0027quotas\u0027, \u0027quotausages\u0027, \u0027reservations\u0027, \u0027serviceprofiles\u0027, \u0027standardattributes\u0027, \u0027flavorserviceprofilebindings\u0027, \u0027ipamallocationpools\u0027, \u0027ipamallocations\u0027, \u0027meteringlabelrules\u0027, \u0027networks\u0027, \u0027provisioningblocks\u0027, \u0027qos_bandwidth_limit_rules\u0027, \u0027qos_dscp_marking_rules\u0027, \u0027qospolicyrbacs\u0027, \u0027resourcedeltas\u0027, \u0027securitygroups\u0027, \u0027subnetpools\u0027, \u0027tags\u0027, \u0027default_security_group\u0027, \u0027externalnetworks\u0027, \u0027ha_router_networks\u0027, \u0027ha_router_vrid_allocations\u0027, \u0027ipamavailabilityranges\u0027, \u0027networkdhcpagentbindings\u0027, \u0027networkdnsdomains\u0027, \u0027networkrbacs\u0027, \u0027networksecuritybindings\u0027, \u0027networksegments\u0027, \u0027ports\u0027, \u0027qos_network_policy_bindings\u0027, \u0027securitygrouprules\u0027, \u0027subnetpoolprefixes\u0027, \u0027allowedaddresspairs\u0027, \u0027extradhcpopts\u0027, \u0027ml2_distributed_port_bindings\u0027, \u0027ml2_port_binding_levels\u0027, \u0027ml2_port_bindings\u0027, \u0027portbindingports\u0027, \u0027portdnses\u0027, \u0027portsecuritybindings\u0027, \u0027qos_port_policy_bindings\u0027, \u0027routers\u0027, \u0027securitygroupportbindings\u0027, \u0027segmenthostmappings\u0027, \u0027subnets\u0027, \u0027trunks\u0027, \u0027auto_allocated_topologies\u0027, \u0027dnsnameservers\u0027, \u0027floatingips\u0027, \u0027ha_router_agent_port_bindings\u0027, \u0027ipallocationpools\u0027, \u0027ipallocations\u0027, \u0027router_extra_attributes\u0027, \u0027routerl3agentbindings\u0027, \u0027routerports\u0027, \u0027routerroutes\u0027, \u0027subnetroutes\u0027, \u0027subports\u0027, \u0027floatingipdnses\u0027, \u0027ipavailabilityranges\u0027]\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/functional/db/test_models.py#L33","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"17cb9962b320ef860ebfe619e476ae253323c211","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"},{"line_number":42,"context_line":"          \u0027brocadeports\u0027, \u0027cisco_csr_identifier_map\u0027,"},{"line_number":43,"context_line":"          \u0027cisco_hosting_devices\u0027, \u0027cisco_ml2_apic_contracts\u0027,"},{"line_number":44,"context_line":"          \u0027cisco_ml2_n1kv_profile_bindings\u0027, \u0027default_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_95dbe44e","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":36},"updated":"2016-07-06 01:56:51.000000000","message":"With mysql-server 5.7 I get the following error:\n\n\"(1171, u\u0027All parts of a PRIMARY KEY must be NOT NULL; if you need NULL in a key, use UNIQUE instead\u0027) [SQL: u\u0027ALTER TABLE auto_allocated_topologies CHANGE tenant_id project_id VARCHAR(255) NULL\u0027]\"","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8a8c51db65ed97c8054b2376234f48918cad10c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"},{"line_number":42,"context_line":"          \u0027brocadeports\u0027, \u0027cisco_csr_identifier_map\u0027,"},{"line_number":43,"context_line":"          \u0027cisco_hosting_devices\u0027, \u0027cisco_ml2_apic_contracts\u0027,"},{"line_number":44,"context_line":"          \u0027cisco_ml2_n1kv_profile_bindings\u0027, \u0027default_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c15644cd","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":36},"in_reply_to":"1aa78d24_95dbe44e","updated":"2016-07-06 09:25:03.000000000","message":"I think that this error will disappear when proper existing_type and existing_nullable will be used properly.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5249603a3ae244338247cfa7c70c7b8f0f30d17","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#         AND TABLE_SCHEMA\u003d\u0027neutron\u0027;"},{"line_number":39,"context_line":"TABLES \u003d (\u0027address_scopes\u0027, \u0027arista_provisioned_nets\u0027,"},{"line_number":40,"context_line":"          \u0027arista_provisioned_tenants\u0027, \u0027arista_provisioned_vms\u0027,"},{"line_number":41,"context_line":"          \u0027auto_allocated_topologies\u0027, \u0027bgp_peers\u0027, \u0027bgp_speakers\u0027,"},{"line_number":42,"context_line":"          \u0027brocadeports\u0027, \u0027cisco_csr_identifier_map\u0027,"},{"line_number":43,"context_line":"          \u0027cisco_hosting_devices\u0027, \u0027cisco_ml2_apic_contracts\u0027,"},{"line_number":44,"context_line":"          \u0027cisco_ml2_n1kv_profile_bindings\u0027, \u0027default_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_00dc5445","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":36},"in_reply_to":"1aa78d24_c15644cd","updated":"2016-07-08 02:09:29.000000000","message":"Will retry with existing_* and check if problem still occurs.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5c0cb0726147c17069557214c19434c85bf152b4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          \u0027brocadeports\u0027, \u0027cisco_csr_identifier_map\u0027,"},{"line_number":43,"context_line":"          \u0027cisco_hosting_devices\u0027, \u0027cisco_ml2_apic_contracts\u0027,"},{"line_number":44,"context_line":"          \u0027cisco_ml2_n1kv_profile_bindings\u0027, \u0027default_security_group\u0027,"},{"line_number":45,"context_line":"          \u0027firewall_policies\u0027, \u0027firewall_rules\u0027, \u0027firewalls\u0027,"},{"line_number":46,"context_line":"          \u0027floatingips\u0027, \u0027ha_router_networks\u0027, \u0027healthmonitors\u0027,"},{"line_number":47,"context_line":"          \u0027ikepolicies\u0027, \u0027ipsec_site_connections\u0027, \u0027ipsecpolicies\u0027,"},{"line_number":48,"context_line":"          \u0027members\u0027, \u0027meteringlabels\u0027, \u0027ml2_brocadenetworks\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5e29a136","line":45,"updated":"2016-07-05 22:34:41.000000000","message":"it looks we\u0027re getting failures in renaming the tenant_id column of firewall_rules [1]. It looks like we have two problems; a) we\u0027re still installing fwaas in the neutron jobs, and b) this patch somewhat breaks out of tree plugins. I\u0027ll take care of a) separately, but now I wonder whether there\u0027s a specific order in which we need to land stuff (e.g. projects like *-aas first)\n\n[1] http://logs.openstack.org/86/335786/3/check/gate-neutron-dsvm-api/b0516d7/logs/devstacklog.txt.gz#_2016-06-30_05_08_27_668","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2660c2e684de305f7d62fb0d28e87e4f5940f6c2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          \u0027brocadeports\u0027, \u0027cisco_csr_identifier_map\u0027,"},{"line_number":43,"context_line":"          \u0027cisco_hosting_devices\u0027, \u0027cisco_ml2_apic_contracts\u0027,"},{"line_number":44,"context_line":"          \u0027cisco_ml2_n1kv_profile_bindings\u0027, \u0027default_security_group\u0027,"},{"line_number":45,"context_line":"          \u0027firewall_policies\u0027, \u0027firewall_rules\u0027, \u0027firewalls\u0027,"},{"line_number":46,"context_line":"          \u0027floatingips\u0027, \u0027ha_router_networks\u0027, \u0027healthmonitors\u0027,"},{"line_number":47,"context_line":"          \u0027ikepolicies\u0027, \u0027ipsec_site_connections\u0027, \u0027ipsecpolicies\u0027,"},{"line_number":48,"context_line":"          \u0027members\u0027, \u0027meteringlabels\u0027, \u0027ml2_brocadenetworks\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_de4471b8","line":45,"in_reply_to":"1aa78d24_5e29a136","updated":"2016-07-05 22:43:53.000000000","message":"https://review.openstack.org/#/c/321146/ should \u0027fix\u0027 the fwaas issue, but I wonder if we\u0027re gonna stumble upon an lbaas failure.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a5421b711035a6f36b5a3dde790f40e5aa2093b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ac3cb493","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"updated":"2016-06-30 07:54:51.000000000","message":"you will have to rename all indexes as well, I think you can get them directly from db with a help of sqlachemy Inspector\n\n     bind \u003d op.get_bind()\n     insp \u003d sqlalchemy.engine.reflection.Inspector.from_engine(bind)\n     table_names \u003d insp.get_table_names()\n     for table in table_names:\n          index_names \u003d [idx[\u0027name\u0027] for idx in insp.get_indexes(table)]\n          ...\n\nsomething like this","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e36f49ea921a24d1e061bc6ad2fcfc95b13d8581","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e04a0c54","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"1aa78d24_6a9c975d","updated":"2016-07-07 13:11:51.000000000","message":"I think the approach should be:\n\nManually create the list of tables from the models (I did this in my comment on line 38).\n\nThis list will not contain tables from any external project, which makes sense since they are on separate alembic branches.\n\nEach project will have a similar patch to rename tenant_id columns in the table in its own alembic branch (I will provide a recipe for such a patch and perhaps apply to one or two stadium projects as an example).","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8a8c51db65ed97c8054b2376234f48918cad10c4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c158048d","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"1aa78d24_ad3b4b37","updated":"2016-07-06 09:25:03.000000000","message":"Actually, Akihiro made a fair point here,  now this change try to rename columns even if they related to external projects, and this should not be done, as this should be up them.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e1582b9b56e65890fc08d7352373972470709bf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_6a9c975d","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"1aa78d24_ad3b4b37","updated":"2016-07-07 11:13:44.000000000","message":"I think I misunderstood the context.\nWhen i read the above comment about index renaming indexes, I misunderstood we are trying to collect tables dynamically. It was completely wrong.\n\nOn the other hand, do we renaming tenant_id in *aaS tables in this patch? (as Ann mentioned) I see LB/VPN/FW-aaS related tables at the table list above.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9574ffbb646eb8f35df5712c0d42dc2bdcd8ca83","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_aef03392","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"1aa78d24_c158048d","updated":"2016-07-06 14:25:24.000000000","message":"Yeah, sorry about that, I did not notice what was in the list.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e4141c658971d6c6d055ff3d41c60d6a08cfa1be","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ad3b4b37","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"1aa78d24_c42332a6","updated":"2016-07-05 17:51:55.000000000","message":"Akihiro, do you mean projects like *aas and networking-*? Each of those projects have their own alembic contract branch where they will need to add similar rename scripts.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28007b936b0a9e5b1b6f933834b81c207845bc58","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c42332a6","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"3aaa91ec_777602a5","updated":"2016-07-05 13:17:16.000000000","message":"There is a case where neutron DB contains tables from projects other than neutron itself. If we get table names dynamically, will tenant_id in such tables renamed to project_id too?","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"449dace9c7fbcf0155eb511e8e91ead0afacbd25","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def upgrade():"},{"line_number":59,"context_line":"    for table in TABLES:"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_777602a5","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":27},"in_reply_to":"3aaa91ec_ac3cb493","updated":"2016-06-30 13:17:26.000000000","message":"Thank you, will look into this.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a5421b711035a6f36b5a3dde790f40e5aa2093b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cc3780ae","line":64,"range":{"start_line":64,"start_character":28,"end_line":64,"end_character":33},"updated":"2016-06-30 07:54:51.000000000","message":"use existing_type here and existing_nullable","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"44a6434f3e5bca2162572ed323550dfd970e25be","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_dee6eaae","line":64,"range":{"start_line":64,"start_character":28,"end_line":64,"end_character":33},"in_reply_to":"3aaa91ec_9759eeff","updated":"2016-06-30 15:23:54.000000000","message":"MySQL\u0027s ALTER for columns usually needs to re-state the entire column definition, so the \"existing_type\" and \"existing_nullable\" makes sure it has that.  \"type_\" here means, \"change the type\" which I don\u0027t think is what you want.\n\nhttp://alembic.zzzcomputing.com/en/latest/ops.html?highlight\u003dexisting_type#alembic.operations.Operations.alter_column.params.existing_type","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"449dace9c7fbcf0155eb511e8e91ead0afacbd25","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9759eeff","line":64,"range":{"start_line":64,"start_character":28,"end_line":64,"end_character":33},"in_reply_to":"3aaa91ec_cc3780ae","updated":"2016-06-30 13:17:26.000000000","message":"You mean, get info from processed table and reassign type and nullable? Or is there some kind of fancy sqlalchemy feature?","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"05d1918eab142db9076499e9201e848bd6523b18","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            op.alter_column(table,"},{"line_number":62,"context_line":"                            column_name\u003d\u0027tenant_id\u0027,"},{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b515f040","line":64,"range":{"start_line":64,"start_character":28,"end_line":64,"end_character":33},"in_reply_to":"3aaa91ec_dee6eaae","updated":"2016-06-30 18:45:11.000000000","message":"Thanks Michael. When I was doing migration, sqla was complaining about missing type_. Didn\u0027t think about existing_* Will do this.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a5421b711035a6f36b5a3dde790f40e5aa2093b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_4cc5508c","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"updated":"2016-06-30 07:54:51.000000000","message":"we need to figure out why this is happening, as in postgres database we have this table http://paste.openstack.org/show/524196/","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2bdc45b3b9bab7b0e7ded04488e5bef4a52f882f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_9ba2fb97","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_843aca96","updated":"2016-07-05 22:20:22.000000000","message":"I fear this is happening because trunks is the only migration in the expand branch that introduces models that rely on tenant_id. Since this is not released functionality I think it\u0027s safe to replace inline (i.e. in the migration script) and avoid catching the programmatic error. See [1] for details. Just a hunch so far.\n\n[1] https://review.openstack.org/#/c/337906/","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf09068188176a9260b555796dc017c09ab39618","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e1bf12a8","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_9ba2fb97","updated":"2016-07-05 23:25:45.000000000","message":"we went past the failure induced by the trunk migration, but there\u0027s more.\n\n[1] http://logs.openstack.org/06/337906/2/check/gate-neutron-dsvm-functional/b83beb6/testr_results.html.gz","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8088c1b23e637f3fb1b9c2260f539f7af0e6733c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f49ccac1","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_bc399bf4","updated":"2016-07-06 14:28:34.000000000","message":"Yay! :)","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c325ef950c25877f8b9f7797e94732f010dcd407","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_bc399bf4","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_e10b8028","updated":"2016-07-06 09:43:54.000000000","message":"Oh, I almost forgot, we have depends_on option, we just need to add depends_on\u003d(5abc0278ca73,) and we won\u0027t have this error :)","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8a8c51db65ed97c8054b2376234f48918cad10c4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e10b8028","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_e1bf12a8","updated":"2016-07-06 09:25:03.000000000","message":"The other failures will be gone when indexes will be renamed as well and used the right nullable.\nI guess we don\u0027t have many other options, as the only other way, is to have a separate expand migration that will rename column in trunks.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5249603a3ae244338247cfa7c70c7b8f0f30d17","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_658c4a80","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"1aa78d24_f49ccac1","updated":"2016-07-08 02:09:29.000000000","message":"Done","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"449dace9c7fbcf0155eb511e8e91ead0afacbd25","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_77bc42dc","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"3aaa91ec_4cc5508c","updated":"2016-06-30 13:17:26.000000000","message":"It\u0027s strange also to me. Maybe something happens with fullstack tests. I\u0027ll try to investigate this further.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6484ae3a0205024604004d6284a2e59457a41512","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_97e8ceb4","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"3aaa91ec_77bc42dc","updated":"2016-06-30 13:20:14.000000000","message":"I see this is happening also on gate: http://logs.openstack.org/86/335786/3/check/gate-neutron-dsvm-api/b0516d7/logs/devstacklog.txt.gz#_2016-06-30_05_08_27_550","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28007b936b0a9e5b1b6f933834b81c207845bc58","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                            new_column_name\u003d\u0027project_id\u0027,"},{"line_number":64,"context_line":"                            type_\u003dsa.String(attr.TENANT_ID_MAX_LEN))"},{"line_number":65,"context_line":"        except sa.exc.ProgrammingError as exc:"},{"line_number":66,"context_line":"            # NOTE(dasm): dsvm-fullstack is complaining about missing \"trunks\""},{"line_number":67,"context_line":"            # table."},{"line_number":68,"context_line":"            print(exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_843aca96","line":68,"range":{"start_line":66,"start_character":12,"end_line":68,"end_character":22},"in_reply_to":"3aaa91ec_97e8ceb4","updated":"2016-07-05 13:17:16.000000000","message":"Is this exception clause temporary?\nIn general, it is better not to catch an error.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"56b32ca91b83aea6b0a23f2db3b05dd752b9d851","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_tables():"},{"line_number":43,"context_line":"    metadata \u003d head.get_metadata()"},{"line_number":44,"context_line":"    all_tables \u003d metadata.sorted_tables"},{"line_number":45,"context_line":"    tenant_tables \u003d []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    for table in all_tables:"},{"line_number":48,"context_line":"        for column in table.columns:"},{"line_number":49,"context_line":"            if column.name \u003d\u003d \u0027tenant_id\u0027:"},{"line_number":50,"context_line":"                tenant_tables.append(table)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    return tenant_tables"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def alter_column(table):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_a8e442ac","line":52,"range":{"start_line":43,"start_character":4,"end_line":52,"end_character":24},"updated":"2016-07-08 03:39:00.000000000","message":"We don\u0027t want to do this dynamically because head changes over time. Do it now manually and hard-code the list for this alembic script so it is frozen in time.","commit_id":"e72cab3da265602816d1bf6c1a57b59b3f7cc0d8"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"4b51154832ebca85f79ef677ef9c5b6abb2a93de","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_tables():"},{"line_number":43,"context_line":"    metadata \u003d head.get_metadata()"},{"line_number":44,"context_line":"    all_tables \u003d metadata.sorted_tables"},{"line_number":45,"context_line":"    tenant_tables \u003d []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    for table in all_tables:"},{"line_number":48,"context_line":"        for column in table.columns:"},{"line_number":49,"context_line":"            if column.name \u003d\u003d \u0027tenant_id\u0027:"},{"line_number":50,"context_line":"                tenant_tables.append(table)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    return tenant_tables"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def alter_column(table):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_5e259408","line":52,"range":{"start_line":43,"start_character":4,"end_line":52,"end_character":24},"in_reply_to":"1aa78d24_a8e442ac","updated":"2016-07-08 05:06:03.000000000","message":"Done","commit_id":"e72cab3da265602816d1bf6c1a57b59b3f7cc0d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a9919cad01100a4aec76a4ea09d6fa9a711c3729","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"rename tenant to project"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 7d9d8eeec6ad"},{"line_number":19,"context_line":"Revises: 4bcd4df1f426"},{"line_number":20,"context_line":"Create Date: 2016-06-29 19:42:17.862721"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_1238ea3c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":21},"updated":"2016-07-09 03:48:07.000000000","message":"Word of advice: delete this line. It is a comment duplicate of line 26 and it becomes an annoyance to remember to update when you need to rebase on other migrations.","commit_id":"6e5da697ed8b099646fba3621531367fdd35e8f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0e905641f0e127ff90dd46335c4e4053a7cba22b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"rename tenant to project"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 7d9d8eeec6ad"},{"line_number":19,"context_line":"Revises: 4bcd4df1f426"},{"line_number":20,"context_line":"Create Date: 2016-06-29 19:42:17.862721"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_aac2ff82","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":21},"in_reply_to":"1aa78d24_1238ea3c","updated":"2016-07-12 19:51:34.000000000","message":"Done","commit_id":"6e5da697ed8b099646fba3621531367fdd35e8f9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a9919cad01100a4aec76a4ea09d6fa9a711c3729","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa78d24_1d12bb09","line":151,"updated":"2016-07-09 03:48:07.000000000","message":"Add the following function here to allow contract branch creation exceptions:\n\n\ndef contract_creation_exceptions():\n    \"\"\"Special migration for the blueprint to support Keystone V3.\n\n    We drop all tenant_id columns and create project_id columns instead.\n    \"\"\"\n    return {\n        sa.Column: [\u0027.\u0027.join([table, \u0027project_id\u0027]) for table in get_tables()],\n        sa.Index: get_tables()\n    }","commit_id":"6e5da697ed8b099646fba3621531367fdd35e8f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0e905641f0e127ff90dd46335c4e4053a7cba22b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa78d24_e8920f56","line":151,"in_reply_to":"1aa78d24_1d12bb09","updated":"2016-07-12 19:51:34.000000000","message":"Done","commit_id":"6e5da697ed8b099646fba3621531367fdd35e8f9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d41faaefec12986690be865f587e94e27b83caf3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"def recreate_pk(table_name):"},{"line_number":150,"context_line":"    # I hope this will work, but if not, look:"},{"line_number":151,"context_line":"    # https://stackoverflow.com/questions/13756567/adding-primary-key-to-existing-mysql-table-in-alembic/13757758#13757758"},{"line_number":152,"context_line":"    constraint_name \u003d \u0027pk_{}\u0027.format(table_name)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    op.drop_constraint(constraint_name, table_name, type_\u003d\u0027primary\u0027)"},{"line_number":155,"context_line":"    op.create_primary_key(constraint_name, table_name, [\u0027project_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_4e39a1a3","line":152,"updated":"2016-07-13 01:35:18.000000000","message":"For postgresql they seem to be named \u0027{}_pkey\u0027. But let\u0027s stick with the latest patch set for now.","commit_id":"610434c740afdfcaae32242a62e05b02f862621e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fbafccfa6d5607fed842a5303fb8795b9d40622f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"def recreate_pk(table_name):"},{"line_number":150,"context_line":"    # I hope this will work, but if not, look:"},{"line_number":151,"context_line":"    # https://stackoverflow.com/questions/13756567/adding-primary-key-to-existing-mysql-table-in-alembic/13757758#13757758"},{"line_number":152,"context_line":"    constraint_name \u003d \u0027pk_{}\u0027.format(table_name)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    op.drop_constraint(constraint_name, table_name, type_\u003d\u0027primary\u0027)"},{"line_number":155,"context_line":"    op.create_primary_key(constraint_name, table_name, [\u0027project_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_392d7dfe","line":152,"in_reply_to":"1aa78d24_4e39a1a3","updated":"2016-07-13 02:22:44.000000000","message":"I verified for mysql, that when altering column name, primary key is kept. No additional change is required. Although didn\u0027t verify for postgres.","commit_id":"610434c740afdfcaae32242a62e05b02f862621e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c5ac1331fe37617079b2e39333f022ebf2321c7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_INSPECTOR \u003d None"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_5908e0d9","line":30,"updated":"2016-07-14 18:13:19.000000000","message":"Please add here:\n\n  from sqlalchemy.engine import reflection","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ec046288f18c4ae50e427155a14c86b833732e61","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_INSPECTOR \u003d None"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_afdb764e","line":30,"in_reply_to":"1aa78d24_5908e0d9","updated":"2016-07-14 18:32:11.000000000","message":"Done","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c5ac1331fe37617079b2e39333f022ebf2321c7","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    else:"},{"line_number":44,"context_line":"        bind \u003d op.get_bind()"},{"line_number":45,"context_line":"        _INSPECTOR \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return _INSPECTOR"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_19ff78ab","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":41},"updated":"2016-07-14 18:13:19.000000000","message":"Use imported reflection module (see line 30).","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ec046288f18c4ae50e427155a14c86b833732e61","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    else:"},{"line_number":44,"context_line":"        bind \u003d op.get_bind()"},{"line_number":45,"context_line":"        _INSPECTOR \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return _INSPECTOR"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_efe57e0a","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":41},"in_reply_to":"1aa78d24_19ff78ab","updated":"2016-07-14 18:32:11.000000000","message":"Done","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c5ac1331fe37617079b2e39333f022ebf2321c7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    Returns hardcoded list of tables which have ``tenant_id`` column."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    DB head can be changed. To prevent possible problems, when models will be"},{"line_number":55,"context_line":"    updated, return hardcoded list of tables, up-to-date for this day."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    Output retrieved by using:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_b9b2a404","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":70},"updated":"2016-07-14 18:13:19.000000000","message":"Nit: rather than mentioning head, may I suggest:\n\n\"The list is hard-coded to match the state of the schema when this upgrade script is run.\"","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ec046288f18c4ae50e427155a14c86b833732e61","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    Returns hardcoded list of tables which have ``tenant_id`` column."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    DB head can be changed. To prevent possible problems, when models will be"},{"line_number":55,"context_line":"    updated, return hardcoded list of tables, up-to-date for this day."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    Output retrieved by using:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_cfe24201","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":70},"in_reply_to":"1aa78d24_b9b2a404","updated":"2016-07-14 18:32:11.000000000","message":"Done","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c5ac1331fe37617079b2e39333f022ebf2321c7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"def get_data():"},{"line_number":102,"context_line":"    \"\"\"Returns combined list of tuples: [(table, column)]."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    List is built, based on retrieved tables, where column with name"},{"line_number":105,"context_line":"    ``tenant_id`` exists."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    output \u003d []"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_b9ae247f","line":105,"range":{"start_line":104,"start_character":4,"end_line":105,"end_character":25},"updated":"2016-07-14 18:13:19.000000000","message":"Grammar nit:\n\"The list is built from tables with a tenant_id column.\"","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ec046288f18c4ae50e427155a14c86b833732e61","unresolved":false,"context_lines":[{"line_number":101,"context_line":"def get_data():"},{"line_number":102,"context_line":"    \"\"\"Returns combined list of tuples: [(table, column)]."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    List is built, based on retrieved tables, where column with name"},{"line_number":105,"context_line":"    ``tenant_id`` exists."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    output \u003d []"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_6f9fce65","line":105,"range":{"start_line":104,"start_character":4,"end_line":105,"end_character":25},"in_reply_to":"1aa78d24_b9ae247f","updated":"2016-07-14 18:32:11.000000000","message":"Done","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"}],"neutron/db/model_base.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"10bc5b9569e3d81f611d1169ace250400048aee7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class HasProject(object):"},{"line_number":28,"context_line":"    \"\"\"Project mixin, add to subclasses that have a user.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # NOTE(jkoelker) project_id is just a free form string ;("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_def1ca02","line":27,"updated":"2016-06-30 15:13:29.000000000","message":"can you also add: \n\nclass HasTenant(HasProject):\n   pass\n\nJust to allow people to migrate to this new class name?","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"eddf5cede490444992b882f531e83da5af653b92","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class HasProject(object):"},{"line_number":28,"context_line":"    \"\"\"Project mixin, add to subclasses that have a user.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # NOTE(jkoelker) project_id is just a free form string ;("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9b3c5bc9","line":27,"in_reply_to":"3aaa91ec_174841cb","updated":"2016-07-01 00:22:24.000000000","message":"No problem. I couldn\u0027t put it above HasProject, because it wouldn\u0027t work. And below HasProject class could be easily unnoticed.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"265614351262a987ca5139e043ac138466cb2316","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class HasProject(object):"},{"line_number":28,"context_line":"    \"\"\"Project mixin, add to subclasses that have a user.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # NOTE(jkoelker) project_id is just a free form string ;("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_174841cb","line":27,"in_reply_to":"3aaa91ec_da7a6bb9","updated":"2016-06-30 22:42:19.000000000","message":"ah i see. thanks","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"05d1918eab142db9076499e9201e848bd6523b18","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class HasProject(object):"},{"line_number":28,"context_line":"    \"\"\"Project mixin, add to subclasses that have a user.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # NOTE(jkoelker) project_id is just a free form string ;("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_da7a6bb9","line":27,"in_reply_to":"3aaa91ec_def1ca02","updated":"2016-06-30 18:45:11.000000000","message":"Aaron, it is done in line 51 by introducing deprecated method.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"87cc74979cf6ae18c81e04cf365807eca700338a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            descriptor\u003dproperty(cls.get_tenant_id, cls.set_tenant_id))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"HasTenant \u003d debtcollector.moves.moved_class(HasProject, \"HasTenant\", __name__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class HasProjectNoIndex(HasProject):"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_35643be4","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":78},"updated":"2016-07-22 09:41:10.000000000","message":"Should this not be deprecated before it\u0027s removed?","commit_id":"30582abbdfae91399509936fea139aada126350f"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d534667f0a8de4b2268478840c327bf52f9c130b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            descriptor\u003dproperty(cls.get_tenant_id, cls.set_tenant_id))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"HasTenant \u003d debtcollector.moves.moved_class(HasProject, \"HasTenant\", __name__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class HasProjectNoIndex(HasProject):"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_1647214c","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":78},"in_reply_to":"dada55a8_35643be4","updated":"2016-07-25 16:38:51.000000000","message":"It\u0027s technically not removal, but renaming. Class is just renamed, so debtcollector will inform, every time when someone will import HasTenant, that this is deprecated.","commit_id":"30582abbdfae91399509936fea139aada126350f"}],"neutron/db/models_v2.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c18cbf6c2bb8b0cd1a1621defb4f9655c6474d1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":"from sqlalchemy import orm"},{"line_number":18,"context_line":"from sqlalchemy import sql"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import debtcollector"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.api.v2 import attributes as attr"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1df7f8d3","line":19,"updated":"2016-06-30 04:39:49.000000000","message":"no need for the new line here debtcollector is 3rd party","commit_id":"a73ea929f8f9fe946d52b054e3daf0f9b7e5047a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c18cbf6c2bb8b0cd1a1621defb4f9655c6474d1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# expectations and meet reality."},{"line_number":33,"context_line":"HasTenant \u003d debtcollector.moves.moved_class("},{"line_number":34,"context_line":"    model_base.HasProject, \"HasTenant\", __name__)"},{"line_number":35,"context_line":"HasId \u003d debtcollector.moves.moved_class("},{"line_number":36,"context_line":"    model_base.HasId, \"HasId\", __name__)"},{"line_number":37,"context_line":"HasStatusDescription \u003d debtcollector.moves.moved_class("},{"line_number":38,"context_line":"    model_base.HasStatusDescription, \"HasStatusDescription\", __name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fd0b0cd3","line":35,"updated":"2016-06-30 04:39:49.000000000","message":"please see comment below","commit_id":"a73ea929f8f9fe946d52b054e3daf0f9b7e5047a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c18cbf6c2bb8b0cd1a1621defb4f9655c6474d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        return \"%s - %s\" % (self.first_ip, self.last_ip)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"class IPAllocationPool(model_base.BASEV2, model_base.HasId):"},{"line_number":76,"context_line":"    \"\"\"Representation of an allocation pool in a Neutron subnet.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027subnets.id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5d66a0bb","line":75,"updated":"2016-06-30 04:39:49.000000000","message":"sorry for the nitpicking but the HasId change can be done in a separate patch","commit_id":"a73ea929f8f9fe946d52b054e3daf0f9b7e5047a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"64208943faf8a0d5a4787a84b46981a475639f0f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        return \"%s - %s\" % (self.first_ip, self.last_ip)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"class IPAllocationPool(model_base.BASEV2, model_base.HasId):"},{"line_number":76,"context_line":"    \"\"\"Representation of an allocation pool in a Neutron subnet.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027subnets.id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fd95cc31","line":75,"in_reply_to":"3aaa91ec_5d66a0bb","updated":"2016-06-30 04:50:30.000000000","message":"Done. Removed, will create separate review.","commit_id":"a73ea929f8f9fe946d52b054e3daf0f9b7e5047a"}],"neutron/tests/unit/quota/__init__.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"eb4766afa29b5bae7d90e88a7ad1866cd3dd87e3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Model classes for test resources"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class MehModel(model_base.BASEV2, model_base.HasProject):"},{"line_number":23,"context_line":"    meh \u003d sa.Column(sa.String(8), primary_key\u003dTrue)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_30cc65ba","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":14},"updated":"2016-07-21 20:01:53.000000000","message":"meh","commit_id":"30582abbdfae91399509936fea139aada126350f"}],"releasenotes/notes/rename-tenant-to-project-b19a4068f8625969.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28007b936b0a9e5b1b6f933834b81c207845bc58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - This change is required to be applied as offline migration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_8abda76a","line":3,"updated":"2016-07-05 13:17:16.000000000","message":"When reading the release note, all contents are displayed in one HTML file, so readers cannot understand what is \"This change\". Could you describe more specifically? For example,\n\n  tenant_id column has been renamed to project_id.\n  This database migration is required to be applied as offline migration.","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5249603a3ae244338247cfa7c70c7b8f0f30d17","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - This change is required to be applied as offline migration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_4ac3168b","line":3,"in_reply_to":"1aa78d24_8abda76a","updated":"2016-07-08 02:09:29.000000000","message":"Done","commit_id":"29a0f3a96d57ea2bac8a0bee6f746d65101a3c83"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c5ac1331fe37617079b2e39333f022ebf2321c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    tenant_id column has been renamed to project_id."},{"line_number":5,"context_line":"    This database migration is required to be applied as offline migration."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1aa78d24_749963d0","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":75},"updated":"2016-07-14 18:13:19.000000000","message":"\"All ``tenant_id`` columns in the database have been renamed to ``project_id``. The database migration for this must be applied offline (with the neutron service stopped).\"","commit_id":"bc29bbb02c860ceed640e683607dcf8ca1afd881"}]}
