)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9f7636fb8a255895e51a485ff803d75abb39e231","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Deprecation Warning to models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Models HasTenant, HasId and HasStatusDescription"},{"line_number":10,"context_line":"were moved outside of models_v2. Added info about"},{"line_number":11,"context_line":"deprecation to allow all projects to alter their"},{"line_number":12,"context_line":"code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_f2a52a47","line":9,"updated":"2016-08-04 09:18:18.000000000","message":"those are not models, those are mixins with attributes.","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9842343250fb19b18be41a592fc3691e28caed80","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Deprecation Warning to models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Models HasTenant, HasId and HasStatusDescription"},{"line_number":10,"context_line":"were moved outside of models_v2. Added info about"},{"line_number":11,"context_line":"deprecation to allow all projects to alter their"},{"line_number":12,"context_line":"code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_75138865","line":9,"in_reply_to":"bacf61ea_f2a52a47","updated":"2016-08-05 19:37:04.000000000","message":"Done","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"}],"neutron/db/models_v2.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"28fad468b28afa1a37a145bd212d1749eb346806","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(dasm): Added debtcollector to force external projects to change their"},{"line_number":31,"context_line":"# expectations and meet reality."},{"line_number":32,"context_line":"HasTenant \u003d debtcollector.moves.moved_class("},{"line_number":33,"context_line":"    model_base.HasProject, \"HasTenant\", __name__)"},{"line_number":34,"context_line":"HasId \u003d debtcollector.moves.moved_class("},{"line_number":35,"context_line":"    model_base.HasId, \"HasId\", __name__)"},{"line_number":36,"context_line":"HasStatusDescription \u003d debtcollector.moves.moved_class("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fb6f94c1","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":25},"updated":"2016-06-30 06:10:46.000000000","message":"why is this being changed to Project here?","commit_id":"ad61639adc0c8a8c63ac0b7eba365961bc557287"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3c2cdae3585d8d3f57d7b80eec5e3cb2813520ba","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(dasm): Added debtcollector to force external projects to change their"},{"line_number":31,"context_line":"# expectations and meet reality."},{"line_number":32,"context_line":"HasTenant \u003d debtcollector.moves.moved_class("},{"line_number":33,"context_line":"    model_base.HasProject, \"HasTenant\", __name__)"},{"line_number":34,"context_line":"HasId \u003d debtcollector.moves.moved_class("},{"line_number":35,"context_line":"    model_base.HasId, \"HasId\", __name__)"},{"line_number":36,"context_line":"HasStatusDescription \u003d debtcollector.moves.moved_class("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b410685a","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":25},"in_reply_to":"3aaa91ec_fb6f94c1","updated":"2016-06-30 13:11:30.000000000","message":"This is part of keystone-v3 bp. garyk suggested to split-out these changes from initial review: I87a8ef342ccea004731ba0192b23a8e79bc382dc to not mix deprecations on models_v2 and deprecations of HasTenant there.","commit_id":"ad61639adc0c8a8c63ac0b7eba365961bc557287"}],"releasenotes/notes/deprecate-modelsv2-classes-c34ebdb9d54248f4.yaml":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4ff9ca1ad42156d727075d34579bafce5a7a1dfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Classes HasTenant, HasId, HasStatusDescription no longer exist in"},{"line_number":4,"context_line":"    models_v2. They were moved to model_base. Added information about"},{"line_number":5,"context_line":"    deprecation."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_e988c024","line":2,"updated":"2016-07-28 21:55:19.000000000","message":"Do we really need to release with the content like this? This seems specific knowledge of interest for Neutron developers. I would imagine that release notes are pertinent to operators and users, and I\u0027d rather phrase this by saying that the Neutron DB schema has been updated to adopt the project_id attribute rather than the tenant_id one. We could add that the codebase can still potentially handle mixed schemas, but third-party Neutron developers are invited to validate their own DB models.","commit_id":"ad61639adc0c8a8c63ac0b7eba365961bc557287"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8369b302d246d4364cdfde080390ff17ab633fea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Classes HasTenant, HasId, HasStatusDescription no longer exist in"},{"line_number":4,"context_line":"    models_v2. They were moved to model_base. Added information about"},{"line_number":5,"context_line":"    deprecation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_493bcc38","line":2,"updated":"2016-07-28 21:55:37.000000000","message":"Do we really need to release with the content like this? This seems specific knowledge of interest for Neutron developers. I would imagine that release notes are pertinent to operators and users, and I\u0027d rather phrase this by saying that the Neutron DB schema has been updated to adopt the project_id attribute rather than the tenant_id one. We could add that the codebase can still potentially handle mixed schemas, but third-party Neutron developers are invited to validate their own DB models.","commit_id":"989575bd3cd8b34c04542371acdb1a40f85df874"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"764a0800adbe7ac356fedf4588e1727b0d33c1de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Classes HasTenant, HasId, HasStatusDescription no longer exist in"},{"line_number":4,"context_line":"    models_v2. They were moved to model_base. Added information about"},{"line_number":5,"context_line":"    deprecation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_739b1573","line":2,"in_reply_to":"bacf61ea_493bcc38","updated":"2016-07-29 01:06:33.000000000","message":"Agreed, we don\u0027t need a release note for the change in this patch.","commit_id":"989575bd3cd8b34c04542371acdb1a40f85df874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"33765bb3f894e7ce7df171dd35943b86ac2b1fa6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Classes HasTenant, HasId, HasStatusDescription no longer exist in"},{"line_number":4,"context_line":"    models_v2. They were moved to model_base. Added information about"},{"line_number":5,"context_line":"    deprecation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_932169fe","line":2,"in_reply_to":"bacf61ea_739b1573","updated":"2016-07-29 01:13:18.000000000","message":"I mean, we can keep it if we can phrase it properly.","commit_id":"989575bd3cd8b34c04542371acdb1a40f85df874"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e42140310294ff4e07cd3b1d618878b569f336d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Classes HasTenant, HasId, HasStatusDescription no longer exist in"},{"line_number":4,"context_line":"    models_v2. They were moved to model_base. Added information about"},{"line_number":5,"context_line":"    deprecation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_0f226d52","line":2,"in_reply_to":"bacf61ea_932169fe","updated":"2016-07-29 02:43:33.000000000","message":"Done. Armando, I used your words. I hope it is good description of changes.","commit_id":"989575bd3cd8b34c04542371acdb1a40f85df874"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5e0f1944c3fe15a29a77f2bd8cd73679ace22018","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Neutron DB schema has been updated to adopt the project_id attribute rather"},{"line_number":4,"context_line":"    than the tenant_id one. The codebase can still handle mixed schemas, but"},{"line_number":5,"context_line":"    third-party Neutron developers are invited to validate their own DB models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_796d9a03","line":3,"updated":"2016-08-04 11:43:53.000000000","message":"+1. Unlike the DB column rename (which I was already on the edge about the release note being created for), this is completely invisible to operators...","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9f7636fb8a255895e51a485ff803d75abb39e231","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Neutron DB schema has been updated to adopt the project_id attribute rather"},{"line_number":4,"context_line":"    than the tenant_id one. The codebase can still handle mixed schemas, but"},{"line_number":5,"context_line":"    third-party Neutron developers are invited to validate their own DB models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_12943ee0","line":3,"updated":"2016-08-04 09:18:18.000000000","message":"I always thought that release notes are targeting end users. Why should they care?","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9842343250fb19b18be41a592fc3691e28caed80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Neutron DB schema has been updated to adopt the project_id attribute rather"},{"line_number":4,"context_line":"    than the tenant_id one. The codebase can still handle mixed schemas, but"},{"line_number":5,"context_line":"    third-party Neutron developers are invited to validate their own DB models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_f5ff78ff","line":3,"in_reply_to":"bacf61ea_498ef62e","updated":"2016-08-05 19:37:04.000000000","message":"Done","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9ba5cf5e8e1c9d4ad75d40b4ff820ff635c1b948","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Neutron DB schema has been updated to adopt the project_id attribute rather"},{"line_number":4,"context_line":"    than the tenant_id one. The codebase can still handle mixed schemas, but"},{"line_number":5,"context_line":"    third-party Neutron developers are invited to validate their own DB models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_498ef62e","line":3,"in_reply_to":"bacf61ea_4e539c17","updated":"2016-08-04 16:31:26.000000000","message":"For people browsing the DB we already have a release note.\nhttps://github.com/openstack/neutron/blob/master/releasenotes/notes/rename-tenant-to-project-b19a4068f8625969.yaml","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"54c30e48fb7b99cbc8a61a298cf972de9a3be078","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Neutron DB schema has been updated to adopt the project_id attribute rather"},{"line_number":4,"context_line":"    than the tenant_id one. The codebase can still handle mixed schemas, but"},{"line_number":5,"context_line":"    third-party Neutron developers are invited to validate their own DB models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_4e539c17","line":3,"in_reply_to":"bacf61ea_796d9a03","updated":"2016-08-04 16:07:14.000000000","message":"I had the same comment on PS1 and I was on the fence. Operators may end up signing in on the DB and browse the DB tables so I thought there was some value in advertising this. So rephrase once more?\n\nhttps://review.openstack.org/#/c/335792/1..6/releasenotes/notes/deprecate-modelsv2-classes-c34ebdb9d54248f4.yaml","commit_id":"4688259086843a5f28e0759aafc83e321e29ebaf"}]}
