)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"27a50c77aa7eaf8012ab358a0f7f4012b0400309","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add set_status helper in PortContext"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to create a helper method for PortContext"},{"line_number":10,"context_line":"to set the status of its port to abnormal status."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Closes-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_4f71a60b","line":10,"updated":"2016-06-30 16:16:00.000000000","message":"this commit message is stale","commit_id":"44b1c2658337090b7ee092c4e9f0b347d436e94b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5bc49e063336cd70912b79ff924f613aa835318a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add setter to status in PortContext"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to create a helper method for PortContext"},{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Closes-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_80c1a3e6","line":10,"updated":"2016-07-27 08:56:39.000000000","message":"can you document in which context this is supposed to be used?\neg. in which MD methods?\neg. in which MD, in case multiple MDs are involved?","commit_id":"1f70d92a425985aae30550c495d28cf311727059"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1dae222e0af0655325fff71bcb3891a6c23fe84a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When a mechanism driver cooperates with another backend,"},{"line_number":13,"context_line":"we may want to change the status of the port to indicate"},{"line_number":14,"context_line":"a failure."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":17,"context_line":"Closes-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba5da102_e5168ff0","line":14,"updated":"2016-11-04 18:30:39.000000000","message":"If you can, it would be nice to provide an example of this in use, because even if a MD can set the status of a port context, that doesn\u0027t necessarily mean it gets persisted in the datastore.","commit_id":"804e1a81ecd8f2da65ed1f44a0d6cb4289a725db"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"4bfded8e912f9fd63bf96d614a39ad2844402363","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When a mechanism driver cooperates with another backend,"},{"line_number":13,"context_line":"we may want to change the status of the port to indicate"},{"line_number":14,"context_line":"a failure."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":17,"context_line":"Closes-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba5da102_f62483b3","line":14,"in_reply_to":"ba5da102_e5168ff0","updated":"2016-11-04 20:28:04.000000000","message":"I wish I could, I think we would want to use the precommit and postcommit for the resource the driver is attached to with something similar to what rkukura proposed in the bug comments:\n\n \"...There had been some discussion at a mid-cycle of how to do this in a way that rolls up multiple MDs\u0027 individual statuses into the resource\u0027s overall status. Simply letting any MD set the resource\u0027s status is probably not sufficient with multiple drivers, as with HPB or heterogeneous deployments. A proposal handling this would be welcome.\"\n\nBut I think this is a necessary step to achieve the quoted comment. I will change it to partial bug since it doesn\u0027t fully meet the requirements of tying it to a backend.","commit_id":"804e1a81ecd8f2da65ed1f44a0d6cb4289a725db"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"705b24e2b7e4ef4d0e0c0d27b3e8a60de10c8bfa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to create a helper method for PortContext"},{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Partial-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a6eadb0_86ab1889","line":11,"updated":"2016-12-13 08:59:11.000000000","message":"Why do we need this fix? The reason should be in CommitMessage.","commit_id":"662836e03e673416cb5c9545819e38731c846346"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6ac065efb277dab707ec09be8af1d249006e1c70","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to create a helper method for PortContext"},{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Partial-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a6eadb0_0e4b48b1","line":11,"in_reply_to":"1a6eadb0_86ab1889","updated":"2016-12-14 17:44:46.000000000","message":"Done","commit_id":"662836e03e673416cb5c9545819e38731c846346"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"705b24e2b7e4ef4d0e0c0d27b3e8a60de10c8bfa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Partial-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a6eadb0_66bfdcd0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"updated":"2016-12-13 08:59:11.000000000","message":"How does the Bug close if this fix doesn\u0027t finish up the issue?","commit_id":"662836e03e673416cb5c9545819e38731c846346"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6ac065efb277dab707ec09be8af1d249006e1c70","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":13,"context_line":"Partial-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a6eadb0_aedc14e5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"1a6eadb0_66bfdcd0","updated":"2016-12-14 17:44:46.000000000","message":"Done","commit_id":"662836e03e673416cb5c9545819e38731c846346"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"76ceaad79c61e7e86d33be456eeba6e51616df48","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set the status of its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I should be able to set _new_port_status attribute to trigger"},{"line_number":13,"context_line":"the call in ml2/plugin[1]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ml2/plugin.py#n517"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"fa31d9ce_0d8e4e27","line":13,"updated":"2017-02-17 01:09:40.000000000","message":"i\u0027m not sure what you mean here.\n\n_new_port_status doesn\u0027t seem to be used when the port is already bound.","commit_id":"25bf40f4d4bcbda0d301ad0350774d85bbbb0398"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"76ceaad79c61e7e86d33be456eeba6e51616df48","unresolved":false,"context_lines":[{"line_number":12,"context_line":"I should be able to set _new_port_status attribute to trigger"},{"line_number":13,"context_line":"the call in ml2/plugin[1]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ml2/plugin.py#n517"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I16cf661e30d8ef2c33f033bc4f9910d9ff90e46c"},{"line_number":18,"context_line":"Closes-Bug: #1587401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"fa31d9ce_ad1c6214","line":15,"updated":"2017-02-17 01:09:40.000000000","message":"it seems the line number in the link is already stale.\nplease consider to use a version-dependent link.","commit_id":"25bf40f4d4bcbda0d301ad0350774d85bbbb0398"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"dbc7f076cb3c4262c5dc4d2351427db5b8558209","unresolved":false,"context_lines":[{"line_number":56,"context_line":"PENDING_UPDATE \u003d \"PENDING_UPDATE\""},{"line_number":57,"context_line":"PENDING_DELETE \u003d \"PENDING_DELETE\""},{"line_number":58,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":59,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":60,"context_line":"NOTAPPLICABLE \u003d \"N/A\""},{"line_number":61,"context_line":"BUILD \u003d \"BUILD\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_812be232","line":59,"updated":"2016-08-31 16:35:46.000000000","message":"seems like all the constants in this file are now available in neutron lib","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bcc39d3fbdb99bc0d575b91a4e58735a3c0fcd9b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"PENDING_UPDATE \u003d \"PENDING_UPDATE\""},{"line_number":57,"context_line":"PENDING_DELETE \u003d \"PENDING_DELETE\""},{"line_number":58,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":59,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":60,"context_line":"NOTAPPLICABLE \u003d \"N/A\""},{"line_number":61,"context_line":"BUILD \u003d \"BUILD\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_0d55bdc4","line":59,"in_reply_to":"fa7ab95a_812be232","updated":"2016-09-07 21:19:39.000000000","message":"I used the PORT_STATUS_* constants for neutron lib.","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"dbc7f076cb3c4262c5dc4d2351427db5b8558209","unresolved":false,"context_lines":[{"line_number":58,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":59,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":60,"context_line":"NOTAPPLICABLE \u003d \"N/A\""},{"line_number":61,"context_line":"BUILD \u003d \"BUILD\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"ACTIVE_PENDING_STATUSES \u003d ("},{"line_number":64,"context_line":"    ACTIVE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c1afaa7b","line":61,"updated":"2016-08-31 16:35:46.000000000","message":"in neutron lib, those 2 have the prefix PORT_STATUS_. Maybe it makes sense to name them like they are named there right now? But I must admit I don\u0027t understand the difference between service operation statuses and port status...","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bcc39d3fbdb99bc0d575b91a4e58735a3c0fcd9b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"INACTIVE \u003d \"INACTIVE\""},{"line_number":59,"context_line":"ERROR \u003d \"ERROR\""},{"line_number":60,"context_line":"NOTAPPLICABLE \u003d \"N/A\""},{"line_number":61,"context_line":"BUILD \u003d \"BUILD\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"ACTIVE_PENDING_STATUSES \u003d ("},{"line_number":64,"context_line":"    ACTIVE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_6d32c9a8","line":61,"in_reply_to":"fa7ab95a_c1afaa7b","updated":"2016-09-07 21:19:39.000000000","message":"I used the PORT_STATUS_* constants for neutron lib.","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"}],"neutron/plugins/ml2/driver_api.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1dae222e0af0655325fff71bcb3891a6c23fe84a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        \"\"\"The status of the current port."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        This property returns the status of the current port and supports"},{"line_number":267,"context_line":"        assignment. Assignment can only be done by a mechanical driver that"},{"line_number":268,"context_line":"        owns the leaf binding of the port."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_253b279e","line":267,"range":{"start_line":267,"start_character":53,"end_line":267,"end_character":63},"updated":"2016-11-04 18:30:39.000000000","message":"mechanism. We still write software, even if that controls physical appliances with moving parts.","commit_id":"804e1a81ecd8f2da65ed1f44a0d6cb4289a725db"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"4bfded8e912f9fd63bf96d614a39ad2844402363","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        \"\"\"The status of the current port."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        This property returns the status of the current port and supports"},{"line_number":267,"context_line":"        assignment. Assignment can only be done by a mechanical driver that"},{"line_number":268,"context_line":"        owns the leaf binding of the port."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_f68d632b","line":267,"range":{"start_line":267,"start_character":53,"end_line":267,"end_character":63},"in_reply_to":"ba5da102_253b279e","updated":"2016-11-04 20:28:04.000000000","message":"Done","commit_id":"804e1a81ecd8f2da65ed1f44a0d6cb4289a725db"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f580c7067887153cacb04e420f0f3c5698dfcbf1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        pass"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @abc.abstractproperty"},{"line_number":263,"context_line":"    def status(self):"},{"line_number":264,"context_line":"        \"\"\"The status of the current port."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        This property returns the status of the current port and supports"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_b99d0968","line":263,"updated":"2016-12-15 15:23:05.000000000","message":"to me status means that it is read only.\nif you want to update then create a new method to update status","commit_id":"28b0012650d648bf1150e1596211527948d94f9b"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e2836f003826d79863abe82376e9c43677deba7c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        pass"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @abc.abstractproperty"},{"line_number":263,"context_line":"    def status(self):"},{"line_number":264,"context_line":"        \"\"\"The status of the current port."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        This property returns the status of the current port and supports"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_bfc6c965","line":263,"in_reply_to":"1a6eadb0_b99d0968","updated":"2016-12-15 16:28:39.000000000","message":"Done","commit_id":"28b0012650d648bf1150e1596211527948d94f9b"}],"neutron/plugins/ml2/driver_context.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ad78c78399d4ac7906a665d5f23f4311ef5e0378","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def set_abnormal_status(self):"},{"line_number":269,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":270,"context_line":"            self._binding.status \u003d \u0027abnormal status\u0027"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            self._port[\u0027status\u0027] \u003d \u0027abnormal status\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_51acab8b","line":270,"updated":"2016-06-30 15:37:29.000000000","message":"These types of changes have been rejected in the past. We can\u0027t simply store whatever we like here, and we can\u0027t even make it plugin dependent. What does abnormal even mean? Might make more sense to provide a set_status method that has a valid input. The possible values for port status are well known constants.","commit_id":"acb6a059e7619d56613c6e6e513639f03044c728"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"27a50c77aa7eaf8012ab358a0f7f4012b0400309","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return self._plugin.type_manager.release_dynamic_segment("},{"line_number":266,"context_line":"                self._plugin_context.session, segment_id)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def set_status(self, status):"},{"line_number":269,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":270,"context_line":"            self._binding.status \u003d status"},{"line_number":271,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8f68aef6","line":268,"updated":"2016-06-30 16:16:00.000000000","message":"there\u0027s currently no user of this user of this method. We should probably err on the side of caution and validate the input on the caller\u0027s behalf. A valid input must be one of the values as defined in [1]. I don\u0027t understand why ERROR would not be adequate.\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/common/constants.py#L50","commit_id":"44b1c2658337090b7ee092c4e9f0b347d436e94b"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"007cc6702eebfc191f0ce881040032bd2791ad50","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return self._binding_levels.pop()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _is_valid_status(self, status):"},{"line_number":127,"context_line":"        valid_statuses \u003d [constants.ACTIVE, constants.DOWN, constants.CREATED,"},{"line_number":128,"context_line":"                          constants.PENDING_CREATE, constants.PENDING_UPDATE,"},{"line_number":129,"context_line":"                          constants.PENDING_DELETE, constants.INACTIVE,"},{"line_number":130,"context_line":"                          constants.ERROR]"},{"line_number":131,"context_line":"        return status in valid_statuses"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # The following implement the abstract methods and properties of"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_62664052","line":130,"range":{"start_line":127,"start_character":25,"end_line":130,"end_character":42},"updated":"2016-07-07 01:21:09.000000000","message":"Please use \u0027set\u0027 instead of \u0027list\u0027 for \u0027in\u0027 lookup.\n\nI would also suggest to move \u0027valid_statuses\u0027 to either class constant or maybe even into the \u0027constants\u0027 module itself. And then you probably would not need this method as it would be easily substituted by \u0027status in self._valid_statuses\u0027.","commit_id":"2a5eaac877bc0eb0d9574d45b43fccc913a44c8d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"01cea7db53b485e7d471db940be127b6e1f6afe4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self._original_vif_details \u003d None"},{"line_number":106,"context_line":"            self._original_binding_levels \u003d None"},{"line_number":107,"context_line":"        self._new_port_status \u003d None"},{"line_number":108,"context_line":"        self._valid_statuses \u003d set([constants.ACTIVE, constants.DOWN,"},{"line_number":109,"context_line":"            constants.CREATED, constants.PENDING_CREATE,"},{"line_number":110,"context_line":"            constants.PENDING_UPDATE, constants.PENDING_DELETE,"},{"line_number":111,"context_line":"            constants.INACTIVE, constants.ERROR])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_bc65b21e","line":108,"updated":"2016-07-07 20:17:09.000000000","message":"what? Why can\u0027t this just be a tuple!","commit_id":"e1dc9289b7bd8092e814b0e63aaffdbc2c328d1a"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"e350e751c4412a88b1f499d4eed0c5d29d11b5ee","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self._original_vif_details \u003d None"},{"line_number":106,"context_line":"            self._original_binding_levels \u003d None"},{"line_number":107,"context_line":"        self._new_port_status \u003d None"},{"line_number":108,"context_line":"        self._valid_statuses \u003d set([constants.ACTIVE, constants.DOWN,"},{"line_number":109,"context_line":"            constants.CREATED, constants.PENDING_CREATE,"},{"line_number":110,"context_line":"            constants.PENDING_UPDATE, constants.PENDING_DELETE,"},{"line_number":111,"context_line":"            constants.INACTIVE, constants.ERROR])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_df018b6c","line":108,"in_reply_to":"1aa78d24_54c0e22a","updated":"2016-07-07 22:43:59.000000000","message":"@Armando, no, it\u0027s 8 constants, don\u0027t you see how that changes everything! :) \n\nSeriously, though, I\u0027m just curious about what do we gain from using \u0027tuple\u0027 over \u0027set\u0027, as I remember you asked me to use \u0027tuple\u0027 over \u0027list\u0027 or \u0027set\u0027 in one of my patches in a similar case. Is it for \u0027tuple\u0027s immutability?\n\nAnyway, I\u0027m ok with either \u0027set\u0027 or \u0027tuple\u0027, but I\u0027d like to see that as class- or module-level constant.","commit_id":"e1dc9289b7bd8092e814b0e63aaffdbc2c328d1a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd3e247ca418fce37b858fba7800dfc99ccdb994","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self._original_vif_details \u003d None"},{"line_number":106,"context_line":"            self._original_binding_levels \u003d None"},{"line_number":107,"context_line":"        self._new_port_status \u003d None"},{"line_number":108,"context_line":"        self._valid_statuses \u003d set([constants.ACTIVE, constants.DOWN,"},{"line_number":109,"context_line":"            constants.CREATED, constants.PENDING_CREATE,"},{"line_number":110,"context_line":"            constants.PENDING_UPDATE, constants.PENDING_DELETE,"},{"line_number":111,"context_line":"            constants.INACTIVE, constants.ERROR])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_54c0e22a","line":108,"in_reply_to":"1aa78d24_71e410ac","updated":"2016-07-07 22:02:13.000000000","message":"dude it\u0027s like 5 constants, and the code path is not invoked like a gazillion times...optimization for optimization sake is ludicrous!","commit_id":"e1dc9289b7bd8092e814b0e63aaffdbc2c328d1a"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"6d02bdbcbbe67cc86b8929fdb13ffefc7fbb7c99","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self._original_vif_details \u003d None"},{"line_number":106,"context_line":"            self._original_binding_levels \u003d None"},{"line_number":107,"context_line":"        self._new_port_status \u003d None"},{"line_number":108,"context_line":"        self._valid_statuses \u003d set([constants.ACTIVE, constants.DOWN,"},{"line_number":109,"context_line":"            constants.CREATED, constants.PENDING_CREATE,"},{"line_number":110,"context_line":"            constants.PENDING_UPDATE, constants.PENDING_DELETE,"},{"line_number":111,"context_line":"            constants.INACTIVE, constants.ERROR])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_71e410ac","line":108,"in_reply_to":"1aa78d24_bc65b21e","updated":"2016-07-07 21:54:31.000000000","message":"@Armando, why would you prefer \u0027tuple\u0027 over \u0027set\u0027 for \u0027in\u0027 lookup?\n\nfrom timeit import timeit\nfor t in (\u0027list\u0027,\u0027set\u0027,\u0027tuple\u0027):\n  print(\"%s: %f\" % (t, timeit(\u0027\"10\" in v\u0027, \u0027v\u003d%s(str(i) for i in range(20))\u0027 % (t), number\u003d10000000)))\n\n\n  list: 1.729031\n  set: 0.477150\n  tuple: 1.700031\n\n\n@Trevor, you should use \u0027{...}\u0027 syntax for sets, e.g.:\n\n  _valid_statuses \u003d {constants.ACTIVE, constants.DOWN, ... }\n\nAnd I was also suggesting to make \u0027_valid_statuses\u0027 a class or module-level constant instead of an instance property.","commit_id":"e1dc9289b7bd8092e814b0e63aaffdbc2c328d1a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3d758f2f803e289ca26776d61593bd55c972d9f3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self._original_vif_details \u003d None"},{"line_number":106,"context_line":"            self._original_binding_levels \u003d None"},{"line_number":107,"context_line":"        self._new_port_status \u003d None"},{"line_number":108,"context_line":"        self._valid_statuses \u003d set([constants.ACTIVE, constants.DOWN,"},{"line_number":109,"context_line":"            constants.CREATED, constants.PENDING_CREATE,"},{"line_number":110,"context_line":"            constants.PENDING_UPDATE, constants.PENDING_DELETE,"},{"line_number":111,"context_line":"            constants.INACTIVE, constants.ERROR])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_80f044cb","line":108,"in_reply_to":"1aa78d24_df018b6c","updated":"2016-07-08 00:06:27.000000000","message":"I think that the selection of a data structure should be consciously made when the performance of the operations in which it is involved matters, for real. Otherwise expressiveness and readability should be favoured. \n\nNow I think that the sequence of valid statuses we care about should not change over the the course of the system lifecycle, and have this be a class member seems clearly off.","commit_id":"e1dc9289b7bd8092e814b0e63aaffdbc2c328d1a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"77b905baa5a3f4f478376b84d6413eb41727b4b5","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return self._plugin.type_manager.release_dynamic_segment("},{"line_number":268,"context_line":"                self._plugin_context.session, segment_id)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def set_status(self, status):"},{"line_number":271,"context_line":"        if status not in p_const.VALID_STATUSES:"},{"line_number":272,"context_line":"            raise exceptions.StateInvalid(port_state\u003dstatus)"},{"line_number":273,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_78ca04a3","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":19},"updated":"2016-07-18 17:27:58.000000000","message":"Is using the setter property preferred here?\n\n@status.setter\ndef set_status(self, status):","commit_id":"e795cb9612599ffe5a4d1e2734cb9c46ddbc6a09"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"9410262dff04f35f9e038501cf9192a308cdb28d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return self._plugin.type_manager.release_dynamic_segment("},{"line_number":268,"context_line":"                self._plugin_context.session, segment_id)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def set_status(self, status):"},{"line_number":271,"context_line":"        if status not in p_const.VALID_STATUSES:"},{"line_number":272,"context_line":"            raise exceptions.StateInvalid(port_state\u003dstatus)"},{"line_number":273,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_1bfc2f71","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":19},"in_reply_to":"dada55a8_78ca04a3","updated":"2016-07-20 15:47:44.000000000","message":"Done","commit_id":"e795cb9612599ffe5a4d1e2734cb9c46ddbc6a09"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cb063353879b9ce237af3ba271a34bc72197497f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                self._plugin_context.session, segment_id)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @status.setter"},{"line_number":271,"context_line":"    def status(self, status):"},{"line_number":272,"context_line":"        if status not in p_const.PORT_STATUSES:"},{"line_number":273,"context_line":"            raise exceptions.StateInvalid(port_state\u003dstatus)"},{"line_number":274,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_ffd7f5bc","line":271,"updated":"2016-08-03 08:34:02.000000000","message":"as this is a driver api, you should add abc to driver_api.py\nwith documentation.","commit_id":"1f70d92a425985aae30550c495d28cf311727059"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"c8493ab876e6928eed187ba52aca75f00c524614","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                self._plugin_context.session, segment_id)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @status.setter"},{"line_number":271,"context_line":"    def status(self, status):"},{"line_number":272,"context_line":"        if status not in p_const.PORT_STATUSES:"},{"line_number":273,"context_line":"            raise exceptions.StateInvalid(port_state\u003dstatus)"},{"line_number":274,"context_line":"        if self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_adab4ed5","line":271,"in_reply_to":"bacf61ea_ffd7f5bc","updated":"2016-08-22 16:14:31.000000000","message":"Done","commit_id":"1f70d92a425985aae30550c495d28cf311727059"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"01d66877a40eddabc74eb73fbdebdabe47f38c90","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class PortContext(MechanismDriverContext, api.PortContext):"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    PORT_STATUSES \u003d (constants.PORT_STATUS_ACTIVE, constants.PORT_STATUS_BUILD,"},{"line_number":88,"context_line":"                     constants.PORT_STATUS_DOWN, constants.PORT_STATUS_ERROR,"},{"line_number":89,"context_line":"                     constants.PORT_STATUS_NOTAPPLICABLE)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __init__(self, plugin, plugin_context, port, network, binding,"},{"line_number":92,"context_line":"                 binding_levels, original_port\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_863decbd","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":57},"updated":"2016-12-07 16:48:46.000000000","message":"after thinking a bit more, i changed my mind. (sorry!)\n\ni think this gives too much freedom to MDs.  it\u0027s better to have a more restrictive api\nfor drivers, so that status transition is maintainable.\nhow do you think?","commit_id":"10956a22fa75f4ca4f30bd8b653315c2225ec0ef"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"9430080a9228385b2532011e437dd2d1a778e6ad","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class PortContext(MechanismDriverContext, api.PortContext):"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    PORT_STATUSES \u003d (constants.PORT_STATUS_ACTIVE, constants.PORT_STATUS_BUILD,"},{"line_number":88,"context_line":"                     constants.PORT_STATUS_DOWN, constants.PORT_STATUS_ERROR,"},{"line_number":89,"context_line":"                     constants.PORT_STATUS_NOTAPPLICABLE)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __init__(self, plugin, plugin_context, port, network, binding,"},{"line_number":92,"context_line":"                 binding_levels, original_port\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_ae1d5d68","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":57},"in_reply_to":"3a71b18c_863decbd","updated":"2016-12-12 23:01:30.000000000","message":"Right, based on the bug description they only wanted to change the status to an abnormal status. This means we should only allow ERROR or NOTAPPLICABLE\n\nACTIVE, BUILD, and DOWN should be restricted.","commit_id":"10956a22fa75f4ca4f30bd8b653315c2225ec0ef"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f580c7067887153cacb04e420f0f3c5698dfcbf1","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class PortContext(MechanismDriverContext, api.PortContext):"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    PORT_STATUSES \u003d (constants.PORT_STATUS_ERROR,"},{"line_number":88,"context_line":"                     constants.PORT_STATUS_NOTAPPLICABLE)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __init__(self, plugin, plugin_context, port, network, binding,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_991f6d07","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":17},"updated":"2016-12-15 15:23:05.000000000","message":"this name is quite cryptic. please change it to be more reflect of an error or invalid state","commit_id":"28b0012650d648bf1150e1596211527948d94f9b"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e2836f003826d79863abe82376e9c43677deba7c","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class PortContext(MechanismDriverContext, api.PortContext):"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    PORT_STATUSES \u003d (constants.PORT_STATUS_ERROR,"},{"line_number":88,"context_line":"                     constants.PORT_STATUS_NOTAPPLICABLE)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __init__(self, plugin, plugin_context, port, network, binding,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_ed4edb6d","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":17},"in_reply_to":"1a6eadb0_991f6d07","updated":"2016-12-15 16:28:39.000000000","message":"Done.\n\nI was hesitant on changing the name because the statuses we want is still being discussed.","commit_id":"28b0012650d648bf1150e1596211527948d94f9b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7ee61664839c411194fce1b0cd6937c32586036a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        if (self._port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_DVR_INTERFACE"},{"line_number":276,"context_line":"                and self._binding.status !\u003d status):"},{"line_number":277,"context_line":"            self._binding.status \u003d status"},{"line_number":278,"context_line":"            self._plugin.update_port_status(self._plugin_context,"},{"line_number":279,"context_line":"                                            self._port[\u0027id\u0027],"},{"line_number":280,"context_line":"                                            status,"},{"line_number":281,"context_line":"                                            self._binding.host)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_7f073481","line":278,"range":{"start_line":278,"start_character":25,"end_line":278,"end_character":43},"updated":"2017-01-11 08:56:55.000000000","message":"this method is called by MDs and update_port_status can call MDs.  is it safe?\n\ni guess it\u0027s simpler to make MDs just record the intent in port context and then make the manager reflect it to db if necessary.  how do you think?","commit_id":"cab418aba4f9019f927e19b0048f68394ee3b9df"}],"neutron/tests/unit/plugins/ml2/test_driver_context.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"dbc7f076cb3c4262c5dc4d2351427db5b8558209","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        network \u003d mock.MagicMock()"},{"line_number":137,"context_line":"        binding \u003d mock.Mock()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        port \u003d {\u0027device_owner\u0027: constants.DEVICE_OWNER_DVR_INTERFACE}"},{"line_number":140,"context_line":"        binding.status \u003d \u0027foostatus\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        with mock.patch.object(driver_context.segments_db,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_9b4ef594","line":139,"updated":"2016-08-31 16:35:46.000000000","message":"this port dict seems to be the only difference to the test above. You should refactor that to reuse the common code!","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bcc39d3fbdb99bc0d575b91a4e58735a3c0fcd9b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        network \u003d mock.MagicMock()"},{"line_number":137,"context_line":"        binding \u003d mock.Mock()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        port \u003d {\u0027device_owner\u0027: constants.DEVICE_OWNER_DVR_INTERFACE}"},{"line_number":140,"context_line":"        binding.status \u003d \u0027foostatus\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        with mock.patch.object(driver_context.segments_db,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_6d8e492f","line":139,"in_reply_to":"fa7ab95a_9b4ef594","updated":"2016-09-07 21:19:39.000000000","message":"You\u0027re right, I was following what the other tests did. I refactored my unit tests.","commit_id":"055eda79350aad8e79b481ce14d7f76ff76e89fa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b0b04a6aaac3a617a6604290635f7440811bb2b1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        ctx.set_error_or_na_status(constants.ERROR)"},{"line_number":140,"context_line":"        self.assertEqual(constants.ERROR, ctx.status)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_set_error_or_na_status_super(self):"},{"line_number":143,"context_line":"        port \u003d {\u0027device_owner\u0027: \u0027compute\u0027,"},{"line_number":144,"context_line":"                \u0027status\u0027: \u0027status\u0027,"},{"line_number":145,"context_line":"                \u0027id\u0027: None}"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_63b3490b","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":41},"updated":"2016-12-19 14:43:44.000000000","message":"The title and L135 are confused me. IMO, It\u0027s better to change L135 to \"test_set_error_or_na_status_dvr\" and L142 to \"test_set_error_or_na_status\".","commit_id":"a8b85b4061b6bb4a1fab93ec096b6812392f9429"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"4160e2a56c1ca582e169db4f0f6cee2e86ba85a4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        ctx.set_error_or_na_status(constants.ERROR)"},{"line_number":140,"context_line":"        self.assertEqual(constants.ERROR, ctx.status)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_set_error_or_na_status_super(self):"},{"line_number":143,"context_line":"        port \u003d {\u0027device_owner\u0027: \u0027compute\u0027,"},{"line_number":144,"context_line":"                \u0027status\u0027: \u0027status\u0027,"},{"line_number":145,"context_line":"                \u0027id\u0027: None}"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_2c93f9a4","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":41},"in_reply_to":"1a6eadb0_63b3490b","updated":"2016-12-19 17:04:47.000000000","message":"Done","commit_id":"a8b85b4061b6bb4a1fab93ec096b6812392f9429"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b0b04a6aaac3a617a6604290635f7440811bb2b1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(constants.ERROR, ctx.status)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_set_error_or_na_status_super(self):"},{"line_number":143,"context_line":"        port \u003d {\u0027device_owner\u0027: \u0027compute\u0027,"},{"line_number":144,"context_line":"                \u0027status\u0027: \u0027status\u0027,"},{"line_number":145,"context_line":"                \u0027id\u0027: None}"},{"line_number":146,"context_line":"        ctx \u003d self._get_port_context(port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_03bb750f","line":143,"range":{"start_line":143,"start_character":32,"end_line":143,"end_character":41},"updated":"2016-12-19 14:43:44.000000000","message":"It looks like \"constants.DEVICE_OWNER_COMPUTE_PREFIX\" is better.","commit_id":"a8b85b4061b6bb4a1fab93ec096b6812392f9429"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"4160e2a56c1ca582e169db4f0f6cee2e86ba85a4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(constants.ERROR, ctx.status)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_set_error_or_na_status_super(self):"},{"line_number":143,"context_line":"        port \u003d {\u0027device_owner\u0027: \u0027compute\u0027,"},{"line_number":144,"context_line":"                \u0027status\u0027: \u0027status\u0027,"},{"line_number":145,"context_line":"                \u0027id\u0027: None}"},{"line_number":146,"context_line":"        ctx \u003d self._get_port_context(port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_4c903596","line":143,"range":{"start_line":143,"start_character":32,"end_line":143,"end_character":41},"in_reply_to":"1a6eadb0_03bb750f","updated":"2016-12-19 17:04:47.000000000","message":"Done","commit_id":"a8b85b4061b6bb4a1fab93ec096b6812392f9429"}]}
