)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6b107aff44e8d5699fa7e2a63edeee6536a926ed","unresolved":false,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def vxlan_mcast_supported(self):"},{"line_number":636,"context_line":"        if not cfg.CONF.VXLAN.vxlan_group:"},{"line_number":637,"context_line":"            LOG.warning(_LW(\u0027VXLAN muticast group(s) must be provided in \u0027"},{"line_number":638,"context_line":"                            \u0027vxlan_group option to enable VXLAN MCAST mode\u0027))"},{"line_number":639,"context_line":"            return False"},{"line_number":640,"context_line":"        if not ip_lib.iproute_arg_supported("}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_4dbabf0b","side":"PARENT","line":637,"updated":"2016-08-16 09:27:39.000000000","message":"something isn\u0027t adding up. The function check_vxlan_support() calls this function to determine if multicast support is enabled if unicast isn\u0027t supported. If this returns false it throws an exception VxlanNetworkUnsupported, which should kill everything. I don\u0027t see how this patch would change anything.\n\nLinux bridge can be run without multicast in unicast mode, so maybe ansidble was deploying it that way and something misconfigured for unicast...","commit_id":"fc02d5b7eaaa06a42d7bec1b56f5d15c6a4ec0c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a500a6ab2a735329a395e0e0944ef816ff09d5cb","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        if not cfg.CONF.VXLAN.vxlan_group:"},{"line_number":637,"context_line":"            LOG.error(_LW(\u0027VXLAN muticast group(s) must be provided in \u0027"},{"line_number":638,"context_line":"                          \u0027vxlan_group option to enable VXLAN MCAST mode\u0027))"},{"line_number":639,"context_line":"            sys.exit(1)"},{"line_number":640,"context_line":"        if not ip_lib.iproute_arg_supported("},{"line_number":641,"context_line":"                [\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027type\u0027, \u0027vxlan\u0027],"},{"line_number":642,"context_line":"                \u0027proxy\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_55364c51","line":639,"updated":"2016-06-30 18:50:20.000000000","message":"I think raising SystemError is nicer. I have seen instances where sys.exit(1) is very rude to the test runner, but that\u0027s a different argument","commit_id":"83d00f75efcab19c85739e539289f93241f80a44"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f8868b976999dd7d3e347479e4821e8399e3fd5d","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        elif self.vxlan_mcast_supported():"},{"line_number":658,"context_line":"            self.vxlan_mode \u003d lconst.VXLAN_MCAST"},{"line_number":659,"context_line":"        else:"},{"line_number":660,"context_line":"            raise exceptions.VxlanNetworkUnsupported()"},{"line_number":661,"context_line":"        LOG.debug(\u0027Using %s VXLAN mode\u0027, self.vxlan_mode)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def fdb_ip_entry_exists(self, mac, ip, interface):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_607d886c","line":660,"updated":"2016-06-30 19:01:23.000000000","message":"In the commit message you say that the agent did not exit when vxlan_group was set to \u0027\u0027, I\u0027m having trouble following that in the code. In that case wouldn\u0027t this exception be thrown? I don\u0027t see any code that would catch this exception.","commit_id":"83d00f75efcab19c85739e539289f93241f80a44"}]}