)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f425638193e87a02a3ec4327d7fbb6dbe876f517","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add callbacks for networks and subnets in ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds callback \u0027after\u0027 events for networks and subnets in ML2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements: blueprint push-notifications"},{"line_number":12,"context_line":"Change-Id: I735e33df08252103e8e3a6b3e0143373706b5b8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_77bec9ae","line":9,"updated":"2016-07-22 02:16:01.000000000","message":"is \u0027after\u0027 the semantic you\u0027re after? Refresh your memory here:\n\nhttp://docs.openstack.org/developer/neutron/devref/callbacks.html\n\nPerhaps you need a PRECOMMIT? Please state your requirements clearly so that we can more mindfully give you a vote.","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cb3af855af824d8449fd78b7c6d48b2c9b4e1a48","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add callbacks for networks and subnets in ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds callback \u0027after\u0027 events for networks and subnets in ML2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements: blueprint push-notifications"},{"line_number":12,"context_line":"Change-Id: I735e33df08252103e8e3a6b3e0143373706b5b8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_d4e914b9","line":9,"in_reply_to":"dada55a8_179e6d06","updated":"2016-07-25 11:19:51.000000000","message":"Fist fight!","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"14d3b314cd3315d33bb7e89d6184c5bb51e707b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add callbacks for networks and subnets in ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds callback \u0027after\u0027 events for networks and subnets in ML2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements: blueprint push-notifications"},{"line_number":12,"context_line":"Change-Id: I735e33df08252103e8e3a6b3e0143373706b5b8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_f78479d3","line":9,"in_reply_to":"dada55a8_77bec9ae","updated":"2016-07-22 02:17:55.000000000","message":"Yes, don\u0027t question my intentions! This is used for some notification stuff.","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8b7be722e58a30437d975e3c9941c4c473b352db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add callbacks for networks and subnets in ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds callback \u0027after\u0027 events for networks and subnets in ML2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements: blueprint push-notifications"},{"line_number":12,"context_line":"Change-Id: I735e33df08252103e8e3a6b3e0143373706b5b8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_179e6d06","line":9,"in_reply_to":"dada55a8_f78479d3","updated":"2016-07-22 02:23:44.000000000","message":"ok ok no need to get moody.","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7678295b9280a8400067f772b663fc85e19b6368","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            self._delete_ports(context, port_ids)"},{"line_number":899,"context_line":"            self._delete_subnets(context, subnet_ids)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: network}"},{"line_number":903,"context_line":"            registry.notify(resources.NETWORK, events.AFTER_DELETE, self,"},{"line_number":904,"context_line":"                            **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_18e78d41","line":901,"updated":"2016-07-08 12:57:54.000000000","message":"Please put it before the try.","commit_id":"be71941ef561c133e1f34f66ff7d0373305ddabb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ab76eb35613f42dd0f5ab39dea7bed9de534c6db","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            self._delete_ports(context, port_ids)"},{"line_number":899,"context_line":"            self._delete_subnets(context, subnet_ids)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: network}"},{"line_number":903,"context_line":"            registry.notify(resources.NETWORK, events.AFTER_DELETE, self,"},{"line_number":904,"context_line":"                            **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_1469ff8b","line":901,"in_reply_to":"1aa78d24_18e78d41","updated":"2016-07-08 21:09:48.000000000","message":"Done","commit_id":"be71941ef561c133e1f34f66ff7d0373305ddabb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4665e66b061d28bb62f2d327681b547d7475511e","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        except ml2_exc.MechanismDriverError:"},{"line_number":727,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":728,"context_line":"                LOG.error(_LE(\"mechanism_manager.create_network_postcommit \""},{"line_number":729,"context_line":"                              \"failed, deleting network \u0027%s\u0027\"), result[\u0027id\u0027])"},{"line_number":730,"context_line":"                self.delete_network(context, result[\u0027id\u0027])"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_de73fab2","line":729,"updated":"2016-07-10 19:50:28.000000000","message":"If the mechanism manager creation fails, we call delete network. Subscribers can subscribe to AFTER_DELETE events to get that. No need for a special-case.","commit_id":"8b8634bae1f5e6f1db3da0ca5b3688600c0fc6ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"52bb4cacdd8eacbe51fffccf482b6255a538123d","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        except ml2_exc.MechanismDriverError:"},{"line_number":727,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":728,"context_line":"                LOG.error(_LE(\"mechanism_manager.create_network_postcommit \""},{"line_number":729,"context_line":"                              \"failed, deleting network \u0027%s\u0027\"), result[\u0027id\u0027])"},{"line_number":730,"context_line":"                self.delete_network(context, result[\u0027id\u0027])"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_0a6d4199","line":729,"updated":"2016-07-10 17:22:21.000000000","message":"if the mechanism manager creation fails then i think that we need a rollback callback to be consistant","commit_id":"8b8634bae1f5e6f1db3da0ca5b3688600c0fc6ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7654e2dae20308ebdef9920c7402f2fc04238dd3","unresolved":false,"context_lines":[{"line_number":729,"context_line":"    def create_network(self, context, network):"},{"line_number":730,"context_line":"        result, mech_context \u003d self._create_network_db(context, network)"},{"line_number":731,"context_line":"        kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: result}"},{"line_number":732,"context_line":"        registry.notify(resources.NETWORK, events.AFTER_CREATE, self, **kwargs)"},{"line_number":733,"context_line":"        try:"},{"line_number":734,"context_line":"            self.mechanism_manager.create_network_postcommit(mech_context)"},{"line_number":735,"context_line":"        except ml2_exc.MechanismDriverError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_cd46347a","line":732,"updated":"2016-07-21 09:41:13.000000000","message":"if the callback raises an exception then should re rollback?","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f425638193e87a02a3ec4327d7fbb6dbe876f517","unresolved":false,"context_lines":[{"line_number":729,"context_line":"    def create_network(self, context, network):"},{"line_number":730,"context_line":"        result, mech_context \u003d self._create_network_db(context, network)"},{"line_number":731,"context_line":"        kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: result}"},{"line_number":732,"context_line":"        registry.notify(resources.NETWORK, events.AFTER_CREATE, self, **kwargs)"},{"line_number":733,"context_line":"        try:"},{"line_number":734,"context_line":"            self.mechanism_manager.create_network_postcommit(mech_context)"},{"line_number":735,"context_line":"        except ml2_exc.MechanismDriverError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_37a1f194","line":732,"in_reply_to":"dada55a8_cd46347a","updated":"2016-07-22 02:16:01.000000000","message":"callbacks for AFTER_CREATE do not raise exceptions\n\nhttp://docs.openstack.org/developer/neutron/devref/callbacks.html#subscribing-and-aborting-events","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2d53a7c2f031855d238648991ca27df7bbd00dfb","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: result}"},{"line_number":732,"context_line":"        registry.notify(resources.NETWORK, events.AFTER_CREATE, self, **kwargs)"},{"line_number":733,"context_line":"        try:"},{"line_number":734,"context_line":"            self.mechanism_manager.create_network_postcommit(mech_context)"},{"line_number":735,"context_line":"        except ml2_exc.MechanismDriverError:"},{"line_number":736,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":737,"context_line":"                LOG.error(_LE(\"mechanism_manager.create_network_postcommit \""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_778d29d2","line":734,"updated":"2016-07-22 02:24:52.000000000","message":"if this fails then your AFTER_CREATE handler may have been voided, but you have an AFTER_DELETE so...all good.","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7654e2dae20308ebdef9920c7402f2fc04238dd3","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":933,"context_line":"        result, mech_context \u003d self._create_subnet_db(context, subnet)"},{"line_number":934,"context_line":"        kwargs \u003d {\u0027context\u0027: context, \u0027subnet\u0027: result}"},{"line_number":935,"context_line":"        registry.notify(resources.SUBNET, events.AFTER_CREATE, self, **kwargs)"},{"line_number":936,"context_line":"        try:"},{"line_number":937,"context_line":"            self.mechanism_manager.create_subnet_postcommit(mech_context)"},{"line_number":938,"context_line":"        except ml2_exc.MechanismDriverError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_6d2f48a1","line":935,"updated":"2016-07-21 09:41:13.000000000","message":"ditto","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f425638193e87a02a3ec4327d7fbb6dbe876f517","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":933,"context_line":"        result, mech_context \u003d self._create_subnet_db(context, subnet)"},{"line_number":934,"context_line":"        kwargs \u003d {\u0027context\u0027: context, \u0027subnet\u0027: result}"},{"line_number":935,"context_line":"        registry.notify(resources.SUBNET, events.AFTER_CREATE, self, **kwargs)"},{"line_number":936,"context_line":"        try:"},{"line_number":937,"context_line":"            self.mechanism_manager.create_subnet_postcommit(mech_context)"},{"line_number":938,"context_line":"        except ml2_exc.MechanismDriverError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_b7bb21c3","line":935,"in_reply_to":"dada55a8_6d2f48a1","updated":"2016-07-22 02:16:01.000000000","message":"dito","commit_id":"a5cd3b65d1e7468e77247d58f5ef0adcc265d54c"}]}
