)]}'
{"quantum/extensions/providernet.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"43173c769b1a2eb16f55658b20b6087db516ed8d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _check_provider_not_update(attrs):"},{"line_number":49,"context_line":"    network_type \u003d attrs.get(NETWORK_TYPE)"},{"line_number":50,"context_line":"    physical_network \u003d attrs.get(PHYSICAL_NETWORK)"},{"line_number":51,"context_line":"    segmentation_id \u003d attrs.get(SEGMENTATION_ID)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2DA%3D","line":48,"updated":"2013-06-19 22:24:51.000000000","message":"I don\u0027t think we need \"provider\" in the name (and provider_not is too close to provider_net). Considering how it is called, may I suggest \"_verify_update_supported\".\n\nAlso, a docstring would be nice.","commit_id":"0a3029c36720764dd3167f0645c11706403fcbd9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _check_provider_not_update(attrs):"},{"line_number":49,"context_line":"    network_type \u003d attrs.get(NETWORK_TYPE)"},{"line_number":50,"context_line":"    physical_network \u003d attrs.get(PHYSICAL_NETWORK)"},{"line_number":51,"context_line":"    segmentation_id \u003d attrs.get(SEGMENTATION_ID)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F11g%3D","line":48,"in_reply_to":"AAAAPn%2F%2F13A%3D","updated":"2013-06-20 00:08:22.000000000","message":"/me _raise_if_update_provider()","commit_id":"0a3029c36720764dd3167f0645c11706403fcbd9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _check_provider_not_update(attrs):"},{"line_number":49,"context_line":"    network_type \u003d attrs.get(NETWORK_TYPE)"},{"line_number":50,"context_line":"    physical_network \u003d attrs.get(PHYSICAL_NETWORK)"},{"line_number":51,"context_line":"    segmentation_id \u003d attrs.get(SEGMENTATION_ID)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F13A%3D","line":48,"in_reply_to":"AAAAPn%2F%2F2DA%3D","updated":"2013-06-20 00:06:39.000000000","message":"Changed to: _raise_update_not_supported()","commit_id":"0a3029c36720764dd3167f0645c11706403fcbd9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _raise_if_updates_provider(attrs):"},{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F1VI%3D","line":48,"updated":"2013-06-20 06:21:41.000000000","message":"name was a little confusing. How about something like: _raise_if_provider_update_not_supported","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _raise_if_updates_provider(attrs):"},{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0KM%3D","line":48,"in_reply_to":"AAAAPn%2F%2F0mc%3D","updated":"2013-06-20 15:29:50.000000000","message":"Done","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _raise_if_updates_provider(attrs):"},{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0mc%3D","line":48,"in_reply_to":"AAAAPn%2F%2F0qI%3D","updated":"2013-06-20 12:37:34.000000000","message":"i am slow - _raise_if_updates_provider_attributes would have been easier for me to udnerstand","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"43173c769b1a2eb16f55658b20b6087db516ed8d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _raise_if_updates_provider(attrs):"},{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0qI%3D","line":48,"in_reply_to":"AAAAPn%2F%2F1VI%3D","updated":"2013-06-20 12:16:47.000000000","message":"Hmmm, I think Aaron\u0027s naming is correct. The way I understand it is that a plugin that supports updating of provider attributes would not call this function. (Such a plugin does not exist yet.)","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    network_type \u003d attrs.get(NETWORK_TYPE)"},{"line_number":54,"context_line":"    physical_network \u003d attrs.get(PHYSICAL_NETWORK)"},{"line_number":55,"context_line":"    segmentation_id \u003d attrs.get(SEGMENTATION_ID)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F1rk%3D","line":53,"updated":"2013-06-20 02:32:20.000000000","message":"Consider refactoring to this implementation:\n\nimmutable \u003d (NETWORK_TYPE, PHYSICAL_NETWORK, SEGMENTATION_ID)\nif any(attributes.is_attr_set(attrs.get(a)) for a in immutable):\n    msg \u003d _(\"plugin does not support updating provider attributes\")\n    raise q_exc.InvalidInput(error_message\u003dmsg)","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    network_type \u003d attrs.get(NETWORK_TYPE)"},{"line_number":54,"context_line":"    physical_network \u003d attrs.get(PHYSICAL_NETWORK)"},{"line_number":55,"context_line":"    segmentation_id \u003d attrs.get(SEGMENTATION_ID)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0Kw%3D","line":53,"in_reply_to":"AAAAPn%2F%2F1rk%3D","updated":"2013-06-20 15:29:50.000000000","message":"Done","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"43173c769b1a2eb16f55658b20b6087db516ed8d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            segmentation_id_set):"},{"line_number":63,"context_line":"        return"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    msg \u003d _(\"plugin does not support updating provider attributes\")"},{"line_number":66,"context_line":"    raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0p4%3D","line":65,"updated":"2013-06-20 12:16:47.000000000","message":"Should we add \"network\" here?\n\n\"plugin does not support updating provider network attributes\"?\n\n\"plugin does not support updating provider:network attributes\"?","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"            segmentation_id_set):"},{"line_number":63,"context_line":"        return"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    msg \u003d _(\"plugin does not support updating provider attributes\")"},{"line_number":66,"context_line":"    raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fj4M%3D","line":65,"in_reply_to":"AAAAPn%2F%2F0Kk%3D","updated":"2013-06-27 19:08:51.000000000","message":"nvm leave as is..","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"            segmentation_id_set):"},{"line_number":63,"context_line":"        return"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    msg \u003d _(\"plugin does not support updating provider attributes\")"},{"line_number":66,"context_line":"    raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0Kk%3D","line":65,"in_reply_to":"AAAAPn%2F%2F0p4%3D","updated":"2013-06-20 15:29:50.000000000","message":"Done","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    immutable \u003d (NETWORK_TYPE, PHYSICAL_NETWORK, SEGMENTATION_ID)"},{"line_number":54,"context_line":"    if any(attributes.is_attr_set(attrs.get(a)) for a in immutable):"},{"line_number":55,"context_line":"        msg \u003d _(\"plugin does not support updating provider attributes\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FiLI%3D","line":52,"updated":"2013-06-28 11:02:05.000000000","message":"Congratulations!\n\nYou\u0027re the target of today\u0027s share of pedantry from salv-orlando.\n\nYou are violating conventions on multi-line docstrings according to: https://github.com/openstack/quantum/blob/master/HACKING.rst#docstrings\n\nYou are SO earning a -1 for this!","commit_id":"2983fa6076ff3891ecbfbf21f9ebefc44e415cde"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\"Check if request modifies the provider network fields and raise"},{"line_number":50,"context_line":"    if it does. This method is used for plugins that do not support"},{"line_number":51,"context_line":"    updating provider networks."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    immutable \u003d (NETWORK_TYPE, PHYSICAL_NETWORK, SEGMENTATION_ID)"},{"line_number":54,"context_line":"    if any(attributes.is_attr_set(attrs.get(a)) for a in immutable):"},{"line_number":55,"context_line":"        msg \u003d _(\"plugin does not support updating provider attributes\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ff%2Fk%3D","line":52,"in_reply_to":"AAAAPn%2F%2FiLI%3D","updated":"2013-06-29 05:32:04.000000000","message":"im opinion if we don\u0027t have this option configured for flake8 then.... icbb.. I\u0027ll bb though and fix it...","commit_id":"2983fa6076ff3891ecbfbf21f9ebefc44e415cde"}],"quantum/plugins/hyperv/hyperv_quantum_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def update_network(self, context, id, network):"},{"line_number":257,"context_line":"        network_attrs \u003d network[\u0027network\u0027]"},{"line_number":258,"context_line":"        provider._raise_if_updates_provider(network_attrs)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        session \u003d context.session"},{"line_number":261,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F1rc%3D","line":258,"updated":"2013-06-20 02:32:20.000000000","message":"simplify 257-8:\nprovider._raise_if_updates_provider(network[\u0027network\u0027])","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def update_network(self, context, id, network):"},{"line_number":257,"context_line":"        network_attrs \u003d network[\u0027network\u0027]"},{"line_number":258,"context_line":"        provider._raise_if_updates_provider(network_attrs)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        session \u003d context.session"},{"line_number":261,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0K8%3D","line":258,"in_reply_to":"AAAAPn%2F%2F1rc%3D","updated":"2013-06-20 15:29:50.000000000","message":"Done","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"}],"quantum/plugins/ml2/plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":206,"context_line":"        return result"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def update_network(self, context, id, network):"},{"line_number":209,"context_line":"        attrs \u003d network[\u0027network\u0027]"},{"line_number":210,"context_line":"        provider._raise_if_updates_provider(attrs)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F1rM%3D","line":209,"updated":"2013-06-20 02:32:20.000000000","message":"Simplify 209-10:\n\nprovider._raise_if_updates_provider(network[\u0027network\u0027])","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":206,"context_line":"        return result"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def update_network(self, context, id, network):"},{"line_number":209,"context_line":"        attrs \u003d network[\u0027network\u0027]"},{"line_number":210,"context_line":"        provider._raise_if_updates_provider(attrs)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0K0%3D","line":209,"in_reply_to":"AAAAPn%2F%2F1rM%3D","updated":"2013-06-20 15:29:50.000000000","message":"Done","commit_id":"e1c19a3ddd77654470c28f5c501087f58dbfd8e8"}]}