)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"45563d2e4d2cb07cb4edd2956675a4293dea734d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Ruan \u003cruansx@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-05 19:04:04 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027orig_address_scope_id\u0027 and \u0027new_address_scope_id\u0027 to"},{"line_number":8,"context_line":"SUBNETPOOL_ADDRESS_SCOPE event"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I78e9a4efdde95153e0ee75ba1bc197ec76a650c1"},{"line_number":11,"context_line":"Closes-bug: #1598735"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_64d5eb1a","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":30},"updated":"2016-07-06 03:20:47.000000000","message":"Pls follow the guide to write the commit msg.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"d77dbe0843e95c42457b4a4720dc9d3f4420ea79"},{"author":{"_account_id":17609,"name":"steve","email":"ruansx@cn.ibm.com","username":"steve.ruan"},"change_message_id":"efba17eff2a3ca750412aa28ca89aeb958870cb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Ruan \u003cruansx@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-05 19:04:04 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027orig_address_scope_id\u0027 and \u0027new_address_scope_id\u0027 to"},{"line_number":8,"context_line":"SUBNETPOOL_ADDRESS_SCOPE event"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I78e9a4efdde95153e0ee75ba1bc197ec76a650c1"},{"line_number":11,"context_line":"Closes-bug: #1598735"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_87b3b9e8","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":30},"in_reply_to":"1aa78d24_64d5eb1a","updated":"2016-07-06 04:14:10.000000000","message":"Thanks. Will fix it.","commit_id":"d77dbe0843e95c42457b4a4720dc9d3f4420ea79"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"45563d2e4d2cb07cb4edd2956675a4293dea734d","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"            # Notify about the update of subnetpool\u0027s address scope"},{"line_number":1057,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027subnetpool_id\u0027: id,"},{"line_number":1058,"context_line":"                      \u0027orig_address_scope_id\u0027: orig_address_scope_id,"},{"line_number":1059,"context_line":"                      \u0027new_address_scope_id\u0027: new_address_scope_id}"},{"line_number":1060,"context_line":"            registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1061,"context_line":"                            events.AFTER_UPDATE,"},{"line_number":1062,"context_line":"                            self.update_subnetpool,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c4e65f14","line":1059,"range":{"start_line":1059,"start_character":22,"end_line":1059,"end_character":67},"updated":"2016-07-06 03:20:47.000000000","message":"Is new address scope necessary here? Because new address scope could be found at subnetpool.","commit_id":"d77dbe0843e95c42457b4a4720dc9d3f4420ea79"},{"author":{"_account_id":17609,"name":"steve","email":"ruansx@cn.ibm.com","username":"steve.ruan"},"change_message_id":"efba17eff2a3ca750412aa28ca89aeb958870cb4","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"            # Notify about the update of subnetpool\u0027s address scope"},{"line_number":1057,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027subnetpool_id\u0027: id,"},{"line_number":1058,"context_line":"                      \u0027orig_address_scope_id\u0027: orig_address_scope_id,"},{"line_number":1059,"context_line":"                      \u0027new_address_scope_id\u0027: new_address_scope_id}"},{"line_number":1060,"context_line":"            registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1061,"context_line":"                            events.AFTER_UPDATE,"},{"line_number":1062,"context_line":"                            self.update_subnetpool,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_67068d87","line":1059,"range":{"start_line":1059,"start_character":22,"end_line":1059,"end_character":67},"in_reply_to":"1aa78d24_c4e65f14","updated":"2016-07-06 04:14:10.000000000","message":"Yes, event handler can lookup the \u0027new_address_scope_id\u0027 from db by \u0027subnetpool_id\u0027, it will waste the CPU cycle.\nIMO, I prefer to add \u0027new_address_scope_id\u0027 as argument to event handler.\n:)","commit_id":"d77dbe0843e95c42457b4a4720dc9d3f4420ea79"}]}