)]}'
{"neutron/db/common_db_mixin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2a9b4702ea882cecd192fa80c30b28038e8b9b23","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        return weakref.proxy(self)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # TODO(HenryG): Deprecate this when available in neutron-lib"},{"line_number":90,"context_line":"    def model_query_scope(self, context, model):"},{"line_number":91,"context_line":"        return ndb_utils.model_query_scope_is_project(context, model)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_02ed3c25","line":89,"updated":"2016-10-17 22:28:24.000000000","message":"I want to brainstorm about this a bit. I think this business of deprecating stuff being exported into neutron-lib hinders our development effort a bit. I think we can simplify our lives a bit by avoiding deprecation in case of straightforward relocations. Stadium projects and projects that are close to the our chest should have no problem keeping up if we give sufficient notice and we introduce disruptive changes on a particular cadence.","commit_id":"5a1f84958023b53653ea5cc80cd917b578f4e884"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"96ab1d1216905b6660ac703bd949b96c8bdcc781","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        return weakref.proxy(self)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # TODO(HenryG): Deprecate this when available in neutron-lib"},{"line_number":90,"context_line":"    def model_query_scope(self, context, model):"},{"line_number":91,"context_line":"        return ndb_utils.model_query_scope_is_project(context, model)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_5c444d1a","line":89,"in_reply_to":"fa6399be_02ed3c25","updated":"2016-10-18 22:54:53.000000000","message":"OK, I\u0027ll change \u0027deprecate\u0027 to \u0027remove\u0027 in these comments.","commit_id":"5a1f84958023b53653ea5cc80cd917b578f4e884"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6efdee3f76734a90f6db15abdfc0c83dc64f568d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from sqlalchemy import sql"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.api.v2 import attributes"},{"line_number":28,"context_line":"from neutron.db import _utils as ndb_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_004cf86e","line":28,"updated":"2016-10-19 19:21:13.000000000","message":"nit: it would be nice to have this rename ndb_utils as db_utils. So that it\u0027s consistent across all the files in this patch.","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c2f830f1f016705b2e2e36af7780e3e6799fb840","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from sqlalchemy import sql"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.api.v2 import attributes"},{"line_number":28,"context_line":"from neutron.db import _utils as ndb_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_5626f3ba","line":28,"in_reply_to":"fa6399be_004cf86e","updated":"2016-10-23 09:57:18.000000000","message":"Then it would conflict with db_utils from line 18. Once _utils.py is available in neutron-lib then \u0027ndb_utils\u0027 will be renamed to \u0027db_utils\u0027.","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b29a7264f10b7d423fa7f67dff928d1dba10c400","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            query \u003d query.filter(query_filter)"},{"line_number":130,"context_line":"        return query"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # TODO(HenryG): Remove this when available in neutron-lib"},{"line_number":133,"context_line":"    def _fields(self, resource, fields):"},{"line_number":134,"context_line":"        return ndb_utils.resource_fields(resource, fields)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_1659db5a","line":132,"updated":"2016-10-23 14:17:45.000000000","message":"can you please add in a depracation warning here so that decomposed plugins may get a \u0027hint\u0027 about this. As far as I see it, it will be a two phase move:\n1. use the internal _utils\n2. just change the import to neutron-lib\nSo if you add the depraction warning it will help us considerably.","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1d39bebb5a2a8abd21cf84ae83249b2f1093114e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            query \u003d query.filter(query_filter)"},{"line_number":130,"context_line":"        return query"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # TODO(HenryG): Remove this when available in neutron-lib"},{"line_number":133,"context_line":"    def _fields(self, resource, fields):"},{"line_number":134,"context_line":"        return ndb_utils.resource_fields(resource, fields)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_a930cd02","line":132,"in_reply_to":"da6895a0_1659db5a","updated":"2016-10-28 14:48:08.000000000","message":"The idea with this patch/phase is that it will not impact any sub-projects. Also, as per the new strategy for neutron-lib, we will not be deprecating things that are release noted, so it remains to be seen if any deprecations are needed.","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6efdee3f76734a90f6db15abdfc0c83dc64f568d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from neutron.common import ipv6_utils"},{"line_number":43,"context_line":"from neutron.common import utils"},{"line_number":44,"context_line":"from neutron import context as ctx"},{"line_number":45,"context_line":"from neutron.db import _utils as ndb_utils"},{"line_number":46,"context_line":"from neutron.db import api as db_api"},{"line_number":47,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":48,"context_line":"from neutron.db import ipam_pluggable_backend"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_20473c4c","line":45,"updated":"2016-10-19 19:21:13.000000000","message":"ditto","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c2f830f1f016705b2e2e36af7780e3e6799fb840","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from neutron.common import ipv6_utils"},{"line_number":43,"context_line":"from neutron.common import utils"},{"line_number":44,"context_line":"from neutron import context as ctx"},{"line_number":45,"context_line":"from neutron.db import _utils as ndb_utils"},{"line_number":46,"context_line":"from neutron.db import api as db_api"},{"line_number":47,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":48,"context_line":"from neutron.db import ipam_pluggable_backend"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_96208b9d","line":45,"in_reply_to":"fa6399be_20473c4c","updated":"2016-10-23 09:57:18.000000000","message":"ditto","commit_id":"beedbcc1fa233f5375e552ce2134b49e248f047c"}],"neutron/db/utils.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2632feb208b3f013a3c2d55efce067a430d2e011","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return obj, value"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def model_query_scope_is_tenant(context, model):"},{"line_number":72,"context_line":"    # Unless a context has \u0027admin\u0027 or \u0027advanced-service\u0027 rights the"},{"line_number":73,"context_line":"    # query will be scoped to a single tenant_id"},{"line_number":74,"context_line":"    return ((not context.is_admin and hasattr(model, \u0027tenant_id\u0027)) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_49d74423","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":31},"updated":"2016-07-05 15:27:56.000000000","message":"Should I use \u0027project\u0027 instead?","commit_id":"064c72337faf1ed532bcc452139154ba20474cd9"}]}
