)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8bcf0b27ffa83194c3377257ed075ab8e3188f8b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_6227b2b6","line":12,"updated":"2016-07-05 17:22:05.000000000","message":"I agree that we shouldn\u0027t be logging these exceptions since they are legitimately meant to stop notifiers. Maybe we need a way for a subscriber to indicate which types of exceptions are normal when they subscribe which would control this logging.","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9b14864f69c609a87f429bd5b55d3329de549c05","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_6d87a3d7","line":12,"updated":"2016-07-05 17:51:18.000000000","message":"Yeah, so maybe no logging on PRECOMMIT or BEFORE.","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bb387731e9df60bbacb8c788bd62808c5757b656","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_497d84e6","line":12,"updated":"2016-07-05 15:30:59.000000000","message":"it should not litter the log file unless a genuine bug crept in and the stacktrace is helpful. Where do you see the litter?","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd3289d044a9a09d0e945b024fefd0dd486871e2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_65b857e6","line":12,"in_reply_to":"1aa78d24_08ca4d6d","updated":"2016-07-05 19:36:56.000000000","message":"Can you share the code you\u0027re referring to? It\u0027ll help have some context.","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"920a0f31d254f70afa6819e3bdbc7451da5b743d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_849c73c1","line":12,"in_reply_to":"1aa78d24_497d84e6","updated":"2016-07-05 15:37:47.000000000","message":"I see examples when a callback raises an exception as mentioned in the commit message above. Why do we need the log trace? \n\nSay you have a callback bound to an event. This is method foo.\n\ndef foo(bar):\n\n    if bar is None:\n        raise(\u0027bar is not set\u0027)\n    LOG.info(\"At bar %s. Please get me a moscow mule\", bar)\n\nThe exceptions are seen when we are running load tests","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"025070fc8fca1144da25010d5f5192e3c07c4d44","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_42ed5624","line":12,"in_reply_to":"1aa78d24_6227b2b6","updated":"2016-07-05 17:25:39.000000000","message":"The notifications to BEFORE_* events are the ones meant to stop the execution path. We have access to the event in the notifier look, maybe we can skip/log differently when event starts with BEFORE_","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d4148bb334fbfeb7f96e2a7db9580987cd840376","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_55ed1324","line":12,"in_reply_to":"1aa78d24_640987dd","updated":"2016-07-05 16:09:34.000000000","message":"If an exception is explicitly raised by the callback, ie it\u0027s intentional to prevent something from happening, then I can see that the stacktrace may not help because you know where in the code it takes place, but for those that aren\u0027t? Stack traces can help debugging, so I wonder where you see the litter because there might be another issue at play.","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcaee0608f0b892857484917b9202c1d9cd99407","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_08ca4d6d","line":12,"in_reply_to":"1aa78d24_6d87a3d7","updated":"2016-07-05 18:08:08.000000000","message":"I am not sure that I follow. The problem here is that the code that we write throws exceptions and does not return error codes. The callbacks are also not defined as such. Unless I am missing something and it specifically states that a callback should return an error code - if so the code do not do any changing for that.\nWhy do we need the stack trace here? It seriously litters the log file with unnecessary traces.","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d10856ad9888e2ffa63e0bb422c8c6a9c9cd490","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is no need for a stack trace when a callback raises an"},{"line_number":10,"context_line":"exception."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This litters the log files."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_640987dd","line":12,"in_reply_to":"1aa78d24_849c73c1","updated":"2016-07-05 15:38:32.000000000","message":"In addition to this can you please elaborate why the exception trace here is important","commit_id":"baf4215c69f468ff5cadb51cc11130018c304901"}]}