)]}'
{"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4b7fd524e950a44ba049c1b00023fab67b8c0905","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                 \u0027qos_policy_id\u0027: port.get(qos_consts.QOS_POLICY_ID),"},{"line_number":126,"context_line":"                 \u0027network_qos_policy_id\u0027: network_qos_policy_id,"},{"line_number":127,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE],"},{"line_number":128,"context_line":"                 \u0027trunk_details\u0027: port.get(\u0027trunk_details\u0027)}"},{"line_number":129,"context_line":"        if \u0027security_groups\u0027 in port:"},{"line_number":130,"context_line":"            entry[\u0027security_groups\u0027] \u003d port[\u0027security_groups\u0027]"},{"line_number":131,"context_line":"        LOG.debug(\"Returning: %s\", entry)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2f0c61ec","line":128,"updated":"2016-07-06 00:40:01.000000000","message":"This is pollution.\n\nIt\u0027s bad already that other stuff that doesn\u0027t belong here ended up being here. I have clearly stated already that in lieu of a mechanism for cleanly passing this info to the agent from the core plugin, we should accept the cost of an extra call for fetching trunk information. To avoid the cost, let\u0027s figure out how to avoid this because it\u0027s clearly a code smell.","commit_id":"ce14819af9c89f149be035cdc05eb2ba532975e7"}]}