)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"cce53a5d0cfe8ac0e8fd16a19cc9a19e81bee9ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron/conf/agent/l3. This would allow centralization of all configuration"},{"line_number":11,"context_line":"options under neutron/conf and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I18e5f683690cffd6e0ad5e35f459b86c5b3332ac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_35503032","line":13,"updated":"2016-07-11 19:32:00.000000000","message":"missing bug #?","commit_id":"880ab8aa9762a9dbcaa76c458f92e8bd6bcfd597"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"68bdabfb896ef620ceba303ef4dc36c3f574fe9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aradhana Singh \u003caradhana1.singh@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-11 20:52:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring config options for l3 agent keepalived_state_change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring configuration options in neutron/agent/l3/keepalived_state_change"},{"line_number":10,"context_line":"to be in neutron/conf/agent/l3. This would allow centralization of all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_cfe2cdd4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":63},"updated":"2016-07-26 15:45:13.000000000","message":"nit: Title exceeds 50 characters","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9d0da332638e94851886c142a9eeb6cbedb2a6b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring config options for l3 agent keepalived_state_change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring configuration options in neutron/agent/l3/keepalived_state_change"},{"line_number":10,"context_line":"to be in neutron/conf/agent/l3. This would allow centralization of all"},{"line_number":11,"context_line":"configuration options under neutron/conf and provide an easy way to import."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_f31f37b5","line":9,"updated":"2016-07-22 22:18:42.000000000","message":"nit: the commit msg line is more than 72 characters","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9d0da332638e94851886c142a9eeb6cbedb2a6b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring configuration options in neutron/agent/l3/keepalived_state_change"},{"line_number":10,"context_line":"to be in neutron/conf/agent/l3. This would allow centralization of all"},{"line_number":11,"context_line":"configuration options under neutron/conf and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I18e5f683690cffd6e0ad5e35f459b86c5b3332ac"},{"line_number":14,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_137dabe7","line":11,"updated":"2016-07-22 22:18:42.000000000","message":"ditto","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"}],"neutron/conf/agent/l3/keepalived.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"cce53a5d0cfe8ac0e8fd16a19cc9a19e81bee9ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def register_cli_agent_l3_keepalived_opts(conf):"},{"line_number":43,"context_line":"    conf.register_cli_opts(CLI_OPTS)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d578ccc6","line":42,"range":{"start_line":42,"start_character":17,"end_line":42,"end_character":25},"updated":"2016-07-11 19:32:00.000000000","message":"same as my other reviews :)\n\nl3_agent","commit_id":"880ab8aa9762a9dbcaa76c458f92e8bd6bcfd597"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"cce53a5d0cfe8ac0e8fd16a19cc9a19e81bee9ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    conf.register_cli_opts(CLI_OPTS)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def register_agent_l3_keepalived_opts(conf):"},{"line_number":47,"context_line":"    conf.register_opts(OPTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b57540cc","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":21},"updated":"2016-07-11 19:32:00.000000000","message":"same","commit_id":"880ab8aa9762a9dbcaa76c458f92e8bd6bcfd597"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"90a5617c2ca730a54d7cd4771dd5630e21b267db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_35a7370c","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-07-21 19:41:54.000000000","message":"2016","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b5ad0d58f10d0ab6a20e0e7d22bc6314a7000c4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c04960d2","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_183b089e","updated":"2016-07-24 18:38:32.000000000","message":"yeah since its just moving code around, just keep it as is.  If you did change significant amounts then you would add another line (2016 company you work for)","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"33ec0da009c1a18eb76d087344b402971078cf9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5ad12f22","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_35a7370c","updated":"2016-07-21 23:10:39.000000000","message":"not sure if i can update the year, since i don\u0027t work for Red Hat Inc","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fa5bcd90a2578ec3983ae64e1c2cc693f70ea605","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_205a85f2","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_4f525d68","updated":"2016-07-26 23:59:28.000000000","message":"i believe anytime you modify the file you would add the year and or company.  however, this is not done in practice very often.","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9d0da332638e94851886c142a9eeb6cbedb2a6b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_183b089e","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_5ad12f22","updated":"2016-07-22 22:18:42.000000000","message":"As per our discussion, makes sense not to change it","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"68bdabfb896ef620ceba303ef4dc36c3f574fe9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_4f525d68","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_c04960d2","updated":"2016-07-26 15:45:13.000000000","message":"My assumption was that this year refers when this file was created","commit_id":"5a2a1b6283f9186203da41e14b2398e80a66c2c3"}],"neutron/tests/functional/agent/l3/test_keepalived_state_change.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ef14094bbb9b226f497880bed0b0349db02567e8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def tearDown(self):"},{"line_number":48,"context_line":"        super(TestKeepalivedStateChange, self).tearDown()"},{"line_number":49,"context_line":"        self.conf_fixture.conf.reset()"},{"line_number":50,"context_line":"        self.conf_fixture.conf.unregister_opts(kd.OPTS)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_parse_and_handle_event_wrong_device_completes_without_error(self):"},{"line_number":53,"context_line":"        self.monitor.parse_and_handle_event("}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1e3ff6b4","line":50,"updated":"2016-08-05 05:59:13.000000000","message":"its better to use self.addCleanup(...) in the setUp method because tearDown\u0027s won\u0027t run if the test throws an uncaught exception (cleanups will), leading to some possible false negative failures in subsequent tests.\n\n\nself.addCleanup(self.conf_fixture.conf.reset)\nself.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)","commit_id":"a4010d8f9f4ec1c1cadb7f0097e17ab7adeac87e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"18571af5cfaf832319604cc486a7f5971a46e8e9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_572b98eb","line":31,"updated":"2016-08-08 20:15:13.000000000","message":"setUp is run per test, meaning that self.conf_fixture is generated per test. There\u0027s no need to reset or unregister options.","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"840269c23b499f390a7b2da056e39cdd0f238a90","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c2f9834f","line":31,"in_reply_to":"9ad45d7e_572b98eb","updated":"2016-08-08 23:02:33.000000000","message":"when above lines are not included i see following error on jenkins gate http://paste.openstack.org/show/545224/","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"de25067ef206b0c30dbda6ecd5a57931648271d5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_a0ff2733","line":31,"in_reply_to":"9ad45d7e_c2f9834f","updated":"2016-08-09 00:09:47.000000000","message":"Regardless one issue is that you execute reset instead of pass it to the cleanup function.","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"de25067ef206b0c30dbda6ecd5a57931648271d5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_e0f91f4f","line":31,"in_reply_to":"9ad45d7e_c2f9834f","updated":"2016-08-09 00:09:47.000000000","message":"Regardless one issue is that you execute the reset function instead of pass it.","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"de25067ef206b0c30dbda6ecd5a57931648271d5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_e0a75f4d","line":31,"in_reply_to":"9ad45d7e_c2f9834f","updated":"2016-08-09 00:09:47.000000000","message":"Regardless one issue is that you execute the reset function instead of pass it.\n\nAfter you change \u0027reset()\u0027 to \u0027reset\u0027, you get this error:\noslo_config.cfg.ArgsAlreadyParsedError: arguments already parsed: reset before unregistering options\n\nThat\u0027s because cleanups are executed in reverse order of definition. You need to reverse lines 31 and 32, so that it first resets and then unregisters the options.\n\nPlease run these tests locally before submitting. There\u0027s instructions how to do that here:\nhttp://docs.openstack.org/developer/neutron/devref/development.environment.html#id2\n\nAfter these two changes the tests ran fine. I then commented out these two lines and ran:\ntox -e dsvm-functional test_parse_and_handle_event_writes_to_file\\|test_create_subnet_with_dhcp\n\nAnd it passed fine, I didn\u0027t get the duplicate opt error. Can you expand on the issue you were seeing?","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"61efffab96e87860d8f832567a4964495fb26bc7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_5545ddb0","line":31,"in_reply_to":"9ad45d7e_e0a75f4d","updated":"2016-08-10 16:45:11.000000000","message":"thank you Assaf for the detailed explanation, \nI have removed addCleanup methods to check if Jenkins gives me same error because of which  I added cleanup method.\nAs far I recollect  duplicate error was on  https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/test_dhcp_agent.py#L62,\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/dhcp_agent.py#L31\nbecause both  metadata_proxy_socket opt are https://github.com/openstack/neutron/blob/master/neutron/agent/metadata/config.py#L22\nand https://github.com/openstack/neutron/blob/master/neutron/agent/l3/keepalived_state_change.py#L120.","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"61efffab96e87860d8f832567a4964495fb26bc7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.addCleanup(self.conf_fixture.conf.reset())"},{"line_number":32,"context_line":"        self.addCleanup(self.conf_fixture.conf.unregister_opts, kd.OPTS)"},{"line_number":33,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":34,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_3570290b","line":31,"in_reply_to":"9ad45d7e_e0f91f4f","updated":"2016-08-10 16:45:11.000000000","message":"Done","commit_id":"7bee7f58ea89a81edae2bebf824f4559f96ed28e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"be41d1c10bf5bfd31604418951de545db9c8297a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":32,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"},{"line_number":33,"context_line":"        self.cidr \u003d \u0027169.254.128.1/24\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_929bd917","line":30,"updated":"2016-08-10 23:39:09.000000000","message":"I looked at oslo_config\u0027s Config fixture:\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/fixture.py#L24\n\nTurns out that instantiating a Config() object uses the global cfg.CONF object, instead of generating a local oslo_config.cfg.ConfigOpts instance. This means that different tests actually use the same ConfigOpts instance (cfg.CONF global). We do reset the global conf option on test cleanup here https://github.com/openstack/neutron/blob/master/neutron/tests/base.py#L288, but we don\u0027t unregister all options (reset removes values, defaults and overrides but not the registration of options).\n\nCheck out:\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/fixture.py#L86\n\nWhat\u0027s happening is that register_l3_agent_keepalived_opts calls the base cfg.CONF.register_opt, and doesn\u0027t use oslo_config.fixture\u0027s implementation that I linked just above.\n\nThere\u0027s many ways to fix this, the easiest of which is to edit line 30 to send \u0027self.conf_fixture\u0027 to the method, instead of \u0027self.conf_fixture.conf\u0027.\n\nFYI the easiest way I found to reproduce locally is:\ntox -e dsvm-functional DHCPAgentOVSTestCase\\|TestKeepalivedStateChange\n\nI can confirm that my suggestion above fixes the issue.\n\nWe may want to follow up with a solution that will prevent this waste of time in the future. For example, by making sure that each test uses a local copy of oslo_config.cfg.ConfigOpts, and for insurance, unregistering all options to the global cfg.CONF in neutron.tests.base.","commit_id":"2cab2afee0d5c820e77ce64c41930451e5903bfa"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"55b57d28b08eb1ca17e0c0db5ada3a35b420b101","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestKeepalivedStateChange, self).setUp()"},{"line_number":29,"context_line":"        self.conf_fixture \u003d self.useFixture(fixture_config.Config())"},{"line_number":30,"context_line":"        kd.register_l3_agent_keepalived_opts(self.conf_fixture.conf)"},{"line_number":31,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":32,"context_line":"        self.conf_dir \u003d self.get_default_temp_dir().path"},{"line_number":33,"context_line":"        self.cidr \u003d \u0027169.254.128.1/24\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_38df2c3b","line":30,"in_reply_to":"9ad45d7e_929bd917","updated":"2016-08-11 22:51:46.000000000","message":"Done,\nStill working on the followup patch","commit_id":"2cab2afee0d5c820e77ce64c41930451e5903bfa"}]}
