)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"807979de37685b2ae7f146ae2c065c950b989fd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactoring config options for l3 agent config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring neutron configuration options for l3 agent to be in"},{"line_number":10,"context_line":"neutron/conf/agent/l3. This would allow centralization of all configuration"},{"line_number":11,"context_line":"options in neutron/conf and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie7533ea55eaa4d0f2c1919131a75f56e027c4d6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_4ca7cb0a","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":75},"updated":"2016-07-21 17:05:26.000000000","message":"nit: this exceeds the limits of the characters for the description","commit_id":"25cd922009e9e6803f25454d49bfbce41a1c5df5"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"8139bdd83814ece5822bd07c8fa35af5edf9d6a6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# neutron.agent.l3.config to neutron.conf.agent.l3.config."},{"line_number":19,"context_line":"# neutron-fwaas/cmd/eventlet/agents/fw.py imports neutron.agent.l3.config"},{"line_number":20,"context_line":"# This file will be removed when neutron-fwaas imports the updated file"},{"line_number":21,"context_line":"# https://review.openstack.org/#/c/339177/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b56b801d","line":21,"updated":"2016-07-11 19:28:33.000000000","message":"I put comments on the fwaas review and I believe if you just use the Depends-On directive on that review\u0027s commit, you\u0027ll be able to remove this file in this review too.  I\u0027d like to test that out first though.  If you could add the Depends-On directive in the fwaas review and then push up another PS to this review with this file, then we can see if it this works or if it blows everything up.","commit_id":"25155a4b56ce38eb94dcf02dfc8e6456f664182f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"1a55d386e8f8e66fa09097372763b78eefd215ff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.common import constants"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027agent_mode\u0027, default\u003dconstants.L3_AGENT_MODE_LEGACY,"},{"line_number":32,"context_line":"               choices\u003d(constants.L3_AGENT_MODE_DVR,"},{"line_number":33,"context_line":"                        constants.L3_AGENT_MODE_DVR_SNAT,"},{"line_number":34,"context_line":"                        constants.L3_AGENT_MODE_LEGACY),"},{"line_number":35,"context_line":"               help\u003d_(\"The working mode for the agent. Allowed modes are: \""},{"line_number":36,"context_line":"                      \"\u0027legacy\u0027 - this preserves the existing behavior \""},{"line_number":37,"context_line":"                      \"where the L3 agent is deployed on a centralized \""},{"line_number":38,"context_line":"                      \"networking node to provide L3 services like DNAT, \""},{"line_number":39,"context_line":"                      \"and SNAT. Use this mode if you do not want to \""},{"line_number":40,"context_line":"                      \"adopt DVR. \u0027dvr\u0027 - this mode enables DVR \""},{"line_number":41,"context_line":"                      \"functionality and must be used for an L3 agent \""},{"line_number":42,"context_line":"                      \"that runs on a compute host. \u0027dvr_snat\u0027 - this \""},{"line_number":43,"context_line":"                      \"enables centralized SNAT support in conjunction \""},{"line_number":44,"context_line":"                      \"with DVR.  This mode must be used for an L3 agent \""},{"line_number":45,"context_line":"                      \"running on a centralized node (or in single-host \""},{"line_number":46,"context_line":"                      \"deployments, e.g. devstack)\")),"},{"line_number":47,"context_line":"    cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":48,"context_line":"                default\u003d9697,"},{"line_number":49,"context_line":"                help\u003d_(\"TCP Port used by Neutron metadata namespace proxy.\")),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027send_arp_for_ha\u0027,"},{"line_number":51,"context_line":"               default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"Send this many gratuitous ARPs for HA setup, if \""},{"line_number":53,"context_line":"                      \"less than or equal to 0, the feature is disabled\")),"},{"line_number":54,"context_line":"    cfg.BoolOpt(\u0027handle_internal_only_routers\u0027,"},{"line_number":55,"context_line":"                default\u003dTrue,"},{"line_number":56,"context_line":"                help\u003d_(\"Indicates that this L3 agent should also handle \""},{"line_number":57,"context_line":"                       \"routers that do not have an external network gateway \""},{"line_number":58,"context_line":"                       \"configured. This option should be True only for a \""},{"line_number":59,"context_line":"                       \"single agent in a Neutron deployment, and may be \""},{"line_number":60,"context_line":"                       \"False for all agents if all routers must have an \""},{"line_number":61,"context_line":"                       \"external network gateway.\")),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":63,"context_line":"               help\u003d_(\"When external_network_bridge is set, each L3 agent can \""},{"line_number":64,"context_line":"                      \"be associated with no more than one external network. \""},{"line_number":65,"context_line":"                      \"This value should be set to the UUID of that external \""},{"line_number":66,"context_line":"                      \"network. To allow L3 agent support multiple external \""},{"line_number":67,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":68,"context_line":"                      \"gateway_external_network_id must be left empty.\")),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027ipv6_gateway\u0027, default\u003d\u0027\u0027,"},{"line_number":70,"context_line":"               help\u003d_(\"With IPv6, the network used for the external gateway \""},{"line_number":71,"context_line":"                      \"does not need to have an associated subnet, since the \""},{"line_number":72,"context_line":"                      \"automatically assigned link-local address (LLA) can \""},{"line_number":73,"context_line":"                      \"be used. However, an IPv6 gateway address is needed \""},{"line_number":74,"context_line":"                      \"for use as the next-hop for the default route. \""},{"line_number":75,"context_line":"                      \"If no IPv6 gateway address is configured here, \""},{"line_number":76,"context_line":"                      \"(and only then) the neutron router will be configured \""},{"line_number":77,"context_line":"                      \"to get its default route from router advertisements \""},{"line_number":78,"context_line":"                      \"(RAs) from the upstream router; in which case the \""},{"line_number":79,"context_line":"                      \"upstream router must also be configured to send \""},{"line_number":80,"context_line":"                      \"these RAs. \""},{"line_number":81,"context_line":"                      \"The ipv6_gateway, when configured, should be the LLA \""},{"line_number":82,"context_line":"                      \"of the interface on the upstream router. If a \""},{"line_number":83,"context_line":"                      \"next-hop using a global unique address (GUA) is \""},{"line_number":84,"context_line":"                      \"desired, it needs to be done via a subnet allocated \""},{"line_number":85,"context_line":"                      \"to the network and not through this parameter. \")),"},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027prefix_delegation_driver\u0027,"},{"line_number":87,"context_line":"               default\u003d\u0027dibbler\u0027,"},{"line_number":88,"context_line":"               help\u003d_(\u0027Driver used for ipv6 prefix delegation. This needs to \u0027"},{"line_number":89,"context_line":"                      \u0027be an entry point defined in the \u0027"},{"line_number":90,"context_line":"                      \u0027neutron.agent.linux.pd_drivers namespace. See \u0027"},{"line_number":91,"context_line":"                      \u0027setup.cfg for entry points included with the neutron \u0027"},{"line_number":92,"context_line":"                      \u0027source.\u0027)),"},{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027enable_metadata_proxy\u0027, default\u003dTrue,"},{"line_number":94,"context_line":"                help\u003d_(\"Allow running metadata proxy.\")),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027metadata_access_mark\u0027,"},{"line_number":96,"context_line":"               default\u003d\u00270x1\u0027,"},{"line_number":97,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark metadata valid \u0027"},{"line_number":98,"context_line":"                      \u0027requests. This mark will be masked with 0xffff so \u0027"},{"line_number":99,"context_line":"                      \u0027that only the lower 16 bits will be used.\u0027)),"},{"line_number":100,"context_line":"    cfg.StrOpt(\u0027external_ingress_mark\u0027,"},{"line_number":101,"context_line":"               default\u003d\u00270x2\u0027,"},{"line_number":102,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":103,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":104,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":105,"context_line":"]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_7fc96079","line":107,"range":{"start_line":30,"start_character":0,"end_line":107,"end_character":34},"updated":"2016-07-14 06:12:17.000000000","message":"would be best to replace all of this with just:\n\nOPTS \u003d neutron.conf.agent.l3.config.OPTS\n\nObviously with better import :)\n\nThis is just to avoid duplicate defining and registering of the same options.","commit_id":"2f863e1b9f25df87a2be2ad55e97820ec8dfdd38"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fd59986780bc5f9010a167718c8e64c64d48a12c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPTS \u003d neutron.conf.agent.l3.config.OPTS"},{"line_number":28,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_26d050c9","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":34},"updated":"2016-07-14 19:30:41.000000000","message":"this line already gets executed in the new config file, so L27 will already have this config option added to OPTS.  No need to do it again.","commit_id":"c5ba82f9ae2fc894d6bc8bfb74a7debca69c100a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"807979de37685b2ae7f146ae2c065c950b989fd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_cc145bea","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":20},"updated":"2016-07-21 17:05:26.000000000","message":"nit: s/2015/2016","commit_id":"25cd922009e9e6803f25454d49bfbce41a1c5df5"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"1f1b791c8dab864504856b68ee7190cd3b02f677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_00bc186b","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_3ca44406","updated":"2016-07-24 18:40:27.000000000","message":"since you\u0027re just moving code around, don\u0027t change it","commit_id":"25cd922009e9e6803f25454d49bfbce41a1c5df5"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"70b0303781d58375c63b8b542ff2cc2e417470dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_3ca44406","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":20},"in_reply_to":"dada55a8_cc145bea","updated":"2016-07-21 18:28:23.000000000","message":"not sure if i should change this, since i don\u0027t work for OpenStack Foundation","commit_id":"25cd922009e9e6803f25454d49bfbce41a1c5df5"}],"neutron/conf/agent/l3/config.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"8139bdd83814ece5822bd07c8fa35af5edf9d6a6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def register_agent_l3_config_opts(opts, cfg\u003dcfg.CONF):"},{"line_number":105,"context_line":"    cfg.register_opts(opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_75d3d8d5","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":21},"updated":"2016-07-11 19:28:33.000000000","message":"just like the dhcp one, l3_agent makes more sense.  I know why you\u0027ve done it this way though.","commit_id":"25155a4b56ce38eb94dcf02dfc8e6456f664182f"}]}