)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f7e5ebd0a37d17b00c12cdd508ec20ec38ec9af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 12:21:53 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM: Test subport validator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaa67235cd021542d5cc5676366b3c0a1ecb49bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_c1dffb0a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-07-07 19:47:58.000000000","message":"IMO this can be merged.","commit_id":"902558795727c529c4ef68fab4c791ad3da37792"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e0ecb1487d5420fe524c46eedd544e6a2aac6613","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 12:21:53 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM: Test subport validator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaa67235cd021542d5cc5676366b3c0a1ecb49bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_970a51d0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"1aa78d24_c1dffb0a","updated":"2016-07-07 20:28:55.000000000","message":"sure, it\u0027s gonna get ripped out before Newton though.","commit_id":"902558795727c529c4ef68fab4c791ad3da37792"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"948e2913798b6e36c9e0eea2b0a7d8b937d0351b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Temporarily pull changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-on: I56a66dab2393cdc43db916f6d8417361e3df6275"},{"line_number":12,"context_line":"Change-Id: Iaa67235cd021542d5cc5676366b3c0a1ecb49bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_31d0c8f7","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2016-07-07 21:31:25.000000000","message":"Not needed.","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5be41b349e37bd15389c5501e3a9ac5265ae4b48","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Temporarily pull changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-on: I56a66dab2393cdc43db916f6d8417361e3df6275"},{"line_number":12,"context_line":"Change-Id: Iaa67235cd021542d5cc5676366b3c0a1ecb49bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_514ab4ad","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"1aa78d24_31d0c8f7","updated":"2016-07-07 21:34:28.000000000","message":"buuuuu, you don\u0027t like me anymore!","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"}],"neutron/extensions/trunk.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"21ccaa86cd3b0c656e383570f689378b4b916fa7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# TODO(armax): this validator was introduced in neutron-lib in"},{"line_number":32,"context_line":"# https://review.openstack.org/#/c/319386/; remove it as soon"},{"line_number":33,"context_line":"# as there is a new release."},{"line_number":34,"context_line":"def validate_subports(data, valid_values\u003dNone):"},{"line_number":35,"context_line":"    if not isinstance(data, list):"},{"line_number":36,"context_line":"        msg \u003d _(\"Invalid data format for subports: \u0027%s\u0027 is not a list\") % data"},{"line_number":37,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a348b788","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"updated":"2016-07-08 20:13:09.000000000","message":"You should change this to a private method (stick an underscore in front) so that it is not inadvertently picked up by any external project before we delete it.","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"55b0f4d5b4a91dea28bd2be91b0b511c63982495","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# TODO(armax): this validator was introduced in neutron-lib in"},{"line_number":32,"context_line":"# https://review.openstack.org/#/c/319386/; remove it as soon"},{"line_number":33,"context_line":"# as there is a new release."},{"line_number":34,"context_line":"def validate_subports(data, valid_values\u003dNone):"},{"line_number":35,"context_line":"    if not isinstance(data, list):"},{"line_number":36,"context_line":"        msg \u003d _(\"Invalid data format for subports: \u0027%s\u0027 is not a list\") % data"},{"line_number":37,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_aab50dd1","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"in_reply_to":"1aa78d24_12b74af6","updated":"2016-07-10 17:51:20.000000000","message":"It seems that this change is dependant on the neutron-lib change. Ideally we would like people to use the neutron lib code. Can you please mark this method as depreacted and have a deprecation warning that people should use the neutron-lib implementation","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2fbb46aa7fe4fee6d89109d633190f7430e9e89e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# TODO(armax): this validator was introduced in neutron-lib in"},{"line_number":32,"context_line":"# https://review.openstack.org/#/c/319386/; remove it as soon"},{"line_number":33,"context_line":"# as there is a new release."},{"line_number":34,"context_line":"def validate_subports(data, valid_values\u003dNone):"},{"line_number":35,"context_line":"    if not isinstance(data, list):"},{"line_number":36,"context_line":"        msg \u003d _(\"Invalid data format for subports: \u0027%s\u0027 is not a list\") % data"},{"line_number":37,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_12b74af6","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"in_reply_to":"1aa78d24_3477db03","updated":"2016-07-09 03:08:50.000000000","message":"Alright, fine, let\u0027s hope the non-morons read the comment.","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ed3d24a22a1397c9fee318c974940bb7d352a1a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# TODO(armax): this validator was introduced in neutron-lib in"},{"line_number":32,"context_line":"# https://review.openstack.org/#/c/319386/; remove it as soon"},{"line_number":33,"context_line":"# as there is a new release."},{"line_number":34,"context_line":"def validate_subports(data, valid_values\u003dNone):"},{"line_number":35,"context_line":"    if not isinstance(data, list):"},{"line_number":36,"context_line":"        msg \u003d _(\"Invalid data format for subports: \u0027%s\u0027 is not a list\") % data"},{"line_number":37,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3477db03","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"in_reply_to":"1aa78d24_a348b788","updated":"2016-07-08 21:21:56.000000000","message":"Come on, that\u0027s nitpicking, when has that stopped morons to use private methods before?","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf2b2a127f96c6daf1faabeefee3b088b85aa99b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# TODO(armax): this validator was introduced in neutron-lib in"},{"line_number":32,"context_line":"# https://review.openstack.org/#/c/319386/; remove it as soon"},{"line_number":33,"context_line":"# as there is a new release."},{"line_number":34,"context_line":"def validate_subports(data, valid_values\u003dNone):"},{"line_number":35,"context_line":"    if not isinstance(data, list):"},{"line_number":36,"context_line":"        msg \u003d _(\"Invalid data format for subports: \u0027%s\u0027 is not a list\") % data"},{"line_number":37,"context_line":"        LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0bb82b29","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"in_reply_to":"1aa78d24_aab50dd1","updated":"2016-07-13 00:49:35.000000000","message":"this is like shooting a fly with a bazooka. Deprecation is not needed because no-one is using this code, because this is not released yet [1]. If someone is pulling it from source they are perpetrating the bad habit of importing from neutron even with new code and they deserve to get stung :)\n\n[1] http://codesearch.openstack.org/?q\u003dvalidate_subports\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"ee16137fe04c69699ea4065917dce1fedea7c261"}]}