)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ed064d1f7a5f73c47c47e4d1446a63b5d40d3927","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Implement L3 Agent Extension Manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the generalized agent extension mechanism, create an agent extension"},{"line_number":10,"context_line":"manager in the L3 agent, so that the L3 agent can load agent extensions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":13,"context_line":"Depends-On: I9380343c09d28eec67077c9e6d77c33a195e516b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_2becba8e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":72},"updated":"2016-07-08 12:46:33.000000000","message":"I think we need to reference https://blueprints.launchpad.net/neutron/+spec/l3-agent-extensions","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f97c8076b90fe6db4b72832f3300470affc6e31f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Implement L3 Agent Extension Manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the generalized agent extension mechanism, create an agent extension"},{"line_number":10,"context_line":"manager in the L3 agent, so that the L3 agent can load agent extensions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":13,"context_line":"Depends-On: I9380343c09d28eec67077c9e6d77c33a195e516b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_191bc51c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":72},"in_reply_to":"1aa78d24_2becba8e","updated":"2016-07-11 13:02:17.000000000","message":"I added \"Implements: blueprint l3-agent-extensions\" which has that effect.","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bbcbf570094c12b0171880db769b8342d9a6b331","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 18:31:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement L2 Agent Extension Manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the generalized agent extension mechanism, create an agent extension"},{"line_number":10,"context_line":"manager in the L3 agent, so that the L3 agent can load agent extensions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9ad45d7e_7bd9abf2","line":7,"updated":"2016-08-11 18:41:52.000000000","message":"s/L2/L3","commit_id":"f61acda56924868bd2f7adee12be7cd0342457ae"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9f28c30a4ec2292872577a9a776a862765743eda","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 18:31:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement L2 Agent Extension Manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the generalized agent extension mechanism, create an agent extension"},{"line_number":10,"context_line":"manager in the L3 agent, so that the L3 agent can load agent extensions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9ad45d7e_bebe71ab","line":7,"in_reply_to":"9ad45d7e_7bd9abf2","updated":"2016-08-11 18:55:59.000000000","message":"Done","commit_id":"f61acda56924868bd2f7adee12be7cd0342457ae"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1d2357539b4f9233adcd9d5f2ca75231be0f93e5","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_84c7a944","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"updated":"2016-07-27 22:27:34.000000000","message":"So, this registers \"extensions\" as a config option for the l3 agent, right? I wonder if there is any alternative that we could explore. I imagine that something like fwaas will have a server side component. I wonder if we could avoid having to set this config on all of the L3 agents if the server side could somehow specify that a particular extension should be loaded.\n\nI don\u0027t know, I\u0027m just thinking out loud here trying to minimize the amount of config that the operator needs to perform. What are your thoughts?","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5aa66227e9ebe104e9213355f4f148198dd7eb95","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_600cb83b","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"9ad45d7e_65127364","updated":"2016-08-10 10:30:46.000000000","message":"Yes yes, of course, sorry for not making that clear, I was thinking of a separate change, even on a separate release. It needs thought.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"49f3186a100aaf596d02ec4f5d405cc1728a27f1","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_65127364","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_1284f308","updated":"2016-08-08 16:16:55.000000000","message":"@ajo: I think that is a great idea, but probably something that should be addressed in a separate change.  Does stevedore support dynamic extension load/unload?  I have only used it in a scenario where extensions to load were determined at boot.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"902f7752d59f662d5988af179c6a19d2a12a991a","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_6d6eaa97","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_3aafc695","updated":"2016-07-28 16:54:48.000000000","message":"Thank you Carl.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e974a5351781316e0b7d6e13b679ecd23cc39675","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_1284f308","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_6d6eaa97","updated":"2016-08-05 13:35:16.000000000","message":"I was thinking about this on the context of the L2 extensions.\n\nI believe that we should make specific services declare the need for an L2 agent or L3 agent extension, and that would make the agent pull in the extension where available at boot.\n\nPlease note there could be ordering issues here, where you add a service to your server, and your agents were already running. We could fanout the new list of needed extensions, and let the agents decide if they print warnings, add/remove the extension in runtime, restart, etc...\n\nThis could be easily done by exposing a new type of in-memory-only object via the rpc_callback interface\n\nRequiredAgentExtensions(neutronobject):\n    id \u003d \u0027l3\u0027 or \u0027l2\u0027\n    extensions \u003d [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]\n\n\nThe agent could pull(REQUIRED_AGENT_EXTENSIONS, id\u003d\u0027l3\u0027)\n\nor get a notification of that being changed.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"8755d8c13ccc62ee84e17ad06f0006ba802ab81f","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_b1b489f2","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_84c7a944","updated":"2016-07-28 14:09:46.000000000","message":"Yep, this does register \"extensions\" as a config option for the L3 agent  (https://git.openstack.org/cgit/openstack/neutron/tree/neutron/agent/agent_extensions_manager.py#n22).   \n\nYep, there\u0027s a server-side FWaaS component.  (And a server-side QoS component, to bring L2 into the mix.)  I think we want the L3 behavior to mirror the L2 behavior as closely as possible, as was the goal of https://review.openstack.org/#/c/329701, now merged.\n\nI like your idea, but would it preclude the introduction of an extension with no server-side component?","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8a5348fe2afbe55572c6920377c37e4154d5e285","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_b7baaf08","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_b1b489f2","updated":"2016-07-28 16:17:03.000000000","message":"I\u0027m not sure that we need to preclude the ability to register config options. I was just wondering if there were scenarios where we could avoid *requiring* the use of config options if extensions could somehow be registered by the server side service plugin or something.\n\nThis is somewhat of a half-baked idea, I\u0027m just thinking out loud.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"32122c14032bc945a757dd792dd6970fc026199a","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def init_extension_manager(self, connection):"},{"line_number":370,"context_line":"        l3_ext_manager.register_opts(self.conf)"},{"line_number":371,"context_line":"        self.l3_ext_manager \u003d ("},{"line_number":372,"context_line":"            l3_ext_manager.L3AgentExtensionsManager(self.conf))"},{"line_number":373,"context_line":"        self.l3_ext_manager.initialize("}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_3aafc695","line":370,"range":{"start_line":370,"start_character":23,"end_line":370,"end_character":47},"in_reply_to":"bacf61ea_b7baaf08","updated":"2016-07-28 16:35:43.000000000","message":"After some discussion with armax, I think we\u0027d like to clean this up soon but don\u0027t think it should hold up your efforts. So, this comment is no longer a -1 for me. Let\u0027s separate this idea out in to an RFE that I could write.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1d2357539b4f9233adcd9d5f2ca75231be0f93e5","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self._process_added_router(router)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            self._process_updated_router(router)"},{"line_number":433,"context_line":"        self.l3_ext_manager.handle_router(self.context, router)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def _process_added_router(self, router):"},{"line_number":436,"context_line":"        self._router_added(router[\u0027id\u0027], router)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_c4b6c13c","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":41},"updated":"2016-07-27 22:27:34.000000000","message":"Do you think we should distinguish between add and update in the extension? It might be helpful for some. At this point, we already know if it is an add or an update.\n\nI think it is pretty common to want to distinguish between the two events. If an extension wishes to do the same thing with both events then they can simply share code internally.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"c49234b8c3247054f78a3b0e604de596f36cd809","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self._process_added_router(router)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            self._process_updated_router(router)"},{"line_number":433,"context_line":"        self.l3_ext_manager.handle_router(self.context, router)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def _process_added_router(self, router):"},{"line_number":436,"context_line":"        self._router_added(router[\u0027id\u0027], router)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_8f0ee489","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":41},"in_reply_to":"bacf61ea_4db5a6ec","updated":"2016-08-01 18:43:27.000000000","message":"Split handle_router into add_router and update_router in PS11.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e974a5351781316e0b7d6e13b679ecd23cc39675","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self._process_added_router(router)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            self._process_updated_router(router)"},{"line_number":433,"context_line":"        self.l3_ext_manager.handle_router(self.context, router)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def _process_added_router(self, router):"},{"line_number":436,"context_line":"        self._router_added(router[\u0027id\u0027], router)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_86648249","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":41},"in_reply_to":"bacf61ea_4db5a6ec","updated":"2016-08-05 13:35:16.000000000","message":"add/update","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"902f7752d59f662d5988af179c6a19d2a12a991a","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self._process_added_router(router)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            self._process_updated_router(router)"},{"line_number":433,"context_line":"        self.l3_ext_manager.handle_router(self.context, router)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def _process_added_router(self, router):"},{"line_number":436,"context_line":"        self._router_added(router[\u0027id\u0027], router)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_4db5a6ec","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":41},"in_reply_to":"bacf61ea_c4b6c13c","updated":"2016-07-28 16:54:48.000000000","message":"Because it seems to me to be fairly clear that we should do this, I worry I\u0027m overlooking considerations that led us down this path in the first place.  I\u0027m pinging some others who worked on the analogous part of the QoS implementation to see if they can chime in on this one.","commit_id":"44de1d6f7eae3f1659a0de1be805ee52eb084e9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0170558cf3b9cc3fdba9368cdb773750ceeb1014","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        \"\"\"Try to delete a router and return True if successful.\"\"\""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        try:"},{"line_number":346,"context_line":"            self._router_removed(router_id)"},{"line_number":347,"context_line":"        except Exception:"},{"line_number":348,"context_line":"            LOG.exception(_LE(\u0027Error while deleting router %s\u0027), router_id)"},{"line_number":349,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_1f77bc02","line":346,"updated":"2016-08-11 18:15:55.000000000","message":"isn\u0027t THAT the right place to call to extension manager for delete?","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0170558cf3b9cc3fdba9368cdb773750ceeb1014","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                                    queue.PRIORITY_RPC,"},{"line_number":381,"context_line":"                                    action\u003dqueue.DELETE_ROUTER)"},{"line_number":382,"context_line":"        self._queue.add(update)"},{"line_number":383,"context_line":"        self.l3_ext_manager.delete_router(self.context, router_id)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":386,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_3f0a808a","line":383,"updated":"2016-08-11 18:15:55.000000000","message":"Wait, shouldn\u0027t we call it when the router deleted event is actually handled, not when it\u0027s added to the queue?","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7f82a68e46253d6567d9daa083b609a929a37444","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                                    queue.PRIORITY_RPC,"},{"line_number":381,"context_line":"                                    action\u003dqueue.DELETE_ROUTER)"},{"line_number":382,"context_line":"        self._queue.add(update)"},{"line_number":383,"context_line":"        self.l3_ext_manager.delete_router(self.context, router_id)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":386,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_db9ed761","line":383,"in_reply_to":"9ad45d7e_3f0a808a","updated":"2016-08-11 18:28:15.000000000","message":"Good point.  I can imagine an extension that would need to know when intent is expressed, but the use case for this (FWaaS) doesn\u0027t.  I\u0027ll change it, and then if it needs to be adjusted later then we can handle it at that juncture.","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"}],"neutron/agent/l3/l3_agent_extension.py":[{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ed064d1f7a5f73c47c47e4d1446a63b5d40d3927","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mellanox Technologies, Ltd"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_ac9e0d61","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":47},"updated":"2016-07-08 12:46:33.000000000","message":"Mellanox can go :)","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f97c8076b90fe6db4b72832f3300470affc6e31f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mellanox Technologies, Ltd"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_39ca011b","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":47},"in_reply_to":"1aa78d24_ac9e0d61","updated":"2016-07-11 13:02:17.000000000","message":"Done","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4231ca0a3495542e2dca681a9fb046efcf6102c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dada55a8_c3f6ee5b","line":48,"updated":"2016-07-21 16:18:46.000000000","message":"Would it be worth adding the AgentExtensionsAPI to the L3 agent? It would mean the l3 agents have access to the openflow table like the l2 agent extensions.","commit_id":"0d5eb7a2ca83d0c5549894544dc2ed4ffd735273"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7f72f3e610ee288c3c011af395f27a68ef093305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dada55a8_0950200a","line":48,"in_reply_to":"dada55a8_c3f6ee5b","updated":"2016-07-21 18:06:18.000000000","message":"Only the L2 agent manages the openflow table; since the L3 agent never touches L2 resources like that, giving that access here would not help.  So, I am not currently aware of a use-case for the AgentExtensionsAPI, so I was going to try for MVP and ship without it.  But if you know of a use case for L3 extensions to need access to an L3 agent internal like that, I am very interested to know it.","commit_id":"0d5eb7a2ca83d0c5549894544dc2ed4ffd735273"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c328450ba117d0e3ce7e70610341332dfa5288da","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @abc.abstractmethod"},{"line_number":40,"context_line":"    def update_router(self, context, data):"},{"line_number":41,"context_line":"        \"\"\"Handle agent extension for update."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        Called on router update."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3ac371cc_17300201","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":44},"updated":"2016-08-15 13:53:40.000000000","message":"A nit, but should this be \"update router for agent extension\"?\nIt seems like an unusual way to phrase it since the function name has changed from \"handle_router\".","commit_id":"93a8dc3dbe4faae6efd017105fb407d7dfca1d32"}],"neutron/agent/l3/l3_agent_extensions_manager.py":[{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ed064d1f7a5f73c47c47e4d1446a63b5d40d3927","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"L3_AGENT_EXT_MANAGER_NAMESPACE \u003d \u0027neutron.agent.l2.extensions\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9f3ecc27","line":24,"range":{"start_line":24,"start_character":48,"end_line":24,"end_character":61},"updated":"2016-07-08 12:46:33.000000000","message":"Should be l3 analogue of l2 :)","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f97c8076b90fe6db4b72832f3300470affc6e31f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"L3_AGENT_EXT_MANAGER_NAMESPACE \u003d \u0027neutron.agent.l2.extensions\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d9b01d8e","line":24,"range":{"start_line":24,"start_character":48,"end_line":24,"end_character":61},"in_reply_to":"1aa78d24_9f3ecc27","updated":"2016-07-11 13:02:17.000000000","message":"Done","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ed064d1f7a5f73c47c47e4d1446a63b5d40d3927","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class L3AgentExtensionsManager(agent_ext_manager.AgentExtensionsManager):"},{"line_number":32,"context_line":"    \"\"\"Manage l2 agent extensions.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conf):"},{"line_number":35,"context_line":"        super(L3AgentExtensionsManager, self).__init__(conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_bf4588b4","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":16},"updated":"2016-07-08 12:46:33.000000000","message":"L3 :)","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ed064d1f7a5f73c47c47e4d1446a63b5d40d3927","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(L3AgentExtensionsManager, self).__init__(conf,"},{"line_number":36,"context_line":"                L3_AGENT_EXT_MANAGER_NAMESPACE)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def handle_router(self, context, data):"},{"line_number":39,"context_line":"        \"\"\"Notify all agent extensions to handle router.\"\"\""},{"line_number":40,"context_line":"        for extension in self:"},{"line_number":41,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_7f50405f","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":22},"updated":"2016-07-08 12:46:33.000000000","message":"Should we add handle_port and delete_port at this time?","commit_id":"7a9343fcbd5c08c85256eed54312b54bbad3b66a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21c0387db4f86b177f52d93e8e290e03187b3fcc","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def add_router(self, context, data):"},{"line_number":39,"context_line":"        \"\"\"Notify all agent extensions to add router.\"\"\""},{"line_number":40,"context_line":"        for extension in self:"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_1f125257","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":29},"updated":"2016-08-10 22:54:51.000000000","message":"aside: This construct now strikes me as very strange. I know I\u0027ve reviewed it before but it struck me differently this time. Why would I think of iterating over the manager itself to get the extensions. I think self.get_extensions() would be much more intuitive. But, it looks like this is a stevedore thing. It looks like stevedore has some interesting \"convenience\" features that I find odd like this.\n\nDon\u0027t change anything now. I\u0027m just commenting.","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2cc43c13e3d2996fb1f47b9e71d5761cd883a7e1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"},{"line_number":44,"context_line":"                LOG.exception("},{"line_number":45,"context_line":"                    _LE(\"Agent Extension \u0027%(name)s\u0027 failed \""},{"line_number":46,"context_line":"                        \"while handling router add\"),"},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ac969e8_41a01191","line":44,"updated":"2016-08-13 05:02:44.000000000","message":"is logging at exception level really appropriate here? I wonder if this is not just gonna litter the log for no good reason.","commit_id":"22471fdeb94bd9863e5b426164aeea7555cbdd1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b7786a8e735dfa8324376d525a303d9b4ded71ca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"},{"line_number":44,"context_line":"                LOG.exception("},{"line_number":45,"context_line":"                    _LE(\"Agent Extension \u0027%(name)s\u0027 failed \""},{"line_number":46,"context_line":"                        \"while handling router add\"),"},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"}],"source_content_type":"text/x-python","patch_set":15,"id":"5ac665da_65772603","line":44,"in_reply_to":"5ac665da_0510f24d","updated":"2016-08-13 16:57:23.000000000","message":"This is not an excepted scenario, all extensions should implement the symbol. That said, it\u0027s probably too broad to catch it that way, because the exception can be raised by any other code inside the handler. If anything, we should raise only if not hasattr(...).","commit_id":"22471fdeb94bd9863e5b426164aeea7555cbdd1c"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b87fce367c3d2aa626370717cfbe40c7f476905f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"},{"line_number":44,"context_line":"                LOG.exception("},{"line_number":45,"context_line":"                    _LE(\"Agent Extension \u0027%(name)s\u0027 failed \""},{"line_number":46,"context_line":"                        \"while handling router add\"),"},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_9878c591","line":44,"in_reply_to":"5ac665da_65772603","updated":"2016-08-14 03:42:05.000000000","message":"I changed the logic to \"if not hasattr(...)\", and reduced the severity to error.  I introduced a complementary change for L2 agent extensions, here: https://review.openstack.org/355220","commit_id":"22471fdeb94bd9863e5b426164aeea7555cbdd1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65d57626a7053a3e04e1211faede66d419a1dcf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"},{"line_number":44,"context_line":"                LOG.exception("},{"line_number":45,"context_line":"                    _LE(\"Agent Extension \u0027%(name)s\u0027 failed \""},{"line_number":46,"context_line":"                        \"while handling router add\"),"},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ac969e8_b7edc727","line":44,"in_reply_to":"7ac969e8_41a01191","updated":"2016-08-13 07:39:10.000000000","message":"That will happen if extension does not conform the interface. We should have some way of notifying developers, but maybe logging an error for ops is not the right way. How do we handle such cases?\n\nbtw I think we do the same for l2 agent extensions, so if we decide to change, we should follow up there too.","commit_id":"22471fdeb94bd9863e5b426164aeea7555cbdd1c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"aa96214b984eba3661ec9eabe333f640ebc5c24d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                extension.obj.handle_router(context, data)"},{"line_number":43,"context_line":"            except AttributeError:"},{"line_number":44,"context_line":"                LOG.exception("},{"line_number":45,"context_line":"                    _LE(\"Agent Extension \u0027%(name)s\u0027 failed \""},{"line_number":46,"context_line":"                        \"while handling router add\"),"},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"}],"source_content_type":"text/x-python","patch_set":15,"id":"5ac665da_0510f24d","line":44,"in_reply_to":"7ac969e8_b7edc727","updated":"2016-08-13 15:35:56.000000000","message":"If this is an expected scenario, then we should not log at exception level, and perhaps we should not log at all. Of all the exceptions AttributeError is perhaps the least useful of all.","commit_id":"22471fdeb94bd9863e5b426164aeea7555cbdd1c"}],"releasenotes/notes/l3-agent-extensions-b348ff26aec0fe88.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0170558cf3b9cc3fdba9368cdb773750ceeb1014","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ad45d7e_9fe72cab","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":18},"updated":"2016-08-11 18:15:55.000000000","message":"L3","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"c68526b46cc50911cbdd91c03f9fdb76c88b4c5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ad45d7e_5efdb56c","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":18},"in_reply_to":"9ad45d7e_9fe72cab","updated":"2016-08-11 18:57:44.000000000","message":"Done","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"b00c3c9e1acf2c91fb6a427de2f56d5191aa1cbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ad45d7e_ee705774","line":5,"range":{"start_line":4,"start_character":22,"end_line":5,"end_character":24},"updated":"2016-08-11 11:47:05.000000000","message":"Suggest something like: \"which allows other services to be integrated without additional agent changes.\"","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21c0387db4f86b177f52d93e8e290e03187b3fcc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ad45d7e_7f18ae1e","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"updated":"2016-08-10 22:54:51.000000000","message":"nit: Take care of the whitespace at the end of the line.","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"c68526b46cc50911cbdd91c03f9fdb76c88b4c5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ad45d7e_9e428dac","line":5,"range":{"start_line":4,"start_character":22,"end_line":5,"end_character":24},"in_reply_to":"9ad45d7e_ee705774","updated":"2016-08-11 18:57:44.000000000","message":"Done","commit_id":"9102147b3666038aedf089b90885af3a2f40919c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bbcbf570094c12b0171880db769b8342d9a6b331","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ad45d7e_1b4d0f9a","line":5,"updated":"2016-08-11 18:41:52.000000000","message":"trailing whitespace here and L3","commit_id":"f61acda56924868bd2f7adee12be7cd0342457ae"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9f28c30a4ec2292872577a9a776a862765743eda","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron l3 agent now has the ability to load "},{"line_number":4,"context_line":"    agent extensions, which allow other services the"},{"line_number":5,"context_line":"    ability to integrate.  "}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ad45d7e_1ee05dcc","line":5,"in_reply_to":"9ad45d7e_1b4d0f9a","updated":"2016-08-11 18:55:59.000000000","message":"Done","commit_id":"f61acda56924868bd2f7adee12be7cd0342457ae"}]}
