)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b13fda93bdec188415f39af50b53da89bc16f0dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc5a9ab268578c243ef13f7e0041bacd6c0c410b"},{"line_number":14,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3a71b18c_c99b7771","line":14,"updated":"2016-12-07 17:11:18.000000000","message":"Needed-By: Ibc5a9ab268578c243ef13f7e0041bacd6c0c410b","commit_id":"1ec17571840503cacec34ed4e8473926ae68c26b"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"bbc65997621b4f4c19a6f70dbe50ab92af4de373","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc5a9ab268578c243ef13f7e0041bacd6c0c410b"},{"line_number":14,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3a71b18c_37c995ad","line":14,"in_reply_to":"3a71b18c_c99b7771","updated":"2016-12-07 22:16:52.000000000","message":"Done","commit_id":"1ec17571840503cacec34ed4e8473926ae68c26b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f538c3e556e932f2b8462aa6ce0cddbca55cad5d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Refactoring neutron ml2 config opts to be in neutron/conf/plugins/ml2."},{"line_number":10,"context_line":"This would allow centralization of all configuration options and"},{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc5a9ab268578c243ef13f7e0041bacd6c0c410b"},{"line_number":14,"context_line":"Partial-Bug: #1563069"},{"line_number":15,"context_line":"Needed-By: Id0a97dda7718f06e33b2d30ce01cdcb3e9a46f7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3a71b18c_b721f7fe","line":12,"updated":"2016-12-08 19:01:57.000000000","message":"I just learned about NeutronLibImpact message that will flag this patch as something that could break other projects.  Could you add it here?","commit_id":"37daad4319545eb1142ab92b507f9cf101b32a58"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"abb03558fca8e5c1f994ebedc1e129605c58535c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Refactoring neutron ml2 config opts to be in neutron/conf/plugins/ml2."},{"line_number":10,"context_line":"This would allow centralization of all configuration options and"},{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc5a9ab268578c243ef13f7e0041bacd6c0c410b"},{"line_number":14,"context_line":"Partial-Bug: #1563069"},{"line_number":15,"context_line":"Needed-By: Id0a97dda7718f06e33b2d30ce01cdcb3e9a46f7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3a71b18c_72b76df5","line":12,"in_reply_to":"3a71b18c_b721f7fe","updated":"2016-12-08 19:24:27.000000000","message":"Done","commit_id":"37daad4319545eb1142ab92b507f9cf101b32a58"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4fb25017fe9172f3f5b34242499841edce9fda4a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring config options for ml2 config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring neutron ml2 config opts to be in neutron/conf/plugins/ml2."},{"line_number":10,"context_line":"This would allow centralization of all configuration options and"},{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"ffe62b97_da19fb21","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":70},"updated":"2017-03-29 22:35:48.000000000","message":"IMHO, this seems redundant with the title","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7331bd6c12f61a1d54c3ce75cbc37b9ccbc17fca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring config options for ml2 config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring neutron ml2 config opts to be in neutron/conf/plugins/ml2."},{"line_number":10,"context_line":"This would allow centralization of all configuration options and"},{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"bff0334d_0a85bcad","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":70},"in_reply_to":"dfeb2761_973753e4","updated":"2017-04-05 16:25:26.000000000","message":"Maybe something like:\n\nMoving ml2 config opts in neutron/conf/plugins/ml2 will allow have all the configuration options in a single place and improve the way to import them.","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"44b2422455ebadd5f61f78298e4b6be5de44484f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring config options for ml2 config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring neutron ml2 config opts to be in neutron/conf/plugins/ml2."},{"line_number":10,"context_line":"This would allow centralization of all configuration options and"},{"line_number":11,"context_line":"provides an easy way to import."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"dfeb2761_973753e4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":70},"in_reply_to":"ffe62b97_da19fb21","updated":"2017-04-03 20:46:34.000000000","message":"Yeah, its similar, what would you suggest ? Will include it in next patch.","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"}],"neutron/conf/plugins/ml2/config.py":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"45913ad560ede773f50a0ea4bc5ecb1e08e7195a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugins_opts(opts, plugin_group, cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(opts, plugin_group)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_43e3d2a3","line":73,"range":{"start_line":73,"start_character":28,"end_line":73,"end_character":40},"updated":"2016-08-15 17:03:23.000000000","message":"Since \"ml2\" is the only group being registered, can\u0027t we do:\ncfg.register_opts(opts, ml2) instead of sending additional parameter during the function call? Same for opts: can directly use ml2_opts.","commit_id":"eb0a2c287e316697f86407b1f8e3d8dd2bb21d23"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a5b9c1f9962ce78b079ceddb9d21d300aeee9ad7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugins_opts(cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(ml2_opts, \"ml2\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_3bbfa0fc","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":24},"updated":"2016-09-22 22:47:34.000000000","message":"this shoudl be plugin, not plugins.  kind of a nit but not.  reads oddly.","commit_id":"8dbeafb8a1a2aae4e36532f8baf90f03d8e8bcf0"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"dd662cb6520e34c96c0a63580b9a2e22d998a667","unresolved":false,"context_lines":[{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugins_opts(cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(ml2_opts, \"ml2\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_0708902b","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":24},"in_reply_to":"5a8bc5a2_3bbfa0fc","updated":"2016-09-23 21:40:32.000000000","message":"Done","commit_id":"8dbeafb8a1a2aae4e36532f8baf90f03d8e8bcf0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4fb25017fe9172f3f5b34242499841edce9fda4a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugin_opts(cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(ml2_opts, \"ml2\")"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_9a97f3ec","line":72,"updated":"2017-03-29 22:35:48.000000000","message":"Quick question about centralize configuration, Maybe it\u0027s documented but what is the reason behind changing this behavior, it\u0027s to avoid circular imports?","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7331bd6c12f61a1d54c3ce75cbc37b9ccbc17fca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugin_opts(cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(ml2_opts, \"ml2\")"}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_3d18c87f","line":72,"in_reply_to":"dfeb2761_74084d2b","updated":"2017-04-05 16:25:26.000000000","message":"Thanks","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"44b2422455ebadd5f61f78298e4b6be5de44484f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_ml2_plugin_opts(cfg\u003dcfg.CONF):"},{"line_number":73,"context_line":"    cfg.register_opts(ml2_opts, \"ml2\")"}],"source_content_type":"text/x-python","patch_set":37,"id":"dfeb2761_74084d2b","line":72,"in_reply_to":"ffe62b97_9a97f3ec","updated":"2017-04-03 20:46:34.000000000","message":"yes , it was done to avoid circular imports. Now the registration is being done in neutron/plugins/ml2/managers.py [1]\n\n[1] https://review.openstack.org/#/c/340228/37/neutron/plugins/ml2/managers.py","commit_id":"e1ddf36363705dcae52b3ca4af389a3c6f63323e"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"11ef2d4112cd0cf437efd9a452b825d318ae6008","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def __init__(self):"},{"line_number":47,"context_line":"        # Mapping from type name to DriverManager"},{"line_number":48,"context_line":"        self.drivers \u003d {}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(_LI(\"Configured type driver names: %s\"),"},{"line_number":51,"context_line":"                 cfg.CONF.ml2.type_drivers)"},{"line_number":52,"context_line":"        super(TypeManager, self).__init__(\u0027neutron.ml2.type_drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_f4911848","side":"PARENT","line":49,"updated":"2016-08-24 08:08:53.000000000","message":"nit: no related change.","commit_id":"1b19d06e7be5cd8a84fb7d0d834ed9bb04234103"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"a36fc5be8c9f489624d4641ff87c95a052d30ff9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def __init__(self):"},{"line_number":47,"context_line":"        # Mapping from type name to DriverManager"},{"line_number":48,"context_line":"        self.drivers \u003d {}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(_LI(\"Configured type driver names: %s\"),"},{"line_number":51,"context_line":"                 cfg.CONF.ml2.type_drivers)"},{"line_number":52,"context_line":"        super(TypeManager, self).__init__(\u0027neutron.ml2.type_drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_2fdcd745","side":"PARENT","line":49,"in_reply_to":"1ac06dbe_f4911848","updated":"2016-08-24 17:00:19.000000000","message":"Done","commit_id":"1b19d06e7be5cd8a84fb7d0d834ed9bb04234103"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"11ef2d4112cd0cf437efd9a452b825d318ae6008","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MAX_BINDING_LEVELS \u003d 10"},{"line_number":42,"context_line":"config.register_ml2_plugins_opts(config.ml2_opts, \"ml2\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TypeManager(stevedore.named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_14eaf473","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":56},"updated":"2016-08-24 08:08:53.000000000","message":"Why you change ml2 config this way, but change linuxbridge config [1] in another way? I think the linuxbridge way is better, because the function here call \"***ml2***\", there is no need to pass the options and \"ml2\" as param here. Or, do you intend to put other ml2 configs to neutron.conf.plugins.ml2.config?\n\n[1] 0810cbdad85fb06b1ece292e2a52b1a53c9359df","commit_id":"ecbf65596785e54b4638e56ecccba9b1f8fc26c0"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"a36fc5be8c9f489624d4641ff87c95a052d30ff9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MAX_BINDING_LEVELS \u003d 10"},{"line_number":42,"context_line":"config.register_ml2_plugins_opts(config.ml2_opts, \"ml2\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TypeManager(stevedore.named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_2faa1786","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":56},"in_reply_to":"1ac06dbe_14eaf473","updated":"2016-08-24 17:00:19.000000000","message":"Done","commit_id":"ecbf65596785e54b4638e56ecccba9b1f8fc26c0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9b47da0e68e7f7fbf69264df4e461a684b8227ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"MAX_BINDING_LEVELS \u003d 10"},{"line_number":41,"context_line":"config.register_ml2_plugin_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class TypeManager(stevedore.named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_00aec6e6","line":41,"updated":"2017-04-05 12:55:04.000000000","message":"This works, but why not leave this logic in the main ml2 plugin.py file?","commit_id":"3ada80341634061f063bbb98c07e1970ae52f17c"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"3f6ab029cc43cf6b62462dc79936dea8205c6c02","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"MAX_BINDING_LEVELS \u003d 10"},{"line_number":41,"context_line":"config.register_ml2_plugin_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class TypeManager(stevedore.named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_e034f7e0","line":41,"in_reply_to":"bff0334d_00aec6e6","updated":"2017-04-05 16:26:23.000000000","message":"Maybe part of the answer is here:\n\nhttps://review.openstack.org/#/c/340228/37/neutron/conf/plugins/ml2/config.py@72","commit_id":"3ada80341634061f063bbb98c07e1970ae52f17c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"892c042114b6103a5747f1c202e4809e9bac7f1f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"MAX_BINDING_LEVELS \u003d 10"},{"line_number":41,"context_line":"config.register_ml2_plugin_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class TypeManager(stevedore.named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_4e628640","line":41,"in_reply_to":"bff0334d_e034f7e0","updated":"2017-04-06 16:03:55.000000000","message":"After configuration options were moved to neutron/conf from [1] , one line of code that registered ml2_opts remained in [1].  Therefore I moved registration of ml2_opts to [2], deleted neutron/plugins/ml2/config.py file and removed imports for the same.  \n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/config.py#L72\n[2]\nhttps://review.openstack.org/#/c/340228/17/neutron/plugins/ml2/managers.py","commit_id":"3ada80341634061f063bbb98c07e1970ae52f17c"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a5b9c1f9962ce78b079ceddb9d21d300aeee9ad7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"from neutron import manager"},{"line_number":75,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":76,"context_line":"from neutron.plugins.ml2.common import exceptions as ml2_exc"},{"line_number":77,"context_line":"from neutron.plugins.ml2 import config  # noqa"},{"line_number":78,"context_line":"from neutron.plugins.ml2 import db"},{"line_number":79,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":80,"context_line":"from neutron.plugins.ml2 import driver_context"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_fbb0d88d","side":"PARENT","line":77,"updated":"2016-09-22 22:47:34.000000000","message":"this gives me pause.  the only reason this import would be done would be so that the config options were registered.  Since that is now being moved to a function, that doesn\u0027t happen anymore becuase I don\u0027t see that function being called anywhere relevant.  However, there aren\u0027t any failing tests due to this, so I can\u0027t say this break anything.  It\u0027s just concerning that this was obviously placed here to have the register config options line executed.  If you have a definitive reason why this doesn\u0027t matter anymore, please do share.","commit_id":"84a18731120f4e3b616e9ee066b22a3f57cefcb4"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"dd662cb6520e34c96c0a63580b9a2e22d998a667","unresolved":false,"context_lines":[{"line_number":74,"context_line":"from neutron import manager"},{"line_number":75,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":76,"context_line":"from neutron.plugins.ml2.common import exceptions as ml2_exc"},{"line_number":77,"context_line":"from neutron.plugins.ml2 import config  # noqa"},{"line_number":78,"context_line":"from neutron.plugins.ml2 import db"},{"line_number":79,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":80,"context_line":"from neutron.plugins.ml2 import driver_context"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_f0927c9e","side":"PARENT","line":77,"in_reply_to":"5a8bc5a2_fbb0d88d","updated":"2016-09-23 21:40:32.000000000","message":"After configuration options were moved to neutron/conf from [1] , one line of code that registered ml2_opts remained in [1].  Therefore I moved registration of ml2_opts to [2], deleted neutron/plugins/ml2/config.py file and removed imports for the same.  \n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/config.py#L72\n[2]\nhttps://review.openstack.org/#/c/340228/17/neutron/plugins/ml2/managers.py","commit_id":"84a18731120f4e3b616e9ee066b22a3f57cefcb4"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"ea35864630dd88eaa025a246869c92888b146b5a","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"    def setUp(self):"},{"line_number":1410,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":1411,"context_line":"                              [\u0027physnet:200:209\u0027, \u0027physnet0:200:209\u0027,"},{"line_number":1412,"context_line":"                              \u0027physnet1:200:209\u0027, \u0027physnet2:200:209\u0027],"},{"line_number":1413,"context_line":"                              group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":1414,"context_line":"        super(TestSegmentAwareIpamML2, self).setUp(plugin\u003d\u0027ml2\u0027)"},{"line_number":1415,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"1a1ced50_c6f28406","line":1412,"updated":"2017-03-16 16:26:59.000000000","message":"The indentation changed slightly here, we should keep it consistent with the rest of the project (example on L987-988 in this file).\n\n[\u0027...\u0027,\n \u0027...\u0027]\n\nrather than:\n\n[\u0027...\u0027,\n\u0027...\u0027]","commit_id":"91996b69ff04f7a833d79c8a3505fcc559f5617c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"14d97525055a427e3cb66502db6144d8d571a592","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"    def setUp(self):"},{"line_number":1410,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":1411,"context_line":"                              [\u0027physnet:200:209\u0027, \u0027physnet0:200:209\u0027,"},{"line_number":1412,"context_line":"                              \u0027physnet1:200:209\u0027, \u0027physnet2:200:209\u0027],"},{"line_number":1413,"context_line":"                              group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":1414,"context_line":"        super(TestSegmentAwareIpamML2, self).setUp(plugin\u003d\u0027ml2\u0027)"},{"line_number":1415,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"1a1ced50_7248a65c","line":1412,"in_reply_to":"1a1ced50_c6f28406","updated":"2017-03-16 17:52:59.000000000","message":"Done","commit_id":"91996b69ff04f7a833d79c8a3505fcc559f5617c"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"ea35864630dd88eaa025a246869c92888b146b5a","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"                              group\u003d\u0027ml2\u0027)"},{"line_number":1424,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":1425,"context_line":"                              [\u0027physnet:200:209\u0027, \u0027physnet0:200:209\u0027,"},{"line_number":1426,"context_line":"                              \u0027physnet1:200:209\u0027, \u0027physnet2:200:209\u0027],"},{"line_number":1427,"context_line":"                              group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":1428,"context_line":"        super(TestNovaSegmentNotifier, self).setUp(plugin\u003d\u0027ml2\u0027)"},{"line_number":1429,"context_line":"        self.segments_plugin \u003d directory.get_plugin(ext_segment.SEGMENTS)"}],"source_content_type":"text/x-python","patch_set":35,"id":"1a1ced50_86e88c18","line":1426,"updated":"2017-03-16 16:26:59.000000000","message":"ditto","commit_id":"91996b69ff04f7a833d79c8a3505fcc559f5617c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"14d97525055a427e3cb66502db6144d8d571a592","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"                              group\u003d\u0027ml2\u0027)"},{"line_number":1424,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":1425,"context_line":"                              [\u0027physnet:200:209\u0027, \u0027physnet0:200:209\u0027,"},{"line_number":1426,"context_line":"                              \u0027physnet1:200:209\u0027, \u0027physnet2:200:209\u0027],"},{"line_number":1427,"context_line":"                              group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":1428,"context_line":"        super(TestNovaSegmentNotifier, self).setUp(plugin\u003d\u0027ml2\u0027)"},{"line_number":1429,"context_line":"        self.segments_plugin \u003d directory.get_plugin(ext_segment.SEGMENTS)"}],"source_content_type":"text/x-python","patch_set":35,"id":"1a1ced50_b2785e91","line":1426,"in_reply_to":"1a1ced50_86e88c18","updated":"2017-03-16 17:52:59.000000000","message":"Done","commit_id":"91996b69ff04f7a833d79c8a3505fcc559f5617c"}]}