)]}'
{"neutron/db/api.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"abb7a78f923e8411200e9a1fb03726bb28073612","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def dispose():"},{"line_number":110,"context_line":"    if context_manager._factory._started:"},{"line_number":111,"context_line":"        get_engine().pool.dispose()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3f7ca1ea","line":110,"updated":"2016-07-11 13:37:42.000000000","message":"this is fine though we certainly might want to create a context_manager.dispose_pool() method in oslo.db to avoid all the underscores here.","commit_id":"2df2808fa3ce11c87668ba8d00491ab7bf986d27"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7d80bfddf0e8b4a05cf4fe0732e6dab55c7d544e","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def dispose():"},{"line_number":110,"context_line":"    if context_manager._factory._started:"},{"line_number":111,"context_line":"        get_engine().pool.dispose()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_47b39be9","line":110,"in_reply_to":"1aa78d24_3f7ca1ea","updated":"2016-07-11 16:40:52.000000000","message":"yes","commit_id":"2df2808fa3ce11c87668ba8d00491ab7bf986d27"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9c509786321526d748e8f896693fc08b080dbc3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"def dispose():"},{"line_number":110,"context_line":"    # TODO(akamyshnikova): Use context_manager.dispose_pool() when it is"},{"line_number":111,"context_line":"    #                      available in oslo.db"},{"line_number":112,"context_line":"    if context_manager._factory._started:"},{"line_number":113,"context_line":"        get_engine().pool.dispose()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_386020cf","line":112,"updated":"2016-07-11 21:51:29.000000000","message":"i am not sure that we should use internal variables. the API route is better","commit_id":"1d7a0334f36a3eb2519e6eea1e5a8e34d22151b1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"de1521d31bb91dbdd0a95319cddb7aed18979e13","unresolved":false,"context_lines":[{"line_number":109,"context_line":"def dispose():"},{"line_number":110,"context_line":"    # TODO(akamyshnikova): Use context_manager.dispose_pool() when it is"},{"line_number":111,"context_line":"    #                      available in oslo.db"},{"line_number":112,"context_line":"    if context_manager._factory._started:"},{"line_number":113,"context_line":"        get_engine().pool.dispose()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3818201e","line":112,"in_reply_to":"1aa78d24_386020cf","updated":"2016-07-11 21:57:43.000000000","message":"Hi Gary, can you look at the previous comments in this review? I think together with the TODO above they explain this temporary usage of private variables to fix the high priority bug.","commit_id":"1d7a0334f36a3eb2519e6eea1e5a8e34d22151b1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"58c9cfbb826023741abe2e51c6416300f989e96e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # TODO(akamyshnikova): Use context_manager.dispose_pool() when it is"},{"line_number":111,"context_line":"    #                      available in oslo.db"},{"line_number":112,"context_line":"    if context_manager._factory._started:"},{"line_number":113,"context_line":"        get_engine().pool.dispose()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"#TODO(akamyshnikova): when all places in the code, which use sessions/"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_89110807","line":113,"updated":"2016-07-11 23:40:19.000000000","message":"looking at past memories I found this one:\n\nhttps://review.openstack.org/#/c/159365/6/neutron/wsgi.py\n\nbut that was taken out by:\n\nI3dbad1bef5da7b3765898e7d539b4d119b89e73a","commit_id":"1d7a0334f36a3eb2519e6eea1e5a8e34d22151b1"}]}