)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Check traffic pass when the SNAT port is enabled"},{"line_number":10,"context_line":"Disable the port and check the traffic is still passing"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2) Check centralized routers on DVR setup works through networker"},{"line_number":13,"context_line":"Update router to be distributed"},{"line_number":14,"context_line":"Check trafic works when the SNAT port is down"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a6eadb0_ca97618e","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":65},"updated":"2016-12-21 13:15:58.000000000","message":"you mean \u0027networking node\u0027?","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2) Check centralized routers on DVR setup works through networker"},{"line_number":13,"context_line":"Update router to be distributed"},{"line_number":14,"context_line":"Check trafic works when the SNAT port is down"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"3) Fix test_trunk as the function for creating router changed"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a6eadb0_4a9c31c0","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":12},"updated":"2016-12-21 13:15:58.000000000","message":"traffic","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c901fb943b97dd0abc2e1dd8a6173c3476d39b8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: I05233e69801be27cc35211148a53af02af29c8a5"},{"line_number":20,"context_line":"Change-Id: I5022f42392c0a076aa4980082640392cad1688a0"},{"line_number":21,"context_line":"(cherry picked from commit 4222387c0b2759d05d991f5139fb8a7877e79fbe)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba5201f7_db6dc633","line":21,"updated":"2017-01-03 06:39:39.000000000","message":"why the cherry pick?","commit_id":"be3d9cbc974b8594721bc14695fec18fc24bf332"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b209b34b27fc8bbe53bac9ac07ef6858c7c4ea65","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: I05233e69801be27cc35211148a53af02af29c8a5"},{"line_number":20,"context_line":"Change-Id: I5022f42392c0a076aa4980082640392cad1688a0"},{"line_number":21,"context_line":"(cherry picked from commit 4222387c0b2759d05d991f5139fb8a7877e79fbe)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba5201f7_ff1b1d19","line":21,"in_reply_to":"ba5201f7_db6dc633","updated":"2017-01-04 13:15:41.000000000","message":"Done","commit_id":"be3d9cbc974b8594721bc14695fec18fc24bf332"}],"neutron.iml":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5bc699a44a9098b0b07675f82dcc7ae26f9e02cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cmodule type\u003d\"PYTHON_MODULE\" version\u003d\"4\"\u003e"},{"line_number":3,"context_line":"  \u003ccomponent name\u003d\"NewModuleRootManager\" inherit-compiler-output\u003d\"true\"\u003e"},{"line_number":4,"context_line":"    \u003cexclude-output /\u003e"}],"source_content_type":"text/xml","patch_set":5,"id":"7a8ec9b2_2d25fd5a","line":1,"updated":"2016-09-18 11:54:25.000000000","message":"why are we adding this file?","commit_id":"46836826fbd87c469d63f6e6d30047981b310ad2"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c901fb943b97dd0abc2e1dd8a6173c3476d39b8a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return body[\u0027port\u0027]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @classmethod"},{"line_number":320,"context_line":"    def _create_router_with_client("},{"line_number":321,"context_line":"        cls, client, router_name\u003dNone, admin_state_up\u003dFalse,"},{"line_number":322,"context_line":"        external_network_id\u003dNone, enable_snat\u003dNone, **kwargs"},{"line_number":323,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba5201f7_5bc71612","line":320,"range":{"start_line":320,"start_character":22,"end_line":320,"end_character":34},"updated":"2017-01-03 06:39:39.000000000","message":"this for me is confusing. what does _with_client mean?\nI would just change the method name to _create_router and then have the client as a parameter.","commit_id":"be3d9cbc974b8594721bc14695fec18fc24bf332"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2a68763c382e7de73a95a0f845e4995193fbaf34","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return body[\u0027port\u0027]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @classmethod"},{"line_number":320,"context_line":"    def _create_router_with_client("},{"line_number":321,"context_line":"        cls, client, router_name\u003dNone, admin_state_up\u003dFalse,"},{"line_number":322,"context_line":"        external_network_id\u003dNone, enable_snat\u003dNone, **kwargs"},{"line_number":323,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba5201f7_7f272d64","line":320,"range":{"start_line":320,"start_character":22,"end_line":320,"end_character":34},"in_reply_to":"ba5201f7_5bc71612","updated":"2017-01-04 13:15:08.000000000","message":"There is already a function called create_router, so I didn\u0027t want to add more complication by calling the function with almost the same name\nAs well it\u0027s using different clients for router creation, so this is how the name was born","commit_id":"be3d9cbc974b8594721bc14695fec18fc24bf332"}],"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"28f136610955833f80dab18be4d03e68683de029","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def create_router_and_interface(cls, subnet_id, **kwargs):"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            kwargs.pop(\u0027is_admin\u0027)"},{"line_number":106,"context_line":"        except KeyError:"},{"line_number":107,"context_line":"            router \u003d cls.create_router("},{"line_number":108,"context_line":"                router_name\u003ddata_utils.rand_name(\u0027router\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_7fadc287","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":34},"updated":"2016-09-22 09:32:20.000000000","message":"is_admin might be explicitly set to False, in which case your code will not behave as expected.","commit_id":"edcab2e515cb27688bbe0231a25cc20c6959cf8a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a2bbf56d94d1b23548dbdd88d751f9e943fcb020","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        cls.create_secgroup_rules(rule_list, secgroup_id\u003dsecgroup_id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def create_router_and_interface(cls, subnet_id, **kwargs):"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            kwargs.pop(\u0027is_admin\u0027)"},{"line_number":106,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_6868a1bb","line":103,"updated":"2016-09-28 17:19:08.000000000","message":"There\u0027s a lot of obvious code duplication between these two methods. The only difference is that this function also creates a router interface. Why not have this function called create_router_by_client, or any other way to reuse code?","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def create_router_by_client(cls, is_admin\u003dFalse, **kwargs):"},{"line_number":128,"context_line":"        if not is_admin:"},{"line_number":129,"context_line":"            router \u003d cls.create_router("},{"line_number":130,"context_line":"                router_name\u003ddata_utils.rand_name(\u0027router\u0027),"},{"line_number":131,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":132,"context_line":"                external_network_id\u003dCONF.network.public_network_id, **kwargs)"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            router \u003d cls.create_admin_router("},{"line_number":135,"context_line":"                router_name\u003ddata_utils.rand_name(\u0027router\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_0ac6b967","line":132,"range":{"start_line":130,"start_character":16,"end_line":132,"end_character":77},"updated":"2016-12-21 13:15:58.000000000","message":"nit: we could form a single dict with args fitting both methods, and then just pass it into the correct one. That would allow us to avoid copy-pasting those lines.","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def create_router_by_client(cls, is_admin\u003dFalse, **kwargs):"},{"line_number":128,"context_line":"        if not is_admin:"},{"line_number":129,"context_line":"            router \u003d cls.create_router("},{"line_number":130,"context_line":"                router_name\u003ddata_utils.rand_name(\u0027router\u0027),"},{"line_number":131,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":132,"context_line":"                external_network_id\u003dCONF.network.public_network_id, **kwargs)"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            router \u003d cls.create_admin_router("},{"line_number":135,"context_line":"                router_name\u003ddata_utils.rand_name(\u0027router\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_01dc5411","line":132,"range":{"start_line":130,"start_character":16,"end_line":132,"end_character":77},"in_reply_to":"1a6eadb0_0ac6b967","updated":"2017-01-02 12:40:32.000000000","message":"Done","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"}],"neutron/tests/tempest/scenario/test_dvr.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"240b0572e14d3068c7c8ac3273d159c26ff033dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"},{"line_number":28,"context_line":"    def test_vm_reachable_compute(self):"},{"line_number":29,"context_line":"        \"\"\""},{"line_number":30,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":31,"context_line":"        down on controller node"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c53fd623","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":33},"updated":"2016-07-18 13:57:05.000000000","message":"One way to check if DVR is running is by using a configuration option defined in tempest.conf (which is used as an indicator of whether a feature is on). If the option is, off, the test should be skipped.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d50b07023f8d6792c9c20909c467b45557416bd5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"},{"line_number":28,"context_line":"    def test_vm_reachable_compute(self):"},{"line_number":29,"context_line":"        \"\"\""},{"line_number":30,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":31,"context_line":"        down on controller node"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2928d299","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":33},"in_reply_to":"dada55a8_32bffffc","updated":"2016-07-20 14:07:26.000000000","message":"Done","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"2a8ff1920e289f7b0f7f61d2d07c5aa4fe790cd9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"},{"line_number":28,"context_line":"    def test_vm_reachable_compute(self):"},{"line_number":29,"context_line":"        \"\"\""},{"line_number":30,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":31,"context_line":"        down on controller node"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_32bffffc","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":33},"in_reply_to":"dada55a8_c53fd623","updated":"2016-07-18 22:20:56.000000000","message":"Yup!\n\n    @classmethod\n    @test.requires_ext(extension\u003d\"dvr\", service\u003d\"network\")\n    def skip_checks(cls):\n        super(DvrRoutersTest, cls).skip_checks()\n\nThe scenario job is currently not set up for DVR, which means the test will be skipped. You can set up the job however you want in other environments to make sure this test runs. We can also change the current scenario job to use DVR (That would be a change in project-config).","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"240b0572e14d3068c7c8ac3273d159c26ff033dd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":31,"context_line":"        down on controller node"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        self.setup_network_and_server()"},{"line_number":34,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":35,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":36,"context_line":"            device_owner\u003d\u0027network:router_centralized_snat\u0027)[\u0027ports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c554f655","line":33,"range":{"start_line":33,"start_character":13,"end_line":33,"end_character":37},"updated":"2016-07-18 13:57:05.000000000","message":"It sure will be nice if this could be used to test DVR+HA, and in addition to also test DVR+HA routers. I see that you ran this locally and a multinode OSPD, but it\u0027s interesting to see if this can be ran on a multinode deployment at the gate (some gate jobs are already doing this). If so, the DVR+HA case is very interesting indeed.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"240b0572e14d3068c7c8ac3273d159c26ff033dd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":36,"context_line":"            device_owner\u003d\u0027network:router_centralized_snat\u0027)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":37,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":38,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":39,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":40,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":41,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8582fefe","line":38,"updated":"2016-07-18 13:57:05.000000000","message":"Can we also call check_connectivity() before we set turn the port off? This will make the test clearer IMO in the aspect of \"turning off the snat shouldn\u0027t make a difference\".","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d50b07023f8d6792c9c20909c467b45557416bd5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":36,"context_line":"            device_owner\u003d\u0027network:router_centralized_snat\u0027)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":37,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":38,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":39,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":40,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":41,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_692e4aa6","line":38,"in_reply_to":"dada55a8_8582fefe","updated":"2016-07-20 14:07:26.000000000","message":"Done","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae66f96cb990e207fb57bf7d3458f7c3f3c2f878","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":42,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":43,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":44,"context_line":"            device_owner\u003d\u0027network:router_centralized_snat\u0027)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":45,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":46,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":47,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_cff8a54c","line":44,"updated":"2016-08-26 19:51:35.000000000","message":"Should use DEVICE_OWNER_ROUTER_SNAT from neutron_lib constants file.\n\nThis is the log on the test patch:\n\nhttp://logs.openstack.org/80/342180/2/experimental/gate-tempest-dsvm-neutron-scenario/3ae19b3/console.html.gz#_2016-08-25_01_31_21_435166\n\nWhich we\u0027d expect to fail as John says there is no dvr :(","commit_id":"d69a26590ab380753fc63158da99c6bda8110d7d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"75abd4443589f85cd67d6d74722a1b5c4df9165a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":42,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":43,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":44,"context_line":"            device_owner\u003d\u0027network:router_centralized_snat\u0027)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":45,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":46,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":47,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_64b78986","line":44,"in_reply_to":"fa7ab95a_cff8a54c","updated":"2016-08-29 08:57:11.000000000","message":"We need https://review.openstack.org/#/c/355344/ first to be able to trigger this job.","commit_id":"d69a26590ab380753fc63158da99c6bda8110d7d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"28f136610955833f80dab18be4d03e68683de029","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.check_connectivity(fip, CONF.validation.image_ssh_user, keypair)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"},{"line_number":42,"context_line":"    def test_vm_reachable_compute(self):"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":45,"context_line":"        down on controller node"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_bf62ea14","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":33},"updated":"2016-09-22 09:32:20.000000000","message":"Please rename to \"test_vm_reachable_through_compute\", as it\u0027s not clear that you\u0027re not testing that the compute node itself is reachable.","commit_id":"edcab2e515cb27688bbe0231a25cc20c6959cf8a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"28f136610955833f80dab18be4d03e68683de029","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"},{"line_number":42,"context_line":"    def test_vm_reachable_compute(self):"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        Check the VM is reachable through compute by putting the SNAT port"},{"line_number":45,"context_line":"        down on controller node"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        self.setup_network_and_server()"},{"line_number":48,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_7f2f82a1","line":45,"range":{"start_line":44,"start_character":8,"end_line":45,"end_character":31},"updated":"2016-09-22 09:32:20.000000000","message":"Please read [1] and fix your docstring appropriately :)\n\n[1]: http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"edcab2e515cb27688bbe0231a25cc20c6959cf8a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"28f136610955833f80dab18be4d03e68683de029","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @test.idempotent_id(\u002723724222-483a-4129-bc15-7a9278f3828b\u0027)"},{"line_number":56,"context_line":"    def test_update_centr_router_to_dvr(self):"},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        Check that updating centralized router to be distributed works"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        # Created a centralized router on a DVR setup"},{"line_number":61,"context_line":"        tenant_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_9f036e0f","line":58,"range":{"start_line":58,"start_character":69,"end_line":58,"end_character":70},"updated":"2016-09-22 09:32:20.000000000","message":"nit: end sentence with \".\"","commit_id":"edcab2e515cb27688bbe0231a25cc20c6959cf8a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a2bbf56d94d1b23548dbdd88d751f9e943fcb020","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(NetworkDvrTest, cls).skip_checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def check_connectivity_snat_down(self, network_id, fip, keypair):"},{"line_number":34,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_1d0cbd93","line":33,"updated":"2016-09-28 17:19:08.000000000","message":"I think that one of the guidelines for a well designed function is that it does one thing. Here you\u0027re updating the SNAT port of a router to down, then checking connectivity. I recommend splitting the connectivity check out.","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"362616eb3a8a7955bbba3f4347d4c6aa59e0911c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(NetworkDvrTest, cls).skip_checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def check_connectivity_snat_down(self, network_id, fip, keypair):"},{"line_number":34,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_53e34d05","line":33,"in_reply_to":"3a98d1f4_1d0cbd93","updated":"2016-10-06 09:15:02.000000000","message":"Done","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a2bbf56d94d1b23548dbdd88d751f9e943fcb020","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":37,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":38,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":39,"context_line":"        self.check_connectivity(fip, CONF.validation.image_ssh_user, keypair)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_dd9415ea","line":38,"updated":"2016-09-28 17:19:08.000000000","message":"You can just get rid of line 37 and change line 38 to:\n...update_port(port_id, admin_state_up\u003dFalse)","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"362616eb3a8a7955bbba3f4347d4c6aa59e0911c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":37,"context_line":"        port_status \u003d {\u0027admin_state_up\u0027: False}"},{"line_number":38,"context_line":"        self.admin_manager.network_client.update_port(port_id, **port_status)"},{"line_number":39,"context_line":"        self.check_connectivity(fip, CONF.validation.image_ssh_user, keypair)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @test.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d344\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_656a6c82","line":38,"in_reply_to":"3a98d1f4_dd9415ea","updated":"2016-10-06 09:15:02.000000000","message":"Done","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a2bbf56d94d1b23548dbdd88d751f9e943fcb020","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.keypair[\u0027private_key\u0027])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @test.idempotent_id(\u002723724222-483a-4129-bc15-7a9278f3828b\u0027)"},{"line_number":56,"context_line":"    def test_update_centr_router_to_dvr(self):"},{"line_number":57,"context_line":"        \"\"\"Check that updating centralized router to be distributed works."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        # Created a centralized router on a DVR setup"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_3dbb3974","line":56,"updated":"2016-09-28 17:19:08.000000000","message":"Might as well spell out centralized \u003dD","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"362616eb3a8a7955bbba3f4347d4c6aa59e0911c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.keypair[\u0027private_key\u0027])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @test.idempotent_id(\u002723724222-483a-4129-bc15-7a9278f3828b\u0027)"},{"line_number":56,"context_line":"    def test_update_centr_router_to_dvr(self):"},{"line_number":57,"context_line":"        \"\"\"Check that updating centralized router to be distributed works."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        # Created a centralized router on a DVR setup"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_413562d8","line":56,"in_reply_to":"3a98d1f4_3dbb3974","updated":"2016-10-06 09:15:02.000000000","message":"Done","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a2bbf56d94d1b23548dbdd88d751f9e943fcb020","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Update router to be distributed"},{"line_number":69,"context_line":"        router_id \u003d self.client.list_routers()[\u0027routers\u0027][0][\u0027id\u0027]"},{"line_number":70,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":71,"context_line":"            router_id\u003drouter_id,"},{"line_number":72,"context_line":"            admin_state_up\u003dFalse, distributed\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_9d58cd58","line":69,"updated":"2016-09-28 17:19:08.000000000","message":"Line 69 introduces a race condition where some other test creates a router and you actually grab the router_id of some other router. You can just get the router_id from the \u0027router\u0027 object created in line 61.","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"362616eb3a8a7955bbba3f4347d4c6aa59e0911c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Update router to be distributed"},{"line_number":69,"context_line":"        router_id \u003d self.client.list_routers()[\u0027routers\u0027][0][\u0027id\u0027]"},{"line_number":70,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":71,"context_line":"            router_id\u003drouter_id,"},{"line_number":72,"context_line":"            admin_state_up\u003dFalse, distributed\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_206bf21f","line":69,"in_reply_to":"3a98d1f4_9d58cd58","updated":"2016-10-06 09:15:02.000000000","message":"Done","commit_id":"96581c0a68eda6247ca388ce3d2d1225c5343b04"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c85112115f876f1c338bb2680f764e4c0ef2a877","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(NetworkDvrTest, cls).skip_checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def put_snat_port_down(self, network_id):"},{"line_number":34,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_6f13dc66","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":26},"updated":"2016-12-04 08:24:27.000000000","message":"super-super-nit: rename to _put_snat_port_down","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"38b08b7f65869ab8543c3dbe6177bd2e9b5b13f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(NetworkDvrTest, cls).skip_checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def put_snat_port_down(self, network_id):"},{"line_number":34,"context_line":"        port_id \u003d self.client.list_ports("},{"line_number":35,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":36,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_SNAT)[\u0027ports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_4befd786","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":26},"in_reply_to":"3a71b18c_6f13dc66","updated":"2016-12-11 09:38:11.000000000","message":"Done","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c85112115f876f1c338bb2680f764e4c0ef2a877","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        The test is done by putting the SNAT port down on controller node."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        self.setup_network_and_server()"},{"line_number":47,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":48,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":49,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_32006701","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":37},"updated":"2016-12-04 08:24:27.000000000","message":"Does this create a dvr router (documentation/code don\u0027t mention that)? I\u0027ve tried looking at the code flow but I don\u0027t think it is (unless the server is configured to automatically create a distributed router). If it\u0027s implicit, can we explicitly create a dvr router instead?","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"38b08b7f65869ab8543c3dbe6177bd2e9b5b13f0","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        The test is done by putting the SNAT port down on controller node."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        self.setup_network_and_server()"},{"line_number":47,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":48,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":49,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_8b6acfeb","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":37},"in_reply_to":"3a71b18c_32006701","updated":"2016-12-11 09:38:11.000000000","message":"When on the DVR env, but default the router will be created with distributed option enabled","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5c378088fd5840d391021f72c6d5cfbe1bc7c372","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        The test is done by putting the SNAT port down on controller node."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        self.setup_network_and_server()"},{"line_number":47,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":48,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":49,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_9d885273","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":37},"in_reply_to":"3a71b18c_8b6acfeb","updated":"2016-12-11 09:53:05.000000000","message":"On non-DVR envs, this will fail, then.\n\nCan we be explicit here and create a distributed router to begin with?","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c85112115f876f1c338bb2680f764e4c0ef2a877","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dTrue)"},{"line_number":71,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":72,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dTrue)"},{"line_number":73,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":74,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":75,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Put the Router_SNAT port down, so the traffic flows through Compute"},{"line_number":78,"context_line":"        self.put_snat_port_down(self.network[\u0027id\u0027])"},{"line_number":79,"context_line":"        self.check_connectivity("},{"line_number":80,"context_line":"            self.fip[\u0027floating_ip_address\u0027], CONF.validation.image_ssh_user,"},{"line_number":81,"context_line":"            self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_5203230d","line":81,"range":{"start_line":73,"start_character":8,"end_line":81,"end_character":40},"updated":"2016-12-04 08:24:27.000000000","message":"These lines are pretty much a copy-paste from lines 47-53. Can we move them to some shared, private function and just call that?\n\nAlso, regarding the comment in line 77 - the traffic always flows through the compute in DVR - the comment should say something like \"put router\u0027s snat port down to make sure the traffic flows through compute\" (the \"so\" implies causality).","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"38b08b7f65869ab8543c3dbe6177bd2e9b5b13f0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dTrue)"},{"line_number":71,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":72,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dTrue)"},{"line_number":73,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":74,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":75,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Put the Router_SNAT port down, so the traffic flows through Compute"},{"line_number":78,"context_line":"        self.put_snat_port_down(self.network[\u0027id\u0027])"},{"line_number":79,"context_line":"        self.check_connectivity("},{"line_number":80,"context_line":"            self.fip[\u0027floating_ip_address\u0027], CONF.validation.image_ssh_user,"},{"line_number":81,"context_line":"            self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_7d27f6b5","line":81,"range":{"start_line":73,"start_character":8,"end_line":81,"end_character":40},"in_reply_to":"3a71b18c_5203230d","updated":"2016-12-11 09:38:11.000000000","message":"Done","commit_id":"69b6a92159ca701412fd57901c7491cfb39f5a32"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"4a9074b3190e817dd28e94e173dea11fc62ffe43","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(NetworkDvrTest, cls).skip_checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _check_snat_port_connectivity(self):"},{"line_number":34,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":35,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":36,"context_line":"                                self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_dd464a7a","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":37},"updated":"2016-12-11 11:59:35.000000000","message":"Technically it\u0027s also a fip port check, but I won\u0027t hold this against you :)","commit_id":"aa1f68b5978d9de05c95ac4f822d5564d3c99863"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Put the Router_SNAT port down to make sure the traffic flows through"},{"line_number":39,"context_line":"        # Compute node."},{"line_number":40,"context_line":"        self._put_snat_port_down(self.network[\u0027id\u0027])"},{"line_number":41,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":42,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":43,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _put_snat_port_down(self, network_id):"},{"line_number":46,"context_line":"        port_id \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_cacbe151","line":43,"range":{"start_line":41,"start_character":8,"end_line":43,"end_character":60},"updated":"2016-12-21 13:15:58.000000000","message":"nit: this duplicates lines 34-36, so you could create a helper method for that.","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Put the Router_SNAT port down to make sure the traffic flows through"},{"line_number":39,"context_line":"        # Compute node."},{"line_number":40,"context_line":"        self._put_snat_port_down(self.network[\u0027id\u0027])"},{"line_number":41,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":42,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":43,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _put_snat_port_down(self, network_id):"},{"line_number":46,"context_line":"        port_id \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_6131a0a2","line":43,"range":{"start_line":41,"start_character":8,"end_line":43,"end_character":60},"in_reply_to":"1a6eadb0_cacbe151","updated":"2017-01-02 12:40:32.000000000","message":"Done","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":59,"context_line":"            distributed\u003dTrue, tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":60,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":61,"context_line":"        self._check_snat_port_connectivity()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @test.idempotent_id(\u002723724222-483a-4129-bc15-7a9278f3828b\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_0ae319a5","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":52},"updated":"2016-12-21 13:15:58.000000000","message":"I see you call setup_network_and_server both here and in another test case (line 70), and since the method is classmethod, it will probably update the same class attribute. Will those two tests break each other if executed at the same time?","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":59,"context_line":"            distributed\u003dTrue, tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":60,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":61,"context_line":"        self._check_snat_port_connectivity()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @test.idempotent_id(\u002723724222-483a-4129-bc15-7a9278f3828b\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_21ef98e9","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":52},"in_reply_to":"1a6eadb0_0ae319a5","updated":"2017-01-02 12:40:32.000000000","message":"I didn\u0027t find out how those 2 tests could run at the same time","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":69,"context_line":"            distributed\u003dFalse, tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":70,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":71,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":72,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":73,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_8ab3a999","line":73,"range":{"start_line":71,"start_character":8,"end_line":73,"end_character":60},"updated":"2016-12-21 13:15:58.000000000","message":"again, repeatition","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":69,"context_line":"            distributed\u003dFalse, tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":70,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":71,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":72,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":73,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_c1208c4c","line":73,"range":{"start_line":71,"start_character":8,"end_line":73,"end_character":60},"in_reply_to":"1a6eadb0_8ab3a999","updated":"2017-01-02 12:40:32.000000000","message":"Done","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":77,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dFalse)"},{"line_number":78,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":79,"context_line":"            router_id\u003drouter[\u0027id\u0027], distributed\u003dTrue)"},{"line_number":80,"context_line":"        self.admin_manager.network_client.update_router("}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_4a199187","line":77,"range":{"start_line":77,"start_character":58,"end_line":77,"end_character":75},"updated":"2016-12-21 13:15:58.000000000","message":"why is it needed to pass it the second time? we know that the router is not DVR due to line 69.","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":77,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dFalse)"},{"line_number":78,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":79,"context_line":"            router_id\u003drouter[\u0027id\u0027], distributed\u003dTrue)"},{"line_number":80,"context_line":"        self.admin_manager.network_client.update_router("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_61d8c054","line":77,"range":{"start_line":77,"start_character":58,"end_line":77,"end_character":75},"in_reply_to":"1a6eadb0_4a199187","updated":"2017-01-02 12:40:32.000000000","message":"Thought explicit is better than implicit, but changing to what you propose if you think it\u0027s better this way","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"455e3868dfb681fa6fe90bd0f34787360fcd55d2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":77,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dFalse)"},{"line_number":78,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":79,"context_line":"            router_id\u003drouter[\u0027id\u0027], distributed\u003dTrue)"},{"line_number":80,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":81,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dTrue)"},{"line_number":82,"context_line":"        self._check_snat_port_connectivity()"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a6eadb0_3e1bb674","line":81,"range":{"start_line":78,"start_character":8,"end_line":81,"end_character":56},"updated":"2016-12-21 13:15:58.000000000","message":"won\u0027t it work if we pass both params at the same time, saving one API call?","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f42c0c0f4b758d409aead19f4b35e2e2ed1525ac","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # Update router to be distributed"},{"line_number":76,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":77,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dFalse, distributed\u003dFalse)"},{"line_number":78,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":79,"context_line":"            router_id\u003drouter[\u0027id\u0027], distributed\u003dTrue)"},{"line_number":80,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":81,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dTrue)"},{"line_number":82,"context_line":"        self._check_snat_port_connectivity()"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_011b741c","line":81,"range":{"start_line":78,"start_character":8,"end_line":81,"end_character":56},"in_reply_to":"1a6eadb0_3e1bb674","updated":"2017-01-02 12:40:32.000000000","message":"It will work, but according to Kuba, I should use additional API call, please check the remark in the previous patch","commit_id":"f9cdfa625cd358422ef017c038602d80757e1614"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cd08e673b16d20e4025e6598ca267080d8d60e5","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.tests.tempest import config"},{"line_number":18,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":19,"context_line":"from neutron_lib import constants"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_35e8a010","line":19,"updated":"2017-01-13 20:50:21.000000000","message":"nit: neutron_lib should be up with tempest import","commit_id":"45ae248bec878318d4d95b0bb4939efc082320f8"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"2a8ff1920e289f7b0f7f61d2d07c5aa4fe790cd9","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_52d55341","line":781,"updated":"2016-07-18 22:20:56.000000000","message":"Do we need this function?\n\nCheck out line 159, update_port should work without explicitly defining this function by using _updater internally. update_port is defined in the API tests with a simple wrapper that returns the \u0027port\u0027 body of whatever returns from the server:\nneutron.tests.tempest.api.base.py.*.update_port","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"09d4d74dafb0b0dfeff3e97af6726487b534f4bf","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_984ca5c9","line":781,"in_reply_to":"dada55a8_090cee3f","updated":"2016-07-20 15:36:09.000000000","message":"I kinda agree with Genadi here. Explicit is better than implicit and it saves time to look what update_port() does when you have it written here rather than hunting dynamical magic in client.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"7e3e070f3e43bb6e9160716353f967de5f58c9e2","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_82e570dd","line":781,"in_reply_to":"dada55a8_52d55341","updated":"2016-07-20 07:12:55.000000000","message":"@Assaf , I think that when we can explicitly define a function it\u0027s better.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"03c59f86301f3be8106b8840939247c451036b14","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c7cf6c27","line":781,"in_reply_to":"dada55a8_82e570dd","updated":"2016-07-20 11:09:40.000000000","message":"\u003e I think that when we can explicitly define a function it\u0027s better.\n\nWhy? The downside is clear, I don\u0027t understand the upside.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"6eb6d9264bb88434bf615d51e04e3d522e2a9987","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_27764906","line":781,"in_reply_to":"dada55a8_82e570dd","updated":"2016-07-20 10:54:19.000000000","message":"I disagree. The function that already exists is more robust and is better tested - there\u0027s simply no reason to replace it unless this code adds some kind of functionality (which it doesn\u0027t seem to do).\n\nAnother argument against re-defining this is \"code duplication\" - 2 functions that practically do the same thing.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d50b07023f8d6792c9c20909c467b45557416bd5","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":779,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def update_port(self, port_id, **kwargs):"},{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        Updates port with provided kwargs parameters"},{"line_number":784,"context_line":"        :param port_id: IP of the port to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_090cee3f","line":781,"in_reply_to":"dada55a8_c7cf6c27","updated":"2016-07-20 14:07:26.000000000","message":"Done","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"240b0572e14d3068c7c8ac3273d159c26ff033dd","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        uri \u003d \u0027%s/ports/%s\u0027 % (self.uri_prefix, port_id)"},{"line_number":792,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":793,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":794,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":795,"context_line":"        update_body \u003d dict()"},{"line_number":796,"context_line":"        for key in kwargs:"},{"line_number":797,"context_line":"            update_body[key] \u003d kwargs.get(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8544be74","line":794,"range":{"start_line":794,"start_character":8,"end_line":794,"end_character":36},"updated":"2016-07-18 13:57:05.000000000","message":"The returned \u0027body\u0027 is not used anywhere in this function, so I think lines 792-794 can be removed.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"240b0572e14d3068c7c8ac3273d159c26ff033dd","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":793,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":794,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":795,"context_line":"        update_body \u003d dict()"},{"line_number":796,"context_line":"        for key in kwargs:"},{"line_number":797,"context_line":"            update_body[key] \u003d kwargs.get(key)"},{"line_number":798,"context_line":"        update_body \u003d dict(port\u003dupdate_body)"},{"line_number":799,"context_line":"        update_body \u003d jsonutils.dumps(update_body)"},{"line_number":800,"context_line":"        resp, body \u003d self.put(uri, update_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e5901aef","line":797,"range":{"start_line":795,"start_character":8,"end_line":797,"end_character":46},"updated":"2016-07-18 13:57:05.000000000","message":"This is not needed, since after the loop is ended, update_body will practically equal kwargs. Line 798 can directly use kwargs.","commit_id":"2f3ffa084c9c3193850fcdd4e8aaf752d5cb474d"}]}
