)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"513287a8a3ffc4a9a0c087194055db242f66c4c2","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                    except Exception:"},{"line_number":362,"context_line":"                        with excutils.save_and_reraise_exception():"},{"line_number":363,"context_line":"                            # we need to try to undo the updated router"},{"line_number":364,"context_line":"                            # interfac from above"},{"line_number":365,"context_line":"                            upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":366,"context_line":"                                ip for ip in port[\u0027fixed_ips\u0027]"},{"line_number":367,"context_line":"                                if ip[\u0027subnet_id\u0027] !\u003d fixed_ip[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_352b3e96","line":364,"range":{"start_line":364,"start_character":30,"end_line":364,"end_character":38},"updated":"2016-08-04 01:30:45.000000000","message":"interface","commit_id":"02ee631e5a7c47fa3ea4b8667bc320abc7e2a7a5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5d2f9843e1b1a67b28f1e3cefd8a4e04dfd81b0b","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                    except Exception:"},{"line_number":362,"context_line":"                        with excutils.save_and_reraise_exception():"},{"line_number":363,"context_line":"                            # we need to try to undo the updated router"},{"line_number":364,"context_line":"                            # interfac from above"},{"line_number":365,"context_line":"                            upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":366,"context_line":"                                ip for ip in port[\u0027fixed_ips\u0027]"},{"line_number":367,"context_line":"                                if ip[\u0027subnet_id\u0027] !\u003d fixed_ip[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_87cd92b9","line":364,"range":{"start_line":364,"start_character":30,"end_line":364,"end_character":38},"in_reply_to":"bacf61ea_352b3e96","updated":"2016-08-04 08:45:07.000000000","message":"Done","commit_id":"02ee631e5a7c47fa3ea4b8667bc320abc7e2a7a5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"513287a8a3ffc4a9a0c087194055db242f66c4c2","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                lambda: self._core_plugin.update_port("},{"line_number":371,"context_line":"                                    context.elevated(), port[\u0027id\u0027], upd)"},{"line_number":372,"context_line":"                            )"},{"line_number":373,"context_line":"                            revert()"},{"line_number":374,"context_line":"                    LOG.debug(\"CSNAT port updated for IPv6 subnet: \""},{"line_number":375,"context_line":"                              \"%s\", updated_port)"},{"line_number":376,"context_line":"        router_interface_info \u003d self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_80774a9e","line":373,"updated":"2016-08-04 01:30:45.000000000","message":"i\u0027m feeling we should start using taskflow or something like that.","commit_id":"02ee631e5a7c47fa3ea4b8667bc320abc7e2a7a5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5d2f9843e1b1a67b28f1e3cefd8a4e04dfd81b0b","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                lambda: self._core_plugin.update_port("},{"line_number":371,"context_line":"                                    context.elevated(), port[\u0027id\u0027], upd)"},{"line_number":372,"context_line":"                            )"},{"line_number":373,"context_line":"                            revert()"},{"line_number":374,"context_line":"                    LOG.debug(\"CSNAT port updated for IPv6 subnet: \""},{"line_number":375,"context_line":"                              \"%s\", updated_port)"},{"line_number":376,"context_line":"        router_interface_info \u003d self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_a741b60d","line":373,"in_reply_to":"bacf61ea_80774a9e","updated":"2016-08-04 08:45:07.000000000","message":"Yes, very much so. I think I will start to put a spec together. It may be too late for Newton (at least to have the tasks persisted to the DB for full fault tolerance), but I think it will make this stuff a lot easier to reason about.","commit_id":"02ee631e5a7c47fa3ea4b8667bc320abc7e2a7a5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1b029b23c28f589897bbb24a7082c0ce919e1cd7","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                ]}}"},{"line_number":374,"context_line":"                                self._core_plugin.update_port("},{"line_number":375,"context_line":"                                    context.elevated(), port[\u0027id\u0027], upd)"},{"line_number":376,"context_line":"                            revert()"},{"line_number":377,"context_line":"                    LOG.debug(\"CSNAT port updated for IPv6 subnet: \""},{"line_number":378,"context_line":"                              \"%s\", updated_port)"},{"line_number":379,"context_line":"        router_interface_info \u003d self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_55dae04b","line":376,"updated":"2016-08-05 10:39:36.000000000","message":"Done","commit_id":"57bbd70918b3eccd1713b614b94764cf34f8d86e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fd8f3103275313de02baa90ba65266c48156e139","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                ]}}"},{"line_number":374,"context_line":"                                self._core_plugin.update_port("},{"line_number":375,"context_line":"                                    context.elevated(), port[\u0027id\u0027], upd)"},{"line_number":376,"context_line":"                            revert()"},{"line_number":377,"context_line":"                    LOG.debug(\"CSNAT port updated for IPv6 subnet: \""},{"line_number":378,"context_line":"                              \"%s\", updated_port)"},{"line_number":379,"context_line":"        router_interface_info \u003d self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c074579d","line":376,"updated":"2016-08-05 08:45:19.000000000","message":"when revert() ends up with raising an exception, we should ignore it and raise the original exception.","commit_id":"57bbd70918b3eccd1713b614b94764cf34f8d86e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3ff825dc9dd97a9773e4299c2327dfe862e7ae3e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                            # with the csnat port."},{"line_number":366,"context_line":"                            # TODO(kevinbenton): switch to taskflow to manage"},{"line_number":367,"context_line":"                            # these rollbacks."},{"line_number":368,"context_line":"                            @db_api.retry_db_errors"},{"line_number":369,"context_line":"                            def revert():"},{"line_number":370,"context_line":"                                upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":371,"context_line":"                                    ip for ip in port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0c75ecc9","line":368,"range":{"start_line":368,"start_character":29,"end_line":368,"end_character":51},"updated":"2016-08-05 18:37:07.000000000","message":"If we\u0027re contending on this port update, could that increase our changes of writing a bogus set of fixed_ips back to the port? On each retry, we use the old port data and remove the the fixed_ip matching the subnet_id. What if another operation has come in and changed the fixed_ips?\n\nThis would only be an issue for ipv6 router ports because the ipv4 router ports use a new port for each subnet.","commit_id":"8024d283287c39cc2d2ba2218777be2bd4ce0ed9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a3bcf64d1a1e141f41e530ecec8c2ff593b344a3","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                            # with the csnat port."},{"line_number":366,"context_line":"                            # TODO(kevinbenton): switch to taskflow to manage"},{"line_number":367,"context_line":"                            # these rollbacks."},{"line_number":368,"context_line":"                            @db_api.retry_db_errors"},{"line_number":369,"context_line":"                            def revert():"},{"line_number":370,"context_line":"                                upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":371,"context_line":"                                    ip for ip in port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_926c52d1","line":368,"range":{"start_line":368,"start_character":29,"end_line":368,"end_character":51},"in_reply_to":"bacf61ea_0c75ecc9","updated":"2016-08-05 18:41:02.000000000","message":"s/changes/chances/","commit_id":"8024d283287c39cc2d2ba2218777be2bd4ce0ed9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4a845363081fc8d67139a30d6a05a1854b0ed283","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                            # with the csnat port."},{"line_number":366,"context_line":"                            # TODO(kevinbenton): switch to taskflow to manage"},{"line_number":367,"context_line":"                            # these rollbacks."},{"line_number":368,"context_line":"                            @db_api.retry_db_errors"},{"line_number":369,"context_line":"                            def revert():"},{"line_number":370,"context_line":"                                upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":371,"context_line":"                                    ip for ip in port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e22007fa","line":368,"range":{"start_line":368,"start_character":29,"end_line":368,"end_character":51},"in_reply_to":"bacf61ea_5722a8b9","updated":"2016-08-08 22:57:37.000000000","message":"we can certainly tighten the window with a fresh get_port, but until we can get a compare-and-swap style update available to callers of the core plugin, there will always be a narrow window (even with the create logic). I\u0027ll add a get_port and a note.","commit_id":"8024d283287c39cc2d2ba2218777be2bd4ce0ed9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8cdc89882d13bf5023d0c5a2be1eeb4d70d57b6d","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                            # with the csnat port."},{"line_number":366,"context_line":"                            # TODO(kevinbenton): switch to taskflow to manage"},{"line_number":367,"context_line":"                            # these rollbacks."},{"line_number":368,"context_line":"                            @db_api.retry_db_errors"},{"line_number":369,"context_line":"                            def revert():"},{"line_number":370,"context_line":"                                upd \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["},{"line_number":371,"context_line":"                                    ip for ip in port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_5722a8b9","line":368,"range":{"start_line":368,"start_character":29,"end_line":368,"end_character":51},"in_reply_to":"bacf61ea_926c52d1","updated":"2016-08-08 02:23:32.000000000","message":"Interesting use-case which can lead to a race condition...","commit_id":"8024d283287c39cc2d2ba2218777be2bd4ce0ed9"}]}
