)]}'
{"neutron/extensions/trunk.py":[{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"facc9be30940f14f060857b295fbad3763623ccf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \u0027required_by_policy\u0027: True,"},{"line_number":102,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":103,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":104,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":105,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":106,"context_line":"        \u0027sub_ports\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":107,"context_line":"                      \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_087116a9","line":104,"updated":"2016-07-13 21:14:35.000000000","message":"What updates this status? Or, do you plan to register a dict_extend_func to aggregate all the port statuses?","commit_id":"05be0363382e86e742071fc5249286aee5ce6e02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"599aa88504aeef9a13cdbc1475c6ff2f3f667a27","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \u0027required_by_policy\u0027: True,"},{"line_number":102,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":103,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":104,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":105,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":106,"context_line":"        \u0027sub_ports\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":107,"context_line":"                      \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e3294d3c","line":104,"in_reply_to":"1aa78d24_087116a9","updated":"2016-07-13 21:45:27.000000000","message":"As pointed out in the commit message, this is reserved for future use, once we get the bulk of the agent-side developed we have a better understanding on how to reflect the status of the trunk once the data plane is up.","commit_id":"05be0363382e86e742071fc5249286aee5ce6e02"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a532ffbd41bb3b34773437837310da17ca42060","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":106,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":107,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":108,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":109,"context_line":"        \u0027sub_ports\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":110,"context_line":"                      \u0027default\u0027: [],"},{"line_number":111,"context_line":"                      \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_54ab7ad6","line":108,"updated":"2016-07-19 03:00:15.000000000","message":"we should at least validate that this does not exceed the 16 characters that you have assigned in the DB\n\u0027validate\u0027: {\u0027type:string\u0027: 16},","commit_id":"20b41187dc01ab9c078070e57307e613ca038752"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7fb98aac1e1690a4a45a4d33cb809a4eaa65b992","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":106,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":107,"context_line":"        \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":108,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":109,"context_line":"        \u0027sub_ports\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":110,"context_line":"                      \u0027default\u0027: [],"},{"line_number":111,"context_line":"                      \u0027convert_list_to\u0027: converters.convert_kvp_list_to_dict,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_b4a0f6a0","line":108,"in_reply_to":"dada55a8_54ab7ad6","updated":"2016-07-19 03:10:46.000000000","message":"ignore this comment. its a read only field","commit_id":"20b41187dc01ab9c078070e57307e613ca038752"}],"neutron/objects/trunk.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8caa12949dd8647cf5b3ac70c3b572136fdaee29","unresolved":false,"context_lines":[{"line_number":82,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":83,"context_line":"class Trunk(base.NeutronDbObject):"},{"line_number":84,"context_line":"    # Version 1.0: Initial version"},{"line_number":85,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    db_model \u003d models.Trunk"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_b1bca607","line":85,"updated":"2016-07-14 01:06:42.000000000","message":"you should bump the version number here. then again this is something that has not been released. let me know what you think and i\u0027ll change the score","commit_id":"05be0363382e86e742071fc5249286aee5ce6e02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"236add8e650a7ca53f260b50e30e8a41bd913422","unresolved":false,"context_lines":[{"line_number":82,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":83,"context_line":"class Trunk(base.NeutronDbObject):"},{"line_number":84,"context_line":"    # Version 1.0: Initial version"},{"line_number":85,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    db_model \u003d models.Trunk"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d114d2a0","line":85,"in_reply_to":"1aa78d24_b1bca607","updated":"2016-07-14 01:24:00.000000000","message":"Something tells me you skipped the commit message.","commit_id":"05be0363382e86e742071fc5249286aee5ce6e02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"80c5c838afe64acc8c186860527e2cf148c52fc5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":105,"context_line":"        raise_if_missing \u003d kwargs.pop(\u0027raise_if_missing\u0027, False)"},{"line_number":106,"context_line":"        obj \u003d super(Trunk, cls).get_object(context, **kwargs)"},{"line_number":107,"context_line":"        if obj is None and raise_if_missing:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_e34e5bc0","line":104,"updated":"2016-07-18 11:33:58.000000000","message":"I don\u0027t think such behaviour is properly placed here. If you would like to have it, please do for all objects, in base class. That said, I don\u0027t see a real need to handle it here and not in the caller. It is the designed object API that get_object()/get_objects() don\u0027t raise on missing results. Let\u0027s keep it consistent.","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"efe69cbb9fac2548ab11845750c8791a93e24e07","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":105,"context_line":"        raise_if_missing \u003d kwargs.pop(\u0027raise_if_missing\u0027, False)"},{"line_number":106,"context_line":"        obj \u003d super(Trunk, cls).get_object(context, **kwargs)"},{"line_number":107,"context_line":"        if obj is None and raise_if_missing:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_18bb08c6","line":104,"in_reply_to":"dada55a8_67e705e5","updated":"2016-07-18 17:33:49.000000000","message":"ok, I have had a change of heart, perhaps adding a utility method to the plugin like it\u0027s been done with the qos_plugin in indeed cleaner.","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"911de9b99333eff93b2615044bc15b70e30803f6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":105,"context_line":"        raise_if_missing \u003d kwargs.pop(\u0027raise_if_missing\u0027, False)"},{"line_number":106,"context_line":"        obj \u003d super(Trunk, cls).get_object(context, **kwargs)"},{"line_number":107,"context_line":"        if obj is None and raise_if_missing:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_67e705e5","line":104,"in_reply_to":"dada55a8_7157c702","updated":"2016-07-18 16:38:20.000000000","message":"ok let me see!","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fe75602f25cbc8a6575ac4adc7abe013904bc2ba","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":105,"context_line":"        raise_if_missing \u003d kwargs.pop(\u0027raise_if_missing\u0027, False)"},{"line_number":106,"context_line":"        obj \u003d super(Trunk, cls).get_object(context, **kwargs)"},{"line_number":107,"context_line":"        if obj is None and raise_if_missing:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_7157c702","line":104,"in_reply_to":"dada55a8_bf658be2","updated":"2016-07-18 16:00:16.000000000","message":"An object could specify the exception type to raise as class attribute. Then it would raise the exception, passing primary_keys as id.\n\nIn qos plugin, we just have a _get_policy_obj() that raises the needed exception, that we reuse.","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"35362aee10a175e8a10f93eaccb4ef497cba4246","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":105,"context_line":"        raise_if_missing \u003d kwargs.pop(\u0027raise_if_missing\u0027, False)"},{"line_number":106,"context_line":"        obj \u003d super(Trunk, cls).get_object(context, **kwargs)"},{"line_number":107,"context_line":"        if obj is None and raise_if_missing:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_bf658be2","line":104,"in_reply_to":"dada55a8_e34e5bc0","updated":"2016-07-18 15:18:13.000000000","message":"Checking for missing results and then raise TrunkNotFound happens in multiple places for no good reason. The original signature has not been altered, and as far I far that goes things are consistent.\n\nHow do you suggest we do that for all objects? By passing the exception to raise?","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"}],"neutron/services/trunk/models.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4d58675b6be8ecbaf8244e0038203ff67c6fc544","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                        nullable\u003dFalse,"},{"line_number":35,"context_line":"                        unique\u003dTrue)"},{"line_number":36,"context_line":"    status \u003d sa.Column("},{"line_number":37,"context_line":"        sa.String(16), nullable\u003dFalse, server_default\u003dconstants.ACTIVE_STATUS)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":40,"context_line":"        models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_93dd1a17","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":77},"updated":"2016-07-18 18:23:38.000000000","message":"Why default to active? Wouldn\u0027t we want to wait for VIF plugging and basic trunk initialization to happen before marking the trunk as \"ACTIVE\"? Isn\u0027t there a state like \"BUILDING\" or something along those lines we should be defaulting to instead?","commit_id":"f90656208ed20098396342ff57a15b2535c7a343"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d750b2107d0368f8937e2cbaf3c1410239a7d08c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                        nullable\u003dFalse,"},{"line_number":35,"context_line":"                        unique\u003dTrue)"},{"line_number":36,"context_line":"    status \u003d sa.Column("},{"line_number":37,"context_line":"        sa.String(16), nullable\u003dFalse, server_default\u003dconstants.ACTIVE_STATUS)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":40,"context_line":"        models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_1942e93e","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":77},"in_reply_to":"dada55a8_1655984f","updated":"2016-07-18 18:56:08.000000000","message":"I followed the path that other resources have taken. This is the DB default anyway, nothing stops us from enforcing a different default via business logic (during creation) when time comes to it.","commit_id":"f90656208ed20098396342ff57a15b2535c7a343"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"1d29a42ccf1f6f5dc2c72866f2d8936953fb571e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                        nullable\u003dFalse,"},{"line_number":35,"context_line":"                        unique\u003dTrue)"},{"line_number":36,"context_line":"    status \u003d sa.Column("},{"line_number":37,"context_line":"        sa.String(16), nullable\u003dFalse, server_default\u003dconstants.ACTIVE_STATUS)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":40,"context_line":"        models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_1655984f","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":77},"in_reply_to":"dada55a8_566d5097","updated":"2016-07-18 18:50:25.000000000","message":"I did see the commit message :) Just questioning this default and wondering aloud if there is another status to start with. Your point is well taken though.","commit_id":"f90656208ed20098396342ff57a15b2535c7a343"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94ce85380384e3a68df0089a4abf1378a05cba05","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                        nullable\u003dFalse,"},{"line_number":35,"context_line":"                        unique\u003dTrue)"},{"line_number":36,"context_line":"    status \u003d sa.Column("},{"line_number":37,"context_line":"        sa.String(16), nullable\u003dFalse, server_default\u003dconstants.ACTIVE_STATUS)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":40,"context_line":"        models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_566d5097","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":77},"in_reply_to":"dada55a8_93dd1a17","updated":"2016-07-18 18:40:45.000000000","message":"did you even read the commit message? :)\n\nAt this point it\u0027s premature to worry about \u0027state\u0027, the safest thing to do is to assume that the trunk is active and we\u0027ll worry about how to reflect its status properly when we have finished all the end to end plumbing.","commit_id":"f90656208ed20098396342ff57a15b2535c7a343"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"48f6853a2bb6eaa1fa1a8aa99dc7e7a960381f5a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":71,"context_line":"    def get_trunk(self, context, trunk_id, fields\u003dNone):"},{"line_number":72,"context_line":"        \"\"\"Return information for the specified trunk.\"\"\""},{"line_number":73,"context_line":"        return self._get_trunk(context, trunk_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":76,"context_line":"    @db_base_plugin_common.convert_result_to_dict"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_5230b356","line":73,"updated":"2016-07-18 22:44:02.000000000","message":"Looks like you\u0027re trying to sneak a little bit of refactoring in.  ;)  Since this is all new code that is unreleased, my objection to doing this isn\u0027t strong (no chance for backport, little risk of merge conflict and potential need for revert, etc).  But, it still makes it a little more difficult for reviewers to distinguish between what is refactoring and what changes behavior below.","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"280e6c82e772f895c012d988281cb126940a218e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":71,"context_line":"    def get_trunk(self, context, trunk_id, fields\u003dNone):"},{"line_number":72,"context_line":"        \"\"\"Return information for the specified trunk.\"\"\""},{"line_number":73,"context_line":"        return self._get_trunk(context, trunk_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":76,"context_line":"    @db_base_plugin_common.convert_result_to_dict"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f502713d","line":73,"in_reply_to":"dada55a8_5230b356","updated":"2016-07-18 23:19:47.000000000","message":"I knew you were going to bring this up :)","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"48f6853a2bb6eaa1fa1a8aa99dc7e7a960381f5a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                     for p in trunk[\u0027sub_ports\u0027]]"},{"line_number":96,"context_line":"        trunk_obj \u003d trunk_objects.Trunk("},{"line_number":97,"context_line":"            context\u003dcontext,"},{"line_number":98,"context_line":"            admin_state_up\u003dtrunk.get(\u0027admin_state_up\u0027, True),"},{"line_number":99,"context_line":"            id\u003duuidutils.generate_uuid(),"},{"line_number":100,"context_line":"            name\u003dtrunk.get(\u0027name\u0027, \"\"),"},{"line_number":101,"context_line":"            tenant_id\u003dtrunk[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f2f8c77e","line":98,"range":{"start_line":98,"start_character":27,"end_line":98,"end_character":60},"updated":"2016-07-18 22:44:02.000000000","message":"nit:  You could avoid having to change the indentation by creating a local variable:\n\n  admin_state_up \u003d trunk.get(\u0027admin_state_up\u0027, True)\n\nBut I won\u0027t lose sleep over it.  :)","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"280e6c82e772f895c012d988281cb126940a218e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                     for p in trunk[\u0027sub_ports\u0027]]"},{"line_number":96,"context_line":"        trunk_obj \u003d trunk_objects.Trunk("},{"line_number":97,"context_line":"            context\u003dcontext,"},{"line_number":98,"context_line":"            admin_state_up\u003dtrunk.get(\u0027admin_state_up\u0027, True),"},{"line_number":99,"context_line":"            id\u003duuidutils.generate_uuid(),"},{"line_number":100,"context_line":"            name\u003dtrunk.get(\u0027name\u0027, \"\"),"},{"line_number":101,"context_line":"            tenant_id\u003dtrunk[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_d5ff6d32","line":98,"range":{"start_line":98,"start_character":27,"end_line":98,"end_character":60},"in_reply_to":"dada55a8_f2f8c77e","updated":"2016-07-18 23:19:47.000000000","message":"fair point","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"48f6853a2bb6eaa1fa1a8aa99dc7e7a960381f5a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \"\"\"Delete the specified trunk.\"\"\""},{"line_number":118,"context_line":"        trunk \u003d self._get_trunk(context, trunk_id)"},{"line_number":119,"context_line":"        rules.trunk_can_be_managed(context, trunk)"},{"line_number":120,"context_line":"        if trunk:"},{"line_number":121,"context_line":"            trunk_port_validator \u003d rules.TrunkPortValidator(trunk.port_id)"},{"line_number":122,"context_line":"            if not trunk_port_validator.is_bound(context):"},{"line_number":123,"context_line":"                trunk.delete()"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b235af47","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":17},"updated":"2016-07-18 22:44:02.000000000","message":"nit:  Is this needed given that _get_trunk will now raise an exception?","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"280e6c82e772f895c012d988281cb126940a218e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \"\"\"Delete the specified trunk.\"\"\""},{"line_number":118,"context_line":"        trunk \u003d self._get_trunk(context, trunk_id)"},{"line_number":119,"context_line":"        rules.trunk_can_be_managed(context, trunk)"},{"line_number":120,"context_line":"        if trunk:"},{"line_number":121,"context_line":"            trunk_port_validator \u003d rules.TrunkPortValidator(trunk.port_id)"},{"line_number":122,"context_line":"            if not trunk_port_validator.is_bound(context):"},{"line_number":123,"context_line":"                trunk.delete()"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_15faa542","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":17},"in_reply_to":"dada55a8_b235af47","updated":"2016-07-18 23:19:47.000000000","message":"fair point","commit_id":"31a32142dc944e57706ba88d1cd0d14b998c41c8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0eae4caca7e77f3493b3354dd312b9a676918f8f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    supported_extension_aliases \u003d [\"trunk\", \"trunk-details\"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    __native_pagination_support \u003d True"},{"line_number":39,"context_line":"    __native_sorting_support \u003d True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_ac0d2292","line":38,"updated":"2016-07-19 17:21:35.000000000","message":"heh","commit_id":"20b41187dc01ab9c078070e57307e613ca038752"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0eae4caca7e77f3493b3354dd312b9a676918f8f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        trunk_data \u003d trunk[\u0027trunk\u0027]"},{"line_number":111,"context_line":"        trunk_obj \u003d self._get_trunk(context, trunk_id)"},{"line_number":112,"context_line":"        trunk_obj.update_nonidentifying_fields(trunk_data, reset_changes\u003dTrue)"},{"line_number":113,"context_line":"        trunk_obj.update()"},{"line_number":114,"context_line":"        return trunk_obj"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def delete_trunk(self, context, trunk_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_ec555a50","line":113,"updated":"2016-07-19 17:21:35.000000000","message":"here, you use two transactions to update the trunk object. So you may end up raising an actual db layer error here if the trunk was removed in between line 111 and 113.","commit_id":"20b41187dc01ab9c078070e57307e613ca038752"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c41c83392dc19b4cc366da5238685a88cd91ce9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        trunk_data \u003d trunk[\u0027trunk\u0027]"},{"line_number":111,"context_line":"        trunk_obj \u003d self._get_trunk(context, trunk_id)"},{"line_number":112,"context_line":"        trunk_obj.update_nonidentifying_fields(trunk_data, reset_changes\u003dTrue)"},{"line_number":113,"context_line":"        trunk_obj.update()"},{"line_number":114,"context_line":"        return trunk_obj"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def delete_trunk(self, context, trunk_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_85de310f","line":113,"in_reply_to":"dada55a8_ec555a50","updated":"2016-07-19 18:22:14.000000000","message":"I\u0027ll wrap this, good catch.","commit_id":"20b41187dc01ab9c078070e57307e613ca038752"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"9daf7e60582a8bf52954d5a38172e85774ebcffd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if subports:"},{"line_number":27,"context_line":"            client.remove_subports("},{"line_number":28,"context_line":"                trunk[\u0027id\u0027], subports[\u0027sub_ports\u0027])"},{"line_number":29,"context_line":"        test_utils.call_and_ignore_notfound_exc("},{"line_number":30,"context_line":"            client.delete_trunk, trunk[\u0027id\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_14d139ce","line":29,"updated":"2016-07-15 17:02:10.000000000","message":"Should we update the trunk\u0027s admin_state_up\u003dTrue here rather than the end of tests that set it to False so that it can be deleted?","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"e46f901f64fab9e3ec37988d4db10247c619225a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if subports:"},{"line_number":27,"context_line":"            client.remove_subports("},{"line_number":28,"context_line":"                trunk[\u0027id\u0027], subports[\u0027sub_ports\u0027])"},{"line_number":29,"context_line":"        test_utils.call_and_ignore_notfound_exc("},{"line_number":30,"context_line":"            client.delete_trunk, trunk[\u0027id\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_064a96c5","line":29,"in_reply_to":"fad55976_052bc131","updated":"2016-07-15 22:49:43.000000000","message":"Fair enough, I\u0027ll rescind my -1","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3a7d4d3e39f860920ed043deb504acae43533d3e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if subports:"},{"line_number":27,"context_line":"            client.remove_subports("},{"line_number":28,"context_line":"                trunk[\u0027id\u0027], subports[\u0027sub_ports\u0027])"},{"line_number":29,"context_line":"        test_utils.call_and_ignore_notfound_exc("},{"line_number":30,"context_line":"            client.delete_trunk, trunk[\u0027id\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_052bc131","line":29,"in_reply_to":"fad55976_14d139ce","updated":"2016-07-15 18:00:20.000000000","message":"I\u0027d rather not, as that that would cause an extra call even for trunks that don\u0027t need it, and that\u0027s expensive.","commit_id":"9d9536e5a4ce2faa4390bad93afb9b4f29f1967a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"48f6853a2bb6eaa1fa1a8aa99dc7e7a960381f5a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"class TrunksSearchCriteriaTest(base.BaseSearchCriteriaTest):"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":165,"context_line":"    field \u003d \u0027id\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @classmethod"},{"line_number":168,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_521713a3","side":"PARENT","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":16},"updated":"2016-07-18 22:44:02.000000000","message":"nit:  This seems unrelated.","commit_id":"ca57c9fe8f029edb4d20976319fcc6a0aa6b0831"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"280e6c82e772f895c012d988281cb126940a218e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"class TrunksSearchCriteriaTest(base.BaseSearchCriteriaTest):"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":165,"context_line":"    field \u003d \u0027id\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @classmethod"},{"line_number":168,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b59f5902","side":"PARENT","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":16},"in_reply_to":"dada55a8_521713a3","updated":"2016-07-18 23:19:47.000000000","message":"well, not really, because now that the \u0027name\u0027 attribute is available the override is no longer necessary.","commit_id":"ca57c9fe8f029edb4d20976319fcc6a0aa6b0831"}]}
