)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"bba9509c71f13d57f4a43a8bb0292e158002b1c5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-07-15 05:36:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenAPI: add support for conntrack with XenServer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I304788240bcd590ec211bca052fe64594a4e6eca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_22b6addc","line":8,"updated":"2016-07-15 22:01:40.000000000","message":"Closes-Bug: #1603400","commit_id":"6aaa636f4480370c156285608f5429d81274d845"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"27be68fbd1016e1380180553f457fecefb5a5e23","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-07-15 05:36:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenAPI: add support for conntrack with XenServer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I304788240bcd590ec211bca052fe64594a4e6eca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_e03f4923","line":8,"in_reply_to":"fad55976_22b6addc","updated":"2016-07-16 04:10:19.000000000","message":"Thanks, I pushed the patch before register a bug in Launchpad, so I forgot to add Close-Bug, will add it","commit_id":"6aaa636f4480370c156285608f5429d81274d845"}],"bin/neutron-rootwrap-xen-dom0":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"40fe766c76ab5a6fb6cd70e5d56565c347356af6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            result \u003d session.xenapi.host.call_plugin("},{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            _out \u003d json.loads(result)"},{"line_number":122,"context_line":"            returncode \u003d _out.get(\u0027returncode\u0027)"},{"line_number":123,"context_line":"            _stdout \u003d _out.get(\u0027out\u0027)"},{"line_number":124,"context_line":"            _stderr \u003d _out.get(\u0027err\u0027)"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7a8ec9b2_e4e54309","line":121,"updated":"2016-09-21 13:03:32.000000000","message":"Let\u0027s make this clearer:\nresult_dict\u003djson.loads(result)","commit_id":"32699ad095b17f36bd85e0b198b4d2c1efba52f3"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"bc49cead0b348fb1a56ca74859bea47687d9e92b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            result \u003d session.xenapi.host.call_plugin("},{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            _out \u003d json.loads(result)"},{"line_number":122,"context_line":"            returncode \u003d _out.get(\u0027returncode\u0027)"},{"line_number":123,"context_line":"            _stdout \u003d _out.get(\u0027out\u0027)"},{"line_number":124,"context_line":"            _stderr \u003d _out.get(\u0027err\u0027)"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"5a8bc5a2_5d045c7d","line":121,"in_reply_to":"7a8ec9b2_e4e54309","updated":"2016-09-23 02:32:43.000000000","message":"sure, done","commit_id":"32699ad095b17f36bd85e0b198b4d2c1efba52f3"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"40fe766c76ab5a6fb6cd70e5d56565c347356af6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            _out \u003d json.loads(result)"},{"line_number":122,"context_line":"            returncode \u003d _out.get(\u0027returncode\u0027)"},{"line_number":123,"context_line":"            _stdout \u003d _out.get(\u0027out\u0027)"},{"line_number":124,"context_line":"            _stderr \u003d _out.get(\u0027err\u0027)"},{"line_number":125,"context_line":"            sys.stdout.write(_stdout)"},{"line_number":126,"context_line":"            sys.stderr.write(_stderr)"},{"line_number":127,"context_line":"            sys.exit(returncode)"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7a8ec9b2_c4cf677d","line":124,"updated":"2016-09-21 13:03:32.000000000","message":"Don\u0027t use _stdout, _stderr, underscores preceeding variable names look weird - perhaps captured_stdout/captured_stderr to be totally clear","commit_id":"32699ad095b17f36bd85e0b198b4d2c1efba52f3"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"bc49cead0b348fb1a56ca74859bea47687d9e92b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            _out \u003d json.loads(result)"},{"line_number":122,"context_line":"            returncode \u003d _out.get(\u0027returncode\u0027)"},{"line_number":123,"context_line":"            _stdout \u003d _out.get(\u0027out\u0027)"},{"line_number":124,"context_line":"            _stderr \u003d _out.get(\u0027err\u0027)"},{"line_number":125,"context_line":"            sys.stdout.write(_stdout)"},{"line_number":126,"context_line":"            sys.stderr.write(_stderr)"},{"line_number":127,"context_line":"            sys.exit(returncode)"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"5a8bc5a2_bd3ac034","line":124,"in_reply_to":"7a8ec9b2_c4cf677d","updated":"2016-09-23 02:32:43.000000000","message":"agreed, done","commit_id":"32699ad095b17f36bd85e0b198b4d2c1efba52f3"}],"neutron/agent/linux/utils.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c5cd272b4db80bbcdc990ee01e26dbd2d1e17c98","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if \"rootwrap-xen-dom0\" in cfg.CONF.AGENT.root_helper:"},{"line_number":120,"context_line":"                _out, _err \u003d obj.communicate(_process_input)"},{"line_number":121,"context_line":"                # result is dict returned from Dom0 plugin"},{"line_number":122,"context_line":"                result \u003d ast.literal_eval(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_ebe8b218","line":122,"updated":"2016-07-25 11:56:11.000000000","message":"If you\u0027re using json to encode the return value, you should use json to decode it back into a dictionary?","commit_id":"70db7262abe26821c9257454b06d0be9197ced67"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"352bf2c2bc9ce275a6432c50531c26b9c88ddc6e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if \"rootwrap-xen-dom0\" in cfg.CONF.AGENT.root_helper:"},{"line_number":120,"context_line":"                _out, _err \u003d obj.communicate(_process_input)"},{"line_number":121,"context_line":"                # result is dict returned from Dom0 plugin"},{"line_number":122,"context_line":"                result \u003d ast.literal_eval(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_ae5efc42","line":122,"in_reply_to":"dada55a8_0093f35b","updated":"2016-07-28 08:03:53.000000000","message":"agree, I can move the decode from \"neutron-rootwrap-xen-dom0\" to here, let \"neutron-rootwrap-xen-dom0\" return the result transparently","commit_id":"70db7262abe26821c9257454b06d0be9197ced67"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"a7d1ce2fdfd52078f89197b5371b8a218045a72a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if \"rootwrap-xen-dom0\" in cfg.CONF.AGENT.root_helper:"},{"line_number":120,"context_line":"                _out, _err \u003d obj.communicate(_process_input)"},{"line_number":121,"context_line":"                # result is dict returned from Dom0 plugin"},{"line_number":122,"context_line":"                result \u003d ast.literal_eval(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_f1820151","line":122,"in_reply_to":"dada55a8_ebe8b218","updated":"2016-07-27 01:45:57.000000000","message":"Decode is done here: https://github.com/openstack/neutron/blob/master/bin/neutron-rootwrap-xen-dom0#L121\nThe existing implementation in upstream also use json to encode/decode, so I just re-ues the existing encode/decode part, just change the return value from single output to dict","commit_id":"70db7262abe26821c9257454b06d0be9197ced67"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f361fc515d4e13041737ad9e319aa8cb11a4abcc","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if \"rootwrap-xen-dom0\" in cfg.CONF.AGENT.root_helper:"},{"line_number":120,"context_line":"                _out, _err \u003d obj.communicate(_process_input)"},{"line_number":121,"context_line":"                # result is dict returned from Dom0 plugin"},{"line_number":122,"context_line":"                result \u003d ast.literal_eval(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_0093f35b","line":122,"in_reply_to":"dada55a8_f1820151","updated":"2016-07-27 08:44:52.000000000","message":"OK, then perhaps it should not be, and perhaps the decode should be here?\nI really don\u0027t like assuming a string is a python object. I know ast.literal_eval *should* be safe, but any strings that are passed between processes should be json encoded.","commit_id":"70db7262abe26821c9257454b06d0be9197ced67"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8e25d4d78183042e0aef3980ff0a0b6c80592184","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                result \u003d jsonutils.loads(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"},{"line_number":126,"context_line":"            else:"},{"line_number":127,"context_line":"                _stdout, _stderr \u003d obj.communicate(_process_input)"},{"line_number":128,"context_line":"                returncode \u003d obj.returncode"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_b1c39788","line":125,"updated":"2016-08-17 05:34:24.000000000","message":"why can\u0027t neutron-rootwrap-xen-dom0 propagate the stderr and the return code in a usual way?","commit_id":"baf938a02267cac87e583b7bf0d90cf123551d1b"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"d7f681a992e860b01e282c1afe585c4328e5796d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                result \u003d jsonutils.loads(_out)"},{"line_number":123,"context_line":"                returncode \u003d result.get(\u0027returncode\u0027)"},{"line_number":124,"context_line":"                _stdout \u003d result.get(\u0027out\u0027)"},{"line_number":125,"context_line":"                _stderr \u003d result.get(\u0027err\u0027)"},{"line_number":126,"context_line":"            else:"},{"line_number":127,"context_line":"                _stdout, _stderr \u003d obj.communicate(_process_input)"},{"line_number":128,"context_line":"                returncode \u003d obj.returncode"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_2d23c057","line":125,"in_reply_to":"3ac371cc_b1c39788","updated":"2016-08-17 10:35:16.000000000","message":"I see, it\u0027s much better to propagate stdout/stderr/return code, thanks for your comments, I will change this part","commit_id":"baf938a02267cac87e583b7bf0d90cf123551d1b"}],"neutron/plugins/ml2/drivers/openvswitch/agent/xenapi/etc/xapi.d/plugins/netwrap":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0d9e104ec22b91b540f212cd34e8a06b51ced497","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise PluginError(msg)"},{"line_number":73,"context_line":"    returncode, out, err \u003d _run_command("},{"line_number":74,"context_line":"                                cmd, json.loads(args.get(\u0027cmd_input\u0027, \u0027null\u0027)))"},{"line_number":75,"context_line":"    if not err:"},{"line_number":76,"context_line":"        err \u003d \"\""},{"line_number":77,"context_line":"    if not out:"},{"line_number":78,"context_line":"        out \u003d \"\""},{"line_number":79,"context_line":"    # This runs in Dom0, will return to neutron-ovs-agent in compute node"},{"line_number":80,"context_line":"    result \u003d {\u0027returncode\u0027: returncode,"},{"line_number":81,"context_line":"              \u0027out\u0027: out,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da6895a0_73732db2","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":16},"updated":"2016-10-21 10:05:53.000000000","message":"why is this necessary?  can they be None or something like that?","commit_id":"0d8483391dd7aa19304e3f1e2b6ea3bee040a279"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"1e8a3e3d52ac53bac66ac2a62f9433c592029df5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise PluginError(msg)"},{"line_number":73,"context_line":"    returncode, out, err \u003d _run_command("},{"line_number":74,"context_line":"                                cmd, json.loads(args.get(\u0027cmd_input\u0027, \u0027null\u0027)))"},{"line_number":75,"context_line":"    if not err:"},{"line_number":76,"context_line":"        err \u003d \"\""},{"line_number":77,"context_line":"    if not out:"},{"line_number":78,"context_line":"        out \u003d \"\""},{"line_number":79,"context_line":"    # This runs in Dom0, will return to neutron-ovs-agent in compute node"},{"line_number":80,"context_line":"    result \u003d {\u0027returncode\u0027: returncode,"},{"line_number":81,"context_line":"              \u0027out\u0027: out,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da6895a0_a6dae176","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":16},"in_reply_to":"da6895a0_33945536","updated":"2016-10-21 10:39:32.000000000","message":"Thanks for your detailed review:)","commit_id":"0d8483391dd7aa19304e3f1e2b6ea3bee040a279"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d7d5032137168cd38b5f4d8f27c5c8208730adec","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise PluginError(msg)"},{"line_number":73,"context_line":"    returncode, out, err \u003d _run_command("},{"line_number":74,"context_line":"                                cmd, json.loads(args.get(\u0027cmd_input\u0027, \u0027null\u0027)))"},{"line_number":75,"context_line":"    if not err:"},{"line_number":76,"context_line":"        err \u003d \"\""},{"line_number":77,"context_line":"    if not out:"},{"line_number":78,"context_line":"        out \u003d \"\""},{"line_number":79,"context_line":"    # This runs in Dom0, will return to neutron-ovs-agent in compute node"},{"line_number":80,"context_line":"    result \u003d {\u0027returncode\u0027: returncode,"},{"line_number":81,"context_line":"              \u0027out\u0027: out,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da6895a0_d31a3917","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":16},"in_reply_to":"da6895a0_73732db2","updated":"2016-10-21 10:12:05.000000000","message":"I suspect that, because we are passing stdout\u003dpipe, stderr\u003dpipe that these will never be None - however the xmlrpc interface used by XAPI cannot encode None and will give a hard failure if None is passed through the dictionary.\n\nIt\u0027s an extra layer of safety really.","commit_id":"0d8483391dd7aa19304e3f1e2b6ea3bee040a279"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"1e8a3e3d52ac53bac66ac2a62f9433c592029df5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise PluginError(msg)"},{"line_number":73,"context_line":"    returncode, out, err \u003d _run_command("},{"line_number":74,"context_line":"                                cmd, json.loads(args.get(\u0027cmd_input\u0027, \u0027null\u0027)))"},{"line_number":75,"context_line":"    if not err:"},{"line_number":76,"context_line":"        err \u003d \"\""},{"line_number":77,"context_line":"    if not out:"},{"line_number":78,"context_line":"        out \u003d \"\""},{"line_number":79,"context_line":"    # This runs in Dom0, will return to neutron-ovs-agent in compute node"},{"line_number":80,"context_line":"    result \u003d {\u0027returncode\u0027: returncode,"},{"line_number":81,"context_line":"              \u0027out\u0027: out,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da6895a0_8696bd92","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":16},"in_reply_to":"da6895a0_d31a3917","updated":"2016-10-21 10:39:32.000000000","message":"Thanks for your explanation:)","commit_id":"0d8483391dd7aa19304e3f1e2b6ea3bee040a279"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5a2693c2c7804f0586ee76597c70d993f26b0b11","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise PluginError(msg)"},{"line_number":73,"context_line":"    returncode, out, err \u003d _run_command("},{"line_number":74,"context_line":"                                cmd, json.loads(args.get(\u0027cmd_input\u0027, \u0027null\u0027)))"},{"line_number":75,"context_line":"    if not err:"},{"line_number":76,"context_line":"        err \u003d \"\""},{"line_number":77,"context_line":"    if not out:"},{"line_number":78,"context_line":"        out \u003d \"\""},{"line_number":79,"context_line":"    # This runs in Dom0, will return to neutron-ovs-agent in compute node"},{"line_number":80,"context_line":"    result \u003d {\u0027returncode\u0027: returncode,"},{"line_number":81,"context_line":"              \u0027out\u0027: out,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da6895a0_33945536","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":16},"in_reply_to":"da6895a0_d31a3917","updated":"2016-10-21 10:16:18.000000000","message":"ok, thank you for explanation.","commit_id":"0d8483391dd7aa19304e3f1e2b6ea3bee040a279"}]}
