)]}'
{"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"240a7814cea529ee7a61830041dbf9c0d0947f40","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        # clean up resources after each test"},{"line_number":27,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":28,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_63d6f8c4","line":27,"updated":"2016-07-14 00:04:27.000000000","message":"I don\u0027t think this cleans up trunks or subports explicitly. As of now they will cascade on port delete, but I don\u0027t think we should rely on that. I\u0027m thinking we should be cleaning up trunks and subports before resource_cleanup is invoked. I\u0027m wondering if we should override resource_cleanup() and clean up subports, then trunks, then call super.resource_cleanup().","commit_id":"c807eeaa0d00ea7846ff9c94d8f23f21bcb7858f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a0730a41b8ca614f20a586b3c928b6dfa8986e64","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        # clean up resources after each test"},{"line_number":27,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":28,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6320b8b1","line":27,"in_reply_to":"1aa78d24_63d6f8c4","updated":"2016-07-14 00:08:53.000000000","message":"you\u0027re right that right now trunks get deleted on cascade. In practice this logic will break as soon as we prevent port deletion when a trunk is active and we\u0027ll need to revisit. We can do it now and be done with it.","commit_id":"c807eeaa0d00ea7846ff9c94d8f23f21bcb7858f"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"5005a2c5ea731c5faf3f1a97ba41656f77cd5e0e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    extension \u003d \u0027trunk\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":39,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_ff81e3fc","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":23},"updated":"2016-07-15 16:08:12.000000000","message":"question: why is this needed in this class but not for TrunksSearchCriteriaTest?","commit_id":"698e601364cc249a5f9adf1b9e1130f67bf04ade"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"f9c0ce9969cb544fd4e56c190eb9fd96a4033f1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    extension \u003d \u0027trunk\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":39,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_911d3b69","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":23},"in_reply_to":"fad55976_7f2053f8","updated":"2016-07-15 16:31:55.000000000","message":"Ah ok, so in this class the cleanup is required after running every individual test, whereas the cleanup in TrunksSearchCriteriaTest is only required at the end of running all the tests?","commit_id":"698e601364cc249a5f9adf1b9e1130f67bf04ade"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ba158634b793523098906cc9490e7e382530c55c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    extension \u003d \u0027trunk\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":39,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_d1033375","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":23},"in_reply_to":"fad55976_911d3b69","updated":"2016-07-15 16:36:54.000000000","message":"yes","commit_id":"698e601364cc249a5f9adf1b9e1130f67bf04ade"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"ca165f9af6a04bbbb35e23584142b9692f9e1f80","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    extension \u003d \u0027trunk\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.addCleanup(self.resource_cleanup)"},{"line_number":39,"context_line":"        super(TrunkTestJSONBase, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_7f2053f8","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":23},"in_reply_to":"fad55976_ff81e3fc","updated":"2016-07-15 16:15:48.000000000","message":"TrunksSearchCriteriaTest only creates 1 network with a single trunk. It then tests the sorting, etc. against that 1 trunk. No issues with bumping into a quota limit there. Each test operates against the same trunk which is left in the system throughout all the tests. In these tests, each test creates a new network that needs to be cleaned up after each test. TrunksSearchCriteriaTest won\u0027t cause us to bump into quota issues, but these tests will.","commit_id":"698e601364cc249a5f9adf1b9e1130f67bf04ade"}]}