)]}'
{"neutron/agent/l3/item_allocator.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"88cf1520e61a298b1dcc4139edf667958ec7a71f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                key, saved_value \u003d line.strip().split(delimiter)"},{"line_number":52,"context_line":"                self.remembered[key] \u003d self.ItemClass(saved_value)"},{"line_number":53,"context_line":"            except ValueError:"},{"line_number":54,"context_line":"                LOG.debug(\"Invalid line in %(file)s, ignoring: %(line)s\","},{"line_number":55,"context_line":"                          {\u0027file\u0027: state_file, \u0027line\u0027: line})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.pool.difference_update(self.remembered.values())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_882fc687","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":25},"updated":"2016-07-13 21:15:21.000000000","message":"This is essentially swallowing the error as no one will ever see this message.  What more could we do?  I\u0027m not sure there is any reasonable action that the operator could take on this.\n\nI know this was seen in unit tests where many tests can run in parallel.  Is there any chance the same could happen in the wild?  Does the agent guarantee that access to the file is synchronized appropriately?","commit_id":"fd9d205af779cd88d5920f2e483d2c570d2064a0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e126a2e7f9b1bbfe732d622b46d029e7d02ac614","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                key, saved_value \u003d line.strip().split(delimiter)"},{"line_number":52,"context_line":"                self.remembered[key] \u003d self.ItemClass(saved_value)"},{"line_number":53,"context_line":"            except ValueError:"},{"line_number":54,"context_line":"                LOG.debug(\"Invalid line in %(file)s, ignoring: %(line)s\","},{"line_number":55,"context_line":"                          {\u0027file\u0027: state_file, \u0027line\u0027: line})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.pool.difference_update(self.remembered.values())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_501c3c6a","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":25},"in_reply_to":"1aa78d24_882fc687","updated":"2016-07-14 15:14:28.000000000","message":"Right.  I had thought about making it a warning, so at least it might be noticed, even though there is nothing that can be done.\n\nThe one thing we could do is re-write the file if we have an error, since then that would make it correct, should be easy enough to do that.","commit_id":"fd9d205af779cd88d5920f2e483d2c570d2064a0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"c7f9eb65da7b8287b423e8b60e749957ea1a0daf","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.pool.difference_update(self.remembered.values())"},{"line_number":63,"context_line":"        if read_error:"},{"line_number":64,"context_line":"            LOG.debug(\"Re-writing file %s due to read error\", state_file)"},{"line_number":65,"context_line":"            self._write_allocations()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allocate(self, key):"},{"line_number":68,"context_line":"        \"\"\"Try to allocate an item of ItemClass type."}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a9b8912b","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":37},"updated":"2016-07-14 19:40:29.000000000","message":"I\u0027m sure its just my lack of knowledge for this code here, but why can\u0027t this just be done in the except clause above?  It appears self.pool is not used in self._write_allocations().  So L62 doesn\u0027t seem like it needs to happen before the self._write_allocations.\n\nAgain, I\u0027m sure its just my lack of knowledge in this area.","commit_id":"ed34f18916c62d77358d4c5910ff17694828576a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"345e7d5702d0b1a9d19dde7feb93b8f3ab3b2dee","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.pool.difference_update(self.remembered.values())"},{"line_number":63,"context_line":"        if read_error:"},{"line_number":64,"context_line":"            LOG.debug(\"Re-writing file %s due to read error\", state_file)"},{"line_number":65,"context_line":"            self._write_allocations()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allocate(self, key):"},{"line_number":68,"context_line":"        \"\"\"Try to allocate an item of ItemClass type."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_60ff0835","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":37},"in_reply_to":"1aa78d24_69afc92b","updated":"2016-07-27 19:45:19.000000000","message":"To be honest, my brain went down the same line of thinking but I didn\u0027t have to ask because you beat me to it. Good question.","commit_id":"ed34f18916c62d77358d4c5910ff17694828576a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"73995506f095055f3600b3d82dbc88332aba70cc","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.pool.difference_update(self.remembered.values())"},{"line_number":63,"context_line":"        if read_error:"},{"line_number":64,"context_line":"            LOG.debug(\"Re-writing file %s due to read error\", state_file)"},{"line_number":65,"context_line":"            self._write_allocations()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allocate(self, key):"},{"line_number":68,"context_line":"        \"\"\"Try to allocate an item of ItemClass type."}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e9773906","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":37},"in_reply_to":"1aa78d24_a9b8912b","updated":"2016-07-14 19:55:19.000000000","message":"I did this after the loop so that we waited until self.remembered was fully populated since there could be more than one error.  self._write_allocations() is going to write everything at once, truncating the file if it already exists.","commit_id":"ed34f18916c62d77358d4c5910ff17694828576a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"20383d1093e7a3d41d8520b3e9fd4f8d3b2ee010","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.pool.difference_update(self.remembered.values())"},{"line_number":63,"context_line":"        if read_error:"},{"line_number":64,"context_line":"            LOG.debug(\"Re-writing file %s due to read error\", state_file)"},{"line_number":65,"context_line":"            self._write_allocations()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allocate(self, key):"},{"line_number":68,"context_line":"        \"\"\"Try to allocate an item of ItemClass type."}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_69afc92b","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":37},"in_reply_to":"1aa78d24_e9773906","updated":"2016-07-14 19:58:29.000000000","message":"boo, my brain did not see the loop.  thanks for answering dumb tunnel vision question :)","commit_id":"ed34f18916c62d77358d4c5910ff17694828576a"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e126a2e7f9b1bbfe732d622b46d029e7d02ac614","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"},{"line_number":87,"context_line":"        temp_dir \u003d self.get_new_temp_dir()"},{"line_number":88,"context_line":"        functools.partial(self.get_temp_file_path, root\u003dtemp_dir)"},{"line_number":89,"context_line":"        self.conf.set_override(\u0027state_path\u0027, temp_dir.path)"},{"line_number":90,"context_line":"        self.conf.set_override(\u0027ra_confs\u0027, temp_dir.path)"},{"line_number":91,"context_line":"        self.conf.set_override(\u0027pd_dhcp_driver\u0027, \u0027\u0027)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b029203a","line":89,"updated":"2016-07-14 15:14:28.000000000","message":"Something else I thought of last night is that this should be done at a higher level, a test shouldn\u0027t be setting an override of this.  I\u0027ll see about moving this to the base code.","commit_id":"fd9d205af779cd88d5920f2e483d2c570d2064a0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e126a2e7f9b1bbfe732d622b46d029e7d02ac614","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"        self.assertEqual(tuple(), agent.neutron_service_plugins)"},{"line_number":2237,"context_line":""},{"line_number":2238,"context_line":"    def test_external_gateway_removed_ext_gw_port_no_fip_ns(self):"},{"line_number":2239,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":2242,"context_line":"        agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_70d69828","line":2239,"updated":"2016-07-14 15:14:28.000000000","message":"Think I missed this one.","commit_id":"fd9d205af779cd88d5920f2e483d2c570d2064a0"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5cca40ce4d133474b8fcc93d18eff0a9258b64f0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                               \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":85,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"},{"line_number":86,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":87,"context_line":"        self.conf.set_override(\u0027ra_confs\u0027, \u0027/tmp\u0027)"},{"line_number":88,"context_line":"        self.conf.set_override(\u0027pd_dhcp_driver\u0027, \u0027\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.device_exists_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5450a70a","side":"PARENT","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":50},"updated":"2016-07-14 18:07:39.000000000","message":"Is this related?","commit_id":"4b82d0a4435b9245e1957993911981ed9c356b36"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"345e7d5702d0b1a9d19dde7feb93b8f3ab3b2dee","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                               \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":85,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"},{"line_number":86,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":87,"context_line":"        self.conf.set_override(\u0027ra_confs\u0027, \u0027/tmp\u0027)"},{"line_number":88,"context_line":"        self.conf.set_override(\u0027pd_dhcp_driver\u0027, \u0027\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.device_exists_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_80779cd3","side":"PARENT","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":50},"in_reply_to":"1aa78d24_348fdb76","updated":"2016-07-27 19:45:19.000000000","message":"Given that you\u0027re changing state_path in this patch and you want this config variable to follow, I think this is related.","commit_id":"4b82d0a4435b9245e1957993911981ed9c356b36"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3d0bf392766e722b18e72a93e6ec633afe878e0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                               \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":85,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"},{"line_number":86,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":87,"context_line":"        self.conf.set_override(\u0027ra_confs\u0027, \u0027/tmp\u0027)"},{"line_number":88,"context_line":"        self.conf.set_override(\u0027pd_dhcp_driver\u0027, \u0027\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.device_exists_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_348fdb76","side":"PARENT","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":50},"in_reply_to":"1aa78d24_5450a70a","updated":"2016-07-14 18:08:44.000000000","message":"It\u0027s just not necessary from what I can tell since it defaults to $state_path/ra","commit_id":"4b82d0a4435b9245e1957993911981ed9c356b36"}],"neutron/tests/unit/agent/l3/test_dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7affc371af35aab092981514d1fbe649c6a56742","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"},{"line_number":62,"context_line":"        temp_dir \u003d self.get_new_temp_dir()"},{"line_number":63,"context_line":"        functools.partial(self.get_temp_file_path, root\u003dtemp_dir)"},{"line_number":64,"context_line":"        self.conf.set_override(\u0027state_path\u0027, temp_dir.path)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.device_exists_p \u003d mock.patch("},{"line_number":67,"context_line":"            \u0027neutron.agent.linux.ip_lib.device_exists\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_235e8712","line":64,"updated":"2016-07-14 17:05:22.000000000","message":"arg, missed the update on this one","commit_id":"e8472cde46b283e68bd03d14d3600eda60a7bbd6"}]}
