)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4b8c32a6818ad0d4b026fd24b15b623591179b0f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cbochi@tethrnet.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 23:50:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add support for QinQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since there\u0027s effor in ovs community to add QinQ support,"},{"line_number":10,"context_line":"this patch is to add QinQ support in nuetron for ovs agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_945529c8","line":7,"updated":"2016-07-15 16:49:15.000000000","message":"this should add in Open vSwitch.","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"6a7b329cebed4d3376b1cd86d9f52ef06e0026b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cbochi@tethrnet.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 23:50:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add support for QinQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since there\u0027s effor in ovs community to add QinQ support,"},{"line_number":10,"context_line":"this patch is to add QinQ support in nuetron for ovs agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_6d1cd177","line":7,"in_reply_to":"fad55976_945529c8","updated":"2016-07-19 14:47:35.000000000","message":"Done","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c07d17a4fd4d4cd1130f3fefa06009f40154d6dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Add support for QinQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since there\u0027s effor in ovs community to add QinQ support,"},{"line_number":10,"context_line":"this patch is to add QinQ support in nuetron for ovs agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch uses the already exist property vlan_transparent of network"},{"line_number":13,"context_line":"to indicate that corresponding ovs port needs to be configure to QinQ"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_8e2216b8","line":10,"updated":"2016-07-18 15:59:06.000000000","message":"I think this should be reworded to make it clear what this patch is trying to do.  Here\u0027s a stab at what I think it should say:\n\n\"This patch leverages the effort in the ovs community to add QinQ support in order to enable vlan transparent networks when using the openvswitch ML2 driver.\"","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"6a7b329cebed4d3376b1cd86d9f52ef06e0026b3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Add support for QinQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since there\u0027s effor in ovs community to add QinQ support,"},{"line_number":10,"context_line":"this patch is to add QinQ support in nuetron for ovs agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch uses the already exist property vlan_transparent of network"},{"line_number":13,"context_line":"to indicate that corresponding ovs port needs to be configure to QinQ"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_8d19458b","line":10,"in_reply_to":"dada55a8_8e2216b8","updated":"2016-07-19 14:47:35.000000000","message":"Done","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"3704aa28219548468ee3b78ab307fa56544762d3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Values for qinq tunnel"},{"line_number":76,"context_line":"QINQ_TUNNEL_MODE \u003d \"qinq-tunnel\""},{"line_number":77,"context_line":"QINQ_ENCTYPE \u003d \"0x8100\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# Values for network_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_f38544ad","line":76,"range":{"start_line":76,"start_character":20,"end_line":76,"end_character":31},"updated":"2016-07-19 15:18:09.000000000","message":"According to the upstream Open vSwitch patch for q-in-q tunneling, this mode is named \u0027dot1q-tunnel\u0027.","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"dd620fdf7c46b128f74639ce344e68ee5687a316","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Values for qinq tunnel"},{"line_number":76,"context_line":"QINQ_TUNNEL_MODE \u003d \"qinq-tunnel\""},{"line_number":77,"context_line":"QINQ_ENCTYPE \u003d \"0x8100\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# Values for network_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_9f3e6b26","line":76,"range":{"start_line":76,"start_character":20,"end_line":76,"end_character":31},"in_reply_to":"dada55a8_f38544ad","updated":"2016-07-20 06:30:28.000000000","message":"Done, thanks for pointing out","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"da3ed40de632227cd821ae2f9ecaf7dea6336ac7","unresolved":false,"context_lines":[{"line_number":773,"context_line":"    def port_bound(self, port, net_uuid,"},{"line_number":774,"context_line":"                   network_type, physical_network,"},{"line_number":775,"context_line":"                   segmentation_id, vlan_transparent, fixed_ips, device_owner,"},{"line_number":776,"context_line":"                   ovs_restarted):"},{"line_number":777,"context_line":"        \u0027\u0027\u0027Bind port to net_uuid/lsw_id and install flow for inbound traffic"},{"line_number":778,"context_line":"        to vm."},{"line_number":779,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_9e354df9","line":776,"range":{"start_line":776,"start_character":32,"end_line":776,"end_character":34},"updated":"2016-07-15 15:38:46.000000000","message":"Rather than add the \u0027vlan_transparent\u0027 in the middle of the argument list, it might be preferable to add it to the end as \u0027vlan_transparent\u003dFalse\u0027.  This way existing unit tests that invoke port_bound won\u0027t need to be changed as much.","commit_id":"930e45af4320d7a17bed6c8659cfd200ed50640e"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"da3ed40de632227cd821ae2f9ecaf7dea6336ac7","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"        return changed_ports"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def treat_vif_port(self, vif_port, port_id, network_id, network_type,"},{"line_number":1402,"context_line":"                       physical_network, segmentation_id, vlan_transparent,"},{"line_number":1403,"context_line":"                       admin_state_up, fixed_ips, device_owner,"},{"line_number":1404,"context_line":"                       ovs_restarted):"},{"line_number":1405,"context_line":"        # When this function is called for a port, the port should have"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_796233da","line":1402,"range":{"start_line":1402,"start_character":58,"end_line":1402,"end_character":74},"updated":"2016-07-15 15:38:46.000000000","message":"Same comment here as in port_bound definition, this might be better placed at the end of the argument list as \u0027vlan_transparent\u003dFalse\u0027","commit_id":"930e45af4320d7a17bed6c8659cfd200ed50640e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"5325d19ba169af282fcb538bfd9e5daf1ac644ee","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"        return changed_ports"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def treat_vif_port(self, vif_port, port_id, network_id, network_type,"},{"line_number":1402,"context_line":"                       physical_network, segmentation_id, vlan_transparent,"},{"line_number":1403,"context_line":"                       admin_state_up, fixed_ips, device_owner,"},{"line_number":1404,"context_line":"                       ovs_restarted):"},{"line_number":1405,"context_line":"        # When this function is called for a port, the port should have"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0d79d5c8","line":1402,"range":{"start_line":1402,"start_character":58,"end_line":1402,"end_character":74},"in_reply_to":"fad55976_796233da","updated":"2016-07-19 14:47:05.000000000","message":"IMO place vlan_transparent in the end makes the caller not looking good, let\u0027s see what others think","commit_id":"930e45af4320d7a17bed6c8659cfd200ed50640e"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"57e3b26ce561255a89889acafd60304ab471e6df","unresolved":false,"context_lines":[{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    def port_bound(self, port, net_uuid,"},{"line_number":774,"context_line":"                   network_type, physical_network,"},{"line_number":775,"context_line":"                   segmentation_id, vlan_transparent, fixed_ips, device_owner,"},{"line_number":776,"context_line":"                   ovs_restarted):"},{"line_number":777,"context_line":"        \u0027\u0027\u0027Bind port to net_uuid/lsw_id and install flow for inbound traffic"},{"line_number":778,"context_line":"        to vm."}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_589c0d5d","line":775,"range":{"start_line":775,"start_character":36,"end_line":775,"end_character":52},"updated":"2016-07-29 15:26:39.000000000","message":"I might be missing something here, but the \u0027vlan_transparent\u0027 parameter here seems to never be used in this method.","commit_id":"767827950bb2b21c3fbe418267f10ce614106bed"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":22740,"name":"Xiao Liang","email":"shaw.leon@gmail.com","username":"shawleon"},"change_message_id":"bd756659b82a5855046873b78398093dc00cfa84","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def check_vlan_transparency(self, context):"},{"line_number":68,"context_line":"        \"\"\"Currently Openvswitch driver supports vlan transparency.\"\"\""},{"line_number":69,"context_line":"        return True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def try_to_bind_segment_for_agent(self, context, segment, agent):"},{"line_number":72,"context_line":"        if self.check_segment_for_agent(segment, agent):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b8fa6ebb","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":19},"updated":"2016-07-20 01:33:46.000000000","message":"Instead of returning True, can we check if the OVS on host is capable for QinQ?","commit_id":"0060a03058144528473516c3a71c1c233c98dde3"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"da3ed40de632227cd821ae2f9ecaf7dea6336ac7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                 \u0027network_type\u0027: segment[api.NETWORK_TYPE],"},{"line_number":119,"context_line":"                 \u0027segmentation_id\u0027: segment[api.SEGMENTATION_ID],"},{"line_number":120,"context_line":"                 \u0027physical_network\u0027: segment[api.PHYSICAL_NETWORK],"},{"line_number":121,"context_line":"                 \u0027vlan_transparent\u0027: port_context.network.current[\u0027vlan_transparent\u0027],"},{"line_number":122,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":123,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":124,"context_line":"                 \u0027allowed_address_pairs\u0027: port[\u0027allowed_address_pairs\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_de86a512","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":17},"updated":"2016-07-15 15:38:46.000000000","message":"I am not sure, but is \u0027vlan_transparent\u0027 guaranteed to exist on port_context.network.current?  Would this be safer as a \u0027get\u0027 with a default of False?","commit_id":"930e45af4320d7a17bed6c8659cfd200ed50640e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"5325d19ba169af282fcb538bfd9e5daf1ac644ee","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                 \u0027network_type\u0027: segment[api.NETWORK_TYPE],"},{"line_number":119,"context_line":"                 \u0027segmentation_id\u0027: segment[api.SEGMENTATION_ID],"},{"line_number":120,"context_line":"                 \u0027physical_network\u0027: segment[api.PHYSICAL_NETWORK],"},{"line_number":121,"context_line":"                 \u0027vlan_transparent\u0027: port_context.network.current[\u0027vlan_transparent\u0027],"},{"line_number":122,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":123,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":124,"context_line":"                 \u0027allowed_address_pairs\u0027: port[\u0027allowed_address_pairs\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2d7e59ae","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":17},"in_reply_to":"fad55976_de86a512","updated":"2016-07-19 14:47:05.000000000","message":"Done","commit_id":"930e45af4320d7a17bed6c8659cfd200ed50640e"}]}
