)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"cc5c0b45b11628e28a6fb6ab694031f567994b29","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AutomaticAddressRequest is created manually in"},{"line_number":10,"context_line":"add_auto_addr_on_network_ports."},{"line_number":11,"context_line":"But expected workkflow is to use address request factory, that can be"},{"line_number":12,"context_line":"overriden by ipam driver to deliver custom AddressRequest classes."},{"line_number":13,"context_line":"Added code to follow expected workflow."},{"line_number":14,"context_line":"Now factory method called for SLAAC allocations, so third party ipam"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_bff2c26d","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":23},"updated":"2016-08-08 12:55:50.000000000","message":"nit: s/workkflow/workflow/","commit_id":"410b787dd8826a9df9aafc701a65cb97ac60a310"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"3764f61000ed7afde3c082730cd6e1946fa81017","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            updated_ports \u003d []"},{"line_number":397,"context_line":"            ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":398,"context_line":"            for port in ports:"},{"line_number":399,"context_line":"                factory \u003d ipam_driver.get_address_request_factory()"},{"line_number":400,"context_line":"                ip \u003d {\u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":401,"context_line":"                      \u0027subnet_cidr\u0027: subnet[\u0027cidr\u0027],"},{"line_number":402,"context_line":"                      \u0027eui64_address\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_b8dbfb1a","line":399,"updated":"2016-07-15 20:19:40.000000000","message":"shouldn\u0027t this be outside the loop?","commit_id":"62331f5873711d7c0b818a2f4131c059d2c9fede"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"52a3cde0f786e18b75b475716ce98ddcebb124ed","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                      \u0027eui64_address\u0027: True,"},{"line_number":402,"context_line":"                      \u0027mac\u0027: port[\u0027mac_address\u0027]}"},{"line_number":403,"context_line":"                ip_request \u003d factory.get_request(context, port, ip)"},{"line_number":404,"context_line":"                ipam_allocator \u003d ipam_driver.get_allocator([subnet[\u0027id\u0027]])"},{"line_number":405,"context_line":"                ip_address, subnet_id \u003d ipam_allocator.allocate(ip_request)"},{"line_number":406,"context_line":"                allocated \u003d models_v2.IPAllocation(network_id\u003dnetwork_id,"},{"line_number":407,"context_line":"                                                   port_id\u003dport[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_98ac18ef","line":404,"updated":"2016-07-18 17:26:38.000000000","message":"Sorry I didn\u0027t notice this in the prior patch, but since the ipam_subnet is passed in, do you really need to do the get_allocator? Can\u0027t you just pass this request to the ipam_subnet.allocate method like in the previous version? Aren\u0027t we just trying to change way the request is generated?","commit_id":"148cd3e9c8bc0ab9d60ea2401392683a9fc61813"}]}