)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"edc886c82aed31d7a21173c6ee1b1e6331bd5297","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1563069"},{"line_number":14,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa7ab95a_81b2b4e3","line":13,"updated":"2016-09-01 17:41:07.000000000","message":"Please add depends-on for I00e87e9c6f71a8a59e024a9795c48f7699387d85 to verify, if neutron-lbaas change resolves issues with gate.","commit_id":"19191e8d5ec28c66f5d48b9b14010f8093a99b3d"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"e0a76ee8cc654ad9c7144113c9309a92bec02d5d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1563069"},{"line_number":14,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa7ab95a_59a184f7","line":13,"in_reply_to":"fa7ab95a_81b2b4e3","updated":"2016-09-01 18:32:10.000000000","message":"Done","commit_id":"19191e8d5ec28c66f5d48b9b14010f8093a99b3d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"cdc55a863b495b20b7177f2dff88b9a7e31d7423","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1563069"},{"line_number":14,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"},{"line_number":15,"context_line":"Needed-By: Ib676003bbe909b5a9013a3178b12dbe291d936af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"3a71b18c_37632743","line":13,"updated":"2016-12-08 19:03:15.000000000","message":"Add NeutronLibImpact to this message.  This will allow other projects to easily find out what breaks their projects.","commit_id":"951a13f01d5aa656d988b2383971480de0d6cde0"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"9268854715c49a109b885a22f456d87583def290","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1563069"},{"line_number":14,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"},{"line_number":15,"context_line":"Needed-By: Ib676003bbe909b5a9013a3178b12dbe291d936af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"3a71b18c_129559e3","line":13,"in_reply_to":"3a71b18c_37632743","updated":"2016-12-08 19:35:55.000000000","message":"Done","commit_id":"951a13f01d5aa656d988b2383971480de0d6cde0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"bf1c5cc6b2189e569239894a327e8975b964449f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NeutronLibImpact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1563069"},{"line_number":16,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1a6eadb0_52149e4b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":16},"updated":"2016-12-16 14:09:00.000000000","message":"Why are we using the NeutronLibImpact tag here? As per [1] we\u0027ve been using this to tag neutron changes that are swapping neutron uses to neutron-lib uses. That doesn\u0027t seem to be the case here.\n\n\n[1] https://wiki.openstack.org/wiki/Network/Meetings","commit_id":"1ee2d0f5db3816cd58710c0afa90b9df67b8feb4"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"ef10a03c1e5eefad2f3b2e6d522c99c5d23b2ca2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron/conf/agent/common. This will allow centralization of all"},{"line_number":11,"context_line":"configuration options and provide an easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NeutronLibImpact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1563069"},{"line_number":16,"context_line":"Change-Id: Iebac0cdd3bcfd0135349128921b7ad7a1a939ab8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1a6eadb0_12cd395d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":16},"in_reply_to":"1a6eadb0_52149e4b","updated":"2016-12-20 17:35:57.000000000","message":"Done","commit_id":"1ee2d0f5db3816cd58710c0afa90b9df67b8feb4"}],"neutron/agent/common/config.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b3574a3d6158b3b25e082f8969fde52516c0643c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\"Availability zone of this node\")),"},{"line_number":83,"context_line":"]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"EXT_NET_BRIDGE_OPTS \u003d ["},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":87,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"               help\u003d_(\"Name of bridge used for external network \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_304c0f70","side":"PARENT","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":19},"updated":"2016-08-15 20:50:12.000000000","message":"Based on [1] there are 2 more usages of this related to neutron.debug functionality. Are these in a different patch, or perhaps I missed them?\n\n\n[1] https://github.com/openstack/neutron/search?utf8\u003d%E2%9C%93\u0026q\u003dEXT_NET_BRIDGE_OPTS","commit_id":"590b9dbc93a6be1ccba1969f5230054a5e4ef7e2"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"6dec626a2586998eaef1c3227338239d34d566a3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\"Availability zone of this node\")),"},{"line_number":83,"context_line":"]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"EXT_NET_BRIDGE_OPTS \u003d ["},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":87,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"               help\u003d_(\"Name of bridge used for external network \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_57b9daeb","side":"PARENT","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":19},"in_reply_to":"3ac371cc_304c0f70","updated":"2016-08-19 08:43:39.000000000","message":"Done","commit_id":"590b9dbc93a6be1ccba1969f5230054a5e4ef7e2"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def setup_conf():"},{"line_number":159,"context_line":"    bind_opts \u003d ["},{"line_number":160,"context_line":"        cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":161,"context_line":"                   default\u003d\u0027/var/lib/neutron\u0027,"},{"line_number":162,"context_line":"                   help\u003d_(\"Where to store Neutron state files. \""},{"line_number":163,"context_line":"                          \"This directory must be writable by the agent.\")),"},{"line_number":164,"context_line":"    ]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":167,"context_line":"    conf.register_opts(bind_opts)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_98044316","side":"PARENT","line":164,"range":{"start_line":159,"start_character":4,"end_line":164,"end_character":5},"updated":"2016-10-11 19:51:50.000000000","message":"i would say this would need to be moved too, but it appears to only be used in tests, soooo I\u0027m not too worried about it.","commit_id":"65a3b891166300b447193d2fa0ddc3ad47d3528e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fa6399be_98528312","updated":"2016-10-11 19:51:50.000000000","message":"moving all the config options out of this will make this file not much of a config.py module.  But i suppose its somethign we can address later.","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6608d88b97c792eb0e22d776488638614ab0d579","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"da6895a0_eed9b984","updated":"2016-10-25 19:50:03.000000000","message":"I think it would simplify a lot of the imports if we just moved the entire contents of this file to the new location, instead of keeping a few useful items around. Keeping this file around doesn\u0027t make much sense because its no longer a config module, its just a module that has one or two useful things that could easily just be put into the new config file.\n\nWould end up making the code that imports the new module less invasive too as you wouldn\u0027t need to import this module and the new one.  Would also reduce the need to keep the alias names consistent, which is a problem with some of the following modules.","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"4d90628ed724dcca9fbed43d2bbfa75ba35bfc2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"ba5da102_136834f5","in_reply_to":"da6895a0_eed9b984","updated":"2016-10-26 18:52:03.000000000","message":"Done","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"}],"neutron/agent/common/utils.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _LE"},{"line_number":23,"context_line":"from neutron.common import utils as neutron_utils"},{"line_number":24,"context_line":"from neutron.conf.agent.database import agents_db"},{"line_number":25,"context_line":"from neutron.conf.agent import common as config"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_53560c2a","line":25,"updated":"2016-10-11 19:51:50.000000000","message":"pep8 error here.  this shoudl be before the above line.","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"5ee3aa2c96f7caa1a8aa42689b48534433e80fee","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _LE"},{"line_number":23,"context_line":"from neutron.common import utils as neutron_utils"},{"line_number":24,"context_line":"from neutron.conf.agent.database import agents_db"},{"line_number":25,"context_line":"from neutron.conf.agent import common as config"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_1fdb56ed","line":25,"in_reply_to":"fa6399be_53560c2a","updated":"2016-10-13 16:49:19.000000000","message":"Done","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"}],"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"def main():"},{"line_number":42,"context_line":"    register_options(cfg.CONF)"},{"line_number":43,"context_line":"    common_config.init(sys.argv[1:])"},{"line_number":44,"context_line":"    config.setup_logging()"},{"line_number":45,"context_line":"    server \u003d neutron_service.Service.create("},{"line_number":46,"context_line":"        binary\u003d\u0027neutron-dhcp-agent\u0027,"},{"line_number":47,"context_line":"        topic\u003dtopics.DHCP_AGENT,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_a1ba52df","line":44,"range":{"start_line":44,"start_character":3,"end_line":44,"end_character":26},"updated":"2016-07-25 15:26:38.000000000","message":"you would have to keep following import\nfrom neutron.agent.common import config","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6c4a52ab3c2cb084f3d824c1567916581763312c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def register_options(conf):"},{"line_number":33,"context_line":"    config.register_interface_driver_opts_helper(conf)"},{"line_number":34,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":35,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":36,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":37,"context_line":"    conf.register_opts(metadata_config.DRIVER_OPTS)"},{"line_number":38,"context_line":"    conf.register_opts(metadata_config.SHARED_OPTS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_94687a89","line":35,"updated":"2016-08-02 17:24:32.000000000","message":"Line(33-35): Instead of calling register_*_opts_helper 3 times it will be good to have one method in neutron/conf/agent/common.py that will register all the 3 opts. This will help in reducing the CPU calls.","commit_id":"60387311b4878855aa6e76a59644cd208469a0ce"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"63e609d498922b87ef18b612288f9a19b67f5494","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def register_options(conf):"},{"line_number":33,"context_line":"    config.register_interface_driver_opts_helper(conf)"},{"line_number":34,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":35,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":36,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":37,"context_line":"    conf.register_opts(metadata_config.DRIVER_OPTS)"},{"line_number":38,"context_line":"    conf.register_opts(metadata_config.SHARED_OPTS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_974a3926","line":35,"in_reply_to":"bacf61ea_94687a89","updated":"2016-08-02 18:51:41.000000000","message":"This is debatable. We\u0027d reduce the lookups by 2, but would hide what\u0027s being registered. In addition, this is only called once during initialization, making the benefits dubious.","commit_id":"60387311b4878855aa6e76a59644cd208469a0ce"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.agent.metadata import config as metadata_config"},{"line_number":25,"context_line":"from neutron.common import config as common_config"},{"line_number":26,"context_line":"from neutron.common import topics"},{"line_number":27,"context_line":"from neutron.conf.agent import common as config"},{"line_number":28,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":29,"context_line":"from neutron import service as neutron_service"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_136bb41f","line":27,"updated":"2016-10-11 19:51:50.000000000","message":"i would just name this agent_common_config and not rename the alias above so you don\u0027t have to worry about changing it below. But meh, not a big deal.","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"5ee3aa2c96f7caa1a8aa42689b48534433e80fee","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.agent.metadata import config as metadata_config"},{"line_number":25,"context_line":"from neutron.common import config as common_config"},{"line_number":26,"context_line":"from neutron.common import topics"},{"line_number":27,"context_line":"from neutron.conf.agent import common as config"},{"line_number":28,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":29,"context_line":"from neutron import service as neutron_service"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_5f7dceaf","line":27,"in_reply_to":"fa6399be_136bb41f","updated":"2016-10-13 16:49:19.000000000","message":"Done","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def main(manager\u003d\u0027neutron.agent.l3.agent.L3NATAgentWithStateReport\u0027):"},{"line_number":50,"context_line":"    register_opts(cfg.CONF)"},{"line_number":51,"context_line":"    common_config.init(sys.argv[1:])"},{"line_number":52,"context_line":"    config.setup_logging()"},{"line_number":53,"context_line":"    server \u003d neutron_service.Service.create("},{"line_number":54,"context_line":"        binary\u003d\u0027neutron-l3-agent\u0027,"},{"line_number":55,"context_line":"        topic\u003dtopics.L3_AGENT,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_01787e2a","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":26},"updated":"2016-07-25 15:26:38.000000000","message":"ditto","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6c4a52ab3c2cb084f3d824c1567916581763312c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    conf.register_opts(external_process.OPTS)"},{"line_number":45,"context_line":"    conf.register_opts(pd.OPTS)"},{"line_number":46,"context_line":"    conf.register_opts(ra.OPTS)"},{"line_number":47,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def main(manager\u003d\u0027neutron.agent.l3.agent.L3NATAgentWithStateReport\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_f42a962e","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":4},"updated":"2016-08-02 17:24:32.000000000","message":"Line (41-42, 47) ditto","commit_id":"60387311b4878855aa6e76a59644cd208469a0ce"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"63e609d498922b87ef18b612288f9a19b67f5494","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    conf.register_opts(external_process.OPTS)"},{"line_number":45,"context_line":"    conf.register_opts(pd.OPTS)"},{"line_number":46,"context_line":"    conf.register_opts(ra.OPTS)"},{"line_number":47,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def main(manager\u003d\u0027neutron.agent.l3.agent.L3NATAgentWithStateReport\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_f761f5a9","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":4},"in_reply_to":"bacf61ea_f42a962e","updated":"2016-08-02 18:51:41.000000000","message":"ditto","commit_id":"60387311b4878855aa6e76a59644cd208469a0ce"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f54b45031be60c13149e7f6baa84525e5af91d1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_service import service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.agent.common import config as agent_common_config"},{"line_number":23,"context_line":"from neutron.agent.l3 import config as l3_config"},{"line_number":24,"context_line":"from neutron.agent.l3 import ha"},{"line_number":25,"context_line":"from neutron.agent.linux import external_process"},{"line_number":26,"context_line":"from neutron.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_daba91e0","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":48},"updated":"2016-08-05 01:41:12.000000000","message":"from neutron.conf.agent.l3 import config as l3_config","commit_id":"29c3fd39e5fd83ebc00cb92d52a8dce77b53c4e4"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"36332d657ebec88e967f38aef962c5da32afe122","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_service import service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.agent.common import config as agent_common_config"},{"line_number":23,"context_line":"from neutron.agent.l3 import config as l3_config"},{"line_number":24,"context_line":"from neutron.agent.l3 import ha"},{"line_number":25,"context_line":"from neutron.agent.linux import external_process"},{"line_number":26,"context_line":"from neutron.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_acbca0dc","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"bacf61ea_daba91e0","updated":"2016-08-05 18:24:30.000000000","message":"Done","commit_id":"29c3fd39e5fd83ebc00cb92d52a8dce77b53c4e4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.agent.metadata import config as metadata_config"},{"line_number":28,"context_line":"from neutron.common import config as common_config"},{"line_number":29,"context_line":"from neutron.common import topics"},{"line_number":30,"context_line":"from neutron.conf.agent import common as config"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron import service as neutron_service"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_3378b8f2","line":30,"updated":"2016-10-11 19:51:50.000000000","message":"i sense a pattern...","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"5ee3aa2c96f7caa1a8aa42689b48534433e80fee","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.agent.metadata import config as metadata_config"},{"line_number":28,"context_line":"from neutron.common import config as common_config"},{"line_number":29,"context_line":"from neutron.common import topics"},{"line_number":30,"context_line":"from neutron.conf.agent import common as config"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron import service as neutron_service"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_c2e581dc","line":30,"in_reply_to":"fa6399be_3378b8f2","updated":"2016-10-13 16:49:19.000000000","message":"Done","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"}],"neutron/agent/linux/utils.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    cmd \u003d list(map(str, addl_env_args(addl_env) + cmd))"},{"line_number":81,"context_line":"    if run_as_root:"},{"line_number":82,"context_line":"        cmd \u003d shlex.split(config.get_root_helper(cfg.CONF)) + cmd"},{"line_number":83,"context_line":"    LOG.debug(\"Running command: %s\", cmd)"},{"line_number":84,"context_line":"    obj \u003d utils.subprocess_popen(cmd, shell\u003dFalse,"},{"line_number":85,"context_line":"                                 stdin\u003dsubprocess.PIPE,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e1fe0a6a","line":82,"range":{"start_line":82,"start_character":26,"end_line":82,"end_character":58},"updated":"2016-07-25 15:26:38.000000000","message":"ditto","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"4ffd30d6d6331474d219f76ed356b98b6cb8b35d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def get_log_args(conf, log_file_name, **kwargs):"},{"line_number":98,"context_line":"    cmd_args \u003d []"},{"line_number":99,"context_line":"    if conf.debug:"},{"line_number":100,"context_line":"        cmd_args.append(\u0027--debug\u0027)"},{"line_number":101,"context_line":"    if (conf.log_dir or conf.log_file):"},{"line_number":102,"context_line":"        cmd_args.append(\u0027--log-file\u003d%s\u0027 % log_file_name)"},{"line_number":103,"context_line":"        log_dir \u003d None"},{"line_number":104,"context_line":"        if conf.log_dir and conf.log_file:"},{"line_number":105,"context_line":"            log_dir \u003d os.path.dirname("},{"line_number":106,"context_line":"                os.path.join(conf.log_dir, conf.log_file))"},{"line_number":107,"context_line":"        elif conf.log_dir:"},{"line_number":108,"context_line":"            log_dir \u003d conf.log_dir"},{"line_number":109,"context_line":"        elif conf.log_file:"},{"line_number":110,"context_line":"            log_dir \u003d os.path.dirname(conf.log_file)"},{"line_number":111,"context_line":"        if log_dir:"},{"line_number":112,"context_line":"            cmd_args.append(\u0027--log-dir\u003d%s\u0027 % log_dir)"},{"line_number":113,"context_line":"        if kwargs.get(\u0027metadata_proxy_watch_log\u0027) is False:"},{"line_number":114,"context_line":"            cmd_args.append(\u0027--nometadata_proxy_watch_log\u0027)"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        if conf.use_syslog:"},{"line_number":117,"context_line":"            cmd_args.append(\u0027--use-syslog\u0027)"},{"line_number":118,"context_line":"            if conf.syslog_log_facility:"},{"line_number":119,"context_line":"                cmd_args.append("},{"line_number":120,"context_line":"                    \u0027--syslog-log-facility\u003d%s\u0027 % conf.syslog_log_facility)"},{"line_number":121,"context_line":"    return cmd_args"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"def register_root_helper(conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_2704ed7c","line":121,"range":{"start_line":97,"start_character":0,"end_line":121,"end_character":19},"updated":"2016-07-18 16:48:10.000000000","message":"I would suggest you to keep this method in neutron/agent/common/config.py.","commit_id":"e6bfe4f48cbb6b70fb2d381e675b0b5fb3fd40cd"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"1d1d88993f070875f333fd3c707d07f7ba268a3c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def get_log_args(conf, log_file_name, **kwargs):"},{"line_number":98,"context_line":"    cmd_args \u003d []"},{"line_number":99,"context_line":"    if conf.debug:"},{"line_number":100,"context_line":"        cmd_args.append(\u0027--debug\u0027)"},{"line_number":101,"context_line":"    if (conf.log_dir or conf.log_file):"},{"line_number":102,"context_line":"        cmd_args.append(\u0027--log-file\u003d%s\u0027 % log_file_name)"},{"line_number":103,"context_line":"        log_dir \u003d None"},{"line_number":104,"context_line":"        if conf.log_dir and conf.log_file:"},{"line_number":105,"context_line":"            log_dir \u003d os.path.dirname("},{"line_number":106,"context_line":"                os.path.join(conf.log_dir, conf.log_file))"},{"line_number":107,"context_line":"        elif conf.log_dir:"},{"line_number":108,"context_line":"            log_dir \u003d conf.log_dir"},{"line_number":109,"context_line":"        elif conf.log_file:"},{"line_number":110,"context_line":"            log_dir \u003d os.path.dirname(conf.log_file)"},{"line_number":111,"context_line":"        if log_dir:"},{"line_number":112,"context_line":"            cmd_args.append(\u0027--log-dir\u003d%s\u0027 % log_dir)"},{"line_number":113,"context_line":"        if kwargs.get(\u0027metadata_proxy_watch_log\u0027) is False:"},{"line_number":114,"context_line":"            cmd_args.append(\u0027--nometadata_proxy_watch_log\u0027)"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        if conf.use_syslog:"},{"line_number":117,"context_line":"            cmd_args.append(\u0027--use-syslog\u0027)"},{"line_number":118,"context_line":"            if conf.syslog_log_facility:"},{"line_number":119,"context_line":"                cmd_args.append("},{"line_number":120,"context_line":"                    \u0027--syslog-log-facility\u003d%s\u0027 % conf.syslog_log_facility)"},{"line_number":121,"context_line":"    return cmd_args"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"def register_root_helper(conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_05b24194","line":121,"range":{"start_line":97,"start_character":0,"end_line":121,"end_character":19},"in_reply_to":"dada55a8_2704ed7c","updated":"2016-07-19 18:36:06.000000000","message":"Done","commit_id":"e6bfe4f48cbb6b70fb2d381e675b0b5fb3fd40cd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"4ffd30d6d6331474d219f76ed356b98b6cb8b35d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    return conf.AGENT.root_helper"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def setup_conf():"},{"line_number":153,"context_line":"    bind_opts \u003d ["},{"line_number":154,"context_line":"        cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":155,"context_line":"                   default\u003d\u0027/var/lib/neutron\u0027,"},{"line_number":156,"context_line":"                   help\u003d_(\"Where to store Neutron state files. \""},{"line_number":157,"context_line":"                          \"This directory must be writable by the agent.\")),"},{"line_number":158,"context_line":"    ]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":161,"context_line":"    conf.register_opts(bind_opts)"},{"line_number":162,"context_line":"    return conf"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# add a logging setup method here for convenience"},{"line_number":165,"context_line":"setup_logging \u003d config.setup_logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_272b4ded","line":165,"range":{"start_line":152,"start_character":0,"end_line":165,"end_character":36},"updated":"2016-07-18 16:48:10.000000000","message":"ditto","commit_id":"e6bfe4f48cbb6b70fb2d381e675b0b5fb3fd40cd"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"1d1d88993f070875f333fd3c707d07f7ba268a3c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    return conf.AGENT.root_helper"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def setup_conf():"},{"line_number":153,"context_line":"    bind_opts \u003d ["},{"line_number":154,"context_line":"        cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":155,"context_line":"                   default\u003d\u0027/var/lib/neutron\u0027,"},{"line_number":156,"context_line":"                   help\u003d_(\"Where to store Neutron state files. \""},{"line_number":157,"context_line":"                          \"This directory must be writable by the agent.\")),"},{"line_number":158,"context_line":"    ]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":161,"context_line":"    conf.register_opts(bind_opts)"},{"line_number":162,"context_line":"    return conf"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# add a logging setup method here for convenience"},{"line_number":165,"context_line":"setup_logging \u003d config.setup_logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e5ac4d37","line":165,"range":{"start_line":152,"start_character":0,"end_line":165,"end_character":36},"in_reply_to":"dada55a8_272b4ded","updated":"2016-07-19 18:36:06.000000000","message":"Done","commit_id":"e6bfe4f48cbb6b70fb2d381e675b0b5fb3fd40cd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    conf.register_opts(AVAILABILITY_ZONE_OPTS, \u0027AGENT\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def get_root_helper(conf):"},{"line_number":119,"context_line":"    return conf.AGENT.root_helper"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e1b60a89","line":119,"range":{"start_line":118,"start_character":0,"end_line":119,"end_character":33},"updated":"2016-07-25 15:26:38.000000000","message":"i would suggest you not to move this method","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6608d88b97c792eb0e22d776488638614ab0d579","unresolved":false,"context_lines":[{"line_number":97,"context_line":"]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def register_root_helper(conf):"},{"line_number":101,"context_line":"    conf.register_opts(ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da6895a0_ae2a612a","line":100,"range":{"start_line":100,"start_character":25,"end_line":100,"end_character":29},"updated":"2016-10-25 19:50:03.000000000","message":"i like what other reveiws are doing and making this an optional argument that defaults to cfg.CONF","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"4d90628ed724dcca9fbed43d2bbfa75ba35bfc2c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def register_root_helper(conf):"},{"line_number":101,"context_line":"    conf.register_opts(ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba5da102_2a122163","line":100,"range":{"start_line":100,"start_character":25,"end_line":100,"end_character":29},"in_reply_to":"da6895a0_ae2a612a","updated":"2016-10-26 18:52:03.000000000","message":"Done","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"25267fe0fbc19e21cffe294ab6b85716c166b0d1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027\u0027,"},{"line_number":93,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":94,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":95,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":96,"context_line":"                      \"Linux Bridge. When this parameter is set, each L3 \""},{"line_number":97,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":98,"context_line":"                      \"network. This option is deprecated and will be removed \""},{"line_number":99,"context_line":"                      \"in the M release.\")),"},{"line_number":100,"context_line":"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_59b00d8c","line":99,"range":{"start_line":95,"start_character":32,"end_line":99,"end_character":41},"updated":"2016-10-26 20:47:05.000000000","message":"i think you\u0027ve got the old version here.  We definitely don\u0027t want to revert back.","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"cda4f3f88268990df7b1aa5f52e13807ab17cb00","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027\u0027,"},{"line_number":93,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":94,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":95,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":96,"context_line":"                      \"Linux Bridge. When this parameter is set, each L3 \""},{"line_number":97,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":98,"context_line":"                      \"network. This option is deprecated and will be removed \""},{"line_number":99,"context_line":"                      \"in the M release.\")),"},{"line_number":100,"context_line":"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_c469948d","line":99,"range":{"start_line":95,"start_character":32,"end_line":99,"end_character":41},"in_reply_to":"ba5da102_59b00d8c","updated":"2016-10-26 21:20:18.000000000","message":"Done","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"25267fe0fbc19e21cffe294ab6b85716c166b0d1","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def register_availability_zone_opts_helper(conf):"},{"line_number":124,"context_line":"    conf.register_opts(AVAILABILITY_ZONE_OPTS, \u0027AGENT\u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def get_log_args(conf, log_file_name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_397279e6","line":124,"updated":"2016-10-26 20:47:05.000000000","message":"for easier reviewing, can you move this block below the get_log_args method to keep it consistent with the old version.  Unless there\u0027s a technical reason to move them above that method.  I wouldn\u0027t ask if you didn\u0027t have to do another PS but since there\u0027s already a reason for you to respin, I\u0027m asking now :)","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"cda4f3f88268990df7b1aa5f52e13807ab17cb00","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def register_availability_zone_opts_helper(conf):"},{"line_number":124,"context_line":"    conf.register_opts(AVAILABILITY_ZONE_OPTS, \u0027AGENT\u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def get_log_args(conf, log_file_name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_04638cb2","line":124,"in_reply_to":"ba5da102_397279e6","updated":"2016-10-26 21:20:18.000000000","message":"Done","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"25267fe0fbc19e21cffe294ab6b85716c166b0d1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    conf.register_opts(bind_opts)"},{"line_number":168,"context_line":"    return conf"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# add a logging setup method here for convenience"},{"line_number":172,"context_line":"setup_logging \u003d config.setup_logging"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_79add130","line":170,"updated":"2016-10-26 20:47:05.000000000","message":"unnecessary line","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"cda4f3f88268990df7b1aa5f52e13807ab17cb00","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    conf.register_opts(bind_opts)"},{"line_number":168,"context_line":"    return conf"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# add a logging setup method here for convenience"},{"line_number":172,"context_line":"setup_logging \u003d config.setup_logging"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_e45db8ed","line":170,"in_reply_to":"ba5da102_79add130","updated":"2016-10-26 21:20:18.000000000","message":"Done","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7898c17db6a52f29b9bc2727489a17f3b3f1dea0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    return cmd_args"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def register_root_helper(conf\u003dcfg.CONF):"},{"line_number":131,"context_line":"    conf.register_opts(ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_1f20359b","line":130,"updated":"2016-10-26 22:35:56.000000000","message":"you forgot to do this for the rest of them :(","commit_id":"b3b044505d1b61e94bccf4bc8e9adbf5ee8a2a92"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"31f1b253e6d41906e3a639cae3928e8344d865ea","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    return cmd_args"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def register_root_helper(conf\u003dcfg.CONF):"},{"line_number":131,"context_line":"    conf.register_opts(ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_0fa8f21e","line":130,"in_reply_to":"ba5da102_1f20359b","updated":"2016-10-27 19:04:31.000000000","message":"Done","commit_id":"b3b044505d1b61e94bccf4bc8e9adbf5ee8a2a92"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"cf0b2ac6ad75716c14b13161efefdd8089f59b79","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                      \"plug an interface directly into an external bridge \""},{"line_number":97,"context_line":"                      \"which will not allow any wiring by the L2 agent. Using \""},{"line_number":98,"context_line":"                      \"this will result in incorrect port statuses. This \""},{"line_number":99,"context_line":"                      \"option is deprecated and will be removed in Ocata.\")),"},{"line_number":100,"context_line":"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3a71b18c_b7b570d1","line":99,"range":{"start_line":99,"start_character":76,"end_line":99,"end_character":77},"updated":"2016-12-08 22:25:48.000000000","message":"is it really needed ?","commit_id":"db8eac4895b88c06a9f4500a496bff656a5c78bc"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"423d4b84ba982af8246d1d8f5543e519b48c9276","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                      \"plug an interface directly into an external bridge \""},{"line_number":97,"context_line":"                      \"which will not allow any wiring by the L2 agent. Using \""},{"line_number":98,"context_line":"                      \"this will result in incorrect port statuses. This \""},{"line_number":99,"context_line":"                      \"option is deprecated and will be removed in Ocata.\")),"},{"line_number":100,"context_line":"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1a6eadb0_4bd32d60","line":99,"range":{"start_line":99,"start_character":76,"end_line":99,"end_character":77},"in_reply_to":"3a71b18c_b7b570d1","updated":"2016-12-15 21:56:20.000000000","message":"Done","commit_id":"db8eac4895b88c06a9f4500a496bff656a5c78bc"}],"neutron/conf/agent/l3/config.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"affc4edea13a437f0729e29efbcbdc5c236764dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_dc80918d","line":1,"updated":"2016-08-01 21:16:53.000000000","message":"latest content for this file looks like https://github.com/openstack/neutron/blob/master/neutron/agent/l3/config.py\nmight have to rebase","commit_id":"d52c758d1896fcb89cad8e845bc3d88bbe02139c"}],"neutron/opts.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6608d88b97c792eb0e22d776488638614ab0d579","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import neutron.agent.metadata.config"},{"line_number":26,"context_line":"import neutron.agent.ovsdb.api"},{"line_number":27,"context_line":"import neutron.agent.securitygroups_rpc"},{"line_number":28,"context_line":"import neutron.common.cache_utils"},{"line_number":29,"context_line":"import neutron.conf.agent.common"},{"line_number":30,"context_line":"import neutron.conf.agent.dhcp"},{"line_number":31,"context_line":"import neutron.conf.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":24,"id":"da6895a0_ee6e1995","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":33},"updated":"2016-10-25 19:50:03.000000000","message":"unrelated, i suspect a missed merge conflict line","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"4d90628ed724dcca9fbed43d2bbfa75ba35bfc2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import neutron.agent.metadata.config"},{"line_number":26,"context_line":"import neutron.agent.ovsdb.api"},{"line_number":27,"context_line":"import neutron.agent.securitygroups_rpc"},{"line_number":28,"context_line":"import neutron.common.cache_utils"},{"line_number":29,"context_line":"import neutron.conf.agent.common"},{"line_number":30,"context_line":"import neutron.conf.agent.dhcp"},{"line_number":31,"context_line":"import neutron.conf.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba5da102_8a224db8","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":33},"in_reply_to":"da6895a0_ee6e1995","updated":"2016-10-26 18:52:03.000000000","message":"Done","commit_id":"bbabce9f0024995823c08db61b8a50b5d7f6ba49"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"cf0b2ac6ad75716c14b13161efefdd8089f59b79","unresolved":false,"context_lines":[{"line_number":91,"context_line":"             neutron.conf.agent.common.INTERFACE_DRIVER_OPTS,"},{"line_number":92,"context_line":"             neutron.conf.agent.metadata.config.SHARED_OPTS,"},{"line_number":93,"context_line":"             neutron.conf.agent.metadata.config.DRIVER_OPTS)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"         )"},{"line_number":96,"context_line":"    ]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3a71b18c_d7066c84","line":94,"updated":"2016-12-08 22:25:48.000000000","message":"nit: uneccessary line space here","commit_id":"db8eac4895b88c06a9f4500a496bff656a5c78bc"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"423d4b84ba982af8246d1d8f5543e519b48c9276","unresolved":false,"context_lines":[{"line_number":91,"context_line":"             neutron.conf.agent.common.INTERFACE_DRIVER_OPTS,"},{"line_number":92,"context_line":"             neutron.conf.agent.metadata.config.SHARED_OPTS,"},{"line_number":93,"context_line":"             neutron.conf.agent.metadata.config.DRIVER_OPTS)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"         )"},{"line_number":96,"context_line":"    ]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1a6eadb0_cbc73d94","line":94,"in_reply_to":"3a71b18c_d7066c84","updated":"2016-12-15 21:56:20.000000000","message":"Done","commit_id":"db8eac4895b88c06a9f4500a496bff656a5c78bc"}],"neutron/plugins/ml2/drivers/agent/config.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.conf.agent import common as config"},{"line_number":20,"context_line":"from neutron.conf.plugins.ml2.drivers import agent"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"agent.register_agent_opts()"},{"line_number":24,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_53fa8c43","line":22,"updated":"2016-10-11 19:51:50.000000000","message":"is this line necessary?","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"5ee3aa2c96f7caa1a8aa42689b48534433e80fee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.conf.agent import common as config"},{"line_number":20,"context_line":"from neutron.conf.plugins.ml2.drivers import agent"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"agent.register_agent_opts()"},{"line_number":24,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_e201a56b","line":22,"in_reply_to":"fa6399be_53fa8c43","updated":"2016-10-13 16:49:19.000000000","message":"Done","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"}],"neutron/services/metering/agents/metering_agent.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    conf.register_opts(MeteringAgent.Opts)"},{"line_number":294,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":295,"context_line":"    common_config.init(sys.argv[1:])"},{"line_number":296,"context_line":"    config.setup_logging()"},{"line_number":297,"context_line":"    server \u003d neutron_service.Service.create("},{"line_number":298,"context_line":"        binary\u003d\u0027neutron-metering-agent\u0027,"},{"line_number":299,"context_line":"        topic\u003dtopics.METERING_AGENT,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_414a76ad","line":296,"range":{"start_line":296,"start_character":4,"end_line":296,"end_character":26},"updated":"2016-07-25 15:26:38.000000000","message":"ditto","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a458d2208aa6a8b113abe48121f4ceed525f63e5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":33,"context_line":"from neutron.common import topics"},{"line_number":34,"context_line":"from neutron.common import utils"},{"line_number":35,"context_line":"from neutron.conf.agent import common as config"},{"line_number":36,"context_line":"from neutron.conf.services import metering_agent"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_f3b0008e","line":35,"updated":"2016-10-11 19:51:50.000000000","message":"pattern re-emerges :)","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"5ee3aa2c96f7caa1a8aa42689b48534433e80fee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":33,"context_line":"from neutron.common import topics"},{"line_number":34,"context_line":"from neutron.common import utils"},{"line_number":35,"context_line":"from neutron.conf.agent import common as config"},{"line_number":36,"context_line":"from neutron.conf.services import metering_agent"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_a2808dc1","line":35,"in_reply_to":"fa6399be_f3b0008e","updated":"2016-10-13 16:49:19.000000000","message":"Done","commit_id":"cb154f6241e307c0c5394c1906d5b65da4a62dee"}],"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e75acdd387515e3a3da45bb0a58d4634e0c1d44d","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self.cmd \u003d cmd"},{"line_number":231,"context_line":"        if self.namespace is not None:"},{"line_number":232,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, self.namespace] + cmd"},{"line_number":233,"context_line":"        root_helper \u003d config.get_root_helper(utils.cfg.CONF)"},{"line_number":234,"context_line":"        cmd \u003d shlex.split(root_helper) + cmd"},{"line_number":235,"context_line":"        self.child_pid \u003d None"},{"line_number":236,"context_line":"        super(RootHelperProcess, self).__init__(cmd, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_61fdfa39","line":233,"range":{"start_line":233,"start_character":22,"end_line":233,"end_character":60},"updated":"2016-07-25 15:26:38.000000000","message":"ditto","commit_id":"4926bd8985d97e1e9193651002bb337f4223c374"}],"neutron/tests/functional/agent/l3/framework.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"affc4edea13a437f0729e29efbcbdc5c236764dc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":32,"context_line":"from neutron.common import constants as n_const"},{"line_number":33,"context_line":"from neutron.common import utils as common_utils"},{"line_number":34,"context_line":"from neutron.conf import common as common_config"},{"line_number":35,"context_line":"from neutron.tests.common import l3_test_common"},{"line_number":36,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":37,"context_line":"from neutron.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_bcd5dde5","side":"PARENT","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":48},"updated":"2016-08-01 21:16:53.000000000","message":"core _opts in L59 and L60 need this import","commit_id":"ee42af101157426539162012a5527e1e607e033c"}],"neutron/tests/unit/agent/l3/test_router_info.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"25267fe0fbc19e21cffe294ab6b85716c166b0d1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.agent.l3 import router_info"},{"line_number":18,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":19,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":20,"context_line":"from neutron.conf.agent import common as config"},{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5da102_3949998c","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":47},"updated":"2016-10-26 20:47:05.000000000","message":"i\u0027m tempted to say just keep this as agent_config, but config is consistent with the rest of the files...soooo i don\u0027t care :)","commit_id":"58b23afa2a029279c83a95f06c56174449c90b29"}],"neutron/tests/unit/agent/linux/test_iptables_firewall.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8f54b45031be60c13149e7f6baa84525e5af91d1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent import securitygroups_rpc as sg_cfg"},{"line_number":29,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import common as a_cfg"},{"line_number":32,"context_line":"from neutron.tests import base"},{"line_number":33,"context_line":"from neutron.tests.unit.api.v2 import test_base"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_4f3585d8","line":31,"range":{"start_line":31,"start_character":40,"end_line":31,"end_character":46},"updated":"2016-08-05 01:41:12.000000000","message":"how about agent_cfg or agent_config?","commit_id":"29c3fd39e5fd83ebc00cb92d52a8dce77b53c4e4"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"36332d657ebec88e967f38aef962c5da32afe122","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent import securitygroups_rpc as sg_cfg"},{"line_number":29,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import common as a_cfg"},{"line_number":32,"context_line":"from neutron.tests import base"},{"line_number":33,"context_line":"from neutron.tests.unit.api.v2 import test_base"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_ecb21805","line":31,"range":{"start_line":31,"start_character":40,"end_line":31,"end_character":46},"in_reply_to":"bacf61ea_4f3585d8","updated":"2016-08-05 18:24:30.000000000","message":"Done","commit_id":"29c3fd39e5fd83ebc00cb92d52a8dce77b53c4e4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f8876d8637fd63cd4b624a763e4ea5527fdf5677","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class BaseIptablesFirewallTestCase(base.BaseTestCase):"},{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        super(BaseIptablesFirewallTestCase, self).setUp()"},{"line_number":73,"context_line":"        cfg.CONF.register_opts(agent_config.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(sg_cfg.security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":75,"context_line":"        cfg.CONF.set_override(\u0027comment_iptables_rules\u0027, False, \u0027AGENT\u0027)"},{"line_number":76,"context_line":"        self.utils_exec_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_d2e9aae7","line":73,"range":{"start_line":73,"start_character":17,"end_line":73,"end_character":30},"updated":"2016-08-05 18:50:56.000000000","message":"Y aren\u0027t we calling register_root_helper() like in other files","commit_id":"35dd18242cb5ed4c03a9754c1daac510b8f5268d"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5782d063c4562921a93f4b10af03cfd56273b85d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        super(BaseIptablesFirewallTestCase, self).setUp()"},{"line_number":73,"context_line":"        security_config.register_securitygroups_opts()"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(agent_config.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":75,"context_line":"        cfg.CONF.set_override(\u0027comment_iptables_rules\u0027, False, \u0027AGENT\u0027)"},{"line_number":76,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":77,"context_line":"            \u0027neutron.agent.linux.utils.execute\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a89bdaa_425fc7e4","line":74,"updated":"2016-09-12 18:11:25.000000000","message":"nit: can we use the register_root_helper method in agent_config as agent_config.register_root_helper(cfg.CONF) instead of registering it here.","commit_id":"c40496bc4cd29dc45e29745972236f2d48fa4790"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"87b7b0f33cacf0f1f3a6f216859975bc0dadf48e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        super(BaseIptablesFirewallTestCase, self).setUp()"},{"line_number":73,"context_line":"        security_config.register_securitygroups_opts()"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(agent_config.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":75,"context_line":"        cfg.CONF.set_override(\u0027comment_iptables_rules\u0027, False, \u0027AGENT\u0027)"},{"line_number":76,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":77,"context_line":"            \u0027neutron.agent.linux.utils.execute\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_66762408","line":74,"in_reply_to":"9a89bdaa_425fc7e4","updated":"2016-09-27 18:47:23.000000000","message":"Done","commit_id":"c40496bc4cd29dc45e29745972236f2d48fa4790"}]}