)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5920ee4579264dac29c346cef09330fd5a9d34fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stefan Nica \u003cnica.stefan.daniel@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-16 22:54:11 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keepalived global_defs configuration entries required to avoid DNS lookup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This changeset addresses a particular L3-HA Neutron deployment scenario"},{"line_number":10,"context_line":"in which the DNS server configured for the management network is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_bcb49dd1","line":7,"updated":"2016-09-20 14:36:28.000000000","message":"nit: exceeds 50 characters","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5920ee4579264dac29c346cef09330fd5a9d34fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"also accessible from the virtual router namespace (i.e. over the"},{"line_number":12,"context_line":"external network)."},{"line_number":13,"context_line":"Keepalived uses the hostname against getaddrinfo twice to set default"},{"line_number":14,"context_line":"values for the router_id and notification_email_from global configuration"},{"line_number":15,"context_line":"attributes. If the hostname cannot be resolved through /etc/hosts and"},{"line_number":16,"context_line":"if the nameserver is not reachable, long delays are incurred during"},{"line_number":17,"context_line":"keepalived startup and configuration reload, causing VRRP state flapping"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_3c732d4f","line":14,"updated":"2016-09-20 14:36:28.000000000","message":"nit: exceeds 72 characters","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2340d8806da259632bf324212b55e66fc455e02b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Setting router_id and notification_email_from in the keepalived"},{"line_number":21,"context_line":"configuration avoids unnecessary DNS lookups. However, this solution"},{"line_number":22,"context_line":"is only effective with keepalived \u003e\u003d 1.2.17. Older versions still"},{"line_number":23,"context_line":"exhibit the same problem with or without this patch."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1511722"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_0e25b207","line":22,"updated":"2016-09-26 21:01:22.000000000","message":"When I first read this, I was concerned about keepalived \u003c 1.2.17 not being able to handle these new configuration directives. But, since you say that older versions exhibit the same broken behavior with this patch, I think that you\u0027ve tested it and it is fine, right?","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"04bf1a0b0808fd41dc1722a313dfa3322a3a92c4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Setting router_id and notification_email_from in the keepalived"},{"line_number":21,"context_line":"configuration avoids unnecessary DNS lookups. However, this solution"},{"line_number":22,"context_line":"is only effective with keepalived \u003e\u003d 1.2.17. Older versions still"},{"line_number":23,"context_line":"exhibit the same problem with or without this patch."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1511722"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_921f09b6","line":22,"in_reply_to":"5a8bc5a2_0e25b207","updated":"2016-09-27 12:27:13.000000000","message":"That\u0027s right, Carl, I tested older versions too (1.2.7 which is stock keepalived for Ubuntu 14.04). Besides, router_id and notification_email_from are not new configuration parameters, they have been supported by keepalived for a very long time (the 2005 1.1.8 keepalived version introduced router_id and notification_email_from is even older). It\u0027s just that Neutron never used them before this fix, because they had no relevance.","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7eb413f4d09779fb27e8fa0f53c302827479b34c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Setting router_id and notification_email_from in the keepalived"},{"line_number":21,"context_line":"configuration avoids unnecessary DNS lookups. However, this solution"},{"line_number":22,"context_line":"is only effective with keepalived \u003e\u003d 1.2.17. Older versions still"},{"line_number":23,"context_line":"exhibit the same problem with or without this patch."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1511722"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_1d46a17a","line":22,"in_reply_to":"5a8bc5a2_921f09b6","updated":"2016-09-27 14:17:08.000000000","message":"Exactly, I confirm checking that too (it was long ago, trying to mitigate the issue, btw).","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"4be5724e9c81636a6f546161b125be5b9a81df76","unresolved":false,"context_lines":[{"line_number":31,"context_line":"HA_DEFAULT_PRIORITY \u003d 50"},{"line_number":32,"context_line":"PRIMARY_VIP_RANGE_SIZE \u003d 24"},{"line_number":33,"context_line":"KEEPALIVED_SERVICE_NAME \u003d \u0027keepalived\u0027"},{"line_number":34,"context_line":"KEEPALIVED_EMAIL_FROM \u003d \u0027neutron@openstack\u0027"},{"line_number":35,"context_line":"KEEPALIVED_ROUTER_ID \u003d \u0027neutron\u0027"},{"line_number":36,"context_line":"GARP_MASTER_DELAY \u003d 60"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_88a8f478","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":42},"updated":"2016-09-16 11:49:32.000000000","message":"Dotless email addresses are strongly discouraged by ICANN [1]. Even though this address is unlikely to be used at all, you might consider using stg like openstack.local.\n\n[1] https://www.icann.org/news/announcement-2013-08-30-en","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"2d131b18be8e35b43b1590b974d994c86d1a540e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"HA_DEFAULT_PRIORITY \u003d 50"},{"line_number":32,"context_line":"PRIMARY_VIP_RANGE_SIZE \u003d 24"},{"line_number":33,"context_line":"KEEPALIVED_SERVICE_NAME \u003d \u0027keepalived\u0027"},{"line_number":34,"context_line":"KEEPALIVED_EMAIL_FROM \u003d \u0027neutron@openstack\u0027"},{"line_number":35,"context_line":"KEEPALIVED_ROUTER_ID \u003d \u0027neutron\u0027"},{"line_number":36,"context_line":"GARP_MASTER_DELAY \u003d 60"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3dae3698","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":42},"in_reply_to":"7a8ec9b2_88a8f478","updated":"2016-09-16 15:50:41.000000000","message":"I wasn\u0027t aware of this. Thanks and done !","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"}],"neutron/tests/functional/agent/l3/framework.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6066d1f2bbae1d37ffd79d743e0cd29000120349","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"},{"line_number":366,"context_line":"    state BACKUP"},{"line_number":367,"context_line":"    interface %(ha_device_name)s"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_b83665b2","line":364,"updated":"2016-07-17 19:50:23.000000000","message":"why is this not indented like the others?","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"eabe96a63833d79cd87e92f37784929945af474b","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"},{"line_number":366,"context_line":"    state BACKUP"},{"line_number":367,"context_line":"    interface %(ha_device_name)s"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3bb39eea","line":364,"in_reply_to":"dada55a8_2fb972ea","updated":"2016-09-16 15:51:03.000000000","message":"I actually went back and found a nice solution using textwrap for this type of situation.","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"71b8797adec3a28aede56f6ca1870c64960dd003","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"},{"line_number":366,"context_line":"    state BACKUP"},{"line_number":367,"context_line":"    interface %(ha_device_name)s"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2fb972ea","line":364,"in_reply_to":"dada55a8_b83665b2","updated":"2016-07-18 12:52:48.000000000","message":"this is a multi-line string value that is matched against generated configuration file contents. It needs to match exactly and indenting it would make that impossible.","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"4be5724e9c81636a6f546161b125be5b9a81df76","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        default_gateway_ip \u003d external_port[\u0027subnets\u0027][0].get(\u0027gateway_ip\u0027)"},{"line_number":360,"context_line":"        extra_subnet_cidr \u003d external_port[\u0027extra_subnets\u0027][0].get(\u0027cidr\u0027)"},{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_8818f476","line":362,"range":{"start_line":362,"start_character":28,"end_line":362,"end_character":45},"updated":"2016-09-16 11:49:32.000000000","message":"This is defined in keepalived.py as a KEEPALIVED_EMAIL_FROM constant. The config generation should use that constant, not a static string.","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"2d131b18be8e35b43b1590b974d994c86d1a540e","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        default_gateway_ip \u003d external_port[\u0027subnets\u0027][0].get(\u0027gateway_ip\u0027)"},{"line_number":360,"context_line":"        extra_subnet_cidr \u003d external_port[\u0027extra_subnets\u0027][0].get(\u0027cidr\u0027)"},{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_9b0112b2","line":362,"range":{"start_line":362,"start_character":28,"end_line":362,"end_character":45},"in_reply_to":"7a8ec9b2_8818f476","updated":"2016-09-16 15:50:41.000000000","message":"I usually get weary at the thought of importing definitions from the tested code into the unit-test code, but in this case I think you\u0027re right, there should be no problem.","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"4be5724e9c81636a6f546161b125be5b9a81df76","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        extra_subnet_cidr \u003d external_port[\u0027extra_subnets\u0027][0].get(\u0027cidr\u0027)"},{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"},{"line_number":366,"context_line":"    state BACKUP"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_087144a8","line":363,"range":{"start_line":363,"start_character":14,"end_line":363,"end_character":21},"updated":"2016-09-16 11:49:32.000000000","message":"same as above (use KEEPALIVED_ROUTER_ID constant)","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"2d131b18be8e35b43b1590b974d994c86d1a540e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        extra_subnet_cidr \u003d external_port[\u0027extra_subnets\u0027][0].get(\u0027cidr\u0027)"},{"line_number":361,"context_line":"        return \"\"\"global_defs {"},{"line_number":362,"context_line":"    notification_email_from neutron@openstack"},{"line_number":363,"context_line":"    router_id neutron"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":"vrrp_instance VR_1 {"},{"line_number":366,"context_line":"    state BACKUP"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5b222a53","line":363,"range":{"start_line":363,"start_character":14,"end_line":363,"end_character":21},"in_reply_to":"7a8ec9b2_087144a8","updated":"2016-09-16 15:50:41.000000000","message":"Done","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"}],"neutron/tests/unit/agent/linux/test_keepalived.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6066d1f2bbae1d37ffd79d743e0cd29000120349","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                             KeepalivedConfBaseMixin):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    expected \u003d KEEPALIVED_GLOBAL_CONFIG + \"\"\""},{"line_number":119,"context_line":"vrrp_instance VR_1 {"},{"line_number":120,"context_line":"    state MASTER"},{"line_number":121,"context_line":"    interface eth0"},{"line_number":122,"context_line":"    virtual_router_id 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f840dd09","line":119,"updated":"2016-07-17 19:50:23.000000000","message":"same point here","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"eabe96a63833d79cd87e92f37784929945af474b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                             KeepalivedConfBaseMixin):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    expected \u003d KEEPALIVED_GLOBAL_CONFIG + \"\"\""},{"line_number":119,"context_line":"vrrp_instance VR_1 {"},{"line_number":120,"context_line":"    state MASTER"},{"line_number":121,"context_line":"    interface eth0"},{"line_number":122,"context_line":"    virtual_router_id 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3b38fe3c","line":119,"in_reply_to":"dada55a8_ef93da4d","updated":"2016-09-16 15:51:03.000000000","message":"Done","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"71b8797adec3a28aede56f6ca1870c64960dd003","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                             KeepalivedConfBaseMixin):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    expected \u003d KEEPALIVED_GLOBAL_CONFIG + \"\"\""},{"line_number":119,"context_line":"vrrp_instance VR_1 {"},{"line_number":120,"context_line":"    state MASTER"},{"line_number":121,"context_line":"    interface eth0"},{"line_number":122,"context_line":"    virtual_router_id 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ef93da4d","line":119,"in_reply_to":"dada55a8_f840dd09","updated":"2016-07-18 12:52:48.000000000","message":"same situation as with the other indentation","commit_id":"01f1ef48e7e81e976285b6ca6c3c761a2de884b6"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"4be5724e9c81636a6f546161b125be5b9a81df76","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# http://www.keepalived.org/pdf/UserGuide.pdf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"KEEPALIVED_GLOBAL_CONFIG \u003d \"\"\"global_defs {"},{"line_number":25,"context_line":"    notification_email_from neutron@openstack"},{"line_number":26,"context_line":"    router_id neutron"},{"line_number":27,"context_line":"}\"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_688e487a","line":25,"range":{"start_line":25,"start_character":28,"end_line":25,"end_character":45},"updated":"2016-09-16 11:49:32.000000000","message":"here and the line below: constant defined in keepalived.py should be used instead of static string","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"2d131b18be8e35b43b1590b974d994c86d1a540e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# http://www.keepalived.org/pdf/UserGuide.pdf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"KEEPALIVED_GLOBAL_CONFIG \u003d \"\"\"global_defs {"},{"line_number":25,"context_line":"    notification_email_from neutron@openstack"},{"line_number":26,"context_line":"    router_id neutron"},{"line_number":27,"context_line":"}\"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_dbd47a21","line":25,"range":{"start_line":25,"start_character":28,"end_line":25,"end_character":45},"in_reply_to":"7a8ec9b2_688e487a","updated":"2016-09-16 15:50:41.000000000","message":"Done","commit_id":"f90a4ff9047a602068bad408b08f5cd12fb9f770"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2340d8806da259632bf324212b55e66fc455e02b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"class KeepalivedConfTestCase(base.BaseTestCase,"},{"line_number":120,"context_line":"                             KeepalivedConfBaseMixin):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    expected \u003d KEEPALIVED_GLOBAL_CONFIG + textwrap.dedent(\"\"\""},{"line_number":123,"context_line":"        vrrp_instance VR_1 {"},{"line_number":124,"context_line":"            state MASTER"},{"line_number":125,"context_line":"            interface eth0"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_cea10a48","line":122,"updated":"2016-09-26 21:01:22.000000000","message":"This dedent thing is cute but it really doesn\u0027t have anything to do with this bug fix. Given that we\u0027re in the beginning of the cycle, I think it is probably fine though. I won\u0027t -1 for this. In general, though, please avoid the temptation to reformat stuff along with a bug fix if you don\u0027t have to.","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"04bf1a0b0808fd41dc1722a313dfa3322a3a92c4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"class KeepalivedConfTestCase(base.BaseTestCase,"},{"line_number":120,"context_line":"                             KeepalivedConfBaseMixin):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    expected \u003d KEEPALIVED_GLOBAL_CONFIG + textwrap.dedent(\"\"\""},{"line_number":123,"context_line":"        vrrp_instance VR_1 {"},{"line_number":124,"context_line":"            state MASTER"},{"line_number":125,"context_line":"            interface eth0"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_c65c6f1b","line":122,"in_reply_to":"5a8bc5a2_cea10a48","updated":"2016-09-27 12:27:13.000000000","message":"Gotcha.","commit_id":"b3af52e7388423a5fd3872453512218b00a5c6d7"}]}
