)]}'
{"neutron/db/migration/alembic_migrations/versions/newton/contract/a8b517cff8ab_add_routerport_bindings_for_ha.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"36ac6b52ab68d9f43b1475482d15796a57019681","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_796865bb","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":30},"updated":"2016-08-08 13:36:31.000000000","message":"How is that? I guess there should be 7d9d8eeec6ad","commit_id":"c3b6000bd5f380abed18d117d2376022a45742fe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8fde97ded5865cd8c4d1b72e7e74467c8b4a39ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_82d82bf1","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":30},"in_reply_to":"9ad45d7e_796865bb","updated":"2016-08-08 23:00:21.000000000","message":"ouch, bad conflict resolution on my part. how did this pass jenkins?","commit_id":"c3b6000bd5f380abed18d117d2376022a45742fe"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"73bd6744bf5b6759f6ffd125fc8501f06dd17740","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u0027a8b517cff8ab\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_03bd4668","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":30},"in_reply_to":"9ad45d7e_82d82bf1","updated":"2016-08-09 11:08:49.000000000","message":"This was a supersize for me as well, I thought that alembic should check this. Jenkins pass as this migration just was not running...","commit_id":"c3b6000bd5f380abed18d117d2376022a45742fe"}],"neutron/tests/functional/db/migrations/test_a8b517cff8ab_add_routerport_bindings_for_ha.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"b31f6cae55fa7281d92ec58644d7c05310428a35","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.functional.db import test_migrations"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class HARouterPortMigrationMixin(object):"},{"line_number":24,"context_line":"    \"\"\"Validates HA port to router port migration.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_so(self, o_type, values):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_25a20e4c","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"updated":"2016-07-24 15:26:26.000000000","message":"Not sure if it\u0027s intentional (no \u0027-1 Workflow\u0027), but this class currently doesn\u0027t run any test as it doesn\u0027t have a \u0027test_%s\u0027 function.","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b315d469c4bc7906c88b602a3ca5990abca9a781","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.functional.db import test_migrations"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class HARouterPortMigrationMixin(object):"},{"line_number":24,"context_line":"    \"\"\"Validates HA port to router port migration.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_so(self, o_type, values):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_9a3a0233","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"in_reply_to":"dada55a8_25a20e4c","updated":"2016-07-25 22:41:23.000000000","message":"Please look at https://github.com/openstack/neutron/blob/master/neutron/tests/functional/db/test_migrations.py . It doesn\u0027t have methods named \u0027test\u0027. It\u0027s based on the \u0027pre_upgrade\u0027 and \u0027check\u0027 methods in the class.","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"eaaff9b93f50380f5c2ca48a554effe0699c6894","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.functional.db import test_migrations"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class HARouterPortMigrationMixin(object):"},{"line_number":24,"context_line":"    \"\"\"Validates HA port to router port migration.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_so(self, o_type, values):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d8de346c","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"in_reply_to":"dada55a8_9a3a0233","updated":"2016-07-26 07:32:27.000000000","message":"Ah! Thanks for the clarification!: )","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"b31f6cae55fa7281d92ec58644d7c05310428a35","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        otable \u003d db_utils.get_table(self.engine, o_type)"},{"line_number":39,"context_line":"        self.engine.execute(otable.insert().values(values))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _make_router_agents_and_ports(self, rid, network_id, add_binding):"},{"line_number":42,"context_line":"        self._create_so(\u0027routers\u0027, {\u0027id\u0027: rid})"},{"line_number":43,"context_line":"        # each router gets a couple of agents"},{"line_number":44,"context_line":"        for _ in range(2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a5e0be97","line":41,"range":{"start_line":41,"start_character":44,"end_line":41,"end_character":47},"updated":"2016-07-24 15:26:26.000000000","message":"Please rename to router_id","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"b31f6cae55fa7281d92ec58644d7c05310428a35","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                      \u0027device_id\u0027: rid,"},{"line_number":50,"context_line":"                                      \u0027device_owner\u0027: \u0027network\u0027,"},{"line_number":51,"context_line":"                                      \u0027status\u0027: \u0027ACTIVE\u0027})"},{"line_number":52,"context_line":"            aid \u003d uuidutils.generate_uuid()"},{"line_number":53,"context_line":"            time \u003d \u00272000-04-06T14:34:23\u0027"},{"line_number":54,"context_line":"            self._create_rec(\u0027agents\u0027, {\u0027id\u0027: aid, \u0027topic\u0027: \u0027x\u0027,"},{"line_number":55,"context_line":"                                        \u0027agent_type\u0027: \u0027L3\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c5e5f2a8","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":16},"updated":"2016-07-24 15:26:26.000000000","message":"Please rename to agent_id","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"63080dd2a0f7c8c6a0b20e37e7837b97eed3fdad","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                      \u0027device_id\u0027: rid,"},{"line_number":50,"context_line":"                                      \u0027device_owner\u0027: \u0027network\u0027,"},{"line_number":51,"context_line":"                                      \u0027status\u0027: \u0027ACTIVE\u0027})"},{"line_number":52,"context_line":"            aid \u003d uuidutils.generate_uuid()"},{"line_number":53,"context_line":"            time \u003d \u00272000-04-06T14:34:23\u0027"},{"line_number":54,"context_line":"            self._create_rec(\u0027agents\u0027, {\u0027id\u0027: aid, \u0027topic\u0027: \u0027x\u0027,"},{"line_number":55,"context_line":"                                        \u0027agent_type\u0027: \u0027L3\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_daf75a57","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":16},"in_reply_to":"dada55a8_c5e5f2a8","updated":"2016-07-25 22:47:27.000000000","message":"Done","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"b31f6cae55fa7281d92ec58644d7c05310428a35","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                      \u0027device_owner\u0027: \u0027network\u0027,"},{"line_number":51,"context_line":"                                      \u0027status\u0027: \u0027ACTIVE\u0027})"},{"line_number":52,"context_line":"            aid \u003d uuidutils.generate_uuid()"},{"line_number":53,"context_line":"            time \u003d \u00272000-04-06T14:34:23\u0027"},{"line_number":54,"context_line":"            self._create_rec(\u0027agents\u0027, {\u0027id\u0027: aid, \u0027topic\u0027: \u0027x\u0027,"},{"line_number":55,"context_line":"                                        \u0027agent_type\u0027: \u0027L3\u0027,"},{"line_number":56,"context_line":"                                        \u0027binary\u0027: \u0027x\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_45e8e27c","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":16},"updated":"2016-07-24 15:26:26.000000000","message":"Please rename to \u0027timestamp\u0027 or something else that isn\u0027t importable (you can \"import time\" so it\u0027s confusing which namespace is used below).","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"63080dd2a0f7c8c6a0b20e37e7837b97eed3fdad","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                      \u0027device_owner\u0027: \u0027network\u0027,"},{"line_number":51,"context_line":"                                      \u0027status\u0027: \u0027ACTIVE\u0027})"},{"line_number":52,"context_line":"            aid \u003d uuidutils.generate_uuid()"},{"line_number":53,"context_line":"            time \u003d \u00272000-04-06T14:34:23\u0027"},{"line_number":54,"context_line":"            self._create_rec(\u0027agents\u0027, {\u0027id\u0027: aid, \u0027topic\u0027: \u0027x\u0027,"},{"line_number":55,"context_line":"                                        \u0027agent_type\u0027: \u0027L3\u0027,"},{"line_number":56,"context_line":"                                        \u0027binary\u0027: \u0027x\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_bab0a68c","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":16},"in_reply_to":"dada55a8_45e8e27c","updated":"2016-07-25 22:47:27.000000000","message":"Done","commit_id":"0945355e6ea45cc70904e983a92d56b95297d991"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f1642f5877527e09658659bad3c4834e4d81539a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Business Cat is Very Serious"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_1afadfbd","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":45},"updated":"2016-08-15 16:31:28.000000000","message":"lol","commit_id":"91614d33c101b72c0fab965bf58dddde2fa25c87"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f1642f5877527e09658659bad3c4834e4d81539a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.functional.db import test_migrations"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class HARouterPortMigrationMixin(object):"},{"line_number":24,"context_line":"    \"\"\"Validates HA port to router port migration.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_so(self, o_type, values):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_3a6a3b81","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":32},"updated":"2016-08-15 16:31:28.000000000","message":"You really want to call it a mixin? ;)","commit_id":"91614d33c101b72c0fab965bf58dddde2fa25c87"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f1642f5877527e09658659bad3c4834e4d81539a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                      add_binding):"},{"line_number":43,"context_line":"        self._create_so(\u0027routers\u0027, {\u0027id\u0027: router_id})"},{"line_number":44,"context_line":"        # each router gets a couple of agents"},{"line_number":45,"context_line":"        for _ in range(2):"},{"line_number":46,"context_line":"            port_id \u003d uuidutils.generate_uuid()"},{"line_number":47,"context_line":"            self._create_so(\u0027ports\u0027, {\u0027id\u0027: port_id, \u0027network_id\u0027: network_id,"},{"line_number":48,"context_line":"                                      \u0027mac_address\u0027: port_id[0:31],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_bab0ebf5","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":13},"updated":"2016-08-15 16:31:28.000000000","message":"I guess there is no chance of conflicting with translations in here.","commit_id":"91614d33c101b72c0fab965bf58dddde2fa25c87"}]}
