)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"b33c93a3d0a2219cae1d21c5cbfddffdc481c4e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New exception for deleting a trunk having subports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_55767906","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":8},"updated":"2016-07-20 15:21:30.000000000","message":"I\u0027m not sure that\u0027s correct; the spec [1] says the opposite:\n\n\u003e Deletion of a trunk automatically deletes all of its subports.\n\nThe data model [2] also has a cascading delete of subports when their trunk is deleted.\n\n[1] https://specs.openstack.org/openstack/neutron-specs/specs/backlog/mitaka/vlan-aware-vms.html#constraints\n[2] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/models.py#L60","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"ac6f09aaf19901ac861d68af8e7283ec93e45052","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New exception for deleting a trunk having subports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_1ee6d814","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"dada55a8_1edc1872","updated":"2016-07-20 17:20:19.000000000","message":"\u003e ensure that the trunk deletion triggers agent-side cleanup.\n\nThe trunk cannot be deleted while its parent port is still bound. When Nova unbinds the parent port, it will also delete the trunk vif port. The agent-side cleanup of the trunk/subports needs to be triggered when it detects the trunk vif port has been removed.","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4708d13708cb81b8faa3ac921f6f79a3be7e9e70","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New exception for deleting a trunk having subports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_3ec63c9a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"dada55a8_1edc1872","updated":"2016-07-20 17:11:52.000000000","message":"which is currently missing, but in the works.","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5fc8ca836b5ddb81d903ae5e76a70bb216f34838","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New exception for deleting a trunk having subports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_d89d6767","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"dada55a8_1ee6d814","updated":"2016-07-20 23:35:46.000000000","message":"@Rawlin: right and that is enforced already. Now when Nova deletes a VM (ie. unbinds the port), the agent can do its local cleanup, by deleting the trunk bridge and the associated ports. Thanks for reminding me of that :)","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5040e8956ca5ab42fcdca8ee5d592c68af58b326","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New exception for deleting a trunk having subports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_1edc1872","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"dada55a8_55767906","updated":"2016-07-20 17:11:06.000000000","message":"I thought too...what we need to do here is ensure that the trunk deletion triggers agent-side cleanup.","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"b33c93a3d0a2219cae1d21c5cbfddffdc481c4e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_d50a6978","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":19},"updated":"2016-07-20 15:21:30.000000000","message":"exception","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5a8e612664859c195ab375e0c9b203cf189075f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_9e0be8d5","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":19},"in_reply_to":"dada55a8_d50a6978","updated":"2016-07-20 17:15:00.000000000","message":"can you share the nature of the internal error (e.g. on paste.openstack.org)? I believe this use case is not yet covered because the delete of a trunk with subports is not yet taken care of.","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"46e90da26a1b89fc0f50b695a7e28bf1859237dd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"bp/vlan-aware-vms says we prohibit deletion of a trunk that still has"},{"line_number":10,"context_line":"subports. This constraint is enforced by the DB model, however that"},{"line_number":11,"context_line":"led to an excpetion that was turned into a \u0027Internal Server Error\u0027 in"},{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0198e35a6697cdafa9f46781b79b4935fbabc9bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_78a8d177","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2016-07-20 15:32:40.000000000","message":"I agree with Rawlin. We should add API test for this scenario to make sure server doesn\u0027t return error but deletes subport resources instead.","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dc0cb72df9105f79b56c125f8108d1bb905d1c0d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the API. Introduce a new exception for this case and raise it when"},{"line_number":13,"context_line":"deleting a trunk."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0198e35a6697cdafa9f46781b79b4935fbabc9bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_1897ffec","line":15,"updated":"2016-07-20 23:47:14.000000000","message":"with [1] we should be good going forward, I think this patch can be abandoned.\n\n[1] https://review.openstack.org/#/c/345101/","commit_id":"8b8bac8e3c0bbefe87a02dcb312b4f9179787744"}]}
