)]}'
{"neutron/services/metering/agents/metering_agent.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"cd82eea7f9e311a2fa9948a25f11298ff2308a52","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import topics"},{"line_number":34,"context_line":"from neutron.common import utils"},{"line_number":35,"context_line":"from neutron.conf.services import metering_agent"},{"line_number":36,"context_line":"from neutron.db import api as db_api"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":"from neutron import manager"},{"line_number":39,"context_line":"from neutron import service as neutron_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_d8093d2e","line":36,"updated":"2016-08-25 15:36:22.000000000","message":"It\u0027s may looks strange, but if you will exchange 36 and 37 lines, then pep8 will pass.","commit_id":"9870f413374c44eb316ca2d6b35d721b864c2264"},{"author":{"_account_id":20481,"name":"Sana Khan","email":"sanakhan2011@gmail.com","username":"sana.khan"},"change_message_id":"ca37921f2d7cfc6cde229f73b289c5aa54ab85e9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import topics"},{"line_number":34,"context_line":"from neutron.common import utils"},{"line_number":35,"context_line":"from neutron.conf.services import metering_agent"},{"line_number":36,"context_line":"from neutron.db import api as db_api"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":"from neutron import manager"},{"line_number":39,"context_line":"from neutron import service as neutron_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_d51e4162","line":36,"in_reply_to":"1ac06dbe_d8093d2e","updated":"2016-08-29 09:32:54.000000000","message":"Done","commit_id":"9870f413374c44eb316ca2d6b35d721b864c2264"}],"neutron/services/metering/drivers/abstract_driver.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @abc.abstractmethod"},{"line_number":68,"context_line":"    def populate_stats_for_all_ports (self):"},{"line_number":69,"context_line":"        pass"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5403f2b7","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":37},"updated":"2016-08-11 12:25:52.000000000","message":"space here is not needed","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @abc.abstractmethod"},{"line_number":76,"context_line":"    def get_port_stats (self, port_id):"},{"line_number":77,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f4c82657","line":76,"range":{"start_line":76,"start_character":22,"end_line":76,"end_character":23},"updated":"2016-08-11 12:25:52.000000000","message":"ditto","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"}],"neutron/services/metering/drivers/port_stats/port_stats_driver.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a8e2a1d681f2bfbc28e11a153e6a136dbecc0849","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        self.all_port_stats \u003d []"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    def get_tenant_id_from_meter_label(self, session):"},{"line_number":16,"context_line":"        tenant_id \u003d session.query(metering_db.MeteringLabel).first()[\u0027tenant_id\u0027]"},{"line_number":17,"context_line":"        return tenant_id"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def get_port_id_list_from_neutron_db(self, session, tenant_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d11dbd10","line":16,"updated":"2016-07-28 13:38:22.000000000","message":"please, use get(\u0027tenant_id\u0027) instead of [\u0027tenant_id\u0027]","commit_id":"773ac76a4fe968408443f136ff4b74970cc55ac3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a8e2a1d681f2bfbc28e11a153e6a136dbecc0849","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        return tenant_id"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def get_port_id_list_from_neutron_db(self, session, tenant_id):"},{"line_number":20,"context_line":"        port_list \u003d []"},{"line_number":21,"context_line":"        for port in session.query(models_v2.Port).filter_by(tenant_id\u003dtenant_id):"},{"line_number":22,"context_line":"                port_list.append(port[\u0027id\u0027])"},{"line_number":23,"context_line":"        return port_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_51638db1","line":20,"updated":"2016-07-28 13:38:22.000000000","message":"I\u0027d prefer to use list comprehension here","commit_id":"773ac76a4fe968408443f136ff4b74970cc55ac3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a8e2a1d681f2bfbc28e11a153e6a136dbecc0849","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                    columns\u003d[\u0027name\u0027, \u0027external_ids\u0027,\u0027statistics\u0027]).execute()"},{"line_number":29,"context_line":"        for d in self.data:"},{"line_number":30,"context_line":"            if bool(d[u\u0027external_ids\u0027]):"},{"line_number":31,"context_line":"                self.all_port_stats.append({"},{"line_number":32,"context_line":"                    \u0027port_id\u0027: d[u\u0027external_ids\u0027][u\u0027iface-id\u0027],"},{"line_number":33,"context_line":"                    \u0027port_name\u0027: d[u\u0027name\u0027],"},{"line_number":34,"context_line":"                    \u0027switch.port.receive.packets\u0027 : d[u\u0027statistics\u0027][u\u0027rx_packets\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2c4cc26f","line":31,"updated":"2016-07-28 13:38:22.000000000","message":"I really don\u0027t like a lot of hardcoded stuff here :(","commit_id":"773ac76a4fe968408443f136ff4b74970cc55ac3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a8e2a1d681f2bfbc28e11a153e6a136dbecc0849","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                            session, meter_label_tenant_id)"},{"line_number":53,"context_line":"        tenant_port_stats \u003d []"},{"line_number":54,"context_line":"        for port_id in tenant_port_id_list:"},{"line_number":55,"context_line":"                tenant_port_stats.append(self.get_port_stats(port_id))"},{"line_number":56,"context_line":"        return tenant_port_stats"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_port_stats (self, port_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_31dc1912","line":55,"updated":"2016-07-28 13:38:22.000000000","message":"list comprehension is preferred, again and one unnecessary level of indentation","commit_id":"773ac76a4fe968408443f136ff4b74970cc55ac3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a8e2a1d681f2bfbc28e11a153e6a136dbecc0849","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_port_stats (self, port_id):"},{"line_number":59,"context_line":"        for port_stats in self.all_port_stats:"},{"line_number":60,"context_line":"                if port_stats[\u0027port_id\u0027] \u003d\u003d port_id:"},{"line_number":61,"context_line":"                        return port_stats"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_31e6d9b4","line":60,"updated":"2016-07-28 13:38:22.000000000","message":"one unnecessary level of indentation","commit_id":"773ac76a4fe968408443f136ff4b74970cc55ac3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        ]"},{"line_number":26,"context_line":"        return port_list"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def populate_stats_for_all_ports (self):"},{"line_number":29,"context_line":"        ovs \u003d ovs_lib.BaseOVS()"},{"line_number":30,"context_line":"        self.data \u003d ovs.ovsdb.db_list(\u0027Interface\u0027,"},{"line_number":31,"context_line":"                    columns\u003d[\u0027name\u0027, \u0027external_ids\u0027,\u0027statistics\u0027]).execute()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_14d5fae6","line":28,"range":{"start_line":28,"start_character":36,"end_line":28,"end_character":37},"updated":"2016-08-11 12:25:52.000000000","message":"space is not required","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def populate_stats_for_all_ports (self):"},{"line_number":29,"context_line":"        ovs \u003d ovs_lib.BaseOVS()"},{"line_number":30,"context_line":"        self.data \u003d ovs.ovsdb.db_list(\u0027Interface\u0027,"},{"line_number":31,"context_line":"                    columns\u003d[\u0027name\u0027, \u0027external_ids\u0027,\u0027statistics\u0027]).execute()"},{"line_number":32,"context_line":"        for d in self.data:"},{"line_number":33,"context_line":"            port_statistics \u003d d[u\u0027statistics\u0027]"},{"line_number":34,"context_line":"            if bool(d[u\u0027external_ids\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d434024b","line":31,"updated":"2016-08-11 12:25:52.000000000","message":"18 extra spaces are required here (word \"columns\" should be under \u0027Interface\u0027)","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def populate_stats_for_all_ports (self):"},{"line_number":29,"context_line":"        ovs \u003d ovs_lib.BaseOVS()"},{"line_number":30,"context_line":"        self.data \u003d ovs.ovsdb.db_list(\u0027Interface\u0027,"},{"line_number":31,"context_line":"                    columns\u003d[\u0027name\u0027, \u0027external_ids\u0027,\u0027statistics\u0027]).execute()"},{"line_number":32,"context_line":"        for d in self.data:"},{"line_number":33,"context_line":"            port_statistics \u003d d[u\u0027statistics\u0027]"},{"line_number":34,"context_line":"            if bool(d[u\u0027external_ids\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b40eae89","line":31,"range":{"start_line":31,"start_character":51,"end_line":31,"end_character":53},"updated":"2016-08-11 12:25:52.000000000","message":"space after the comma is needed","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                self.all_port_stats.append({"},{"line_number":36,"context_line":"                    \u0027port_id\u0027: d[u\u0027external_ids\u0027][u\u0027iface-id\u0027],"},{"line_number":37,"context_line":"                    \u0027port_name\u0027: d[u\u0027name\u0027],"},{"line_number":38,"context_line":"                    \u0027port_statistics\u0027 : port_statistics"},{"line_number":39,"context_line":"                    })"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def populate_stats_for_tenant_ports(self, session):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_341bdecb","line":38,"range":{"start_line":38,"start_character":37,"end_line":38,"end_character":38},"updated":"2016-08-11 12:25:52.000000000","message":"space here is not required","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                             for port_id in tenant_port_id_list]"},{"line_number":48,"context_line":"        return tenant_port_stats"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_port_stats (self, port_id):"},{"line_number":51,"context_line":"        for port_stats in self.all_port_stats:"},{"line_number":52,"context_line":"                if port_stats[\u0027port_id\u0027] \u003d\u003d port_id: return port_stats"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_94ca8a19","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":23},"updated":"2016-08-11 12:25:52.000000000","message":"there is an extra space again","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5388cf72f367f77619399a4a2216b0dc72ec76df","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_port_stats (self, port_id):"},{"line_number":51,"context_line":"        for port_stats in self.all_port_stats:"},{"line_number":52,"context_line":"                if port_stats[\u0027port_id\u0027] \u003d\u003d port_id: return port_stats"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_14b4da7d","line":52,"updated":"2016-08-11 12:25:52.000000000","message":"please, move the return-statement on the next line","commit_id":"dc2944f8972d2fd63df0a37a7e2fb63bf1f1629b"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"cd82eea7f9e311a2fa9948a25f11298ff2308a52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from neutron.agent.common import ovs_lib"},{"line_number":2,"context_line":"from neutron.db.metering import metering_db"},{"line_number":3,"context_line":"from neutron.db import models_v2"},{"line_number":4,"context_line":"from neutron.services.metering.drivers import abstract_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_9504b07e","line":1,"updated":"2016-08-25 15:36:22.000000000","message":"Okay, you should paste text from Apache 2.0 license here (like in any other .py file in neutron)","commit_id":"9870f413374c44eb316ca2d6b35d721b864c2264"},{"author":{"_account_id":20481,"name":"Sana Khan","email":"sanakhan2011@gmail.com","username":"sana.khan"},"change_message_id":"ca37921f2d7cfc6cde229f73b289c5aa54ab85e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from neutron.agent.common import ovs_lib"},{"line_number":2,"context_line":"from neutron.db.metering import metering_db"},{"line_number":3,"context_line":"from neutron.db import models_v2"},{"line_number":4,"context_line":"from neutron.services.metering.drivers import abstract_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_ba08cc2e","line":1,"in_reply_to":"1ac06dbe_9504b07e","updated":"2016-08-29 09:32:54.000000000","message":"Done","commit_id":"9870f413374c44eb316ca2d6b35d721b864c2264"}]}
