)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"09047a86135f2066e8bf73facc41496f9a09d1c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  by the agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE this change currently depends on changes to ovs which have"},{"line_number":26,"context_line":"not yet merged. it is expected that these chages will be part of"},{"line_number":27,"context_line":"the next ovs release but are currently under review."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"https://patchwork.ozlabs.org/patch/647253/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_a64303ae","line":26,"updated":"2016-07-21 17:53:31.000000000","message":"how likely is this to happen? Shall we push this only once we have certainty that this new capability is merged?","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e16e8591bc4b7c433051bf1f114d46c9b2473a71","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  by the agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE this change currently depends on changes to ovs which have"},{"line_number":26,"context_line":"not yet merged. it is expected that these chages will be part of"},{"line_number":27,"context_line":"the next ovs release but are currently under review."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"https://patchwork.ozlabs.org/patch/647253/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_b7073dc8","line":26,"in_reply_to":"dada55a8_a64303ae","updated":"2016-07-25 13:33:27.000000000","message":"it is reasonably likely that this will indeed be merged to ovs eventually, i think this patch should be held until the patch is accepted upstream in ovs.\n\nthis feature has two dependeces on ovs.\n\nfirst ovs must be updated to support dpdk 16.07\nthis is not a controversial change so should be merged shortly after the 16.07 release comes out in the next few days.\n\nsecond is the patch to enable reconnect itself. this is also a relitivly straight forward patch which i hope will be included in 2.6 but that is gated on supporting dpdk 16.07 in ovs 2.6\n\nif this was a dependency on another openstack project i would have added a depends annotation. i will update the commit with commit message when the patch has been accepted in openvswich.","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c91d8247c5d79aa1b9553611a65d74186dd85bfb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  by the agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE this change currently depends on changes to ovs which have"},{"line_number":26,"context_line":"not yet merged. it is expected that these chages will be part of"},{"line_number":27,"context_line":"the next ovs release but are currently under review."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"https://patchwork.ozlabs.org/patch/647253/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_90a0b891","line":26,"in_reply_to":"dada55a8_b7073dc8","updated":"2016-08-06 14:55:59.000000000","message":"as a quick update on this.\ndpdk 16.07 is now released an support has merged to the ovs master branch.\n\novs 2.6 is trending to release mid september and reconnect is expected to be included in that release but is still pending review.\n\ni will update this patch when that status changes.","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02c7a91ade5a5e17a494f172c4f29bf59dce90c3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  vhost user socket mode based on the vhost_driver_mode reported"},{"line_number":23,"context_line":"  by the agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE this change currently depends a change to ovs which have"},{"line_number":26,"context_line":"not yet merged. https://patchwork.ozlabs.org/patch/660455/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Iec89eaa597311e086c5f6e8d67308d446b07ac33"},{"line_number":29,"context_line":"Closes-Bug: #1604924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a8bc5a2_1c66c329","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":58},"updated":"2016-09-27 03:45:30.000000000","message":"all changes in ovs are now merged.\nhttps://github.com/openvswitch/ovs/commit/2d24d165d6a56bf5c0eb7015649cab688bcb2863\ni will resping this patach next week for ocata along with the changes to nova and os-vif which will be tracked with depends lines.","commit_id":"47968117ee13a3753cbfc8e2d7027fb92809e142"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"364d81115e8d05148c88fd8224852e26ca266b91","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  shutdown or a crash with out requireing the vm to reboot."},{"line_number":15,"context_line":"- vhost-user recoonect requires qemu to be the vhost-user server"},{"line_number":16,"context_line":"  and ovs to be the client."},{"line_number":17,"context_line":"- dpdk proir to 16.07 only supports qemu client/ dpdk server mode."},{"line_number":18,"context_line":"- This change extends the ovs neutron agent to read the"},{"line_number":19,"context_line":"  vhost_driver_mode form the ovsdb and report it as part of the"},{"line_number":20,"context_line":"  agent report."},{"line_number":21,"context_line":"- This change extends the ovs mech driver to select the correct qemu"},{"line_number":22,"context_line":"  vhost user socket mode based on the vhost_driver_mode reported"},{"line_number":23,"context_line":"  by the agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Iec89eaa597311e086c5f6e8d67308d446b07ac33"},{"line_number":26,"context_line":"Closes-Bug: #1604924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_28509ed3","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":15},"updated":"2016-12-06 17:05:23.000000000","message":"TODO: remove this as it is nolonger correct. \n-this change select the vhost_driver_mode based on the interface types reported by the agent not the mode.","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"09047a86135f2066e8bf73facc41496f9a09d1c8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"OVS_DEFAULT_CAPS \u003d {"},{"line_number":62,"context_line":"    \u0027datapath_types\u0027: [],"},{"line_number":63,"context_line":"    \u0027iface_types\u0027: [],"},{"line_number":64,"context_line":"    \u0027other_config\u0027:{\u0027vhost_driver_mode\u0027:\u0027server\u0027}"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_46afa77c","line":64,"updated":"2016-07-21 17:53:31.000000000","message":"missing space","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"248c2f471ab052867298c880c15403493c11eabd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"OVS_DEFAULT_CAPS \u003d {"},{"line_number":62,"context_line":"    \u0027datapath_types\u0027: [],"},{"line_number":63,"context_line":"    \u0027iface_types\u0027: [],"},{"line_number":64,"context_line":"    \u0027other_config\u0027:{\u0027vhost_driver_mode\u0027:\u0027server\u0027}"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_a61ae3c3","line":64,"in_reply_to":"dada55a8_46afa77c","updated":"2016-07-21 17:54:01.000000000","message":"shall we make a note about what version these other configs are added?","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e16e8591bc4b7c433051bf1f114d46c9b2473a71","unresolved":false,"context_lines":[{"line_number":61,"context_line":"OVS_DEFAULT_CAPS \u003d {"},{"line_number":62,"context_line":"    \u0027datapath_types\u0027: [],"},{"line_number":63,"context_line":"    \u0027iface_types\u0027: [],"},{"line_number":64,"context_line":"    \u0027other_config\u0027:{\u0027vhost_driver_mode\u0027:\u0027server\u0027}"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2b35aa45","line":64,"in_reply_to":"dada55a8_a61ae3c3","updated":"2016-07-25 13:33:27.000000000","message":"the other config field itself predates 2.0 but the new value will be added in 2.6 hopefully.\n\nwould you like me to add the comment on the same line\ne.g.\n\u0027other_config\u0027:{\u0027vhost_driver_mode\u0027:\u0027server\u0027} # added in ovs 2.6","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"09047a86135f2066e8bf73facc41496f9a09d1c8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                              a_const.VHOST_USER_SOCKET_DIR)"},{"line_number":127,"context_line":"        sock_name \u003d (constants.VHOST_USER_DEVICE_PREFIX + port_id)[:14]"},{"line_number":128,"context_line":"        return os.path.join(sockdir, sock_name)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_06a48fb7","line":129,"updated":"2016-07-21 17:53:31.000000000","message":"extra line","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e16e8591bc4b7c433051bf1f114d46c9b2473a71","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                              a_const.VHOST_USER_SOCKET_DIR)"},{"line_number":127,"context_line":"        sock_name \u003d (constants.VHOST_USER_DEVICE_PREFIX + port_id)[:14]"},{"line_number":128,"context_line":"        return os.path.join(sockdir, sock_name)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f7b255e4","line":129,"in_reply_to":"dada55a8_06a48fb7","updated":"2016-07-25 13:33:27.000000000","message":"yep ill remove","commit_id":"d3bf568a3d026360ca79aa0cef4865a16a51ade5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c585f1392c41162b7a7917c71c5ed8aba0a90490","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":88,"context_line":"        return self.vif_type"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":91,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"},{"line_number":92,"context_line":"        # driver mode into the qemu vhost user mode. If ovs is the server"},{"line_number":93,"context_line":"        # qemu is the client. If ovs is the client qemu is the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_21b04243","line":90,"updated":"2016-10-30 14:52:36.000000000","message":"please add a unit test for this method","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df3ceed930c6115156c97ea2f2bc7704189a06a3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":88,"context_line":"        return self.vif_type"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":91,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"},{"line_number":92,"context_line":"        # driver mode into the qemu vhost user mode. If ovs is the server"},{"line_number":93,"context_line":"        # qemu is the client. If ovs is the client qemu is the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_1867bce9","line":90,"in_reply_to":"ba5da102_21b04243","updated":"2016-11-10 22:24:38.000000000","message":"thanks i will add this as part of the next rebase","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2ccbbee133cdf654e8ad77e6975021f7c943e769","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":91,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"},{"line_number":92,"context_line":"        # driver mode into the qemu vhost user mode. If ovs is the server"},{"line_number":93,"context_line":"        # qemu is the client. If ovs is the client qemu is the server."},{"line_number":94,"context_line":"        if (a_const.OVS_DPDK_VHOST_USER_CLIENT in iface_types):"},{"line_number":95,"context_line":"            return portbindings.VHOST_USER_MODE_SERVER"},{"line_number":96,"context_line":"        return portbindings.VHOST_USER_MODE_CLIENT"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_323b36d3","line":93,"range":{"start_line":92,"start_character":53,"end_line":93,"end_character":69},"updated":"2016-10-29 04:02:00.000000000","message":"Can we rephrase this.. To me both the sentences looks independent.. Can we say \"If OVS is the server, qemu is the client or vice-versa\"?","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df3ceed930c6115156c97ea2f2bc7704189a06a3","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":91,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"},{"line_number":92,"context_line":"        # driver mode into the qemu vhost user mode. If ovs is the server"},{"line_number":93,"context_line":"        # qemu is the client. If ovs is the client qemu is the server."},{"line_number":94,"context_line":"        if (a_const.OVS_DPDK_VHOST_USER_CLIENT in iface_types):"},{"line_number":95,"context_line":"            return portbindings.VHOST_USER_MODE_SERVER"},{"line_number":96,"context_line":"        return portbindings.VHOST_USER_MODE_CLIENT"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_18aedce5","line":93,"range":{"start_line":92,"start_character":53,"end_line":93,"end_character":69},"in_reply_to":"ba5da102_323b36d3","updated":"2016-11-10 22:24:38.000000000","message":"yes that is a less clunky then what i have now. i will rephrase when i rebase.","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"}],"releasenotes/notes/vhost-user-reconnect-7650134520022e7d.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2ccbbee133cdf654e8ad77e6975021f7c943e769","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    backend in the event the backend terminates."},{"line_number":6,"context_line":"    This enable a vm utilising a vhost-user interface"},{"line_number":7,"context_line":"    to reconnect automatically to the backend e.g."},{"line_number":8,"context_line":"    a vswitch without requireing the vm to reboot."},{"line_number":9,"context_line":"    In this release support was added to the neutron"},{"line_number":10,"context_line":"    openvswitch agent and ml2 driver for vhost-user"},{"line_number":11,"context_line":"    reconenct."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_f220de9d","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":32},"updated":"2016-10-29 04:02:00.000000000","message":"typo: requiring","commit_id":"230ec4994658b7ba3e6402a67e7eafda11eaf406"}]}