)]}'
{"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fa367e0f8d7497bafb16299053f76bbc32a3175f","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        tags_present \u003d [t for t in tags if t[\u0027tag\u0027] !\u003d []]"},{"line_number":397,"context_line":"        self.assertTrue(tags_present)"},{"line_number":398,"context_line":"        tags_42 \u003d [t for t in tags_present if t[\u0027tag\u0027] \u003d\u003d 42]"},{"line_number":399,"context_line":"        single_value \u003d self.ovs.ovsdb.db_find("},{"line_number":400,"context_line":"            \u0027Port\u0027, (\u0027tag\u0027, \u0027\u003d\u0027, 42), columns\u003d[\u0027tag\u0027]).execute()"},{"line_number":401,"context_line":"        self.assertEqual(tags_42, single_value)"},{"line_number":402,"context_line":"        self.assertItemsEqual(len_0_list, tags_present)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_face5158","line":399,"range":{"start_line":399,"start_character":38,"end_line":399,"end_character":45},"updated":"2016-08-05 15:29:50.000000000","message":"Note: left out of transaction because it\u0027s only querying a single val.","commit_id":"3ef9602a05f0b6d43ec21a4ecbc8589155e9d2c4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"657e645ad5bdd5569e225d8f7976915a3c03cf2f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            txn.add(self.ovs.ovsdb.db_list(\u0027Port\u0027, columns\u003d[\u0027tag\u0027]))"},{"line_number":387,"context_line":"            txn.add(self.ovs.ovsdb.db_find("},{"line_number":388,"context_line":"                    \u0027Port\u0027, (\u0027tag\u0027, \u0027!\u003d\u0027, []), columns\u003d[\u0027tag\u0027]))"},{"line_number":389,"context_line":"            results \u003d txn.do_commit()"},{"line_number":390,"context_line":"            tags \u003d results[0]"},{"line_number":391,"context_line":"            len_0_list \u003d results[1]"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_3552b013","line":389,"range":{"start_line":389,"start_character":26,"end_line":389,"end_character":35},"updated":"2016-08-05 19:09:25.000000000","message":"Apparently only the IDL impl has do_commit().","commit_id":"d29453928bd32af86eb3b38b6e5e4d60c68ebc8b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bf2e0f270aa29a6cf3c387a07aef6fb073150b2d","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.ovs.set_db_attribute(\u0027Port\u0027, port_name, \u0027tag\u0027, 42)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # wrap list/find in transaction so we get a single isolated snapshot"},{"line_number":385,"context_line":"        txn \u003d self.ovs.ovsdb.transaction(check_error\u003dTrue)"},{"line_number":386,"context_line":"        txn.add(self.ovs.ovsdb.db_list(\u0027Port\u0027, columns\u003d[\u0027tag\u0027]))"},{"line_number":387,"context_line":"        txn.add(self.ovs.ovsdb.db_find(\u0027Port\u0027, (\u0027tag\u0027, \u0027!\u003d\u0027, []),"},{"line_number":388,"context_line":"                                       columns\u003d[\u0027tag\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_6967774d","line":385,"updated":"2016-08-10 14:26:23.000000000","message":"You can get rid of relying on positional results if you use the context manager. Something like:\n\n        with self.ovs.ovsdb.transaction(check_error\u003dTrue) as txn:\n            tags \u003d txn.add(self.ovs.ovsdb.db_list(\u0027Port\u0027, columns\u003d[\u0027tag\u0027]))\n            len0 \u003d txn.add(self.ovs.ovsdb.db_find(\u0027Port\u0027, (\u0027tag\u0027, \u0027!\u003d\u0027, []),\n                                                  columns\u003d[\u0027tag\u0027]))\n        tags \u003d tags.result  # These could be used directly below\n        len_0_list \u003d len0.result","commit_id":"2b74f50bd64b483967b4fd9188dc3811c7f05843"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d4016cc74bf88571418853977a62a120dc12b96c","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.ovs.set_db_attribute(\u0027Port\u0027, port_name, \u0027tag\u0027, 42)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # wrap list/find in transaction so we get a single isolated snapshot"},{"line_number":385,"context_line":"        txn \u003d self.ovs.ovsdb.transaction(check_error\u003dTrue)"},{"line_number":386,"context_line":"        txn.add(self.ovs.ovsdb.db_list(\u0027Port\u0027, columns\u003d[\u0027tag\u0027]))"},{"line_number":387,"context_line":"        txn.add(self.ovs.ovsdb.db_find(\u0027Port\u0027, (\u0027tag\u0027, \u0027!\u003d\u0027, []),"},{"line_number":388,"context_line":"                                       columns\u003d[\u0027tag\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_4f055312","line":385,"in_reply_to":"9ad45d7e_6967774d","updated":"2016-08-10 14:54:12.000000000","message":"Done","commit_id":"2b74f50bd64b483967b4fd9188dc3811c7f05843"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bf2e0f270aa29a6cf3c387a07aef6fb073150b2d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        tags_present \u003d [t for t in tags if t[\u0027tag\u0027] !\u003d []]"},{"line_number":397,"context_line":"        self.assertTrue(tags_present)"},{"line_number":398,"context_line":"        tags_42 \u003d [t for t in tags_present if t[\u0027tag\u0027] \u003d\u003d 42]"},{"line_number":399,"context_line":"        single_value \u003d self.ovs.ovsdb.db_find("},{"line_number":400,"context_line":"            \u0027Port\u0027, (\u0027tag\u0027, \u0027\u003d\u0027, 42), columns\u003d[\u0027tag\u0027]).execute()"},{"line_number":401,"context_line":"        self.assertEqual(tags_42, single_value)"},{"line_number":402,"context_line":"        self.assertItemsEqual(len_0_list, tags_present)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_298f3fcd","line":399,"updated":"2016-08-10 14:26:23.000000000","message":"I think this line also would need to be part of the transaction above as something else could theoretically create a port with tag\u003d42.","commit_id":"2b74f50bd64b483967b4fd9188dc3811c7f05843"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d4016cc74bf88571418853977a62a120dc12b96c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        tags_present \u003d [t for t in tags if t[\u0027tag\u0027] !\u003d []]"},{"line_number":397,"context_line":"        self.assertTrue(tags_present)"},{"line_number":398,"context_line":"        tags_42 \u003d [t for t in tags_present if t[\u0027tag\u0027] \u003d\u003d 42]"},{"line_number":399,"context_line":"        single_value \u003d self.ovs.ovsdb.db_find("},{"line_number":400,"context_line":"            \u0027Port\u0027, (\u0027tag\u0027, \u0027\u003d\u0027, 42), columns\u003d[\u0027tag\u0027]).execute()"},{"line_number":401,"context_line":"        self.assertEqual(tags_42, single_value)"},{"line_number":402,"context_line":"        self.assertItemsEqual(len_0_list, tags_present)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_92013008","line":399,"in_reply_to":"9ad45d7e_298f3fcd","updated":"2016-08-10 14:54:12.000000000","message":"Done","commit_id":"2b74f50bd64b483967b4fd9188dc3811c7f05843"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6d10089fe07a71c38e2aac3817d5dde8c7c8a7d5","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            single_value \u003d txn.add(self.ovs.ovsdb.db_find("},{"line_number":390,"context_line":"                    \u0027Port\u0027, (\u0027tag\u0027, \u0027\u003d\u0027, 42), columns\u003d[\u0027tag\u0027]))"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        tags \u003d tags.result"},{"line_number":393,"context_line":"        len_0_list \u003d len_0_list.result"},{"line_number":394,"context_line":"        single_value \u003d single_value.result"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b28a6f19","line":392,"updated":"2016-08-10 16:16:15.000000000","message":"If it were me, I\u0027d just use the .result versions below since each is only used once and it doesn\u0027t look like it would cause line breaks. No big deal though.","commit_id":"29182299631d3657a25c2565ba94f6fd8c969dbc"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a68c5604c3a928cdf42125e133ca3546d74867fb","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            single_value \u003d txn.add(self.ovs.ovsdb.db_find("},{"line_number":390,"context_line":"                    \u0027Port\u0027, (\u0027tag\u0027, \u0027\u003d\u0027, 42), columns\u003d[\u0027tag\u0027]))"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        tags \u003d tags.result"},{"line_number":393,"context_line":"        len_0_list \u003d len_0_list.result"},{"line_number":394,"context_line":"        single_value \u003d single_value.result"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_d2d443be","line":392,"in_reply_to":"9ad45d7e_b28a6f19","updated":"2016-08-10 16:21:55.000000000","message":"Done","commit_id":"29182299631d3657a25c2565ba94f6fd8c969dbc"}]}