)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5f66c791adbf83e5f3b5f25d40f74026ab25fdf6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring ml2 plugin openvswitch driver configuration options to be"},{"line_number":10,"context_line":"in neutron/conf/plugins/ml2/drivers. This would allow centralization"},{"line_number":11,"context_line":"of all configuration options and provides easy way to import."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie8c6023b2d012eae7ecdb99d5d413956608f4294"},{"line_number":14,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_e78a2a63","line":11,"range":{"start_line":11,"start_character":42,"end_line":11,"end_character":46},"updated":"2016-08-01 18:08:26.000000000","message":"nit: an easy","commit_id":"df1dd35b297282c902f4801d6edeb1c4ac18f361"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d719be5c593885a3e2e6e54682764eab5a7bc63d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_4e0ff587","line":1,"updated":"2016-08-11 11:56:10.000000000","message":"Can the copyright be corrected?","commit_id":"670dc9a0b8b490efb03af2f3b53ddf28e1adadbb"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"4f7fe980772f54f696c5b7c95c02fc46b1b73ed1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_63b426d1","line":1,"in_reply_to":"9ad45d7e_4e0ff587","updated":"2016-08-12 17:06:37.000000000","message":"Retained copyright from https://review.openstack.org/#/c/345592/6/neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py@1 because the patch is  just refactoring.\nPlease suggest","commit_id":"670dc9a0b8b490efb03af2f3b53ddf28e1adadbb"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"81a4602732efc2bba0250c52473dcbec2ba45499","unresolved":false,"context_lines":[{"line_number":159,"context_line":"]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":163,"context_line":"    cfg.register_opts(ovs_opts, \"OVS\")"},{"line_number":164,"context_line":"    cfg.register_opts(agent_opts, \"AGENT\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_9875a899","line":162,"updated":"2016-10-07 14:39:43.000000000","message":"Just wondering, Wouldn\u0027t it be better to register these in two separate function. With this we are always bound to register both of them?","commit_id":"d8907a958407d5bf7fe452fb522bff644fe27739"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8a307d6f686c0f8d601477fb9a8caf32ede8240b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":163,"context_line":"    cfg.register_opts(ovs_opts, \"OVS\")"},{"line_number":164,"context_line":"    cfg.register_opts(agent_opts, \"AGENT\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_278b91c4","line":162,"in_reply_to":"1a95cdbc_9875a899","updated":"2016-10-07 16:26:01.000000000","message":"Both of these methods are being called together twice in the current codebase. Didn\u0027t find a use case where different methods is required. Therefore combined these two into one.","commit_id":"d8907a958407d5bf7fe452fb522bff644fe27739"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5f66c791adbf83e5f3b5f25d40f74026ab25fdf6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ovs_conf.register_ovs_opts(ovs_conf.ovs_opts, \"OVS\")"},{"line_number":21,"context_line":"ovs_conf.register_ovs_opts(ovs_conf.agent_opts, \"AGENT\")"},{"line_number":22,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d9870ab3","line":21,"updated":"2016-08-01 18:08:26.000000000","message":"Line (20-21) : Same as line(73-74) as in openstack/neutron / neutron/tests/functional/agent/l2/base.py","commit_id":"df1dd35b297282c902f4801d6edeb1c4ac18f361"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"bd1abc994c6b4756cb2e662155a1e0d69e9446d5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ovs_conf.register_ovs_opts(ovs_conf.ovs_opts, \"OVS\")"},{"line_number":21,"context_line":"ovs_conf.register_ovs_opts(ovs_conf.agent_opts, \"AGENT\")"},{"line_number":22,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a31f7f59","line":21,"in_reply_to":"bacf61ea_d9870ab3","updated":"2016-08-01 20:07:02.000000000","message":"+1","commit_id":"df1dd35b297282c902f4801d6edeb1c4ac18f361"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5f66c791adbf83e5f3b5f25d40f74026ab25fdf6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        config.register_opts(common_config.core_opts)"},{"line_number":72,"context_line":"        config.register_opts(interface.OPTS)"},{"line_number":73,"context_line":"        config.register_opts(ovs_conf.ovs_opts, \"OVS\")"},{"line_number":74,"context_line":"        config.register_opts(ovs_conf.agent_opts, \"AGENT\")"},{"line_number":75,"context_line":"        agent_config.register_interface_driver_opts_helper(config)"},{"line_number":76,"context_line":"        agent_config.register_agent_state_opts_helper(config)"},{"line_number":77,"context_line":"        ext_manager.register_opts(config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_f9700e0d","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":8},"updated":"2016-08-01 18:08:26.000000000","message":"Line (73-74): Instead of calling register_opts twice with 2 different opts to reduce CPU calls it will be good to have a function defined in neutron/conf/plugins/ml2/drivers/ovs_conf.py as \ndef register_ovs_agent_opts(cfg\u003dcfg.CONF):\n      cfg.register_opts(ovs_opts, \"OVS\")\n      cfg.register_opts(agent_opts, \"AGENT\")\n\nThen these lines can be replaced by:\novs_conf.register_ovs_agent_opts()","commit_id":"df1dd35b297282c902f4801d6edeb1c4ac18f361"}]}