)]}'
{"neutron/agent/metadata/agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcefd5a79fbe56de1f5f2b602c03a5434deb5f26","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import constants as n_const"},{"line_number":34,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":35,"context_line":"from neutron.common import topics"},{"line_number":36,"context_line":"from neutron.conf.agent.metadata import config as meta_conf"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_c0db451a","line":36,"range":{"start_line":36,"start_character":47,"end_line":36,"end_character":59},"updated":"2016-10-05 01:11:12.000000000","message":"why do we need this - it would be less changes in the file","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"16f3874307791d20776f30c49569c40693edb54b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import constants as n_const"},{"line_number":34,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":35,"context_line":"from neutron.common import topics"},{"line_number":36,"context_line":"from neutron.conf.agent.metadata import config as meta_conf"},{"line_number":37,"context_line":"from neutron import context"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_6f93eb4f","line":36,"range":{"start_line":36,"start_character":47,"end_line":36,"end_character":59},"in_reply_to":"1a95cdbc_c0db451a","updated":"2016-10-06 14:38:39.000000000","message":"Done","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"}],"neutron/agent/metadata/namespace_proxy.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5c682fa3a1277165031247be40e8af562dfbacf8","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    namespace.register_namespace_proxy_opts(cfg.CONF)"},{"line_number":142,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":143,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":144,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_820a3224","line":141,"range":{"start_line":141,"start_character":44,"end_line":141,"end_character":52},"updated":"2016-08-01 22:17:44.000000000","message":"Since this method(https://review.openstack.org/#/c/346162/2/neutron/conf/agent/metadata/namespace_proxy.py@54) has default value of cfg.CONF, this won\u0027t be required","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"fcd120ee8a26bbaeccc38f7248ac3ca481bf3912","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    namespace.register_namespace_proxy_opts(cfg.CONF)"},{"line_number":142,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":143,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":144,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8ec69847","line":141,"range":{"start_line":141,"start_character":44,"end_line":141,"end_character":52},"in_reply_to":"bacf61ea_820a3224","updated":"2016-08-03 03:42:16.000000000","message":"Done","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b08c44fb2b6c3434da9664d61561b194696777cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.common import config"},{"line_number":28,"context_line":"from neutron.common import exceptions"},{"line_number":29,"context_line":"from neutron.common import utils"},{"line_number":30,"context_line":"#from neutron.conf.agent.metadata import namespace_proxy as namespace"},{"line_number":31,"context_line":"from neutron import wsgi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_6f68e5f5","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":69},"updated":"2016-08-05 15:28:34.000000000","message":"leftover?","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"65af4ca845fead047dcd6586de862693e03efa0b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.common import config"},{"line_number":28,"context_line":"from neutron.common import exceptions"},{"line_number":29,"context_line":"from neutron.common import utils"},{"line_number":30,"context_line":"#from neutron.conf.agent.metadata import namespace_proxy as namespace"},{"line_number":31,"context_line":"from neutron import wsgi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_9ddf4c0c","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":69},"in_reply_to":"bacf61ea_6f68e5f5","updated":"2016-08-05 16:35:03.000000000","message":"Done","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b08c44fb2b6c3434da9664d61561b194696777cf","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    opts \u003d ["},{"line_number":142,"context_line":"        cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":143,"context_line":"                   help\u003d_(\u0027Network that will have instance metadata \u0027"},{"line_number":144,"context_line":"                          \u0027proxied.\u0027)),"},{"line_number":145,"context_line":"        cfg.StrOpt(\u0027router_id\u0027,"},{"line_number":146,"context_line":"                   help\u003d_(\u0027Router that will have connected instances\\\u0027 \u0027"},{"line_number":147,"context_line":"                          \u0027metadata proxied.\u0027)),"},{"line_number":148,"context_line":"        cfg.StrOpt(\u0027pid_file\u0027,"},{"line_number":149,"context_line":"                   help\u003d_(\u0027Location of pid file of this process.\u0027)),"},{"line_number":150,"context_line":"        cfg.BoolOpt(\u0027daemonize\u0027,"},{"line_number":151,"context_line":"                    default\u003dTrue,"},{"line_number":152,"context_line":"                    help\u003d_(\u0027Run as daemon.\u0027)),"},{"line_number":153,"context_line":"        cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":154,"context_line":"                    default\u003d9697,"},{"line_number":155,"context_line":"                    help\u003d_(\"TCP Port to listen for metadata server \""},{"line_number":156,"context_line":"                           \"requests.\")),"},{"line_number":157,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":158,"context_line":"                   default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":159,"context_line":"                   help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":160,"context_line":"                          \u0027socket\u0027)),"},{"line_number":161,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_user\u0027,"},{"line_number":162,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""},{"line_number":163,"context_line":"                          \"its initialization\")),"},{"line_number":164,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_group\u0027,"},{"line_number":165,"context_line":"                   help\u003d_(\"Group (gid or name) running metadata proxy after \""},{"line_number":166,"context_line":"                          \"its initialization\")),"},{"line_number":167,"context_line":"        cfg.BoolOpt(\u0027metadata_proxy_watch_log\u0027,"},{"line_number":168,"context_line":"                    default\u003dTrue,"},{"line_number":169,"context_line":"                    help\u003d_(\"Watch file log. Log watch should be disabled when \""},{"line_number":170,"context_line":"                           \"metadata_proxy_user/group has no read/write \""},{"line_number":171,"context_line":"                           \"permissions on metadata proxy log file.\")),"},{"line_number":172,"context_line":"    ]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":175,"context_line":"    #namespace.register_namespace_proxy_opts()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_bacb39a3","line":172,"range":{"start_line":141,"start_character":0,"end_line":172,"end_character":5},"updated":"2016-08-05 15:28:34.000000000","message":"opts has been refactored to  neutron/conf/agent/metadata/namespace_proxy.py.\nlets delete it from here","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"65af4ca845fead047dcd6586de862693e03efa0b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    opts \u003d ["},{"line_number":142,"context_line":"        cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":143,"context_line":"                   help\u003d_(\u0027Network that will have instance metadata \u0027"},{"line_number":144,"context_line":"                          \u0027proxied.\u0027)),"},{"line_number":145,"context_line":"        cfg.StrOpt(\u0027router_id\u0027,"},{"line_number":146,"context_line":"                   help\u003d_(\u0027Router that will have connected instances\\\u0027 \u0027"},{"line_number":147,"context_line":"                          \u0027metadata proxied.\u0027)),"},{"line_number":148,"context_line":"        cfg.StrOpt(\u0027pid_file\u0027,"},{"line_number":149,"context_line":"                   help\u003d_(\u0027Location of pid file of this process.\u0027)),"},{"line_number":150,"context_line":"        cfg.BoolOpt(\u0027daemonize\u0027,"},{"line_number":151,"context_line":"                    default\u003dTrue,"},{"line_number":152,"context_line":"                    help\u003d_(\u0027Run as daemon.\u0027)),"},{"line_number":153,"context_line":"        cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":154,"context_line":"                    default\u003d9697,"},{"line_number":155,"context_line":"                    help\u003d_(\"TCP Port to listen for metadata server \""},{"line_number":156,"context_line":"                           \"requests.\")),"},{"line_number":157,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":158,"context_line":"                   default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":159,"context_line":"                   help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":160,"context_line":"                          \u0027socket\u0027)),"},{"line_number":161,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_user\u0027,"},{"line_number":162,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""},{"line_number":163,"context_line":"                          \"its initialization\")),"},{"line_number":164,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_group\u0027,"},{"line_number":165,"context_line":"                   help\u003d_(\"Group (gid or name) running metadata proxy after \""},{"line_number":166,"context_line":"                          \"its initialization\")),"},{"line_number":167,"context_line":"        cfg.BoolOpt(\u0027metadata_proxy_watch_log\u0027,"},{"line_number":168,"context_line":"                    default\u003dTrue,"},{"line_number":169,"context_line":"                    help\u003d_(\"Watch file log. Log watch should be disabled when \""},{"line_number":170,"context_line":"                           \"metadata_proxy_user/group has no read/write \""},{"line_number":171,"context_line":"                           \"permissions on metadata proxy log file.\")),"},{"line_number":172,"context_line":"    ]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":175,"context_line":"    #namespace.register_namespace_proxy_opts()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_3dd580e4","line":172,"range":{"start_line":141,"start_character":0,"end_line":172,"end_character":5},"in_reply_to":"bacf61ea_bacb39a3","updated":"2016-08-05 16:35:03.000000000","message":"Ya had kept it here coz was facing some errors. Have removed it now.","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b08c44fb2b6c3434da9664d61561b194696777cf","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    ]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":175,"context_line":"    #namespace.register_namespace_proxy_opts()"},{"line_number":176,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":177,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":178,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_2f526d35","line":175,"range":{"start_line":175,"start_character":3,"end_line":175,"end_character":46},"updated":"2016-08-05 15:28:34.000000000","message":"ditto?","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"65af4ca845fead047dcd6586de862693e03efa0b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    ]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":175,"context_line":"    #namespace.register_namespace_proxy_opts()"},{"line_number":176,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":177,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":178,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_9d062c84","line":175,"range":{"start_line":175,"start_character":3,"end_line":175,"end_character":46},"in_reply_to":"bacf61ea_2f526d35","updated":"2016-08-05 16:35:03.000000000","message":"Done","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b85f7525d9dc7c94d075b94b38992a7d939ce50b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    namespace.register_namespace_proxy_opts(cfg.CONF)"},{"line_number":142,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":143,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":144,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_21a6f2c0","line":141,"range":{"start_line":141,"start_character":51,"end_line":141,"end_character":52},"updated":"2016-08-05 21:04:55.000000000","message":"As register_namespace_proxy_opts(conf\u003dcfg.CONF) is already defining the default value for conf as cfg.CONF no need to pass cfg.CONF here","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"97e2f0ad9dbf3953bfb164a7663a803ae4a77abe","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def main():"},{"line_number":141,"context_line":"    namespace.register_namespace_proxy_opts(cfg.CONF)"},{"line_number":142,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":143,"context_line":"    cfg.CONF(project\u003d\u0027neutron\u0027, default_config_files\u003d[])"},{"line_number":144,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_0e5d99e9","line":141,"range":{"start_line":141,"start_character":51,"end_line":141,"end_character":52},"in_reply_to":"bacf61ea_21a6f2c0","updated":"2016-08-08 15:32:49.000000000","message":"Done","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"}],"neutron/agent/metadata_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b85f7525d9dc7c94d075b94b38992a7d939ce50b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def main():"},{"line_number":31,"context_line":"    meta.register_meta_conf_opts(meta.SHARED_OPTS)"},{"line_number":32,"context_line":"    meta.register_meta_conf_opts(meta.UNIX_DOMAIN_METADATA_PROXY_OPTS)"},{"line_number":33,"context_line":"    meta.register_meta_conf_opts(meta.METADATA_PROXY_HANDLER_OPTS)"},{"line_number":34,"context_line":"    cache.register_oslo_configs(cfg.CONF)"},{"line_number":35,"context_line":"    cfg.CONF.set_default(name\u003d\u0027cache_url\u0027, default\u003d\u0027memory://?default_ttl\u003d5\u0027)"},{"line_number":36,"context_line":"    agent_conf.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_467b3cf5","line":33,"updated":"2016-08-05 21:04:55.000000000","message":"Line(31-33): Instead of making 3 calls it would be good to have one function in neutron.conf.agent.metadata.config that will register all the 3 opts","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"97e2f0ad9dbf3953bfb164a7663a803ae4a77abe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def main():"},{"line_number":31,"context_line":"    meta.register_meta_conf_opts(meta.SHARED_OPTS)"},{"line_number":32,"context_line":"    meta.register_meta_conf_opts(meta.UNIX_DOMAIN_METADATA_PROXY_OPTS)"},{"line_number":33,"context_line":"    meta.register_meta_conf_opts(meta.METADATA_PROXY_HANDLER_OPTS)"},{"line_number":34,"context_line":"    cache.register_oslo_configs(cfg.CONF)"},{"line_number":35,"context_line":"    cfg.CONF.set_default(name\u003d\u0027cache_url\u0027, default\u003d\u0027memory://?default_ttl\u003d5\u0027)"},{"line_number":36,"context_line":"    agent_conf.register_agent_state_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_ce93814e","line":33,"in_reply_to":"bacf61ea_467b3cf5","updated":"2016-08-08 15:32:49.000000000","message":"Different files register different options eg: neutron/agent/l3_agent.py registers only SHARED_OPTS and DRIVER_OPTS. In that case, we\u0027ll need a function to register only those two. This could happen to other files as well and we would need functions for all different combinations of registration.","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"1d9ce9a152ebf04e67f60a0865c7073d08cb88ac","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.common import cache_utils as cache"},{"line_number":23,"context_line":"from neutron.common import config"},{"line_number":24,"context_line":"from neutron.common import utils"},{"line_number":25,"context_line":"from neutron.conf.agent.metadata import config as meta"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_6883e856","line":25,"range":{"start_line":25,"start_character":50,"end_line":25,"end_character":54},"updated":"2016-10-12 19:49:24.000000000","message":"in other files it has been imported as meta_conf.\nOther than this it looks good to me","commit_id":"d3e57b329796a57f766ab28dbb34b73ea3f2e56d"}],"neutron/conf/agent/metadata/config.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5c682fa3a1277165031247be40e8af562dfbacf8","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":"from neutron.common import utils"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEDUCE_MODE \u003d \u0027deduce\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c2a42a4c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":27},"updated":"2016-08-01 22:17:44.000000000","message":"import should be in L15 followed by an empty line and other  two imports","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"fcd120ee8a26bbaeccc38f7248ac3ca481bf3912","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":"from neutron.common import utils"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEDUCE_MODE \u003d \u0027deduce\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_cec0902d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":27},"in_reply_to":"bacf61ea_c2a42a4c","updated":"2016-08-03 03:42:16.000000000","message":"Done","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"671dabe2aa7b487507f335d31906c1f584a741b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9ad45d7e_9de7efe3","side":"PARENT","line":50,"updated":"2016-08-08 21:08:12.000000000","message":"Two blank lines between top-level globals please.","commit_id":"dc417194a1f0626102e8a6fd712a84f03c6c5720"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"78eb0f7a34b5006799ce67c869dbcb384c201bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9ad45d7e_85795532","side":"PARENT","line":50,"in_reply_to":"9ad45d7e_9de7efe3","updated":"2016-08-08 23:22:55.000000000","message":"Done","commit_id":"dc417194a1f0626102e8a6fd712a84f03c6c5720"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"671dabe2aa7b487507f335d31906c1f584a741b8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                default\u003d\u0027\u0027,"},{"line_number":88,"context_line":"                help\u003d_(\"Private key of client certificate.\"))"},{"line_number":89,"context_line":"]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"UNIX_DOMAIN_METADATA_PROXY_OPTS \u003d ["},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket_mode\u0027,"},{"line_number":93,"context_line":"               default\u003dDEDUCE_MODE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_7decbbc7","line":90,"updated":"2016-08-08 21:08:12.000000000","message":"ditto","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"78eb0f7a34b5006799ce67c869dbcb384c201bb7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                default\u003d\u0027\u0027,"},{"line_number":88,"context_line":"                help\u003d_(\"Private key of client certificate.\"))"},{"line_number":89,"context_line":"]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"UNIX_DOMAIN_METADATA_PROXY_OPTS \u003d ["},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket_mode\u0027,"},{"line_number":93,"context_line":"               default\u003dDEDUCE_MODE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_c5734d4c","line":90,"in_reply_to":"9ad45d7e_7decbbc7","updated":"2016-08-08 23:22:55.000000000","message":"Done","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"b8b40ed79f4eadda33d5bc084ba3748212da4e88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_f9576855","line":15,"updated":"2016-08-29 20:46:39.000000000","message":"extra blank line","commit_id":"f3ca24492b27caee704d3d95ad1f91843be0ca90"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"37a363c3f4c38439bc581fefe5c775c156b82358","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_6cdacae9","line":15,"in_reply_to":"1ac06dbe_f9576855","updated":"2016-09-16 16:37:33.000000000","message":"Done","commit_id":"f3ca24492b27caee704d3d95ad1f91843be0ca90"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5ad2d67dceb2969d4ab2d4383180c56f8f4af042","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_463a4a9a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":38},"updated":"2016-09-16 16:48:15.000000000","message":"Please don\u0027t change this copyright, unless you work for OpenStack Foundation","commit_id":"c80e523666d2248024d0d623abc7cf3be7117e14"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"b2bd117d8b9642980890674464658263d41aebe1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_2f4da472","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":38},"in_reply_to":"7a8ec9b2_463a4a9a","updated":"2016-09-22 18:34:15.000000000","message":"Done","commit_id":"c80e523666d2248024d0d623abc7cf3be7117e14"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcefd5a79fbe56de1f5f2b602c03a5434deb5f26","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron._i18n import _"},{"line_number":18,"context_line":"from neutron.common import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEDUCE_MODE \u003d \u0027deduce\u0027"},{"line_number":22,"context_line":"USER_MODE \u003d \u0027user\u0027"},{"line_number":23,"context_line":"GROUP_MODE \u003d \u0027group\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_20094996","line":20,"updated":"2016-10-05 01:11:12.000000000","message":"one too many new lines","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"16f3874307791d20776f30c49569c40693edb54b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron._i18n import _"},{"line_number":18,"context_line":"from neutron.common import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEDUCE_MODE \u003d \u0027deduce\u0027"},{"line_number":22,"context_line":"USER_MODE \u003d \u0027user\u0027"},{"line_number":23,"context_line":"GROUP_MODE \u003d \u0027group\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_8f9af761","line":20,"in_reply_to":"1a95cdbc_20094996","updated":"2016-10-06 14:38:39.000000000","message":"Done","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcefd5a79fbe56de1f5f2b602c03a5434deb5f26","unresolved":false,"context_lines":[{"line_number":23,"context_line":"GROUP_MODE \u003d \u0027group\u0027"},{"line_number":24,"context_line":"ALL_MODE \u003d \u0027all\u0027"},{"line_number":25,"context_line":"SOCKET_MODES \u003d (DEDUCE_MODE, USER_MODE, GROUP_MODE, ALL_MODE)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"SHARED_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_40fe556c","line":26,"updated":"2016-10-05 01:11:12.000000000","message":"ditto","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"16f3874307791d20776f30c49569c40693edb54b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"GROUP_MODE \u003d \u0027group\u0027"},{"line_number":24,"context_line":"ALL_MODE \u003d \u0027all\u0027"},{"line_number":25,"context_line":"SOCKET_MODES \u003d (DEDUCE_MODE, USER_MODE, GROUP_MODE, ALL_MODE)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"SHARED_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_af9df35a","line":26,"in_reply_to":"1a95cdbc_40fe556c","updated":"2016-10-06 14:38:39.000000000","message":"Done","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"}],"neutron/conf/agent/metadata/namespace_proxy.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcefd5a79fbe56de1f5f2b602c03a5434deb5f26","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron._i18n import _"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":22,"context_line":"               help\u003d_(\u0027Network that will have instance metadata \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_e0ef61ae","line":19,"updated":"2016-10-05 01:11:12.000000000","message":"one too mane new lines","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"16f3874307791d20776f30c49569c40693edb54b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron._i18n import _"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":22,"context_line":"               help\u003d_(\u0027Network that will have instance metadata \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_2faac370","line":19,"in_reply_to":"1a95cdbc_e0ef61ae","updated":"2016-10-06 14:38:39.000000000","message":"Done","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcefd5a79fbe56de1f5f2b602c03a5434deb5f26","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":22,"context_line":"               help\u003d_(\u0027Network that will have instance metadata \u0027"},{"line_number":23,"context_line":"                      \u0027proxied.\u0027)),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027router_id\u0027,"},{"line_number":25,"context_line":"               help\u003d_(\u0027Router that will have connected instances\\\u0027 \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_400c9594","line":22,"updated":"2016-10-05 01:11:12.000000000","message":"maybe overliy picky but why not be consistent with the quites - either use \u0027 or \"","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"16f3874307791d20776f30c49569c40693edb54b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027network_id\u0027,"},{"line_number":22,"context_line":"               help\u003d_(\u0027Network that will have instance metadata \u0027"},{"line_number":23,"context_line":"                      \u0027proxied.\u0027)),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027router_id\u0027,"},{"line_number":25,"context_line":"               help\u003d_(\u0027Router that will have connected instances\\\u0027 \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_4fb70fd8","line":22,"in_reply_to":"1a95cdbc_400c9594","updated":"2016-10-06 14:38:39.000000000","message":"Done","commit_id":"44cee10babc4f999c7e2103aee48b46d0bc2b1b7"}],"neutron/opts.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5c682fa3a1277165031247be40e8af562dfbacf8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.conf.agent.metadata import config as meta_conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import neutron.agent.agent_extensions_manager"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_257710a1","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":59},"updated":"2016-08-01 22:17:44.000000000","message":"this import should be in alphabetical order, after \nimport neutron.conf.agent.l3.config","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"fcd120ee8a26bbaeccc38f7248ac3ca481bf3912","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.conf.agent.metadata import config as meta_conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import neutron.agent.agent_extensions_manager"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0ee108d1","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":59},"in_reply_to":"bacf61ea_257710a1","updated":"2016-08-03 03:42:16.000000000","message":"Done","commit_id":"c8ba259e062488c7d62fb564929dfe2774891872"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b08c44fb2b6c3434da9664d61561b194696777cf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":22,"context_line":"import neutron.agent.common.config"},{"line_number":23,"context_line":"import neutron.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_9aa3d5b1","line":20,"updated":"2016-08-05 15:28:34.000000000","message":"why this extra line?","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"65af4ca845fead047dcd6586de862693e03efa0b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":22,"context_line":"import neutron.agent.common.config"},{"line_number":23,"context_line":"import neutron.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_bdffb064","line":20,"in_reply_to":"bacf61ea_9aa3d5b1","updated":"2016-08-05 16:35:03.000000000","message":"Done","commit_id":"daab0978b92c3ac63da9ccfae0eb7b708b995a44"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b85f7525d9dc7c94d075b94b38992a7d939ce50b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    return ["},{"line_number":223,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":224,"context_line":"         itertools.chain("},{"line_number":225,"context_line":"             meta_conf.SHARED_OPTS,"},{"line_number":226,"context_line":"             neutron.conf.agent.metadata.config"},{"line_number":227,"context_line":"                    .METADATA_PROXY_HANDLER_OPTS,"},{"line_number":228,"context_line":"             neutron.conf.agent.metadata.config"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_2130b255","line":225,"range":{"start_line":225,"start_character":13,"end_line":225,"end_character":22},"updated":"2016-08-05 21:04:55.000000000","message":"nit: line 224 can have the same prefix \"neutron.conf.agent.metadata.config\" as line 226 and 227","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"97e2f0ad9dbf3953bfb164a7663a803ae4a77abe","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    return ["},{"line_number":223,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":224,"context_line":"         itertools.chain("},{"line_number":225,"context_line":"             meta_conf.SHARED_OPTS,"},{"line_number":226,"context_line":"             neutron.conf.agent.metadata.config"},{"line_number":227,"context_line":"                    .METADATA_PROXY_HANDLER_OPTS,"},{"line_number":228,"context_line":"             neutron.conf.agent.metadata.config"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_8e5229dc","line":225,"range":{"start_line":225,"start_character":13,"end_line":225,"end_character":22},"in_reply_to":"bacf61ea_2130b255","updated":"2016-08-08 15:32:49.000000000","message":"For some weird reason, I get this error:\nAttributeError: \u0027module\u0027 object has no attribute \u0027metadata\u0027\nwhen I try to use \"neutron.conf.agent.metadata.config\" in line 225. \nBut have made it uniform now.","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"671dabe2aa7b487507f335d31906c1f584a741b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":22,"context_line":"import neutron.agent.common.config"},{"line_number":23,"context_line":"import neutron.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_fdd8ab1f","line":20,"updated":"2016-08-08 21:08:12.000000000","message":"One blank line between import blocks please","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"78eb0f7a34b5006799ce67c869dbcb384c201bb7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":22,"context_line":"import neutron.agent.common.config"},{"line_number":23,"context_line":"import neutron.agent.l3.config"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_258fc924","line":20,"in_reply_to":"9ad45d7e_fdd8ab1f","updated":"2016-08-08 23:22:55.000000000","message":"Done","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"}],"neutron/tests/functional/agent/l3/framework.py":[{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"671dabe2aa7b487507f335d31906c1f584a741b8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":37,"context_line":"from neutron.tests.functional import base"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_uuid \u003d uuidutils.generate_uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_1d4adfc5","side":"PARENT","line":39,"updated":"2016-08-08 21:08:12.000000000","message":"Two blank lines between last import and first statement please.","commit_id":"dc417194a1f0626102e8a6fd712a84f03c6c5720"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"78eb0f7a34b5006799ce67c869dbcb384c201bb7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":37,"context_line":"from neutron.tests.functional import base"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_uuid \u003d uuidutils.generate_uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_6599c16e","side":"PARENT","line":39,"in_reply_to":"9ad45d7e_1d4adfc5","updated":"2016-08-08 23:22:55.000000000","message":"Done","commit_id":"dc417194a1f0626102e8a6fd712a84f03c6c5720"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b85f7525d9dc7c94d075b94b38992a7d939ce50b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(ConfFixture, self).setUp()"},{"line_number":35,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf."},{"line_number":36,"context_line":"                                          METADATA_PROXY_HANDLER_OPTS,"},{"line_number":37,"context_line":"                                          cfg.CONF)"},{"line_number":38,"context_line":"        self.config(auth_ca_cert\u003dNone,"},{"line_number":39,"context_line":"                    nova_metadata_ip\u003d\u00279.9.9.9\u0027,"},{"line_number":40,"context_line":"                    nova_metadata_port\u003d8775,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_810a3e77","line":37,"range":{"start_line":37,"start_character":42,"end_line":37,"end_character":50},"updated":"2016-08-05 21:04:55.000000000","message":"Need to pass self.conf instead of cfg.CONF","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"97e2f0ad9dbf3953bfb164a7663a803ae4a77abe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(ConfFixture, self).setUp()"},{"line_number":35,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf."},{"line_number":36,"context_line":"                                          METADATA_PROXY_HANDLER_OPTS,"},{"line_number":37,"context_line":"                                          cfg.CONF)"},{"line_number":38,"context_line":"        self.config(auth_ca_cert\u003dNone,"},{"line_number":39,"context_line":"                    nova_metadata_ip\u003d\u00279.9.9.9\u0027,"},{"line_number":40,"context_line":"                    nova_metadata_port\u003d8775,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_4ef671d8","line":37,"range":{"start_line":37,"start_character":42,"end_line":37,"end_character":50},"in_reply_to":"bacf61ea_810a3e77","updated":"2016-08-08 15:32:49.000000000","message":"Done","commit_id":"6fe49d9ca358b13e49afe5e602ece5343853e545"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"671dabe2aa7b487507f335d31906c1f584a741b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class ConfFixture(config_fixture.Config):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(ConfFixture, self).setUp()"},{"line_number":35,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf."},{"line_number":36,"context_line":"                                          METADATA_PROXY_HANDLER_OPTS,"},{"line_number":37,"context_line":"                                          self.conf)"},{"line_number":38,"context_line":"        self.config(auth_ca_cert\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_dd02073e","line":35,"updated":"2016-08-08 21:08:12.000000000","message":"Breaking up the chain like this isn\u0027t technically wrong but it\u0027s super strange, it looks like register_meta_conf_opts takes 3 args at first glance. You could do it like this instead:\n\nmeta_conf.register_meta_conf_opts(\n    meta_conf.METADATA_PROXY_HANDLER_OPTS, self.conf)","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"78eb0f7a34b5006799ce67c869dbcb384c201bb7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class ConfFixture(config_fixture.Config):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(ConfFixture, self).setUp()"},{"line_number":35,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf."},{"line_number":36,"context_line":"                                          METADATA_PROXY_HANDLER_OPTS,"},{"line_number":37,"context_line":"                                          self.conf)"},{"line_number":38,"context_line":"        self.config(auth_ca_cert\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_05bba5c5","line":35,"in_reply_to":"9ad45d7e_dd02073e","updated":"2016-08-08 23:22:55.000000000","message":"Done","commit_id":"72e2e690b484448d4547a81d8fb52170f69d722f"}],"neutron/tests/unit/agent/metadata/test_driver.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"c74c898fe6e26a905ef0f2211c6c1b8149c4716c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        l3_config.register_l3_agent_config_opts(l3_config.OPTS, cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF.register_opts(l3_ha_agent.OPTS)"},{"line_number":79,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf.SHARED_OPTS, cfg.CONF)"},{"line_number":80,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf.DRIVER_OPTS, cfg.CONF)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _test_spawn_metadata_proxy(self, expected_user, expected_group,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_7e7603a5","line":79,"range":{"start_line":79,"start_character":65,"end_line":79,"end_character":73},"updated":"2016-08-10 15:55:20.000000000","message":"nit: not needed","commit_id":"653bb008a9f2c2878cc48b582a148440882be45c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"c74c898fe6e26a905ef0f2211c6c1b8149c4716c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        l3_config.register_l3_agent_config_opts(l3_config.OPTS, cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF.register_opts(l3_ha_agent.OPTS)"},{"line_number":79,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf.SHARED_OPTS, cfg.CONF)"},{"line_number":80,"context_line":"        meta_conf.register_meta_conf_opts(meta_conf.DRIVER_OPTS, cfg.CONF)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _test_spawn_metadata_proxy(self, expected_user, expected_group,"},{"line_number":83,"context_line":"                                   user\u003d\u0027\u0027, group\u003d\u0027\u0027, watch_log\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_9e7137ab","line":80,"range":{"start_line":80,"start_character":65,"end_line":80,"end_character":73},"updated":"2016-08-10 15:55:20.000000000","message":"ditto","commit_id":"653bb008a9f2c2878cc48b582a148440882be45c"}]}