)]}'
{"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23806b0f0d105a5d7c2bf4d66efd6efa8bd8aef7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db_data[dns.DNSDOMAIN] \u003d new_value"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def process_create_port(self, plugin_context, request_data, db_data):"},{"line_number":78,"context_line":"        if dns.DNSNAME not in request_data or not request_data[dns.DNSNAME]:"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        network \u003d self._get_network(plugin_context, db_data[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        if not network[dns.DNSDOMAIN]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_94a5f248","line":78,"updated":"2016-07-24 07:38:17.000000000","message":"why not request_data.get(dns.DNSNAME)?","commit_id":"60a75556783d4a62b87a36f129c677803fa9c3a0"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"1d413a89e8001bcd5ee0f4cc84ba4248a951527b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db_data[dns.DNSDOMAIN] \u003d new_value"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def process_create_port(self, plugin_context, request_data, db_data):"},{"line_number":78,"context_line":"        if dns.DNSNAME not in request_data or not request_data[dns.DNSNAME]:"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        network \u003d self._get_network(plugin_context, db_data[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        if not network[dns.DNSDOMAIN]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_aa5a2228","line":78,"in_reply_to":"dada55a8_94a5f248","updated":"2016-07-25 17:29:09.000000000","message":"Done","commit_id":"60a75556783d4a62b87a36f129c677803fa9c3a0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"583d8de5130167fe25d80719dabe2ead1fbd66cf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db_data[dns.DNSDOMAIN] \u003d new_value"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def process_create_port(self, plugin_context, request_data, db_data):"},{"line_number":78,"context_line":"        if request_data.get(dns.DNSNAME):"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        network \u003d self._get_network(plugin_context, db_data[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        if not network[dns.DNSDOMAIN]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2aff52ab","line":78,"updated":"2016-07-25 17:34:25.000000000","message":"If the value is not set then this will return None.\nIt should be:\nif not request_data.get(dns.DNSNAME):\n    return\nCan you please add a unit test for this","commit_id":"aa831e7cddfed6b44ce81c9ff29f9ad0fc10b99c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"246e1c65daa18063b17645ee2fbee0213fb312fe","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db_data[dns.DNSDOMAIN] \u003d new_value"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def process_create_port(self, plugin_context, request_data, db_data):"},{"line_number":78,"context_line":"        if request_data.get(dns.DNSNAME):"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        network \u003d self._get_network(plugin_context, db_data[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        if not network[dns.DNSDOMAIN]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0aa40ea4","line":78,"in_reply_to":"dada55a8_2aff52ab","updated":"2016-07-25 17:38:06.000000000","message":"Sure - I just have no idea how I would do that with the current tests - they seem to be abstracted. Any pointers would be great.","commit_id":"aa831e7cddfed6b44ce81c9ff29f9ad0fc10b99c"}]}